Commit Graph

38 Commits

Author SHA1 Message Date
Brian Wilkerson dd897d35a2 Move the task API out of the public API
Change-Id: I0fbafb4965ced89fb9a063edb773c3f1cb3a39fa
Reviewed-on: https://dart-review.googlesource.com/51242
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-04-16 18:18:08 +00:00
Brian Wilkerson 602a8c2a7b Clean up usage of deprecated constants
Change-Id: I9005ba6e94529e15d8f7b21322591f4a9dabec47
Reviewed-on: https://dart-review.googlesource.com/45763
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-03-09 01:02:49 +00:00
Brian Wilkerson 62d0376231 Run the sorter to reduce code churn
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2933753002 .
2017-06-12 07:37:14 -07:00
Brian Wilkerson d7d3ee40dd Report plugin errors to the instrumentation service
R=mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2913913002 .
2017-05-31 08:01:07 -07:00
Brian Wilkerson 5659afc812 Make instrumentation data structure more regular
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2890193002 .
2017-05-18 09:09:17 -07:00
Brian Wilkerson 3b2c3ae5b2 Add support for built-in plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2874803003 .
2017-05-10 13:31:20 -07:00
Brian Wilkerson a3102bf441 Add support for reporting plugin data to instrumentation
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2834453002 .
2017-04-19 11:01:24 -07:00
Brian Wilkerson c91736b8e5 Fix bugs and add instrumentation
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2748683003 .
2017-03-13 10:12:25 -07:00
Devon Carew 8f36669937 Add instrumentation data to the analysis server diagnostics page.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2717253002 .
2017-03-10 14:08:14 -08:00
Brian Wilkerson 74686371b3 Add support for getting the sessionId from instrumentation and sending it to the client
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2359233002 .
2016-09-22 10:26:13 -07:00
Brian Wilkerson a3ed9fe569 Optimize more megamorphic dispatch sites
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2015513003 .
2016-05-25 10:49:11 -07:00
pq c07b21d03b Dangling comment reference cleanup in analyzer.
First pass with the new `comment_reference` lint.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1994243002 .
2016-05-19 10:24:53 -07:00
Brian Wilkerson 675c221140 Remove a couple of unnecessary is checks
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1906543002 .
2016-04-20 08:38:50 -07:00
Brian Wilkerson f0d249e269 Clean up package imports and library names
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1513643009 .
2015-12-10 08:11:56 -08:00
Brian Wilkerson c5f82b8376 Additional clean-up after moving to the new task model; a breaking change needed to allow a bug to be fixed
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1503203002 .
2015-12-07 12:02:42 -08:00
Konstantin Shcheglov d49d0f7e06 Wait for InstrumentationService.shutdown() before exit(0).
Otherwise we don't get the last portion of instrumentation data in the
file at all.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1413403007 .
2015-11-04 10:08:20 -08:00
Brian Wilkerson 24b24a3569 Reformat code to reduce churn
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1322513004 .
2015-09-09 08:19:41 -07:00
Brian Wilkerson 9aa45d4cf0 Capture more data when instrumenting exceptions
R=lukechurch@google.com

Review URL: https://codereview.chromium.org//1257023003 .
2015-08-06 08:50:39 -07:00
Brian Wilkerson 2980c8839d Improve logging performance
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1152923002
2015-05-23 09:14:31 -07:00
paulberry@google.com 279c20a625 Log details of calls to "pub list" to instrumentation.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1079673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45080 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 21:50:45 +00:00
scheglov@google.com 730390fb82 Overwrite local instrumentation file.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//977953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44243 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-04 18:19:23 +00:00
brianwilkerson@google.com 98b7382071 Reformat
R=paulberry@google.com

Review URL: https://codereview.chromium.org//975453004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44149 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 21:34:46 +00:00
brianwilkerson@google.com 5a4919c270 Add instrumentation (issue 22572)
R=paulberry@google.com

Review URL: https://codereview.chromium.org//956103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44071 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 19:54:36 +00:00
danrubel@google.com f5f408e412 send priority instrumentation message on startup with version info
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//859513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43017 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 17:30:47 +00:00
paulberry@google.com 81b8596681 Add indication of instrumentation active/inactive to analysis server status.
The instrumentation status shows up when querying the "/status" page, when analysis server is started with the "--port" option.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//847963003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42879 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 18:23:22 +00:00
scheglov@google.com e07125e634 Report incremental/full analysis performance via instrumentation.
R=brianwilkerson@google.com, lukechurch@google.com
BUG=

Review URL: https://codereview.chromium.org//844683003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42784 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 18:28:11 +00:00
brianwilkerson@google.com c63e50307a Instrument file reads
R=scheglov@google.com

Review URL: https://codereview.chromium.org//825683005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42748 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 18:26:52 +00:00
brianwilkerson@google.com 9fb54ea3db Capture log messages via instrumentation
R=scheglov@google.com

Review URL: https://codereview.chromium.org//840553004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42741 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 17:06:44 +00:00
scheglov@google.com 501d449ecc File-based and multicast InstrumentationServer implementations.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//833633004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42718 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 21:58:41 +00:00
scheglov@google.com b2835b572b Tweak for escaping in instrumentation.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//837753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42637 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 17:16:07 +00:00
brianwilkerson@google.com fa896352ca Escape field separator
R=danrubel@google.com

Review URL: https://codereview.chromium.org//835213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42634 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 15:37:20 +00:00
brianwilkerson@google.com 248d764ba5 Fix for issue 21982. Note the new instrumentation data tag.
R=danrubel@google.com

Review URL: https://codereview.chromium.org//818733006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42608 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 19:56:45 +00:00
scheglov@google.com d139fbfaa2 Add InstrumentationService.logPriorityException() and use logException() in refactorings.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//816103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42530 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 23:00:19 +00:00
brianwilkerson@google.com a49d0f02c9 Instrument top-level exceptions
R=paulberry@google.com

Review URL: https://codereview.chromium.org//797503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42513 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 17:11:02 +00:00
brianwilkerson@google.com 7c877ab009 Ensure shutdown is always called
R=paulberry@google.com

Review URL: https://codereview.chromium.org//814453003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42442 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 18:16:11 +00:00
brianwilkerson@google.com b9dc81cb2b Add support for a client id
R=jwren@google.com

Review URL: https://codereview.chromium.org//803523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42327 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 17:33:26 +00:00
brianwilkerson@google.com 44b69647a3 Rework instrumentation API
R=danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//801543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42321 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 16:00:23 +00:00
brianwilkerson@google.com 8bfeac0ca5 Instrumentation support
R=danrubel@google.com

Review URL: https://codereview.chromium.org//751063005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42179 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 20:30:19 +00:00