7ab0a914ba
Improve spec style and minor changes
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//461283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39199 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 14:46:56 +00:00
a6dd18a2d7
Cleanup in CodegenJavaVisitor.javaType(...), no functional change.
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//452313004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39166 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 21:35:46 +00:00
b685fa31ee
Get the RemoteAnalysisServer to compile against the new generated AnalysisServer interface.
...
This disables any and all functionality that is not up to date with the current server spec.
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//460423003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39164 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 21:14:24 +00:00
5731ca607a
Use hanging indentation when code generating Javadoc @params.
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//468563003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39160 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 19:52:54 +00:00
6e66a26763
Initial cut at generating the AnalysisServer.java interface. Currently this generates a commented out interface as the java server is not up to date with the spec.
...
This work iterates on the work that Paul started.
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//463163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39155 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 18:33:59 +00:00
153e73e155
Add an integration test for analysis.highlights.
...
Also fix sort order in the API definition of HighlightRegionType.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//463643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39152 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 18:16:37 +00:00
c25a70a1d9
Fixes for the missing highlights.
...
These problems were found in https://codereview.chromium.org/463643002/
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//454843004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39140 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 14:24:01 +00:00
37697c0e81
Rename InttestMixin -> IntegrationTestMixin
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//459203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39128 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 12:07:43 +00:00
19a44a67a6
Split up server_domain_int_test.dart; regularize integration test directories.
...
With this change, there is a separate subfolder in "test/integration"
for each domain, and each subfolder has its own "test_all.dart".
This change is almost entirely code motion. The only material change
is that two tests have been dropped:
- test_connected(): this test is now unnecessary since every time the
"server.connected" message is received, the generated code in
integration_test_methods.dart verifies that it is well-formed.
- test_error(): this was a placeholder to remind us to test the
"server.error" notification. On further reflection, it's unlikely
that we'll be able to integration test this notification, since it
only occurs in the event of a server bug.
R=jwren@google.com
Review URL: https://codereview.chromium.org//458453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39112 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 22:25:26 +00:00
61451c87ad
Tweak for AnalysisDomainHandler.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//463563004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39104 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 20:22:43 +00:00
7ff8e1a17b
rename CompletionSuggestionKind.VARIABLE to LOCAL_VARIABLE to match spec
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//463493003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39103 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 20:13:53 +00:00
3bd149aa45
remove duplicate suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//459853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39100 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 19:18:53 +00:00
931b0afaa6
Split analysis_domain_int_test.dart into several test files.
...
This test was timing out on the debug build bots because it had 6
sub-tests, each of which started a separate instance of the analysis
server. Split it out to one test per file.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//465513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39095 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 17:39:10 +00:00
ff1f9c2643
Code generate integration test streams for notifications.
...
When a notification is received from the server, it is checked to
verify that its type matches the analysis server API, and then it is
dispatched to the proper stream.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//453603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39094 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 17:34:27 +00:00
d80f9d9053
Improve matchers for enums defined by the analysis server API.
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//459643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39090 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 15:21:18 +00:00
8e1d92bcfa
rename and improve imported completion computer
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//458073002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39081 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 12:42:49 +00:00
d5f437d702
local code completion suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//454403003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39069 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 02:18:48 +00:00
80352fd61c
Fix analysis server to only send SERVER_STATUS when subscribed to.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//453263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39065 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-09 16:36:39 +00:00
abfa8dd268
Rework search_domain_int_test to avoid timeouts.
...
Now all sub-tests are run using a single analysis server so that the
SDK only needs to be analyzed once.
Reduces test time by about 9x.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//455983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39064 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-09 14:19:17 +00:00
dd94c27671
Always ignore 'packages' folders.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//452303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39052 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 21:09:52 +00:00
4392cc42a0
Support for excluded files/folders.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//456893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39046 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 19:42:07 +00:00
1a773207c5
Integration test search.getTypeHierarchy and make some minor fixes.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//456613004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39045 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 19:39:50 +00:00
575e80711f
Fixes for adding/removing pubspecs to/from roots.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//455863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39043 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 17:19:46 +00:00
d18d41fb37
Fixes for review comments.
...
Was in https://codereview.chromium.org/450103002/
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//454063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39040 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 16:36:34 +00:00
eda90c0529
Support for pubspec based contexts in subfolders.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//450103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39036 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 15:55:06 +00:00
320cbbf865
Rework "analysis.updateContent" analysis server request.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//449213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39034 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 13:15:26 +00:00
acd92bad63
Code generate integration test methods for synchronous request/response pairs.
...
These methods take care of validating requests and responses (unless
the optional argument 'checkTypes' is false); this should make writing
integration tests easier and less error-prone.
R=jwren@google.com
Review URL: https://codereview.chromium.org//451483005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39007 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 20:13:53 +00:00
25dd28dbf2
Churn-only CL for ContextDirectoryManager.
...
1. Sort and format implementation.
2. Convert tests into reflective.
3. Write comments for tests.
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//450643005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39000 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 18:04:21 +00:00
63b0d11e1b
Fixes for the 'pub' bot and 'analysis_server' on Windows.
...
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//444293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38962 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 02:01:58 +00:00
8b247578f1
Add Folder.contains(path) and use it in ContextDirectoryManager.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//444193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38958 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 22:25:04 +00:00
0f041852a6
Fix for opening SDK sources.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//449583003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38955 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 22:13:28 +00:00
b855a781d6
Remove RefactoringId from the analysis server API.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//446113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38954 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 21:07:59 +00:00
c5263aae9f
Breaking changes in 'analyzer' package.
...
1. Source.uri added.
2. DartSdk.fromEncoding() replaced with fromFileUri().
This CL cannot be committed as is until pkg/code_transformers is fixed.
R=brianwilkerson@google.com , sigmund@google.com
BUG=
Review URL: https://codereview.chromium.org//428303004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38949 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 20:41:42 +00:00
95cc1e5b14
Send 'analysis.errors' notification only for files in analysis roots.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//443213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38944 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 19:58:00 +00:00
a5c9375c30
incremental improvement to top level code completion results
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//440343003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38942 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 19:14:55 +00:00
5353760386
Change the type of Error.code from int to String.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//446983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38940 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 18:44:13 +00:00
0f559b00b0
Add analysis server API specification and related tools.
...
The source for the API specification is in
pkg/analysis_server/spec/spec_input.html. This file uses custom HTML
elements to declare the machine-readable parts of the specification.
The script pkg/analysis_server/spec/generate_files processes that file
and creates two output files:
- pkg/analysis_server/spec/api.html, the human-readable analysis
server spec.
- pkg/analysis_server/test/integration/protocol_matchers.dart, which
is used by integration tests to check the data returned by the
analysis server.
R=brianwilkerson@google.com , jwren@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//443873006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38937 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 18:34:21 +00:00
6224c56dbb
remove unused imports
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//444013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38933 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 15:49:18 +00:00
353546ff4a
Use checked mode in server integration tests
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//445703003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38912 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-05 22:23:48 +00:00
41c4564935
Make Change implementation consistent with the server spec.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//447613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38908 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-05 21:39:05 +00:00
5503d8d727
Change description in analysis_server pubspec to no longer reference web sockets
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//441063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38903 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-05 20:47:01 +00:00
ec6f1dfb64
Simplify handling of pathnames in integration tests.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//437383003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38890 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-05 03:30:06 +00:00
e1697e7488
Remove 'analysis.updateSdks' from server.
...
R=jwren@google.com , brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//436423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38887 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-04 23:42:55 +00:00
ab7701a740
Update 'search.getTypeHierarchy' to the latest spec.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//421123005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38885 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-04 23:27:25 +00:00
cef6c26a95
Update 'analysis.override' notification to the latest spec.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//440743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38882 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-04 21:21:22 +00:00
ec0633a5ec
incremental progress reworking code completion manager / computers
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//436263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38871 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-04 17:37:06 +00:00
7e36498dd4
Add more matchers for use in analysis server integration testing.
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//439313003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38868 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-04 17:15:09 +00:00
9714894e8e
incremental progress aligning code completion api to spec
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//424543004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38835 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-01 16:23:43 +00:00
f974128b01
Ignore 'dynamic' and 'void' elements in the occurrences computer too.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//438753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38809 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 23:48:30 +00:00
e9719d8fcd
Ignore 'dynamic' in the navigation computer.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//433973003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38797 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 20:54:20 +00:00
brianwilkerson@google.com