f0bc442ea4
cache suggestions on change in priority sources
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//787663004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42189 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 22:00:16 +00:00
dc9f446021
update computeFast/Full now that completion manager is long lived
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//758953003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42188 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:56:56 +00:00
7cd5226565
Annotate remaining analyzer/analysis server tests with "@ReflectiveTestCase()"
...
In r42181, I failed to notice the need to annotate these tests because
they aren't currently being run under dart2js (most likely due to
slowness). I've modified runReflectiveTests() to check for the
presence of the annotation before running the tests, in order to
ensure that all the classes are properly annotated now, and so that we
won't forget to add annotations in the future.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//742273005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42185 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:35:52 +00:00
e73e5faaad
Getters should not have parameters.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//787603004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42183 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:04:44 +00:00
a97ad9a625
Handle "fail_" style tests in reflective tests.
...
There is one corner case we don't handle--we don't catch the case
where the test is expected to fail, but the failure comes from an
asynchronous callback invoked via expectAsync(). Fortunately
expectAsync() is rare enough that this doesn't cause a problem with
any of our existing "fail_" style tests.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//790553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42180 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 20:33:18 +00:00
d05b81598f
Ported completion tests
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//785013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42176 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 20:00:24 +00:00
8ef4de75cd
include lower relevance suggestions only if they are already cached
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//784853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42172 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 18:56:43 +00:00
cbbcadc423
remove unused cache arguments
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//787653002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42167 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 16:59:02 +00:00
c3a22ba02d
invoke computeCache when priority sources change
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//787553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42160 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 12:04:32 +00:00
2d6a8357f3
make completion managers responsible for their own caches
...
- move cache out of CompletionDomainHandler into CompletionManager
- make CompletionManager longer lived
- move context and source fields out of DartCompletionManager and into superclass
- encapsulate information related to a specific request in new CompletionRequest rather than in the manager
- remove request specific information from CompletionManager creation
- use same ContextManager instance for consecutive requests on the same context/source pair
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//723263004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42157 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-07 19:31:59 +00:00
d0ec660798
Add an option for incremental resolution of API breaking changes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//781783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42113 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-04 17:10:29 +00:00
c4818d34c4
More work on logging - new classes and timers.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//780643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42090 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 19:47:06 +00:00
555401bc13
Add logging to the incremental resolver.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//774983003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42087 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 18:04:37 +00:00
1d4ba5fba7
Add paging support
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//769963003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42084 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 15:54:20 +00:00
354081528c
Update local functions methods/functions.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//770253003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42078 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-02 23:51:10 +00:00
03346f100e
Keep full test_ method names in reflective tests.
...
If found that when a test fails, need to copy its name, open outline,
don't forget to type * (i.e. Shift+8) and then paste the name.
It would be easier to have full names ready to copy.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//749083005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42067 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-02 15:22:41 +00:00
2427406da3
Fix for NPE in navigation after some incremental changes.
...
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//774543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42058 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-02 02:07:10 +00:00
20d82e5135
Compressed/optimized navigation notification.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//766323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42049 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-01 22:21:28 +00:00
ba033a38f9
Fix the code completion timing test
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//761533006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42007 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 20:09:17 +00:00
c5a938fde2
Allow the contents of the analysis cache to be inspected via http debugging.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//759083003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41975 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 00:51:55 +00:00
fa62416480
An option to enable 'print' to send output to the console.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//751353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41973 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 22:01:20 +00:00
283b78e260
Add --enable-incremental-resolution option.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//756193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41971 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 20:53:10 +00:00
002769a47c
Coalesce analysis server output messages into a single write call.
...
This ensures that only one call to stdout.write() is made per run of
the event loop, so the output of the analysis server should not fall
behind the rate of analysis.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//758833004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41969 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 20:39:49 +00:00
8a12fbbb59
Use write instead of writeln for client/server communication.
...
We have observed that each string sent from the server to the client
using stdout.write() takes at least one cycle of the event loop to
complete. Since writeln() is implemented using two calls to write(),
this means that streaming of messages to the client was almost always
falling behind the actual rate of analysis, resulting in very annoying
delays for the user.
As a stopgap, send each message from server to client using a single
call to write(). This doesn't completely solve the problem, but it
should reduce its impact while we work on a better solution.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//757013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41959 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 16:06:30 +00:00
369b7f3918
fix broadcast streams
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//752193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41940 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 20:26:59 +00:00
8745f2073a
new onPriorityChanged event stream
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//757613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41935 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 17:56:17 +00:00
0cd030eeb8
Issue 21613. Fix for renaming FieldFormalParameterElement.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21613
Review URL: https://codereview.chromium.org//749173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41929 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 16:00:28 +00:00
2996ef1754
Issue 21650. Fix linked positions added after insert code buffers.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21650
Review URL: https://codereview.chromium.org//750423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41928 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 15:52:58 +00:00
a255faf85c
Exchanging operands of a comparision operator should invert the operator.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//756483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41927 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 15:51:47 +00:00
52d55e933d
Issue 21662. Fix 'Sort Members' when both directives and declarations are updated.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21662
Review URL: https://codereview.chromium.org//753883003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41926 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 15:50:19 +00:00
be636515be
refactor import caching to exclude suggestions for inherited members
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//752833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41925 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 12:28:07 +00:00
651d589c2f
Remove flaky check from reanalyze_concurrent_test.
...
This should avoid sporadic false failures with this test. If in the
future we genuinely regress bug 21448, there is a danger that this
test won't catch it reliably, but that is mitigated by the fact that
(a) even flaky failures do get noticed, and (b) the bug was severe
enough that it probably would be noticed in manual testing. The extra
risk seems worth it to avoid the sporadic false failures we've been
seeing.
BUG=dartbug.com/21638
R=scheglov@google.com
Review URL: https://codereview.chromium.org//724403003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41870 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 22:52:30 +00:00
703b744966
Issue 21655. Don't import self when add type declaration.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21655
Review URL: https://codereview.chromium.org//747613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41869 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 22:10:57 +00:00
76f1d90e3e
Matching fields, some parameters, ignore locals.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//733203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41868 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 22:08:47 +00:00
947ec59930
Fix driver.dart
...
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//742023004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41867 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 21:49:59 +00:00
a714eb2faf
cache import suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//742163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41865 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 19:31:31 +00:00
5977fec49b
discard code completion cache if context or other sources change
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//744043002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41860 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 18:40:23 +00:00
4a50ed6cf8
cleanup hints
...
BUG=
R=brianwilkerson@google.com , paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//734403004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41852 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 14:03:18 +00:00
91c02b4a8e
Issue 21618. Fix for empty code for 'dynamic' type.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21618
Review URL: https://codereview.chromium.org//731313004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41838 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-19 17:42:29 +00:00
438fbd7f6b
Cache ElementLocation instance and index key/location ids.
...
This saves us about 9% of time, as the previous CL.
From 22294 ms to 20040 ms.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//739643003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41814 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 23:02:14 +00:00
58587a470e
Rollback r41807.
...
As discussed, it is not compatible with the incremental analysis.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//736603005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41809 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 18:50:28 +00:00
4032b4d86b
Use shorter DartElementLocation.
...
This improves analyzer + analysis_server analysis time from 21841 ms to 19839 ms.
I.e. about 9% faster.
However it is still 25% slower than without index at all - 15593 ms.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//738673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41807 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 16:21:01 +00:00
b7146b4ac1
Add the --no-error-notification flag to the analysis server flag set, not yet implemented.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//737623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41803 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-18 14:22:27 +00:00
b8da9bc651
Format and sort analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//725143004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 22:23:53 +00:00
fabddbd918
add ContextsChangedEvent
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//732093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41786 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 17:14:48 +00:00
f60be24eb8
add code completion cache
...
- generic mechanism for use in a subsequent CL
- minor get_handler import cleanup
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//729193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41778 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 15:13:38 +00:00
dc7f0c20dc
cleanup warnings
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//729283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41776 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 15:06:07 +00:00
30e11469c3
Use a better way to compute InterfaceTypes least upper bound.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//730803003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41761 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-15 16:52:58 +00:00
84c6c0d7ba
only wait for analysis if necessary when computing invocation suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//728143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41760 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-15 15:16:53 +00:00
0f0a275fc7
Issue 21612. Support for multiple returns in the 'Extract Method' refactoring.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21612
Review URL: https://codereview.chromium.org//725393002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41758 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-15 01:40:46 +00:00
danrubel@google.com