Commit Graph

3160 Commits

Author SHA1 Message Date
Danny Tuppeny 5da95d7c9f Fix AssistProcessorTest on Windows
Note: This fixes one of the tests but the other still fails. I believe
that's because of https://github.com/dart-lang/sdk/issues/32278 and
should pass once that issue is fixed.

Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I6469b75de39e6476353da303c9c72cfba2da922e
Reviewed-on: https://dart-review.googlesource.com/43006
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 17:37:11 +00:00
Danny Tuppeny 89240070b0 Fix AnalysisNotificationAnalyzedFilesTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I9d8c333f0c5070d932645d34986dc931b0038b61
Reviewed-on: https://dart-review.googlesource.com/43022
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 17:33:06 +00:00
Danny Tuppeny 6074dcfdae Fix LibraryPrefixContributorTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I7073e516109570ca80b1890368351e22b9ed844f
Reviewed-on: https://dart-review.googlesource.com/43004
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 17:10:38 +00:00
Danny Tuppeny 82a1702cc8 Fix OverrideContributorTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I68f0691007820e5efbabca58b6436d0c68d81487
Reviewed-on: https://dart-review.googlesource.com/43005
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 17:05:43 +00:00
Danny Tuppeny ddf36c26c9 Fix GetTypeHierarchyTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I57a1ebf7481e17d8cdd7be8d69c3ac84d0fcc185
Reviewed-on: https://dart-review.googlesource.com/43000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 17:02:33 +00:00
Danny Tuppeny f94a0f54e6 Fix CommonUsageSorterTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ie90a0b8823816d8b64f261e561183c35fb1737c8
Reviewed-on: https://dart-review.googlesource.com/43001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 16:56:03 +00:00
Danny Tuppeny 812b635ea3 Fix CompletionManagerTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I6b521604141b4584c4ed17470e7ea25b060af841
Reviewed-on: https://dart-review.googlesource.com/43003
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 16:51:53 +00:00
Danny Tuppeny 6437794e32 Fix LocalLibraryContributorTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ie57904d6eac2eabe8538400b4e56b2c414aebb35
Reviewed-on: https://dart-review.googlesource.com/42921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 16:39:43 +00:00
Danny Tuppeny 7d1f930949 Fix DiagnosticDomainTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I3b32087af3690ea7faa6715fdb6e5889b798b263
Reviewed-on: https://dart-review.googlesource.com/42948
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 16:25:03 +00:00
Danny Tuppeny e7d57c8535 Fix RenameClassMemberTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I57804f6c168cccdbfee62f8fa6b60b40f260015b
Reviewed-on: https://dart-review.googlesource.com/42946
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 16:17:33 +00:00
Danny Tuppeny 04830ac262 Fix RenameUnitMemberTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I98f2c5025615adf52919ea87d637a47ee50fe760
Reviewed-on: https://dart-review.googlesource.com/42942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 16:11:53 +00:00
Danny Tuppeny 9e96a89628 Fix NamedConstructorContributorTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I47d47bf7275f4e78d6e077d5f2c1e0ec4246c150
Reviewed-on: https://dart-review.googlesource.com/42943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 16:06:03 +00:00
Danny Tuppeny 0796ea4ee5 Fix RefactoringLocationTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ieead4b1d434740078a6383cafb426ddc4bbe002b
Reviewed-on: https://dart-review.googlesource.com/42941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 15:51:33 +00:00
Danny Tuppeny 1c44401f2e Fix LocalReferenceContributorTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I75a3b5200f6ef06c3c14233d45c897ae8bdd655c
Reviewed-on: https://dart-review.googlesource.com/42923
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 15:46:23 +00:00
Danny Tuppeny 427506d1f0 Fix LibraryMemberContributorTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I53c12fc79d0d5bf9331eb42714d7a6c29a5325af
Reviewed-on: https://dart-review.googlesource.com/42940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 15:36:43 +00:00
Danny Tuppeny 6a82f29e32 Fix ArgListContributorTest on Windows
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I04faca9575387faeca1cf6b505f05c15a1b0e670
Reviewed-on: https://dart-review.googlesource.com/42920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 15:29:36 +00:00
Konstantin Shcheglov 0346acf550 Don't suggest generative constructors of abstract classes.
So, we don't suggest EdgeInsetsGeometry for 'padding: ', even though
it is the type of the parameters. But we still suggest its subclasses
EdgeInsets and EdgeInsetsDirectional.

R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: If2d7ba550ec76e4f66cb81e1346466b5f1a30464
Reviewed-on: https://dart-review.googlesource.com/42888
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-22 02:03:33 +00:00
Konstantin Shcheglov fcccab9199 Filter constructor completions by required type.
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: I88eb345bfa7f0a65d135e5fdcb443d5dadd695c5
Reviewed-on: https://dart-review.googlesource.com/42882
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-21 23:12:31 +00:00
Konstantin Shcheglov ebd16bd33f New Quick Fix 'Convert to named arguments'.
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1100
Change-Id: I317204424c38313c8c3eb844d9e8bb574118aa66
Reviewed-on: https://dart-review.googlesource.com/42860
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-21 20:07:09 +00:00
Danny Tuppeny 23127d04b6 Fix test_ArgDefaults_function_with_required_named test on Windows
The changes in addSource are so that the driver gets the convertedPath
(newFile already converts).

The change in the test is to format a path for importing on Windows - it
seems that importing a file with an absolute path is a bit wonky on
Windows (I presume since this is testing imports it's using absolute
paths for a reason).

The helper in the Mixin is for doing the conversion from a Windows path
to an importable version of it (this has many questions to answer and
maybe already exists somewhere?).

See #32095.

Change-Id: Ifed137ac354f9d0527344020c719e0c3c81ccf3e
Reviewed-on: https://dart-review.googlesource.com/42681
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-21 18:49:19 +00:00
Danny Tuppeny d66e6b1c6e Fix refactoring tests on Windows
This hand-built JSON fails on Windows because the paths being inserted
only have a single slash ("C:\test.dart") but in the real results the
JSON is encoded correctly and hhas two paths.

This works around the issue by JSON-encoding the filename but really the
whole object should be serialised to JSON properly.

Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I8aa418e8e3e6377ed01fe3bbecc3242f3a012629
Reviewed-on: https://dart-review.googlesource.com/42742
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-21 18:49:12 +00:00
Danny Tuppeny 358a8502fd Fix UriContributorTests on Windows
See #32226.

Change-Id: I685b0b5875001a56af5c3cf623fe9bca7261b478
Reviewed-on: https://dart-review.googlesource.com/42740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-21 17:56:59 +00:00
Danny Tuppeny f1cdf5f9be Fix up plugin/protocol_dart_test.dart for Windows paths
See #32226.

Change-Id: I37362ba86188616dd1f0fd6623a62e05ee825454
Reviewed-on: https://dart-review.googlesource.com/42702
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-21 17:39:09 +00:00
Danny Tuppeny 20578644c0 Fix all remaining broken FixProcessorTest tests on Windows
See #32226.

Change-Id: Idc80d0ac7441e1db8c0213093b9b79d4b3e70315
Reviewed-on: https://dart-review.googlesource.com/42700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-21 17:19:19 +00:00
Kevin Millikin be30b62e3d Remove the Kernel type inference listener
We have decided to move to a different API for Fasta/Analyzer
integration, one that doesn't involve compiling to Kernel or observing
type inference.  The listener API will become broken, so let's just
remove it before that happens.

We lose the ability to trace type inference so let's restore that
ability next.  The analyzer's resolution storer is not used, but that
code has been left.  The resolution applier will no longer work
without the resolution storer, so those tests have been disabled.

Change-Id: If9ac5aba2d5de7788d8a65f7fa8410599e636d21
Reviewed-on: https://dart-review.googlesource.com/42400
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-02-21 16:28:07 +00:00
Konstantin Shcheglov fa82626405 Implement 'search.getDeclarations'.
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: I8bf18a15bdc7a761614849cdb32ad9361238289b
Reviewed-on: https://dart-review.googlesource.com/42586
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-21 15:54:33 +00:00
Danny Tuppeny 40e3f9addc Convert paths for mock SDK libraries to fix tests on Windows
The other lines on this method are calling `provider.convertPath` around their paths but these ones do not, which is causing almost all analysis server tests to fail on Windows (for me - I can't explain them not
failing builds). This causes the hard-coded paths like `/lib/core/core.dart` to be fixed up to `C:\lib\core\core.dart` which is what the server is looking for (because at the other end the paths *have* been fixed up).

See #32226.

Closes #32230
https://github.com/dart-lang/sdk/pull/32230

GitOrigin-RevId: 1adeee23f8ac8efc8acf61caf5f769e4ec44c030
Change-Id: Id9bf195967db0912c6f4b67bd79d504e627b8aab
Reviewed-on: https://dart-review.googlesource.com/42300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-20 18:55:38 +00:00
Brian Wilkerson ed88a91f62 Generate an import fix when an undefined function might be a constructor invocation
Change-Id: I1cc98cb14d66db6b241e2a5b008f45881c41d13b
Reviewed-on: https://dart-review.googlesource.com/42340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-19 22:03:22 +00:00
Konstantin Shcheglov ded8dd2ad3 Don't add explicit 'new' when previewDart2.
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/32175
Change-Id: I05c5845a6e511698833045f99716231974e57b61
Reviewed-on: https://dart-review.googlesource.com/42320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-19 19:51:44 +00:00
Konstantin Shcheglov 8fa5567edb API for search.getElementDeclarations.
The goal is to provide clients (specifically VS Code) with API that
is fast, and can search top-level and class member declarations.

I'm not sure whether we want ElementKind, it has kinds that we will
not use, e.g. I don't think we will return local variables or
parameters.

It would be probably still a lot of information, maybe we should use
single string table in response?

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: Ie31bb398a08d462c1cb08c7d82c4443c0c09932a
Reviewed-on: https://dart-review.googlesource.com/42105
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-17 04:27:52 +00:00
Brian Wilkerson b48c12a000 Use the selection computed by the builder in the override contributor
Change-Id: I85b7700bc137388d878c66282660df0d4b8d95af
Reviewed-on: https://dart-review.googlesource.com/42100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-16 20:52:52 +00:00
Konstantin Shcheglov a412f24e41 Add tests for highlighting implicit instance creation.
And in general run analysis server tests with `previewDart2 = true`.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I063d667e96a46d60d3b10aa1a87b4c7a7d2252e5
Reviewed-on: https://dart-review.googlesource.com/42101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-16 20:52:01 +00:00
Konstantin Shcheglov b17ac68b60 Add <Widget> type arguments for wrapping with Column/Row.
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I6e8ee33c453e552965d14ecb95391eb55b7b0bc6
Reviewed-on: https://dart-review.googlesource.com/42025
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-16 18:45:17 +00:00
Konstantin Shcheglov 6790cc30ef Highlight class names in instance creations as constructors.
This is needed for better highlighting optional new/const. I think the
main reason is that 'new' is highlighed and we knew that this is a
new instance creation. Constructors are also highlighed in the default
color scheme. But class names are not. So, to make code look colorful
again, we need to highlight class names in instance creations.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I8fde0b4aa5243e94d7ba575a74d52d31d3b665bb
Reviewed-on: https://dart-review.googlesource.com/42021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-16 17:50:27 +00:00
Brian Wilkerson 0501c740ac Member overrides invoke the overridden member and the display label uses ellipses
Change-Id: I9cb2db1514a8a2798cb3ec69d3d71047573a8dd4
Reviewed-on: https://dart-review.googlesource.com/41903
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2018-02-16 14:12:27 +00:00
pq 3dd7eae4c8 Add @required prefix to required params.
See: https://github.com/flutter/flutter/issues/10219
Change-Id: If8bd55b5a3557f8c49430079b790727f7ba25217
Reviewed-on: https://dart-review.googlesource.com/41924
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-16 00:13:30 +00:00
Konstantin Shcheglov 4039224d5c Don't set the exit position for Flutter Quick Assists.
We decided that we don't want to move caret under the user.

R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/32184
Change-Id: I86199bb060fbbbb8e521572d046b3fcdef80f74d
Reviewed-on: https://dart-review.googlesource.com/41920
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2018-02-15 23:54:06 +00:00
Konstantin Shcheglov 7d0877dbf6 Remove unused methods in assist/fix tests.
R=brianwilkerson@google.com

Change-Id: I6aa5ef067bb3cee4cbd8ffc01bf60bf0637f773e
Reviewed-on: https://dart-review.googlesource.com/41880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-15 19:13:35 +00:00
Konstantin Shcheglov 1e999ed9fe It is OK to inline Column with a single item in 'children' into a 'child'.
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Ifa2a300b2735ab635bbaeeee08ce21ad8a7db9b7
Reviewed-on: https://dart-review.googlesource.com/41901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-15 18:25:57 +00:00
Konstantin Shcheglov 95f336a667 Don't suggest imports of private libraries from other packages.
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1661
Change-Id: I5e458e8815d4f8df3e2f22bdfdc21c7203cefde0
Reviewed-on: https://dart-review.googlesource.com/41620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-15 17:11:56 +00:00
Mike Fairhurst 85973b9a54 Simplify analysis server's excluded file handling
Change-Id: I30bc19e7c185cb3dffbe5b84d0bd3f7b5b6f585b
Reviewed-on: https://dart-review.googlesource.com/41562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
2018-02-14 22:25:54 +00:00
Konstantin Shcheglov 425e07d721 If selection in 'Extract Method' does not cover any node, extract the smallest covering expression.
Two comments.

1. We need also to change the Dart plugin for IntelliJ to not select
   the whole line when selection if empty. The whole line is almost
   never a good choice for Flutter.

2. This is not fully consistent with "Extract Lolal" where we give the
   client the list of possible expressions to extract and the user can
   then choose. Here we use just the smallest one. If we want to make
   it consistent, we will need to enchance the protocol and the plugin.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I87a752234d9c825d78a6d787d2b21d1b252166c2
Reviewed-on: https://dart-review.googlesource.com/41520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-14 20:43:13 +00:00
pq be4040214c Enable @override completion contributions.
See: https://github.com/flutter/flutter-intellij/issues/1110
Change-Id: Iaddb5e9818f737889a484f562febcb4ca72d1017
Reviewed-on: https://dart-review.googlesource.com/41483
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-14 20:23:59 +00:00
Konstantin Shcheglov b5cb793fbd Convert unresolved 'children:' into 'child:'.
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I3ea3f8a8be2e942a3fd00060519a7dbfeae6fb36
Reviewed-on: https://dart-review.googlesource.com/41481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-14 20:23:43 +00:00
Konstantin Shcheglov 4232ac99e8 Fix for surround-with linked edit positions.
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/32106
Change-Id: Ia899171aa38dd1283b72cdd100a0f5b678e9b565
Reviewed-on: https://dart-review.googlesource.com/41420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-14 18:55:33 +00:00
Devon Carew 7579c58fad Rename 'Add widget padding' to 'Add padding'.
Change-Id: I9483e4ed3abe5ccad000b04ed7fe1098ac977e90
Reviewed-on: https://dart-review.googlesource.com/41320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-02-14 16:50:53 +00:00
Paul Berry 421db9c69c Re-land "Implement proper checking for callability of Function class."
(was reverted in https://dart-review.googlesource.com/c/sdk/+/40980
due to an analyzer bot breakage)

Original commit message:
Implement proper checking for callability of Function class.

There was some old (incorrect) logic for doing this, behind the flag
enableStrictCallChecks.  This flag has been removed, since the new
behavior is now standard in Dart 2.0.

Fixes #31509

Change-Id: Ice5cf38bbc648badf7f2563ff930b69f9a799635
Reviewed-on: https://dart-review.googlesource.com/41120
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-02-14 11:30:23 +00:00
Konstantin Shcheglov 4749057586 Don't suggest converting unresolved 'child:' to 'children:'.
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/841
Change-Id: Ib16b8a1e28e18cec9fd30a2f7d364355ce70b757
Reviewed-on: https://dart-review.googlesource.com/41060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-13 23:30:51 +00:00
Konstantin Shcheglov 51eb30dbba New Quick Assists 'Move widget down/up'.
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1638
Change-Id: I84dd60d30409fde430bb9ba3eb794c3c404d66b1
Reviewed-on: https://dart-review.googlesource.com/41023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-13 23:01:41 +00:00
pq f2e063c35e Selection range calculation for override completions.
Change-Id: If3a56c6b5274d5615742ded1ab213918331f4a0c
Reviewed-on: https://dart-review.googlesource.com/41021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-13 22:44:13 +00:00