84350e186c
fix named param default value code completion
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//897483003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43540 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:50:57 +00:00
dc95fd3689
use propogated type for completions
...
BUG=dartbug.com/21457
R=scheglov@google.com
Review URL: https://codereview.chromium.org//902983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43539 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:43:15 +00:00
fa0dc53f6f
fix code completion in conditional expressions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//904653004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43538 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:33:07 +00:00
95a9962be0
Use MemoryResourceProvider in server and execution domain tests
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//896423004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43530 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 22:46:41 +00:00
81ebd5fd77
Fix for extracting local variable in if-else-if statements.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//879463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43528 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 22:36:56 +00:00
e5a34c3c12
fix completions in indexed expression
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//902913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43523 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 21:42:43 +00:00
ae2e608ff9
Send notificatinos after no-op changes.
...
This should solve the problem when client remove some part of the code,
so removes also error markers for it, and then quickly restores it,
so for the server it looks as an empty/no-op change. But information is
lost, and the server should resend it to the client.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//899753004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43521 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 20:42:17 +00:00
2425d0c57c
const rename and cleanup
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//904603004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43520 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 19:50:42 +00:00
8233434126
move relevance computation from client to server
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//901253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43519 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 19:36:19 +00:00
fcd7fdb93a
Fix ambiguous description
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//901063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43493 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 01:31:09 +00:00
a65a5b599b
Have analysis.getLibraryDependencies wait for the server.onAnalysisComplete completer
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//891693003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43489 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 22:06:50 +00:00
6ddc37a5cc
Disable analysis in hidden directories (fix for issue 22170)
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//880313006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43485 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 21:27:43 +00:00
dbd0fa9d68
fix exception and improve keyword completion
...
BUG=dartbug.com/22231
R=scheglov@google.com
Review URL: https://codereview.chromium.org//897833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43466 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 13:18:42 +00:00
51842b06f2
Fix type hierarchy when there is no element.
...
This one was caught by an integration test.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//892913004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43445 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 23:01:51 +00:00
1a94fa3a6a
Wait for analysis in search domain. Rewrite with async/await.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//894323003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43435 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 21:59:31 +00:00
75c26fe8e9
New analyzer version before push.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//893223002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43412 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 17:39:27 +00:00
d04ad125fc
Add link to performance data
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//892843005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43410 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 17:28:11 +00:00
658d3e949e
Check PackageMapUriResolver constructor arguments.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//887943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43405 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 16:06:25 +00:00
98e926db9a
Support for inspecting index.
...
Page http://127.0.0.1:2040/index/element-by-name?name=sendAnalysisNotificationHighlights
shows all relations with elements named 'sendAnalysisNotificationHighlights'.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//894853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43377 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 03:11:09 +00:00
cd996f37bf
Improve error reporting on status page
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//899513003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43374 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:34:29 +00:00
ba6742f9fe
Formatter service API tweaks.
...
Some way to indicate no selection is required in the case where there is none. I opted for the -1 convention not becuase I particularly like it but because, well, it's convention! :)
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//894863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43369 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:14:22 +00:00
81c90c6492
Specify mapUri for directories
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//896513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43364 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 22:45:50 +00:00
b40a5702b3
Fix async/await type checking in analyzer.
...
This required making the "async" library into TypeProvider so that we
can create Future<...> types when doing resolution and error/hint
checking.
BUG=21888,22053,22091,22092,22160,22164
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//898513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43361 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 20:58:37 +00:00
03874e1c60
record and display request latency
...
and update unknown page handler
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//894823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43359 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 19:44:51 +00:00
46e5078360
Bump analyzer rev pre pub publish.
...
Addresses bug in setting linter options.
R=danrubel@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//873883005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43341 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 17:46:37 +00:00
dd09212ee5
fix internal option typo
...
BUG=
Review URL: https://codereview.chromium.org//887053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43339 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 15:53:36 +00:00
01ea08c589
Fix incremental resolution of files referenced by multiple contexts.
...
There were two problems:
1. When a file was set as a priority, we weren't propagating that
information to all contexts; as a result, the resolved AST wasn't
cached in all contexts, so incremental resolution wasn't able to take
place in all contexts.
2. In setPriorityFiles we weren't scheduling analysis operations, so
even after the file was made a priority, its resolved AST wouldn't be
available until some other event triggered analysis in that context.
BUG=dartbug.com/22209
R=scheglov@google.com
Review URL: https://codereview.chromium.org//892493003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43323 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 00:27:58 +00:00
952c2c260f
Bump server analyzer dep to point to latest dev build.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//880103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43316 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 21:56:55 +00:00
f9f324ca9b
Avoid redundant notifications when a file is analyzed in multiple contexts.
...
BUG=dartbug.com/22210
R=danrubel@google.com
Review URL: https://codereview.chromium.org//887793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43315 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 21:42:48 +00:00
675b99110c
fix race condition when recording computeCache performance
...
and improve completion performance status page
BUG=dartbug.com/22205
R=paulberry@google.com
Review URL: https://codereview.chromium.org//889583004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43299 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 17:00:57 +00:00
ef89b4c21a
tests for earlier CL
...
BUG=dartbug.com/21768
R=paulberry@google.com
Review URL: https://codereview.chromium.org//882273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43295 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:50:24 +00:00
cb6c16922f
Fix for issue 22052
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//881403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43292 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:01:58 +00:00
b9f3559e03
(TBR) fix failing test
...
BUG=
Review URL: https://codereview.chromium.org//881413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43258 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 20:39:36 +00:00
4229cb1c6f
use CompletionTarget for replacement offset/length
...
add code completion replacementLength and replacementOffset assertions
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//886463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43255 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 20:11:10 +00:00
36ce6423a6
Fix for two semantic highlighting problems.
...
1. We need to dispose the existing semantic highlighting manager before setting a new input.
So, we would not apply old highlighting to the new file.
2. We need to clear "input" fields to correctly determine full file path.
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//882203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43254 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 19:55:25 +00:00
c5af5132fc
Issue 22191. Grab the document lock before positionsLock to prevent deadlock.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22191
Review URL: https://codereview.chromium.org//885653005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43251 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 18:33:16 +00:00
b35d83dbad
Revert 43227
...
BUG=
Review URL: https://codereview.chromium.org//878353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43228 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 04:48:18 +00:00
5a7c80ab80
(TBR) fix the build
...
BUG=dartbug.com/22180
Review URL: https://codereview.chromium.org//882913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43227 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 04:30:36 +00:00
ea333d8459
Fix mixin resolution order when multiple mixins present.
...
BUG=dartbug.com/22069
R=scheglov@google.com
Review URL: https://codereview.chromium.org//879093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43224 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 23:41:21 +00:00
a016a7b56e
Fix for 'Convert Method to Getter' when multiple files are changed.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//881943002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43221 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 23:12:23 +00:00
3c66f9be64
Change server API version to 1.0.0 for clients
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//881873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43212 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 22:06:16 +00:00
b280b861f9
Issue 22143. Navigation from super initializers.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22143
Review URL: https://codereview.chromium.org//882823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43209 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 21:50:00 +00:00
c93b24904d
Issue 22157. Cancel a pending refactoring request on receiving a new one.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22157
Review URL: https://codereview.chromium.org//884453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43201 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 19:24:19 +00:00
af8a953cb8
Tweaks for refactoring manager.
...
My forgotten changes for your review comments.
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//880613004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43194 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:39:15 +00:00
b9f355d2a4
Library dependencies server API updates (to pass package maps).
...
R=brianwilkerson@google.com , jwren@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//874373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43193 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:23:09 +00:00
4f5494c2ac
Clean up and add analyzing contexts
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//875663002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43170 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 03:40:39 +00:00
aac571f7a0
Add tests for additional bugs fixed by r43163.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//862133006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43168 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 01:09:54 +00:00
7bf029506d
Fix "reanalyze sources" when there are unsaved files.
...
The analysis server now maintains a single content cache which is
shared by all contexts; this allows it to persist the content cache
across reanalysis (which destroys all contexts and recreates them from
scratch).
Two other bugs are fixed in the process:
- If a file is analyzed in multiple contexts, then editing it will
cause all affected contexts to be notified of the change. (Note
that this could potentially account for some other strange behaviors
we've seen recently, such as incorrect semantic highlighting and
lingering errors/warnings.)
- If the client supplies a ChangeContentOverlay for a file which
currently has no overlay, the proper error is generated.
I plan to submit tests for these two bugs in a follow-up CL.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//880643005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43163 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 23:26:45 +00:00
23b8a90d91
Use async/await in edit_domain.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//876633005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43162 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 23:13:47 +00:00
7db81a77c0
Make AnalysisServer.onAnalysisComplete a Future and wait for it before refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//875163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43158 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 22:31:51 +00:00
danrubel@google.com