ebe2ce681e
Fix ClassElement.allSupertypes to include interfaces of mixins (issue 29767)
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/3000183002 .
2017-08-18 07:30:05 -07:00
d87fcfd233
Correctly update positions when adding edits before them (issue 30444)
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2997073002 .
2017-08-16 10:29:26 -07:00
35f6d5da1b
Correctly handle adding imports when pasting into part files
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001733002 .
2017-08-16 07:43:36 -07:00
44b5341de8
Update edit.importElements response data to support part files
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001723002 .
2017-08-15 08:51:51 -07:00
eaf779ba1e
Fix insertion of imports when there are no existing directives (issue 30430)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3002643002 .
2017-08-14 13:32:57 -07:00
31887d6e42
Add a test that requires adding an import
...
Review-Url: https://codereview.chromium.org/2998903002 .
2017-08-13 08:33:50 -07:00
8c8969db4c
Forward Kythe requests to plugins and merge in the results
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/3000823002 .
2017-08-12 08:16:34 -07:00
0647d9a228
Improvements to analysis server closing labels ( #30411 )
...
* Tweak comment that was based on integration test verison.
See #30285
* Include additional 1/2-line spans that end on same lines as >2 line spans.
See #30285
* Add tests to ensure no unwanted closing labels from multiline expressions.
See #30285
* Don't show closing labels for code inside interpolated strings.
See #30285
* Remove unwanted @soloTest.
See #30285
* Make casing of test names consistent.
See #30285
* Add a constructor and make fields final.
See #30285
* Use putIfAbsent for adding to map.
See #30285
* Shorten closing labels constructor.
See #30285
* Run "Sort members" on closing labels files.
See #30285
* Remove unnecessary type annotations.
See #30285
2017-08-11 11:04:34 -07:00
c8f8f8e7cc
Ignore two unused element warnings in pkg/analysis_server.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2994113002 .
2017-08-10 11:36:12 -07:00
619f2995ab
Implement analysis server closing labels (work-in-progress) ( #30372 )
...
* Add empty closing labels computer/visitor and tests.
See #30285
* Add initial implementation and test for closing labels.
See #30285
* Add various tests for analyzer closing labels.
See #30285
* Fail tests if errors occur.
Without this the notifications will never come through and the test will time out. This causes them to fail right away on errors.
See #30285
* Add test and fix for crash that occurred during testing.
See #30285
* Remove unnecessary abs().
See #30285
* Remove question that has been answered (yes).
See #30285
* Remove unnecessary .argumentList on spansManyLines check.
See #30285
* Add test for prefixed import and constructor names.
The behaviour seems like what we want, though need to confirm if this is the best way to do it.
See #30285
* Add additional prefixed tests and another TODO.
See #30285
* Fix method invocations to show full target/name.
See #30285
* Fix constructor invocations to not use toString().
See #30285
* Convert most closing label tests to unit tests.
See #30285
2017-08-09 14:13:47 -07:00
305e84f70a
Fix the buildbots by adding a line for kythe.getKytheEntries to the coverage.md file
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2993353002 .
2017-08-09 13:40:09 -07:00
8a426f3d67
Initial experimental Kythe Dart Analysis Server protocol
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2995683002 .
2017-08-09 12:44:59 -07:00
973d0e1bd1
Add analysis server notifications to the api coverage doc.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/3000563002 .
2017-08-09 10:28:35 -07:00
beae4b29f1
Handle creation of class members in files other than the file containing the error
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2998703002 .
2017-08-09 08:57:29 -07:00
c4420a8943
Add "closing labels" to API spec. ( #30332 )
...
* Add "closing labels" to API spec.
See #30285
* Re-generate spec after adding "closing labels".
See 30285
2017-08-08 11:54:37 -07:00
89c910b9c1
Move byte_store.dart and file_byte_store.dart to their own subdirectory.
...
This allows us to use the subpackage relationships test to verify that
they don't import any other parts of front_end, which paves the way
for the possibility of moving them to their own package in the future.
R=scheglov@google.com , sigmund@google.com
Review-Url: https://codereview.chromium.org/2990323002 .
2017-08-07 11:04:48 -07:00
4c635b7b85
Initial support for an explicit plugin list
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2988343002 .
2017-08-02 11:30:57 -07:00
f383c17bc2
Redo our benchmarks; add a benchmark/benchmarks.dart tool.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2986293002 .
2017-08-02 08:07:38 -07:00
ae69313731
Initial implementation of the import-aware copy support
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2988183002 .
2017-08-01 08:32:12 -07:00
45d0b24283
Add a test for import-aware paste
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2992133002 .
2017-08-01 08:20:30 -07:00
5b88eef0af
Suggest covariant in parameter lists
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2986133002 .
2017-07-28 10:33:07 -07:00
9591a9449f
Partial support for intelligent paste operation
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2986073002 .
2017-07-27 13:55:59 -07:00
c618032a69
Remove the uri from the ImportedElements object in the experimental spec API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2991893002 .
2017-07-27 12:52:38 -07:00
9a6b134d33
Improve name generation for indexed expressions
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2990793002 .
2017-07-27 07:58:34 -07:00
950b4108f7
Add assist to convert part-of directives
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2986903002 .
2017-07-26 09:08:37 -07:00
b1589bf879
Replace typed_mock with mockito in analysis_server.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2991773002 .
2017-07-26 08:14:25 -07:00
8bbf373a5e
Remove the analysus.reanalyze request from the plugin API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2988743002 .
2017-07-25 12:10:52 -07:00
939d8aaf6d
Issue 30238. Fix for subscribing for a notifications with already cached analysis result.
...
With the new 'sendCachedToStream' option we can control that whether
cached analysis result is also reported into the 'results' stream when
it is desirable (when we do this to send analysis notifications from
the stream listener). Or not, when it is not desirable, e.g. when we
ask becaue we need the results unit for Quick Assists.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/30238
Review-Url: https://codereview.chromium.org/2989633002 .
2017-07-25 10:28:25 -07:00
f434d87581
Fix the bots (TBR)
...
Review-Url: https://codereview.chromium.org/2986813002 .
2017-07-24 10:39:16 -07:00
0f9707073d
Add support for creating a .packages file when the plugin is in a Bazel workspace
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2988673002 .
2017-07-24 10:00:05 -07:00
bdd69ccd6c
Remove UriReferencedElement with its uri/uriOffset/uriEnd properties.
...
The 'Move File' refactoring does not work, so I comment out most
of its code.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2982993003 .
2017-07-19 09:31:03 -07:00
90121b528a
Remove the 'Move File' refactoring.
...
It has been broken since we switched to Analysis Driver.
Given that IDEA does not use it, there is little incentive to fix it.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2983783003 .
2017-07-18 17:59:20 -07:00
00d5012906
Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt.
...
...instead of mixing formatting with actual changes in many CLs.
R=ahe@google.com , paulberry@google.com , sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2975253002 .
2017-07-13 16:28:18 -07:00
78f78feaf8
Don't include *.yaml files in 'analysis.analyzedFiles' notification.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review-Url: https://codereview.chromium.org/2980653002 .
2017-07-11 14:19:15 -07:00
5cd77dda37
AnalysisOptionsProvider.getOptionsFile() should return only existing files.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review-Url: https://codereview.chromium.org/2981553002 .
2017-07-11 13:38:08 -07:00
a673395664
Don't depend on visiting local functions.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2970403002 .
2017-07-07 13:01:23 -07:00
ee4a09faea
Fix for element_search.dart import in analysis_server.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2975473002 .
2017-07-06 12:38:56 -07:00
e454986288
Add code to run more tests from test_all
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2968233002 .
2017-07-06 12:24:01 -07:00
19265a82b4
Move findElementsByName() into shared analyzer/element_search.dart file.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2965133003 .
2017-07-06 11:51:17 -07:00
6323bedc58
Stop depending on LabelElement(s) to be reported in visitChildren().
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2973093002 .
2017-07-06 11:28:06 -07:00
cc5ccf5dcf
Add unit tests for copy/paste support
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2965243002 .
2017-07-06 09:54:42 -07:00
d4abd49df7
Add analytics to analyzer-cli and analysis server.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com , zra@google.com
Review-Url: https://codereview.chromium.org/2963323002 .
2017-07-05 23:29:46 -07:00
d9754a58e9
Initial implementation of copy/paste support
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2972833002 .
2017-07-05 14:02:07 -07:00
ce43a15e51
Stop depending of visiting LocalVariableElement(s) in Executableelement.visitChildren().
...
We still visit them, but analyzer and analysis_server don't need it.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2969343002 .
2017-07-05 12:28:20 -07:00
3c1c22a3a1
Add a quick fix for missing new (issue 30077)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2965063002 .
2017-07-05 10:59:34 -07:00
62f43f663b
Fix a bug in inline method refactoring
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2973673002 .
2017-07-05 09:35:48 -07:00
2f28f5713c
Fix a test so that it passes
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2968883002 .
2017-07-03 08:39:31 -07:00
0ee29eadf1
Run the generator after updates to spec
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2972473002 .
2017-07-02 07:49:05 -07:00
8c8a177f3c
Fix failing test (TBR)
...
Review-Url: https://codereview.chromium.org/2964343002 .
2017-07-01 12:55:17 -07:00
aadafd1bd5
Use DartEditBuilder to write types and remove dead code
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2972463003 .
2017-07-01 12:03:44 -07:00
Brian Wilkerson