dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

2234 Commits

Author SHA1 Message Date
Brian Wilkerson 98e8f17b96 Convert server to use RangeFactory 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2869083002 .
 2017-05-09 10:08:14 -07:00
Konstantin Shcheglov bd1ee32543 Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/. 
We are going to reuse ByteStore in front_end, also for incremental
compilation.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2869803004 .
 2017-05-09 09:12:15 -07:00
pq 11558c8a90 Add trailing commas after Flutter instance creation params fixes (flutter-intellij/#f978). 
R=brianwilkerson@google.com

Fixes: https://github.com/flutter/flutter-intellij/issues/978
Review-Url: https://codereview.chromium.org/2864373003 .
 2017-05-09 07:00:15 -07:00
danrubel 959b7c14b8 improve completion for formal param initializers 
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2864233002 .
 2017-05-08 06:50:46 -07:00
danrubel eb15a4c7c9 add constructor initializer completions 
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2869653002 .
 2017-05-08 05:52:12 -07:00
Brian Wilkerson 6b8a56cd7f Switch the default from non-driver to driver in several tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2864813002 .
 2017-05-07 08:34:16 -07:00
Brian Wilkerson 863bd921e1 Remove the non-driver versions of several tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2863593004 .
 2017-05-05 13:46:03 -07:00
Brian Wilkerson 0b59d3f650 Convert some tests to use the driver and prepare for others to be converted 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2859993004 .
 2017-05-05 13:20:38 -07:00
Brian Wilkerson d2bbfb4f77 Make an AstProvider available to AssistProcessors 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2862143003 .
 2017-05-05 09:24:30 -07:00
Brian Wilkerson 6c2023bd07 Move ChangeBuilder to analyzer_plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2860383002 .
 2017-05-05 07:52:27 -07:00
pq 1a394e975f Specify types in generated closure args. 
Follow-up from: https://github.com/flutter/flutter-intellij/issues/975

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2863683002 .
 2017-05-04 12:54:23 -07:00
Brian Wilkerson 4a9092d9c9 Change the ChangeBuilder API to use SourceRange 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2856233003 .
 2017-05-04 08:49:01 -07:00
pq 374871da75 Add default implementation when fixing missing required closures (flutter-intellij#975) 
Fixes: https://github.com/flutter/flutter-intellij/issues/975

Also improves code generation for required lists to include empty list literals.

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2862623002 .
 2017-05-03 13:22:52 -07:00
Brian Wilkerson 78eec999e5 Fix a broken test (TBR) 
Review-Url: https://codereview.chromium.org/2861593003 .
 2017-05-03 13:21:00 -07:00
Lasse R.H. Nielsen 7998f590b1 Update documentation on trignometric functions. 
Fixes #17515
BUG= http://dartbug.com/17515
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/40220ec0766bb2b179d3623d3f298223df842279
Review-Url: https://codereview.chromium.org/2852053002 .
 2017-05-03 09:49:14 +02:00
pq a51af38461 Widget details for Flutter children: param completions. 
R=brianwilkerson@google.com

See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2855883003 .
 2017-05-02 13:50:34 -07:00
Steve Messick 28b7710190 Complete declarations; detect invalid blocks 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2852073002 .
 2017-05-01 08:45:41 -07:00
Florian Loitsch 05e0e1ea40 Revert trigonometric function updates. 
The VM has a fingerprint on the function and failed during compilation.

Revert "Fix patch errors."

This reverts commit ff1d7488d9.

Revert "Update documentation on trignometric functions."

This reverts commit 40220ec076.

BUG=

Review-Url: https://codereview.chromium.org/2851163003 .
 2017-05-01 16:06:56 +02:00
Florian Loitsch ff1d7488d9 Fix patch errors. 
Review-Url: https://codereview.chromium.org/2853813002 .
 2017-05-01 15:57:40 +02:00
Erik Corry aa6353b6da Dart SDK Spelling b, c, and d. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2850783002 .
 2017-05-01 08:28:10 +02:00
Brian Wilkerson 725261ecdd Add support for recording a log file during tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2851833003 .
 2017-04-28 16:47:00 -07:00
jpaulsen 6ff38127d6 New Lint quick-fix: await_only_futures (#29490) 2017-04-28 14:00:52 -07:00
jpaulsen ddd9bb1be2 New Lint quick-fix: avoid_annotating_with_dynamic (#29489) 
New Lint quick-fix: avoid_types_on_closure_parameters
 2017-04-28 13:40:51 -07:00
Brian Wilkerson e55812a3f2 Unify the server and plugin versions of the generators 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2844273003 .
 2017-04-28 07:46:29 -07:00
pq daa399499d Fix following comma detection in code completion (#29503). 
BUG=
R=brianwilkerson@google.com

Fixes: https://github.com/dart-lang/sdk/issues/29503
Review-Url: https://codereview.chromium.org/2849703002 .
 2017-04-27 16:52:33 -07:00
pq efb5c5ddc5 Trailing commas for named args in Flutter cons invocations (flutter-intellij#551). 
* adds trailing commas to named params in Flutter instance creations
* adds trailing commas to default value boilerplate

See https://github.com/flutter/flutter-intellij/issues/551 for action shots. :)

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2850693002 .
 2017-04-27 14:58:02 -07:00
jpaulsen f929ab15e7 New Lint quick-fix: empty_statements (#29491) 2017-04-27 14:10:17 -07:00
pq e02902578b Fix selectionOffset testing. 
Follow-up from: https://codereview.chromium.org/2839273002/.

BUG=
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2848643003 .
 2017-04-27 10:54:24 -07:00
Brian Wilkerson d98d672c16 Add completion support for plugins. 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2842243003 .
 2017-04-27 10:26:46 -07:00
pq bfc071e515 Named arg completion fixes. 
Related to: https://github.com/flutter/flutter-intellij/issues/551

* fixes named arg selection offset to precede comma
* fixes inconsistent trailing commas between completions w/ and w/o prefixes

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2839273002 .
 2017-04-27 10:12:47 -07:00
jpaulsen 404f9a806c New Lint quick-fix: prefer_conditional_assignment (#29473) 2017-04-26 12:56:36 -07:00
jpaulsen ff46777c61 New Lint quick-fix: unnecessary_override (#29472) 2017-04-26 12:56:26 -07:00
Dan Rubel 3b790e5311 new TokenType and Keyword API 
This adds two new methods and adapts most of the old references
to use these new API. Once all call sites have been updated,
the old API can be removed.

This is part one of https://codereview.chromium.org/2842643004/

* replace type == TokenType.KEYWORD with type.isKeyword
* change Keyword.syntax --> Keyword.lexeme

R=paulberry@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2842213003 .
 2017-04-26 15:53:58 -04:00
Brian Wilkerson 207fffe067 Send re-analyze requests to plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2843093002 .
 2017-04-26 12:36:26 -07:00
Brian Wilkerson 65f492a043 Add support for watch events and error notifications 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2842013003 .
 2017-04-26 09:36:26 -07:00
jpaulsen 7979eadef0 New Lint quick-fix: unnecessary_this (#29469) 2017-04-25 16:40:01 -07:00
jpaulsen b90aad2b2e New Lint quick-fix: unnecessary_lambdas (#29459) 2017-04-25 16:14:58 -07:00
Steve Messick 17360ffa6d Add colon to switch cases and default 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2837063003 .
 2017-04-25 11:13:54 -07:00
Steve Messick 8c2aae7dee Fix detection of bad catch-clauses and try-statements 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2842523002 .
 2017-04-24 12:00:14 -07:00
jpaulsen dcba4b42cd New Lint quick-fix: prefer_collection_literals (#29378) (#29427) 2017-04-24 10:49:25 -07:00
Erik Corry 2fb5d08102 Spelling a 
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2841543002 .
 2017-04-24 14:53:51 +02:00
Brian Wilkerson 5695e95902 Add support for three more plugin requests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2834993002 .
 2017-04-22 09:02:30 -07:00
Steve Messick 00d04dda08 Add special completion for control-flow block exits 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2834913002 .
 2017-04-21 14:51:45 -07:00
Brian Wilkerson 4e3d3bdd9f Add support for converting from server to plugin protocol objects 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2830903004 .
 2017-04-21 08:37:12 -07:00
Steve Messick 6407af5dcb Clean up TODOs 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2830793007 .
 2017-04-20 15:19:16 -07:00
Brian Wilkerson aa36e43426 Add plugin support for getAssists 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2832643005 .
 2017-04-20 13:52:34 -07:00
Steve Messick b9c214f374 Compete try-statements 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2834513004 .
 2017-04-20 13:09:23 -07:00
Brian Wilkerson e1a2c81d0b Update PluginWatcher to be more efficient 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2830933005 .
 2017-04-20 12:39:50 -07:00
Brian Wilkerson 913560afb1 Enable missed tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2827353002 .
 2017-04-20 11:30:36 -07:00
Brian Wilkerson ba3ed4ba37 Initial support for getting fixes from plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2830863002 .
 2017-04-19 15:00:00 -07:00