dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

383 Commits

Author SHA1 Message Date
Jaime Wren 7e899d04ab Add fix-all in file fixes for the 2 additional dart analysis server fix types: USE_NOT_EQ_NULL and USE_EQ_EQ_NULL 
Change-Id: Ic8da1d1737145dbd3ddbf5939c327f882a74be24
Reviewed-on: https://dart-review.googlesource.com/57680
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2018-05-31 17:19:22 +00:00
Jaime Wren 8e00451bc2 Add fix-all in file fixes for the 3 additional dart analysis server fix types: ADD_NE_NULL, REMOVE_UNNECESSARY_CAST, REPLACE_BOOLEAN_WITH_BOOL 
Change-Id: Ifb8195e3c68a15faebe91649d86bf94ce9cb2de5
Reviewed-on: https://dart-review.googlesource.com/57486
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-31 16:16:42 +00:00
Jaime Wren b6d20fa975 Enable the fix-all feature for the DartFixKind.ADD_EXPLICIT_CAST fix, tests been added as well. 
Change-Id: I3d2273e0814ac14a597648456cd5035ec54360e5
Reviewed-on: https://dart-review.googlesource.com/57120
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2018-05-30 21:21:03 +00:00
Jaime Wren ca7d545df8 Follow up on initial fix-all fixes PR, https://dart-review.googlesource.com/c/sdk/+/56220, adding some assertions and a test. 
Change-Id: I6e22f8537f616ce2d09247f90bb81fff17eb1b66
Reviewed-on: https://dart-review.googlesource.com/56601
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-24 22:29:45 +00:00
Jaime Wren 351d70674d Initial new union of Dart Analysis Fixes, the initial fix is to remove all unused imports in a file. 
Change-Id: I259e796b2603234955a1950b2c886e6f08a697bc
Reviewed-on: https://dart-review.googlesource.com/56220
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-24 15:23:40 +00:00
Konstantin Shcheglov 9696c9dcd0 Change analysis_server tests to use /project/test.dart as the test file. 
Correspondingly all files that were referenced using relative URI(s)
also put into /project, which is the contextRoot for the test
AnalysisDriver.

This will let us (in a following CL) start checking that the element
being renamed is defined inside the current workspace (the set of
analysis roots). Currently the context root is hardcoded as /project.

R=brianwilkerson@google.com

Change-Id: I9dca3509af1be13c9016bf03d4a4b95d71bc9374
Reviewed-on: https://dart-review.googlesource.com/56031
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-22 00:31:22 +00:00
Konstantin Shcheglov 79a0ef60e0 Fix for 'Convert to final field' quick assist when no return type. 
R=brianwilkerson@google.com

Change-Id: I9927c8f44fcab8ad812939680a1a082f85cc9b66
Reviewed-on: https://dart-review.googlesource.com/56020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-21 20:51:10 +00:00
Konstantin Shcheglov 62ffedefdd Rewrite writing types to using existing writeXYZ() methods. 
Also extract code that ensures imports and writes prefixes into a
separate method.

R=brianwilkerson@google.com

Change-Id: Icd35af19435153bfaebd46f7611823e6a9830d20
Reviewed-on: https://dart-review.googlesource.com/55640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-17 15:51:27 +00:00
Konstantin Shcheglov 757ef3979c Revert "Revert "Revert "Don't do implicit new/const code generation with --preview-dart-2 enabled.""" 
This reverts commit 4089111540.

R=brianwilkerson@google.com

Change-Id: I66297466f8baafe6e070acbcb1776b41f3d9fedc
Reviewed-on: https://dart-review.googlesource.com/55506
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-16 19:43:22 +00:00
Konstantin Shcheglov d9d7cb12a6 Replace DartFileEditBuilder.importLibraries() with importLibrary(). 
It now returns the text of the URI that will be actually used, so
we can show it in the quick fix message without computing it separately.

R=brianwilkerson@google.com

Change-Id: I16a455d8f6a3c3e3a9c5779c94d654de32992006
Reviewed-on: https://dart-review.googlesource.com/55501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-16 18:46:22 +00:00
Konstantin Shcheglov 8907348ae9 Issue 2246. Fix for 'Wrap with new widget' assist when activated on a constructor name. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2246
Change-Id: I66ca8b121b2600fa86c787fc26fe6dc01c79c24d
Reviewed-on: https://dart-review.googlesource.com/55272
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-15 21:22:26 +00:00
Konstantin Shcheglov ee414b4d9d Issue 2249. Fix swap with parent/child when code is not formatted. 
We cannot just rely on line ends.
AST is our best guide.

R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2249
Change-Id: Id901878f621abc745fb6a380e5cf9afe21884642
Reviewed-on: https://dart-review.googlesource.com/55268
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-15 20:35:06 +00:00
Konstantin Shcheglov d48aa1b0c7 Issue 2244. Add 'Import Library' quick fix for (potential) implicit constructor invocations. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2244
Change-Id: I464b3bc872dc6df46197761c8f619cd69f194566
Reviewed-on: https://dart-review.googlesource.com/54962
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-14 18:17:08 +00:00
Konstantin Shcheglov 310745ca8b Add support for adding missing named parameters to constructors. 
I expected it to be more complex than it turned out to be.

R=brianwilkerson@google.com

Change-Id: I2a41204ea615ec7b65d7858bc4ed3908af17b2c1
Reviewed-on: https://dart-review.googlesource.com/54523
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-09 19:32:27 +00:00
Konstantin Shcheglov fd9823ae9e Issue 21965. Add Quick Fix for adding missing named parameter. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/21965
Change-Id: I81a39df6fd38f9f562b494483b3fe0f67f9a627b
Reviewed-on: https://dart-review.googlesource.com/54360
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-09 06:44:38 +00:00
Konstantin Shcheglov 0bab7e6bfa Issue 32765. Improve guess for type name identifier. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/32765
Change-Id: I7587fd2aaba50e4e07c9192d95141ece80d423b1
Reviewed-on: https://dart-review.googlesource.com/54303
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-08 18:57:58 +00:00
Konstantin Shcheglov f62302b8ee Make extracted widgets follow Flutter style - const constructor and @required named parameters. 
R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2166
Change-Id: I28f548c8e814ac5b9585dd46fbb9a8f84f70f418
Reviewed-on: https://dart-review.googlesource.com/54066
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-07 20:59:04 +00:00
Konstantin Shcheglov e5e83a29fb Revert "Add a fix for prefer_single_quotes" 
This reverts commit eb2fbf501f.

Reason for revert: there is already corresponding quick assist, and it might be confusing to have both. Sorry.

Original change's description:
> Add a fix for prefer_single_quotes
> 
> Change-Id: Ifb59ec4c6822858e019adf780bfd7726b229542e
> Reviewed-on: https://dart-review.googlesource.com/53824
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

TBR=devoncarew@google.com,scheglov@google.com,brianwilkerson@google.com,jmesserly@google.com,ianloic@google.com

Change-Id: I880c7188ba25eef66c704ade4b61de3be1b55eb9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/53880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-05 00:42:59 +00:00
Ian McKellar eb2fbf501f Add a fix for prefer_single_quotes 
Change-Id: Ifb59ec4c6822858e019adf780bfd7726b229542e
Reviewed-on: https://dart-review.googlesource.com/53824
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-05-05 00:01:06 +00:00
Konstantin Shcheglov 332dc7f3e9 Issue 32935. Fix NPE in 'Make final' quick fix. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/32935
Change-Id: I980ffebe48050f7835664fa4d7d798c6f48e755c
Reviewed-on: https://dart-review.googlesource.com/53840
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-04 21:19:26 +00:00
Janice Collins 1afe71c08a Enable preview-dart-2 as default for analyzer. 
Based on https://dart-review.googlesource.com/c/sdk/+/52340, but adds
the necessary plumbing through the test system to pass through
negations to strong and preview-dart-2.  Also adds support for those
negations to the analyzer.

Change-Id: I9793ff28bb593d25bbb0a2ed8736b5b53e0a62d8
Reviewed-on: https://dart-review.googlesource.com/52461
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-26 17:01:12 +00:00
Brian Wilkerson 7054d92a02 Remove some classes from the analyzer public API 
Change-Id: Ic53a8426818b06f44c2876abd16c789589bf78b5
Reviewed-on: https://dart-review.googlesource.com/52421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-24 15:28:15 +00:00
Konstantin Shcheglov 7b3a9c9aec Issue 2111. Copy documentation comments when 'Encapsulate Field'. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2111
Change-Id: If971e72b2cde15b7183f148da9da4d0dfed4ae05
Reviewed-on: https://dart-review.googlesource.com/52267
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-23 16:46:22 +00:00
Konstantin Shcheglov f755d9dc33 Don't specify 'void' return type for setters in 'Encapsulate Field'. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2104
Change-Id: Ib7fe60e27f37726be5131c8a2e915b7911773855
Reviewed-on: https://dart-review.googlesource.com/52180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-20 17:40:39 +00:00
Brian Wilkerson a456753267 Move a library only used by tests into the test directory 
Change-Id: Ie8dcadc6313b3745ef874954da968839eb460c71
Reviewed-on: https://dart-review.googlesource.com/52020
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-20 15:56:00 +00:00
Brian Wilkerson 9a7168a2bf Clean up dead code in quick assist support 
Change-Id: I983c78a9ad131e5ae35a83abf2f455608b3ae835
Reviewed-on: https://dart-review.googlesource.com/52060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-20 14:23:29 +00:00
Brian Wilkerson bdc727d49b Fix npe in quick fix computation (issue 32926) 
Change-Id: Ic93da063758513f101d753516cb61c351dae2501
Reviewed-on: https://dart-review.googlesource.com/51940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Danny Tuppeny <dantup@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-19 17:05:20 +00:00
Konstantin Shcheglov 1ff525c7f4 Add tests and fix a problem in inverting expressions. 
R=brianwilkerson@google.com, danrubel@google.com

Change-Id: I4085efd1a4457f01ccb6cf62bd535fed61a1217a
Reviewed-on: https://dart-review.googlesource.com/49541
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-04-04 18:29:05 +00:00
Konstantin Shcheglov 4089111540 Revert "Revert "Don't do implicit new/const code generation with --preview-dart-2 enabled."" 
This reverts commit e5ed23fdb5.

R=brianwilkerson@google.com

Change-Id: Ida33856e965f06f773025f3c625d6ab3bace80a8
Reviewed-on: https://dart-review.googlesource.com/49280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-03 22:29:09 +00:00
Konstantin Shcheglov e5ed23fdb5 Revert "Don't do implicit new/const code generation with --preview-dart-2 enabled." 
This reverts commit a1e4d8e0bf.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Don't do implicit new/const code generation with --preview-dart-2 enabled.
> 
> R=​brianwilkerson@google.com, devoncarew@google.com
> 
> Change-Id: I8a96a5ccceae57c3ed5c1f2e0fd4897a7e99df03
> Reviewed-on: https://dart-review.googlesource.com/48883
> Reviewed-by: Devon Carew <devoncarew@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=devoncarew@google.com,scheglov@google.com,brianwilkerson@google.com

Change-Id: Ie3acf0794ed7b8264682e29aaa4bc1516fce6981
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/48900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-30 19:24:46 +00:00
Jenny Messerly bed5debbeb Callable object support in Analyzer and DDC. 
Fixes #32156
Fixes #32157
Fixes #32426

This also fixes `implements Function` so it has no effect in Dart 2
(it is ignored for the purposes of subtyping.)

Change-Id: Ibec9c77cd516b8b97fef68a579998598d0acf8c6
Reviewed-on: https://dart-review.googlesource.com/45141
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-03-30 18:14:55 +00:00
Konstantin Shcheglov a1e4d8e0bf Don't do implicit new/const code generation with --preview-dart-2 enabled. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I8a96a5ccceae57c3ed5c1f2e0fd4897a7e99df03
Reviewed-on: https://dart-review.googlesource.com/48883
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-03-30 18:07:25 +00:00
Konstantin Shcheglov ce1d52481c Don't remove unused imports when there are unresolved symbols. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/32124
Change-Id: If1b7b57bd98922768f28584325f668ba612c69d7
Reviewed-on: https://dart-review.googlesource.com/48705
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-29 21:44:19 +00:00
Konstantin Shcheglov 98f627f989 Issue 32708. Make GenericFunctionTypeElementForLink implement GenericFunctionTypeElementImpl. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/32708
Change-Id: I50e3bf46ca276dbffed9cccb39d800bebb9aec68
Reviewed-on: https://dart-review.googlesource.com/48761
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-29 19:47:29 +00:00
Paul Berry 506ac7f953 Rework linker type inference using ExprBuilder. 
This CL changes the way linker type inference works.  Instead of
walking the operations in an UnlinkedExpr in order and inferring types
directly, it first builds an AST for the expression using ExprBuilder,
then uses ResolverVisitor to resolve the AST and perform type
inference.

This helps ensure that summary type inference and ordinary AST-based
type inference produce the same result, since they now use the same
core algorithm.  In particular, this means that summary type inference
now does downwards inference properly.

Since the ResolverVisitor makes greater use of the element model than
the rest of the linker, this required implementing additional methods
in the linker's element model.

This CL includes some minor fixes to ExprBuilder that were uncovered
during testing.  It also contains some minor changes to
ResolverVisitor to make it work during linking.

Fixes #32525.
Fixes #32394.

Change-Id: I5ec9b2bf5565ad30b8cc856475334323dc118da8
Reviewed-on: https://dart-review.googlesource.com/48741
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-29 17:16:39 +00:00
Konstantin Shcheglov 859632b439 Fixes for uninitialized fields of Flutter widgets create constructors in Flutter style. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2021
Change-Id: Ia5c8989d463ce7071b31069313e4638dea7b13a6
Reviewed-on: https://dart-review.googlesource.com/48700
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-28 20:28:28 +00:00
Brian Wilkerson dc5a8b2e91 Improve the fix to add an explicit cast 
Change-Id: I748bd56265ea3072a3b7ed49fa77f6a9e91c3093
Reviewed-on: https://dart-review.googlesource.com/47242
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-03-22 15:27:27 +00:00
Brian Wilkerson 746c2557a2 Correctly handle casts of Set in quick fix 
Change-Id: I00067a03b41cc0ace16501fc21b990b91ea0af61
Reviewed-on: https://dart-review.googlesource.com/46944
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-17 14:55:38 +00:00
Brian Wilkerson f6f1327fbe Add a fix to add an explicit cast 
Change-Id: Ib27b2609cce14ea6d7c1666388c653e757b82a64
Reviewed-on: https://dart-review.googlesource.com/46881
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-16 16:43:58 +00:00
Konstantin Shcheglov 2881ebcd78 Fix for lint non_constant_identifier_names. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/32488
Change-Id: I76580a581845d8c6d3c8003b6b0f631a5fc40cdb
Reviewed-on: https://dart-review.googlesource.com/46822
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-15 22:44:44 +00:00
Brian Wilkerson a0295ffa0e Convert analysis_server tests to pass under preview-dart-2 
Change-Id: Ibfdc53c7b1252166d44a0bda077e464a8c474572
Reviewed-on: https://dart-review.googlesource.com/46574
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-15 18:49:24 +00:00
Brian Wilkerson 8d47a6e86f Add a fix for lints that recommend using final (issue 32473) 
Change-Id: I9ba38998e99c6102c0b69a2a3f8427416d087f2e
Reviewed-on: https://dart-review.googlesource.com/45900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-09 22:09:18 +00:00
Brian Wilkerson 716daa3b0d Add assists to convert between literal string styles 
Change-Id: I691ff29d0bdc5a01cef6736f403025d1eee912d0
Reviewed-on: https://dart-review.googlesource.com/43580
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-02-24 21:45:32 +00:00
Konstantin Shcheglov 9567305bd6 Set selection position for Flutter move widget up/down assists. 
This requires also changes to Dart plugin for IntelliJ, because currently
we use exit position only when there are linked edits. I attempted to
implement it myself, it mostly works, but there are race condition
complications.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Iff1a79ebb0cb7e0eabfe59e45d8dde7559c60a0f
Reviewed-on: https://dart-review.googlesource.com/43600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-24 17:14:30 +00:00
Konstantin Shcheglov 0ce1a92d98 Suggest constructors for implicit creation in previewDart2. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/998
Change-Id: I43270f47fb43402d1a9e0f7d9814494ffd83bb5e
Reviewed-on: https://dart-review.googlesource.com/43080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-22 18:03:12 +00:00
Danny Tuppeny 5da95d7c9f Fix AssistProcessorTest on Windows 
Note: This fixes one of the tests but the other still fails. I believe
that's because of https://github.com/dart-lang/sdk/issues/32278 and
should pass once that issue is fixed.

Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I6469b75de39e6476353da303c9c72cfba2da922e
Reviewed-on: https://dart-review.googlesource.com/43006
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 17:37:11 +00:00
Danny Tuppeny 0796ea4ee5 Fix RefactoringLocationTest on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: Ieead4b1d434740078a6383cafb426ddc4bbe002b
Reviewed-on: https://dart-review.googlesource.com/42941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-22 15:51:33 +00:00
Konstantin Shcheglov ebd16bd33f New Quick Fix 'Convert to named arguments'. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1100
Change-Id: I317204424c38313c8c3eb844d9e8bb574118aa66
Reviewed-on: https://dart-review.googlesource.com/42860
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 20:07:09 +00:00
Danny Tuppeny 20578644c0 Fix all remaining broken FixProcessorTest tests on Windows 
See #32226.

Change-Id: Idc80d0ac7441e1db8c0213093b9b79d4b3e70315
Reviewed-on: https://dart-review.googlesource.com/42700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-21 17:19:19 +00:00
Brian Wilkerson ed88a91f62 Generate an import fix when an undefined function might be a constructor invocation 
Change-Id: I1cc98cb14d66db6b241e2a5b008f45881c41d13b
Reviewed-on: https://dart-review.googlesource.com/42340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-19 22:03:22 +00:00