dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

163 Commits

Author SHA1 Message Date
Brian Wilkerson 5460ddbab5 Move three more libraries out of the public API 
Change-Id: I8e6aeaea35c739fb26e22ffcfc30a343ebbb5424
Reviewed-on: https://dart-review.googlesource.com/51363
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-16 22:15:28 +00:00
Devon Carew 70a61e7e6e more fixes to windows tests for path issues 
Change-Id: Ic5e63be99cba833ee96f7b5c1c342b63095e0f47
Reviewed-on: https://dart-review.googlesource.com/49833
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-06 18:10:17 +00:00
Devon Carew 6ce79da9a1 Fix windows issues w/ the packages dir handling removal. 
Change-Id: I78cf4b8787da7449f8a7a2840b9dd91e2342d5ec
Reviewed-on: https://dart-review.googlesource.com/49830
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-04-06 16:24:52 +00:00
Devon Carew 7cbd0f55b5 Remove the special casing of 'packages' files from the analyzer and analysis server. 
Change-Id: I11fa2f73f7cdba8c53478c9002cefe82e58c09d6
Reviewed-on: https://dart-review.googlesource.com/49822
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-06 14:57:42 +00:00
Brian Wilkerson 26c06cdd82 Clean up Dart 2 type issues related to YAML support 
Change-Id: Ic29054afca9773286aa899eecede287f7ecbca9a
Reviewed-on: https://dart-review.googlesource.com/47680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-22 17:06:40 +00:00
Danny Tuppeny 9b1679c52d Don't send modifications for files that should not be analyzed 
Bug: https://github.com/dart-lang/sdk/issues/31564
Change-Id: I91b952cf8f47e5c8b8d12ef137cc2ef1575372d3
Reviewed-on: https://dart-review.googlesource.com/44421
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-01 18:00:39 +00:00
Danny Tuppeny 40e3f9addc Convert paths for mock SDK libraries to fix tests on Windows 
The other lines on this method are calling `provider.convertPath` around their paths but these ones do not, which is causing almost all analysis server tests to fail on Windows (for me - I can't explain them not
failing builds). This causes the hard-coded paths like `/lib/core/core.dart` to be fixed up to `C:\lib\core\core.dart` which is what the server is looking for (because at the other end the paths *have* been fixed up).

See #32226.

Closes #32230
https://github.com/dart-lang/sdk/pull/32230

GitOrigin-RevId: 1adeee23f8ac8efc8acf61caf5f769e4ec44c030
Change-Id: Id9bf195967db0912c6f4b67bd79d504e627b8aab
Reviewed-on: https://dart-review.googlesource.com/42300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-20 18:55:38 +00:00
Paul Berry 421db9c69c Re-land "Implement proper checking for callability of Function class." 
(was reverted in https://dart-review.googlesource.com/c/sdk/+/40980
due to an analyzer bot breakage)

Original commit message:
Implement proper checking for callability of Function class.

There was some old (incorrect) logic for doing this, behind the flag
enableStrictCallChecks.  This flag has been removed, since the new
behavior is now standard in Dart 2.0.

Fixes #31509

Change-Id: Ice5cf38bbc648badf7f2563ff930b69f9a799635
Reviewed-on: https://dart-review.googlesource.com/41120
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-14 11:30:23 +00:00
Paul Berry 35aea15097 Revert "Implement proper checking for callability of Function class." 
This reverts commit 6837dafcc3.

Reason for revert: Broke analyzer bots.

Original change's description:
> Implement proper checking for callability of Function class.
> 
> There was some old (incorrect) logic for doing this, behind the flag
> enableStrictCallChecks.  This flag has been removed, since the new
> behavior is now standard in Dart 2.0.
> 
> Fixes #31509
> 
> Change-Id: I4a6da34a4b85ea8409f6e0d14c377a586546056a
> Reviewed-on: https://dart-review.googlesource.com/40509
> Commit-Queue: Paul Berry <paulberry@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Mike Fairhurst <mfairhurst@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com,mfairhurst@google.com

Change-Id: Ib631ad16bc5e937ff914127d1c5330f3fcaff2c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/40980
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-13 19:56:35 +00:00
Paul Berry 6837dafcc3 Implement proper checking for callability of Function class. 
There was some old (incorrect) logic for doing this, behind the flag
enableStrictCallChecks.  This flag has been removed, since the new
behavior is now standard in Dart 2.0.

Fixes #31509

Change-Id: I4a6da34a4b85ea8409f6e0d14c377a586546056a
Reviewed-on: https://dart-review.googlesource.com/40509
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2018-02-13 14:19:08 +00:00
Paul Berry 105b170ddb Roll package test to 0.12.29+1 and stack_trace to 1.9.0 
This required some changes to analysis_server, since analysis_server
used to have its own version of pumpEventQueue().  Since
pumpEventQueue() is now provided by the test package, I've removed
analysis_server's version, and I've updated some of the call sites to
pass in "times: 5000" to replicate the old analysis_server behavior.

This also required some changes to analyzer, since the fail() method
is now marked as @alwaysThrows, so no code may follow it without
producing a dead code hint.

Change-Id: Ie5ef3a5cc685c18da02de699e59f63f3bb8865f7
Reviewed-on: https://dart-review.googlesource.com/32683
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-01-07 14:22:23 +00:00
Brian Wilkerson 98e0c26a89 Convert several test classes to use ResourceProviderMixin 
Change-Id: I1c85c6f29ae74cca0b594fc1f9ddae098b815e72
Reviewed-on: https://dart-review.googlesource.com/31860
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-01-01 16:21:02 +00:00
Brian Wilkerson 4ecd8f7213 Enable the analysis of pubspec.yaml files in server 
Change-Id: I97c66b357d624cdcd6259c099b6421eb87c317c5
Reviewed-on: https://dart-review.googlesource.com/31404
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-12-24 17:20:42 +00:00
Jens Johansen 22d0696d91 [CFE] Move front-end API under src/ 
This CL deprecates the front-end API and moves it into src/api_prototype.

For now all usages have been updated to point to the new location,
but they should be updated to use custom-client invocations instead (e.g.
one specific way for DDC, another for dart2js etc.)

Bug:
Change-Id: I9b4f41f6ebf55d42510fd35240d942d1dc7292d6
Reviewed-on: https://dart-review.googlesource.com/24822
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2017-12-01 08:42:16 +00:00
Konstantin Shcheglov 5ea30b4e3d Rename performace_logger.dart to performance_logger.dart 
R=paulberry@google.com, sigmund@google.com

Bug:
Change-Id: Ib7b6d122dff3ddabde3db2270daa777a269e04ed
Reviewed-on: https://dart-review.googlesource.com/18512
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-11-03 20:24:00 +00:00
Konstantin Shcheglov 223a78d7bf Listen for watch events and notify AnalysisServer. 
So, AnalysisServer can serve a broadcast Stream and let EditDomain
reset a pending refactoring.

R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1465
Change-Id: I9462ad623ef261a658655a7445ee0ad9b0029a18
Reviewed-on: https://dart-review.googlesource.com/18426
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-03 15:59:45 +00:00
Konstantin Shcheglov 1b4239d2e4 Export ByteStore and its implementations from front_end. 
R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug:
Change-Id: Ie2e3413a7f143e270cec2bd3ae4564ad7cc315b1
Reviewed-on: https://dart-review.googlesource.com/3840
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-09-07 19:23:21 +00:00
Brian Wilkerson e4d44b2dcd Remove more references to the old plugin system 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3004523003 .
 2017-08-23 09:25:07 -07:00
Paul Berry 89c910b9c1 Move byte_store.dart and file_byte_store.dart to their own subdirectory. 
This allows us to use the subpackage relationships test to verify that
they don't import any other parts of front_end, which paves the way
for the possibility of moving them to their own package in the future.

R=scheglov@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2990323002 .
 2017-08-07 11:04:48 -07:00
Konstantin Shcheglov 00d5012906 Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt. 
...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975253002 .
 2017-07-13 16:28:18 -07:00
Brian Wilkerson ec8505fc79 Fix hints and clean-up obsolete comment syntax (TBR) 
Review-Url: https://codereview.chromium.org/2952233002 .
 2017-06-22 10:59:26 -07:00
Brian Wilkerson a420a1fbb5 Remove more dead code from analysis server 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2949103003 .
 2017-06-22 08:21:03 -07:00
Brian Wilkerson e28064f405 Restore partial analysis of analysis options files 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2946313003 .
 2017-06-22 08:00:50 -07:00
Brian Wilkerson e0216fef7f Remove ability to disable new analysis driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2937323003 .
 2017-06-19 08:13:14 -07:00
Konstantin Shcheglov a4fd5d814f Extract PerformanceLogger from AnalysisDriver. 
I also added the runAsync().

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2883633002 .
 2017-05-12 14:27:50 -07:00
Konstantin Shcheglov bd1ee32543 Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/. 
We are going to reuse ByteStore in front_end, also for incremental
compilation.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2869803004 .
 2017-05-09 09:12:15 -07:00
Brian Wilkerson 863bd921e1 Remove the non-driver versions of several tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2863593004 .
 2017-05-05 13:46:03 -07:00
Brian Wilkerson 65f492a043 Add support for watch events and error notifications 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2842013003 .
 2017-04-26 09:36:26 -07:00
Konstantin Shcheglov 6fe8e2278b Simplify PackageMapUriResolver - one folder, return any file, or null. 
If the package is know, we return the corresponding file, whether it
exists or not.

If the package is not know, there is no valid Source to resolve to,
so we return null.

We don't need all the features that existed.

Internally we switched to BazelPackageUriResolver, which has its own
logica for searching files in workspaces across multiple folders.

All the places where we create PackageMapUriResolver in analyzer
or analysis_server, we create it with exactly one folder.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2812093002 .
 2017-04-11 13:03:56 -07:00
Brian Wilkerson dd49e79f74 Add context information to driver and add hooks for plugin management 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2795743002 .
 2017-04-03 10:13:45 -07:00
Kasper Lund 2fe848502c Update context manager test after turning DOWN_CAST_COMPOSITE strong mode warning into a hint. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2741633004 .
 2017-03-09 07:31:40 -08:00
Konstantin Shcheglov 2acfb1d818 ContextBuilder should to throw when a root folder does not exist. 
Otherwise, removing an analysis root with .analysis_options file
causes an exception.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2660073002 .
 2017-01-29 09:37:24 -08:00
Konstantin Shcheglov 8d326e9a14 Report StateError if the DartSDK for an AnalysisDriver does not have summary. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2639743002 .
 2017-01-17 20:46:00 -08:00
Paul Berry c6206ea1de Split "_Driver" tests to separate test files. 
This avoids timeouts on my machine.  Also it makes it easier to disable these tests when necessary.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2627293002 .
 2017-01-12 08:19:19 -08:00
Dan Rubel 384d35240d new test for analysis options include directive 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2590593003 .
 2016-12-20 15:46:37 -05:00
Brian Wilkerson a8e9a1f108 Fix updating source factory in driver (issue 28086) 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2571353002 .
 2016-12-14 13:08:23 -08:00
Brian Wilkerson bead4ce5f3 Add more tests of the driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2572233002 .
 2016-12-14 12:29:20 -08:00
Brian Wilkerson 223513c81a Fix bug when packages file changes in new driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2570623002 .
 2016-12-12 14:03:00 -08:00
Konstantin Shcheglov 0728e4ee70 Implement 'analysis.getErrors' for the new driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2566013002 .
 2016-12-11 15:27:57 -08:00
Brian Wilkerson 86c62a6bad Remove the command-line plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2565993002 .
 2016-12-11 10:59:19 -08:00
Brian Wilkerson a01afcd1d1 Remove the options plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2569603002 .
 2016-12-11 08:38:29 -08:00
Brian Wilkerson ebf5fbcd0e Remove references to the linter plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2567863002 .
 2016-12-10 10:00:20 -08:00
Brian Wilkerson c99adefae7 Get some tests running using the analysis driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2562083002 .
 2016-12-09 08:32:39 -08:00
Brian Wilkerson 20baedc660 Reapply "Move the linter core to the analyzer package" 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2559773002 .
 2016-12-07 09:57:17 -08:00
Paul Berry 1a172e935b Revert "Move the linter core to the analyzer package" 
This reverts commit 6d9d5f53a1, which
was causing analysis server unit tests to fail.

TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2561573003 .
 2016-12-07 05:36:46 -08:00
Brian Wilkerson 6d9d5f53a1 Move the linter core to the analyzer package 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2553203002 .
 2016-12-06 09:42:26 -08:00
Konstantin Shcheglov a86fe28658 Send 'analysis.flushResults' on file removal. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2552023002 .
 2016-12-05 13:38:21 -08:00
Brian Wilkerson e63105555b Remove uses of configuration data 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2522543007 .
 2016-11-22 11:26:08 -08:00
Brian Wilkerson a3e1a0d395 Enable generic method support by default 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2488043002 .
 2016-11-22 09:16:19 -08:00
Dan Rubel 74d713ece9 remove support for analyzer configuration in pubspec 
This removes support for having directives like this in your pubspec:

analyzer:
  configuration: test_pack/config

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2511963002 .
 2016-11-20 20:44:04 -05:00