Brian Wilkerson
3575b810b3
Only add const in a constant context (issue 32819)
...
Change-Id: Ia149d812d2540fa98d76765ffb8b54fe32ecf010
Reviewed-on: https://dart-review.googlesource.com/50120
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-04-09 18:11:36 +00:00
Brian Wilkerson
7e53bb0689
Add hint for optional new/const to hover
...
Change-Id: Id1df68e3446d24bceb96f13c92c721fafa63c859
Reviewed-on: https://dart-review.googlesource.com/48266
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-03-24 14:54:23 +00:00
Brian Wilkerson
ea94e65b43
Make preview-dart-2 imply strong-mode
...
Change-Id: Ifa230f9e64a538e222557ea471dc728ad3dd01d7
Reviewed-on: https://dart-review.googlesource.com/46300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2018-03-13 17:15:39 +00:00
Brian Wilkerson
265ef252ae
Write type parameters when writing members (issue 29714)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2909943004 .
2017-05-30 12:19:15 -07:00
Brian Wilkerson
7d26ff6d4f
Remove some more library directives
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2884233004 .
2017-05-17 08:02:08 -07:00
Brian Wilkerson
27f9e5e4ce
Reverse the sense of the flag to make it easier to find test that need to be converted
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2884593003 .
2017-05-15 08:40:40 -07:00
Brian Wilkerson
e6c8092cea
Enable analysis driver in tests where possible
...
R=danrubel@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2868353002 .
2017-05-10 09:13:25 -07:00
Brian Wilkerson
e55812a3f2
Unify the server and plugin versions of the generators
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2844273003 .
2017-04-28 07:46:29 -07:00
Konstantin Shcheglov
663b7f665e
Analysis.getHover should return the field's documentation for field formal parameters.
...
Also return the parameter's element with completion suggestion.
R=brianwilkerson@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/385
Review-Url: https://codereview.chromium.org/2681233005 .
2017-02-10 08:49:40 -08:00
Konstantin Shcheglov
9723a28457
Support for hover with the new analysis driver.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2477193002 .
2016-11-07 09:09:14 -08:00
Konstantin Shcheglov
05a86a7495
Remove 'initializeTestEnvironment' from 'analysis_server'.
...
Also fixes the server_options_test.dart:22 test broken in https://codereview.chromium.org/2394683006/
R=paulberry@google.com , brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2402483002 .
2016-10-06 10:26:17 -07:00
Konstantin Shcheglov
de4d8b3a78
Switch analysis_server to use 'package:test'.
...
I'm changing DEPS in the corresponding analyzer CL.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/2394683006 .
2016-10-06 08:47:15 -07:00
Konstantin Shcheglov
f4186fb463
Issue 27244. Add 'isDeprecated' to HoverInformation.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27244
Review URL: https://codereview.chromium.org/2310153002 .
2016-09-06 11:31:11 -07:00
Konstantin Shcheglov
c0d40223bf
Issue 25945. Include static/propagateInvokeType for MethodInvocation names into hover.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25945
Review URL: https://codereview.chromium.org/1814893002 .
2016-03-17 10:29:10 -07:00
Konstantin Shcheglov
e7e52ae2c0
Issue 25542. If an element does not have its own documentation, use the documentation from the overridden superclass member or an implemented interface.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25542
Review URL: https://codereview.chromium.org/1632033002 .
2016-01-25 17:09:48 -08:00
Konstantin Shcheglov
6824bd9b32
Fix for enum signatures.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1529593002 .
2015-12-14 10:53:08 -08:00
Konstantin Shcheglov
168556a3e4
Tweaks for hover.
...
1. Include full signature of classes - extends, with and implements clauses.
2. Provide statis type only for variables - for all other elements the static type is always the same as in the signature.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1513943005 .
2015-12-11 14:25:46 -08:00
Konstantin Shcheglov
c302b65584
Use async/await in all analysis domain tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1478513002 .
2015-11-24 14:18:37 -08:00
Brian Wilkerson
9ad256cf18
Move the wire protocol support into the public API
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
Konstantin Shcheglov
0e7f4b5717
Fix hover documentation for parameters.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/1384583007 .
2015-10-05 07:04:20 -07:00
Brian Wilkerson
908708d655
More fixes for failures on the Windows bot
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1266923004 .
2015-08-05 08:13:28 -07:00
scheglov@google.com
9efb25fa50
Use package:test_reflective_loader instead of reflective_tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1101003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45365 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:54:29 +00:00
scheglov@google.com
e154d7ac6a
Tweaks for hover - local variables and methods.
...
1. We don't need enclosing class and library for local elements.
2. None of the elements other than methods append class name in toString(), so remove it there too.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1050983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44838 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-01 18:24:16 +00:00
scheglov@google.com
0c21dc284c
Add 'containingClassDescription' to HoverInformation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1003193005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44483 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 22:05:05 +00:00
brianwilkerson@google.com
cd58e290c4
Reformat
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//969113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 22:43:12 +00:00
scheglov@google.com
a38a503d86
Replace @ReflectiveTestCase() with @reflectiveTest.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//849863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 17:11:24 +00:00
scheglov@google.com
affc91a881
Issue 21552. Fixes for navigation, hover and rename in instance creation expressions.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21552
Review URL: https://codereview.chromium.org//717513003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41651 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-11 03:01:21 +00:00
scheglov@google.com
c7a131a7d5
Churn only: move analysis notification tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//563373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40396 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:16:29 +00:00