dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,224 Commits 2 Branches 0 Tags
8bfbce33f13da170362434c6332f7d6487d92e55
Commit Graph

2393 Commits

Author SHA1 Message Date
scheglov@google.com 2996ef1754 Issue 21650. Fix linked positions added after insert code buffers. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21650

Review URL: https://codereview.chromium.org//750423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41928 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-24 15:52:58 +00:00
scheglov@google.com a255faf85c Exchanging operands of a comparision operator should invert the operator. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//756483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41927 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-24 15:51:47 +00:00
scheglov@google.com 52d55e933d Issue 21662. Fix 'Sort Members' when both directives and declarations are updated. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21662

Review URL: https://codereview.chromium.org//753883003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41926 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-24 15:50:19 +00:00
danrubel@google.com be636515be refactor import caching to exclude suggestions for inherited members 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//752833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41925 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-24 12:28:07 +00:00
scheglov@google.com 703b744966 Issue 21655. Don't import self when add type declaration. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21655

Review URL: https://codereview.chromium.org//747613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41869 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-20 22:10:57 +00:00
scheglov@google.com 76f1d90e3e Matching fields, some parameters, ignore locals. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//733203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41868 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-20 22:08:47 +00:00
scheglov@google.com 947ec59930 Fix driver.dart 
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//742023004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41867 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-20 21:49:59 +00:00
danrubel@google.com a714eb2faf cache import suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//742163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41865 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-20 19:31:31 +00:00
danrubel@google.com 5977fec49b discard code completion cache if context or other sources change 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//744043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41860 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-20 18:40:23 +00:00
danrubel@google.com 4a50ed6cf8 cleanup hints 
BUG=
R=brianwilkerson@google.com, paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//734403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41852 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-20 14:03:18 +00:00
scheglov@google.com 91c02b4a8e Issue 21618. Fix for empty code for 'dynamic' type. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21618

Review URL: https://codereview.chromium.org//731313004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41838 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-19 17:42:29 +00:00
scheglov@google.com 438fbd7f6b Cache ElementLocation instance and index key/location ids. 
This saves us about 9% of time, as the previous CL.
From 22294 ms to 20040 ms.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//739643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41814 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-18 23:02:14 +00:00
scheglov@google.com 58587a470e Rollback r41807. 
As discussed, it is not compatible with the incremental analysis.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//736603005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41809 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-18 18:50:28 +00:00
scheglov@google.com 4032b4d86b Use shorter DartElementLocation. 
This improves analyzer + analysis_server analysis time from 21841 ms to 19839 ms.
I.e. about 9% faster.

However it is still 25% slower than without index at all - 15593 ms.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//738673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41807 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-18 16:21:01 +00:00
jwren@google.com b7146b4ac1 Add the --no-error-notification flag to the analysis server flag set, not yet implemented. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//737623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41803 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-18 14:22:27 +00:00
scheglov@google.com b8da9bc651 Format and sort analyzer and analysis_server packages. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//725143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 22:23:53 +00:00
danrubel@google.com fabddbd918 add ContextsChangedEvent 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//732093003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41786 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 17:14:48 +00:00
danrubel@google.com f60be24eb8 add code completion cache 
- generic mechanism for use in a subsequent CL
- minor get_handler import cleanup

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//729193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41778 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 15:13:38 +00:00
danrubel@google.com dc7f0c20dc cleanup warnings 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//729283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41776 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 15:06:07 +00:00
scheglov@google.com 30e11469c3 Use a better way to compute InterfaceTypes least upper bound. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//730803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41761 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-15 16:52:58 +00:00
danrubel@google.com 84c6c0d7ba only wait for analysis if necessary when computing invocation suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//728143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41760 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-15 15:16:53 +00:00
scheglov@google.com 0f0a275fc7 Issue 21612. Support for multiple returns in the 'Extract Method' refactoring. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21612

Review URL: https://codereview.chromium.org//725393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41758 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-15 01:40:46 +00:00
scheglov@google.com 6a03e08cca Issue 21617. Replace explicit 'this' references and clean ups. 
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21617

Review URL: https://codereview.chromium.org//733663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41753 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-14 23:16:13 +00:00
scheglov@google.com 19bd923634 Remove unused fields from analysis_server. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//725153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41743 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-14 15:47:53 +00:00
scheglov@google.com 2bcc7feba2 Remove unused methods in analysis_server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//721223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41718 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-13 16:27:07 +00:00
scheglov@google.com affc91a881 Issue 21552. Fixes for navigation, hover and rename in instance creation expressions. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21552

Review URL: https://codereview.chromium.org//717513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41651 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-11 03:01:21 +00:00
brianwilkerson@google.com d23df4f448 Clean up references in comments 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//708263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41623 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-08 15:45:19 +00:00
scheglov@google.com 7e71785a58 Issue 20827. Add imports as needed the 'Add type annotation' Quick Assist. 
I left some TODOs, the CL is big enough already.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20827

Review URL: https://codereview.chromium.org//706263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41620 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-07 23:21:35 +00:00
danrubel@google.com 7e7f3ce68c display completion performance in new server status page 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//691853006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41612 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-07 18:10:51 +00:00
danrubel@google.com d3646956e8 first cut argument list completion suggestions 
- first cut simplistic insertion of params
- required params only for now
- move cursor after ) if no params
- don't insert () if identifier suggestion
- does not cover all method/function invocations yet
- updated comments in Server API
- extracted new declaration visitor

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//711533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41586 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-06 21:42:31 +00:00
scheglov@google.com 772a0c6b22 Fix 'Unused local variable' hints in analyzer and analysis_server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//709493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41576 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-06 18:32:54 +00:00
scheglov@google.com df6233ae4a Use Element's source paths instead of URIs as a key in the index. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//703963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41530 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-05 21:02:37 +00:00
danrubel@google.com f92b942be2 move combinator suggestion ast traversal into computeFast 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//694203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41521 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-05 14:13:46 +00:00
scheglov@google.com 7f4d5bb1fb Issue 21506. Fix for adding back previously excluded resources in sub-folders. 
The server's part of the issue.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21506

Review URL: https://codereview.chromium.org//692073004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41500 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-04 18:47:14 +00:00
paulberry@google.com 24fac6c7e5 Flush analysis server output stream when closed. 
This ensures that if the analysis server terminated with an exception,
the stacktrace will actually be written to stdout before the server
exits.

BUG=dartbug.com/21494
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//694413004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41495 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-04 16:11:55 +00:00
scheglov@google.com 1c6ddd0751 Issue 21498. Fix for navigation from instance creation with type arguments. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21498

Review URL: https://codereview.chromium.org//694383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41468 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-03 20:45:34 +00:00
scheglov@google.com 1d69da9c39 Issue 21496. Fix for inlining negate/decrement into negate. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21496

Review URL: https://codereview.chromium.org//695383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41466 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-03 20:29:57 +00:00
scheglov@google.com 15743f701e Support for inlining methods when some arguments are missing. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//694373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41464 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-03 18:35:58 +00:00
paulberry@google.com 9b35b056a7 Fix deprecation warnings in analyzer and analysis server. 
R=brianwilkerson@google.com, danrubel@google.com

Review URL: https://codereview.chromium.org//685133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41461 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-03 17:10:08 +00:00
scheglov@google.com da1b1e947a Remove unnecessary cast in Quick Assist. 
Sorry, missed it in the previous CL.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//696003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41451 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 20:44:44 +00:00
scheglov@google.com 90b785c88c Fix for an error in the error handler. 
We pass exception as String message.

We would have caught it if we had run the server in the checked mode.
Instead it failed at the JSON serialization stage.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//698563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41450 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 20:43:28 +00:00
scheglov@google.com 8bd5c75f0c Fix for 'Replace if-else with conditional expression' in case of mixed expression/return branches. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//690353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41446 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 19:22:22 +00:00
scheglov@google.com b7c685bbe2 Support for 'Add Type Annotation' when selection if right after ';'. 
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//693193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41445 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 19:09:03 +00:00
brianwilkerson@google.com e9696e5f67 Clean up logging uses 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//685993004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41443 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 19:05:19 +00:00
danrubel@google.com 58b915ffea move import combinator suggestions into a separate computer 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//695773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41442 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 18:31:18 +00:00
brianwilkerson@google.com 20c13d4715 Fix logging API. This should fix the exception I'm seeing. I'll clean up uses of the deprecated API in a separate CL. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//694833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41439 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-31 16:22:50 +00:00
brianwilkerson@google.com 3d13808d7d Status page improvements: sort context names, right align numbers, add missing data descriptors. 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//685123006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41427 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-30 21:11:40 +00:00
danrubel@google.com d22c027e0a add suggestions in format parameter list 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//693573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41420 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-30 15:13:57 +00:00
danrubel@google.com 010f33956f cleanup warnings/hints 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//685363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41419 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-30 15:12:30 +00:00
danrubel@google.com b7aeaab3f7 make deprecated elements have low suggestion relevance 
BUG=dartbug.com/19615
R=scheglov@google.com

Review URL: https://codereview.chromium.org//690793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41414 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-30 01:08:32 +00:00