75fff1fdb6
Implement completion in WithDirective.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2665053004 .
2017-01-31 15:06:54 -08:00
fb5e367ca5
Update server generator
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2668733002 .
2017-01-31 08:26:10 -08:00
058b5a9c5b
Add missed return leading to an NPE
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2668523002 .
2017-01-30 13:46:32 -08:00
d29ba1e238
Store exceptions with transitive files context into ByteStore.
...
The key under which the exception context is stored, is included into
ExceptionResult, so Analysis Server can include the key into the message.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2663903002 .
2017-01-30 12:57:44 -08:00
6be5d918d0
Fix strong mode warning in the 'getter to method refactoring.'
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2662893002 .
2017-01-30 08:53:13 -08:00
8c738c2dad
Revert "Revert "Enable the new analysis driver by default, use --disable-new-analysis-driver to disable.""
...
This reverts commit 878775607cR=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2658273002 .
2017-01-27 12:13:04 -08:00
47967ac9f2
Guard against FunctionExpression nodes with null parameters.
...
I see this exception in logs, but I was not able to find which Dart
code would cause this.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2664493004 .
2017-01-27 11:57:08 -08:00
fcd5f16d10
Stop using SDK summary bundle. Analyze dart:xxx as any other libraries.
...
Unfortunately this makes runnings tests about 30% slower :-(
I suspect that's because we have to build unlinked and linked summaries
for SDK libraries again and again for every tiny test.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2653683004 .
2017-01-24 18:32:26 -08:00
c25bd9403f
Move driver creation into ContextBuilder
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2647293007 .
2017-01-24 14:43:39 -08:00
b206c84210
Reland c9e1b88 and 56726fc with a DDC fix.
...
Revert "Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider.""
This reverts commit b701ad6453R=brianwilkerson@google.com , vsm@google.com
BUG=
Review-Url: https://codereview.chromium.org/2647323006 .
2017-01-24 09:13:26 -08:00
b701ad6453
Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider."
...
This reverts commit c9e1b888a356726fcce0TBR=scheglov@google.com
Review-Url: https://codereview.chromium.org/2648213007 .
2017-01-24 06:21:38 -08:00
c9e1b888a3
Use single InputPackagesResultProvider, without SdkSummaryResultProvider.
...
Each SummaryResynthesizer is now responsible for creating its TypeProvider.
And with the new AnalysisDriver we stop using SDK CachePartition.
For now we add SDK's summary bundle into SummaryDataStore.
Eventually we will get rid of it and add individual SDK libraries.
R=brianwilkerson@google.com , paulberry@google.com , vsm@google.com
BUG=
Review-Url: https://codereview.chromium.org/2652823002 .
2017-01-23 16:54:17 -08:00
a483610a96
Issue 28386. Implement search for potential usages with the new analysis driver.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28386
Review-Url: https://codereview.chromium.org/2653493006 .
2017-01-23 14:07:01 -08:00
0160332713
Issue 28027. Move Null to the bottom in the Analyzer.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/28027
Review-Url: https://codereview.chromium.org/2638183002 .
2017-01-18 11:15:11 -08:00
8d326e9a14
Report StateError if the DartSDK for an AnalysisDriver does not have summary.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2639743002 .
2017-01-17 20:46:00 -08:00
878775607c
Revert "Enable the new analysis driver by default, use --disable-new-analysis-driver to disable."
...
This reverts commit 7e560a612fR=brianwilkerson@google.com , paulberry@google.com , devoncarew@google.com
BUG=
Review-Url: https://codereview.chromium.org/2634603002 .
2017-01-13 15:23:22 -08:00
914a117649
Report errors like IMPORT_OF_NON_LIBRARY with the new analysis driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2627093010 .
2017-01-12 13:41:52 -08:00
22f561e914
Reapply "Add support for generic function type syntax, part 1"
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2622303006 .
2017-01-11 14:10:05 -08:00
85b1e7abbe
Revert "Add support for generic function type syntax, part 1"
...
Review-Url: https://codereview.chromium.org/2624283003 .
2017-01-11 13:30:52 -08:00
1cd918533d
Add support for generic function type syntax, part 1
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2613383003 .
2017-01-11 13:12:10 -08:00
5a9c5ac1ec
Issue 28068. Implement diagnostics domain for the new analysis driver.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28068
Review-Url: https://codereview.chromium.org/2625493002 .
2017-01-09 12:07:15 -08:00
266280f0c4
Issue 28300. Reset refactoring when analysis started with the new analysis driver.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28300
Review-Url: https://codereview.chromium.org/2626433002 .
2017-01-09 10:18:20 -08:00
83fc4b6b46
Put a TypeProvider on the TypeSystem implementations.
...
Adding a TypeProvider instance to TypeSystem to avoid needing to
thread it through the various APIs, and to avoid having to change
the API every time a method which previously did not need to
access the TypeSystem suddenly does.
BUG=
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2590883004 .
2017-01-09 02:40:10 -08:00
e80a54e432
Fix the rest of the completion tests with the new analysis driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2618243002 .
2017-01-08 15:16:33 -08:00
7fc5bc3634
Remove REPLACE_IMPORT_URI Quick Fix.
...
I decided that it is not so useful to worth adding special support
for it with the new analysis driver.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2616163002 .
2017-01-06 14:56:20 -08:00
0377beb128
Update 'Add final field formal parameters' Quick Fix to support the new analysis driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2618923003 .
2017-01-06 14:34:49 -08:00
188c087036
Run 'Inline Method' refactoring tests with the new analysis driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2619053002 .
2017-01-06 13:51:02 -08:00
07895169be
Remove code duplication
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2618983003 .
2017-01-06 10:55:55 -08:00
e9794e37b5
Call processOptionsForDriver() before creating the driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2615903002 .
2017-01-05 11:10:01 -08:00
d9930d86cd
processOptionsForDriver() is never called with 'optionsRemoved'.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2612783004 .
2017-01-05 08:47:52 -08:00
9a3b6a09e5
Issue 28261. Add support for implementing generic methods in Quick Fix.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28261
Review-Url: https://codereview.chromium.org/2618653002 .
2017-01-05 08:32:03 -08:00
1e43b4f270
Replace using MockSdk with FolderBasedDartSdk + summaries in AbstractContextTest(s).
...
It has some performance penalty (about 2-3 seconds in 35 seconds total).
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2610823004 .
2017-01-04 14:39:24 -08:00
44bab19cb3
Implement 'analysis.analyzedFiles' notification with the new analysis driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2612723002 .
2017-01-04 07:12:47 -08:00
606bdb519f
Cache results for priority files in AnalysisDriver.
...
Remove corresponding caching from Analysis Server.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2611523005 .
2017-01-03 17:04:58 -08:00
7e560a612f
Enable the new analysis driver by default, use --disable-new-analysis-driver to disable.
...
R=paulberry@google.com , brianwilkerson@google.com , devoncarew@google.com
BUG=
Review-Url: https://codereview.chromium.org/2606283005 .
2017-01-03 14:50:17 -08:00
bbf45b52e6
Guard against missing enclosing class (issue 28163)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2609833002 .
2017-01-03 07:52:54 -08:00
e1a27c0c60
Rework the replay test to be more correct
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2611593002 .
2017-01-03 07:45:07 -08:00
eaca15cd4d
Fix analysis.getNavigation with the new analysis driver.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28125
Review-Url: https://codereview.chromium.org/2582753003 .
2016-12-16 10:52:47 -08:00
7e15a96b1b
Use AnalysisOptions.signature as a way to check compatibility.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2577943003 .
2016-12-15 13:01:06 -08:00
8c946a6b9b
Apply error processors in the new driver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2577913002 .
2016-12-14 16:07:06 -08:00
a8e9a1f108
Fix updating source factory in driver (issue 28086)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2571353002 .
2016-12-14 13:08:23 -08:00
52c81e4a78
Fix for detecting lib/src. Sort fixes by relevance.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2572013002 .
2016-12-14 06:57:19 -08:00
3a422bceb7
Implement SearchEngine.searchMemberDeclarations() for the new driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2566393003 .
2016-12-13 14:06:15 -08:00
142473b8cb
Implement SearchEngine.searchTopLevelDeclarations() for the new driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2572603003 .
2016-12-13 12:11:22 -08:00
cc2b071743
Fix up imports after d8c9645c26.
...
Review-Url: https://codereview.chromium.org/2567403002 .
2016-12-13 05:15:47 -08:00
d8c9645c26
Reorganize InheritedRefenenceContributor to serve angular completion
...
Take the parts that I would have simply copied and pasted them into my
own code, and create new public & private methods to serve the new
organization.
Add an option to get the current class's accessors/methods along with
the inherited ones, because that's what I want.
Make opType a public member of DartCompletionRequest
Its used so heavily by so many of the autocomplete targets, it really
doesn't need to be hidden on the Impl.
Besides, I want to use InheritedReferenceContributor, which upcasts the
DartCompletionRequest into the Impl in order to grab this field -- but
for a large number of reasons I can't really use
DartCompletionRequestImpl. Therefore I need my own class to implement
DartCompletionRequest and therefore my code will only work with
InheritedReferenceContributor if it doesn't have to look outside the
interface for this information.
Change to enable the angular analysis project to do autocomplete
We don't have CompilationUnits, but we do have dart ASTs, and we want to
find the completion target with the same algorithm. The CompletionTarget
class's functionality doesn't depend on its member compilationUnit not
being null, so that isn't a problem for us. However, in `forOffset()`,
we cannot pass in a null unit, even though its only used to set the
`compilationUnit` member and otherwise only used as an `AstNode` which
we have.
So rather than using `compilationUnit` as the entry point of the
algorithm, add a new `AstNode` parameter to represent the entry point,
and when its null simply use the value of `compilationUnit`.
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2565633002 .
2016-12-12 14:29:53 -08:00
223513c81a
Fix bug when packages file changes in new driver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2570623002 .
2016-12-12 14:03:00 -08:00
a5b2e62bda
Fix for completion after the closing quote in a directive.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2572513003 .
2016-12-12 13:38:38 -08:00
c4ed99acc9
Support for overlay only files in Analysis Server with the new driver.
...
Do we need this at all?
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2571593002 .
2016-12-12 13:16:04 -08:00
d564b0aaab
Send errors notification without delay.
...
Update 'analysis.updateContent' integration test.
This might be OK from performance POV - errors are cheaper to send than
for example navigation. And this satisfies the goal of 'analyzing'
notification - that new errors are to be expected.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2567113003 .
2016-12-12 11:39:47 -08:00
Konstantin Shcheglov