c817241ad6
Update the analysis server diagnostic page - re-enable code completion and overlay pages,
...
and refactor the css and navigation.
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2911313002 .
2017-05-30 18:46:33 -07:00
24b0d1489f
Fix an npe in context_manager.dart.
...
BUG=
Review-Url: https://codereview.chromium.org/2917453002 .
2017-05-30 14:29:53 -07:00
82490f0d2f
Allow replacementOffset and replacementLength overriding from plugin autocompletion. In cases where a plugin overrides the original Dart autocompletion offset/length or another plugin's offset/length - the suggestion for the plugin is dropped and an error notification is logged.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2913833002 .
2017-05-30 13:54:11 -07:00
1e7ff6bccf
Add the analysis options path to the diagnostics page.
...
BUG=
R=brianwilkerson@google.com , paulberry@google.com
Review-Url: https://codereview.chromium.org/2913493002 .
2017-05-30 13:29:25 -07:00
9737664106
[Extract Method] When no selection, check for implicitly selected closure.
...
R=brianwilkerson@google.com , devoncarew@google.com
BUG=
Review-Url: https://codereview.chromium.org/2907213002 .
2017-05-30 11:11:46 -07:00
f6c6c01211
Update some of the fixes to use ChangeBuilder
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2910683002 .
2017-05-30 08:01:52 -07:00
03e0a93092
show the enableAssertInitializer setting in the diagnostics page
...
BUG=
R=brianwilkerson@google.com , danrubel@google.com
Review-Url: https://codereview.chromium.org/2911563002 .
2017-05-26 08:36:26 -07:00
a7cc00e01a
Make server forward getNavigation requests to plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2908633002 .
2017-05-25 14:49:35 -07:00
f65c7ecbdf
Fix a recent regression with nested contexts
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2903303002 .
2017-05-25 13:17:08 -07:00
1c8b59dc31
Update status pages to show package map and plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2904983003 .
2017-05-25 12:51:19 -07:00
013411c10b
Allow plugins to provide completions for non-dart files
...
R=maxkim@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2910463002 .
2017-05-25 10:53:07 -07:00
61e3486ed1
Find drivers even when the file is not a dart file
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2898213004 .
2017-05-23 17:23:30 -07:00
ab9ee72a34
Switch server tests to strong mode.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2903523003 .
2017-05-23 14:58:53 -07:00
0929b7736e
Convert quick assist support to use AnalysisDriver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2899843002 .
2017-05-22 13:45:55 -07:00
5b6a9392e5
Fix inifinite loop in analysis server. ( #29685 )
...
It was walking up a directory heirarchy looking for a directory named
"lib" but didn't terminate when it reached the root.
2017-05-22 11:46:44 -07:00
7e47a24c8a
Convert quick fix support to use AnalysisDriver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2894403003 .
2017-05-22 10:41:57 -07:00
5455f21565
Fix reparent on windows
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2892963002 .
2017-05-19 10:28:44 -07:00
a8dc041543
Capture the request time for performance data and support forced shutdown
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2893803004 .
2017-05-19 08:49:47 -07:00
c1a7070770
Add the ability to whitelist plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2897653002 .
2017-05-19 08:48:32 -07:00
a6214b3129
Remove more libraries directives from server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2894883002 .
2017-05-19 08:42:30 -07:00
daffcecc11
Pass the sdk path to plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2885993004 .
2017-05-17 08:19:49 -07:00
aa491e7133
Support tear-off completions for named params (in constructors) (flutter-intellij#836)
...
R=danrubel@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/836
Review-Url: https://codereview.chromium.org/2883363002 .
2017-05-16 13:40:33 -07:00
a03958bfc9
More clean-up after getting common protocol classes
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2880393002 .
2017-05-15 13:01:57 -07:00
6643349a8f
Minor clean-up
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2885473002 .
2017-05-15 10:09:47 -07:00
fb982f5476
Make server use the common protocol classes
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2879273002 .
2017-05-15 09:35:46 -07:00
3085734ef6
Generate common types into a separate library
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2880443006 .
2017-05-13 08:12:14 -07:00
a4fd5d814f
Extract PerformanceLogger from AnalysisDriver.
...
I also added the runAsync().
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2883633002 .
2017-05-12 14:27:50 -07:00
98825b4918
improve code completion abort request tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2876793006 .
2017-05-12 13:28:39 -07:00
bef53e72e4
Remove unintentional dependency on analysis_server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2875323002 .
2017-05-12 10:07:37 -07:00
dc64c43480
Unused import cleanup.
...
BUG=
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2876913002 .
2017-05-11 14:08:47 -07:00
66bb2d618e
Remove unused analysisContext from completion request and contributors
...
Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.
R=brianwilkerson@google.com , pquitslund@google.com
Review-Url: https://codereview.chromium.org/2877653002 .
2017-05-11 09:38:50 -07:00
6798cdfcd1
cleanup dart code completion contributors
...
Remove the following unnecessary methods now that analysis driver
resolves everything in the compilation unit upfront.
DartCompletionRequest
* resolveUnits
* resolveImports
* resolveContainingStatement
* resolveContainingExpression
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2873943003 .
2017-05-11 09:12:36 -07:00
3b2c3ae5b2
Add support for built-in plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2874803003 .
2017-05-10 13:31:20 -07:00
55097a44b3
Recover from merge problem
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2868383002 .
2017-05-10 13:12:14 -07:00
a3ac4253b1
Remove an obsolete error from the spec and an obsolete command-line flag
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2865403005 .
2017-05-10 09:33:43 -07:00
fbc3f3708d
Remove unused reference to SearchEngine
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2872803003 .
2017-05-09 14:32:12 -07:00
98e8f17b96
Convert server to use RangeFactory
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2869083002 .
2017-05-09 10:08:14 -07:00
bd1ee32543
Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/.
...
We are going to reuse ByteStore in front_end, also for incremental
compilation.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2869803004 .
2017-05-09 09:12:15 -07:00
11558c8a90
Add trailing commas after Flutter instance creation params fixes (flutter-intellij/#f978).
...
R=brianwilkerson@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/978
Review-Url: https://codereview.chromium.org/2864373003 .
2017-05-09 07:00:15 -07:00
bc310f5f1f
cleanup KeywordContributor
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2871443003 .
2017-05-08 10:03:39 -07:00
959b7c14b8
improve completion for formal param initializers
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2864233002 .
2017-05-08 06:50:46 -07:00
eb15a4c7c9
add constructor initializer completions
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2869653002 .
2017-05-08 05:52:12 -07:00
d2bbfb4f77
Make an AstProvider available to AssistProcessors
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2862143003 .
2017-05-05 09:24:30 -07:00
6c2023bd07
Move ChangeBuilder to analyzer_plugin
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2860383002 .
2017-05-05 07:52:27 -07:00
0d2bfea054
Remove the use of CorrectionUtilities
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2866603002 .
2017-05-05 06:06:57 -07:00
1a394e975f
Specify types in generated closure args.
...
Follow-up from: https://github.com/flutter/flutter-intellij/issues/975
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2863683002 .
2017-05-04 12:54:23 -07:00
f6f845c879
Fix a completion exception during import suggestions.
...
BUG=
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2862793002 .
2017-05-04 09:24:18 -07:00
4a9092d9c9
Change the ChangeBuilder API to use SourceRange
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2856233003 .
2017-05-04 08:49:01 -07:00
374871da75
Add default implementation when fixing missing required closures (flutter-intellij#975)
...
Fixes: https://github.com/flutter/flutter-intellij/issues/975
Also improves code generation for required lists to include empty list literals.
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2862623002 .
2017-05-03 13:22:52 -07:00
a51af38461
Widget details for Flutter children: param completions.
...
R=brianwilkerson@google.com
See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2855883003 .
2017-05-02 13:50:34 -07:00
Devon Carew