Commit Graph

2342 Commits

Author SHA1 Message Date
scheglov@google.com 4d60770a6f Tweaks for review comments.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//327003004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37198 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 20:37:16 +00:00
scheglov@google.com c83879cb66 Some clean ups for caching tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//329633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37194 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 19:08:10 +00:00
scheglov@google.com c2f9e90500 Node cache, binary search.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//326123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37188 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 17:24:17 +00:00
scheglov@google.com f4a0a16911 FilePageManager - disk based PageManager.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//321953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37158 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 05:51:48 +00:00
scheglov@google.com 06c7850c5e A NodeManager implementation with encoding/decoding keys/values into pages.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//324743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37136 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-09 21:13:03 +00:00
scheglov@google.com ca89ae121e Create/read/write/delete nodes using NodeManager.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//324623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37116 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-08 17:07:46 +00:00
scheglov@google.com 1419a83dac Rename to BPlusTree.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//320723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37115 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-08 16:19:17 +00:00
scheglov@google.com ecef37ed13 A simple B+Tree implementation.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//314413004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37113 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-07 21:36:27 +00:00
brianwilkerson@google.com 7e00cff46a Replace Map with HashMap.
I didn't bother with obviously short-lived objects, like those generated in order to produce JSON strings, or with anything in tests, but tried to catch everything else.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//325433003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37094 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 19:32:03 +00:00
brianwilkerson@google.com d871724d03 Remove unused analysis contexts
R=scheglov@google.com

Review URL: https://codereview.chromium.org//315183004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37081 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 15:27:32 +00:00
scheglov@google.com ae59c7e055 Clean ups for warnings and unused code.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//314173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37039 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-05 17:52:20 +00:00
scheglov@google.com c928073e3d Updates for the Outline API and use it in Editor.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//311053005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37033 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-05 17:01:07 +00:00
scheglov@google.com 1af57c302e Outline notification implementation in server.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//319523004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37025 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-05 01:38:02 +00:00
scheglov@google.com 94404cc0a4 Split computers.dart and use parsed JSON objects for navigation tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//315053005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37007 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-04 20:20:35 +00:00
scheglov@google.com 112890821b Fix for implicit constructor invocation navigation regions.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//313753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36994 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-04 14:16:29 +00:00
scheglov@google.com 80d8779110 Navigation computer and two variants of tests for it.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//314493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36958 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-03 23:14:47 +00:00
scheglov@google.com 61dfa442c9 Extract analysis/notifications into a separate operation/file.
It seems that while we really have to expose some additional API from AnalysisServer,
it still worth to extract analysis and its notifications into a separate file.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//311653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36899 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 21:00:49 +00:00
paulberry@google.com b703deb077 Add a boolean which causes AnalysisServer to rethrow exceptions.
The boolean defaults to true to ensure that any unhandled analysis
exceptions which occur during unit tests are reported as unit test
failures.  When the full analysis server is run normally it is set to false
so that exceptions are simply logged.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//302323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36895 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 19:57:41 +00:00
scheglov@google.com 304243bc5b Add ServerOperation and queue.
Schedule operations to perform analysis.
Moving notifications into operations to be done in the next CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//308003009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36890 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 18:31:49 +00:00
brianwilkerson@google.com ae5597140c First cut at server timing tests
R=jwren@google.com, paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//303233007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36874 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 14:39:33 +00:00
scheglov@google.com a95856f5be Use 'analysis.setSubscriptions' HIGHLIGHTS in Editor.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//304273007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36853 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-31 01:53:28 +00:00
scheglov@google.com fe26a39b8d Initial implementation for 'analysis.setSubscriptions' API.
Not quite all, and not as operations yet.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//308923003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36834 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-30 21:02:28 +00:00
paulberry@google.com 386fcb77c9 Don't add files inside "packages" subdir to context.
In the short term this will allow us to make fair comparisons between
the Java-based and Dart-based analysis engines.  In the long run we'll
be adding these files to the context using a separate mechanism (by
finding them via "pub list-package-dirs").

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//303413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36832 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-30 19:38:20 +00:00
scheglov@google.com 24c8f1f4b2 Extract constants into separate libarary.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//308703005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36828 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-30 18:37:44 +00:00
scheglov@google.com 2ee78ad191 Implementation of 'notification.highlight' API.
Still no subscriptions yet, so we generate highlight regions for all non-SDK files.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//307963006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36822 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-30 17:22:05 +00:00
scheglov@google.com 125d09e37d Computers and services snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//304323004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36808 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-29 22:19:21 +00:00
paulberry@google.com 7b9959065e Change RequestDatum "is" functions into getters.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//309483006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36807 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-29 22:18:11 +00:00
paulberry@google.com a9a6747471 Handle file additions/removals in ContextDirectoryManager.
R=danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//308713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36800 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-29 20:14:24 +00:00
paulberry@google.com 180f3b56a6 Rename PubFolder and update comments.
Since it is no longer always associated with a pubspec.yaml file,
PubFolder is a misleading name.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//304923003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36788 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-29 16:05:25 +00:00
paulberry@google.com f8e69ee59c Make ContextDirectoryManager responsible for scanning directory contents.
It will be responsible for updating the context when the contents of
the directory have changed, so it makes sense to have it do the
initial scan as well.

R=danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//306733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36785 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-29 15:26:13 +00:00
paulberry@google.com 3c32eb2434 Create a new class for managing the set of analysis roots.
This will allow the functionality of mapping analysis roots to context
folders to be tested in isolation.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//305763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36768 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 20:50:48 +00:00
scheglov@google.com e1ecc28e7f Implementation for 'analysis.updateContent' API.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//300553014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36766 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 20:44:32 +00:00
paulberry@google.com b4debf3d44 Add watch and modify/delete support to MemoryFile.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//297303010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36762 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 20:15:58 +00:00
scheglov@google.com 35c177c90b Send 'notification.errors' for all non-SDK files.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//307533004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36743 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 15:50:23 +00:00
danrubel@google.com e7e559942c add server.status notification
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//298823007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36727 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-28 02:25:20 +00:00
scheglov@google.com ae2bee4403 Fix analyzer warning.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//305643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36721 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 23:48:38 +00:00
paulberry@google.com a9c1109b69 Allow physical folder resources to be watched for changes to their contents.
This functionality is just a thin wrapper over the existing Watcher
package.  A future CL will add similar functionality to in-memory
folder resources.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//303503007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36714 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 22:36:20 +00:00
scheglov@google.com 89fd27a218 Tests for exceptional situations in MemoryResourceProvider.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//300853006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36713 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 22:17:48 +00:00
scheglov@google.com 764c6b112c Partial implementation of the 'setAnalysisRoots' API.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//300023004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36702 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 19:01:14 +00:00
scheglov@google.com 73384dcbed Use Posix style for memory resources.
R=brianwilkerson@google.com, ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//300043009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36700 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 18:25:31 +00:00
scheglov@google.com a37f04c568 Resource/File/Folder interfaces and implementations for dart:io and memory.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//299403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36613 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-25 16:17:19 +00:00
scheglov@google.com cb0999996d API and stubs for the 'analysis' domain.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//302503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36611 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-25 15:22:36 +00:00
scheglov@google.com 170020b4f8 Use type annotations everywhere in analysis_server/lib.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//300643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36610 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-24 17:46:27 +00:00
scheglov@google.com ebd41ed304 Implementation of 'Server Domain' in dart analysis server.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//297153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36607 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-24 17:36:06 +00:00
scheglov@google.com fbae744eaa Fix warnings in get_handler.dart
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//297123003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36596 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-23 22:59:33 +00:00
danrubel@google.com 6da2ff1d40 improve analysis server notifications
* add context id to error notifications
* add analysis.complete notification

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//299513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36363 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-20 16:42:50 +00:00
danrubel@google.com f21f056bba implement ByteStreamClientChannel close
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//284353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36316 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-19 19:35:01 +00:00
danrubel@google.com 88344402e1 move context id constant to AnalysisServer
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//284103005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36263 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-16 17:44:24 +00:00
paulberry@google.com 206854b25e Fix remaining RequestDatum tests.
There were a few problems:

- An expression like "x is List<Foo>" doesn't guarantee that every
  element of x is of type Foo.  We need to check item by item.
  Similar for maps.

- InvalidParameterResponseMatcher was failing to account for the fact
  that the response gets wrapped in a RequestFailure object.

- Tests weren't calling setUp().

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//289003003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36237 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-15 20:03:53 +00:00
danrubel@google.com 03aaf34742 add RequestDatum tests and fix some situations
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//281373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36217 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-15 11:55:26 +00:00