55fcc03572
Use the new StaticWarningCode.UNDEFINED_IDENTIFIER_AWAIT error.
...
...instead of StaticWarningCode.UNDEFINED_IDENTIFIER
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2162523003 .
2016-07-18 10:48:55 -07:00
12dfb8b6ed
Keep track of where objects are being referenced in memory status page
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2157613002 .
2016-07-15 14:21:31 -07:00
7d9d451730
Don't insert additional ':' when changing a named argument name.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2136223004 .
2016-07-12 17:25:55 -07:00
79f7150d97
Issue 26249. Quick Assist to convert final fields into getters.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26249
Review URL: https://codereview.chromium.org/2140193003 .
2016-07-12 14:15:44 -07:00
f1fa32e356
Issue 26249. Quick Assist to convert getters into final fields.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26249
Review URL: https://codereview.chromium.org/2144763002 .
2016-07-12 13:31:53 -07:00
bf731dfcd5
Issue 26764. Insert required imports in the correct sorting order.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26764
Review URL: https://codereview.chromium.org/2143023002 .
2016-07-12 11:17:02 -07:00
c706a355b1
Tweak for the type of the 'instances' variable.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2142593002 .
2016-07-11 13:26:38 -07:00
cfb3f57a97
Initial memory use status page
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2140583003 .
2016-07-11 10:27:28 -07:00
d2d8dbff41
'Import library' fixes should use the same 'addLibraryImports' implementation as the fixes where importing is a side effect.
...
Preparation for https://github.com/dart-lang/sdk/issues/26764
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2138843002 .
2016-07-11 09:33:58 -07:00
ed887c09d1
Validate cache consistency asynchronously. Compute modification times of physical files in a separate isolate.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2132073003 .
2016-07-08 15:01:05 -07:00
1ce4c29f51
Validate only private sources, display statistics.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2131303002 .
2016-07-08 10:07:04 -07:00
37a6f62566
fix code completion when enableTrailingCommas is true
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2128693002 .
2016-07-07 12:42:30 -04:00
b8f6bb0958
remove arglist suggestion
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2124103002 .
2016-07-07 12:40:23 -04:00
dc42500408
Issue 26821. Don't add 'void' return type for setters when lint 'avoid_return_types_on_setters' is enabled.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26821
Review URL: https://codereview.chromium.org/2123333002 .
2016-07-06 13:00:38 -07:00
552d209a2a
Add links to context information for SDK contexts
...
R=pquitslund@google.com
Review URL: https://codereview.chromium.org/2119713004 .
2016-07-01 13:10:16 -07:00
71b1359ac8
Option to enable analyzer trailing comma support ( #26647 ).
...
(Parser changes to follow.)
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2112073002 .
2016-07-01 08:40:39 -07:00
e7008947ca
Make SDK contexts visible on status page
...
R=pquitslund@google.com
Review URL: https://codereview.chromium.org/2107313002 .
2016-06-29 10:36:35 -07:00
1b9bf0769d
fix #26122 , classify strong mode errors correctly
...
StaticTypeWarningCode was being handled, but many warnings with StaticWarningCode also need to be treated as errors.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2108823002 .
2016-06-28 14:35:44 -07:00
9c5213a077
Generalize DartSdkManager to support embedder SDKs
...
R=pquitslund@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/2107793002 .
2016-06-28 13:48:57 -07:00
3f1955a819
Add '--finer-grained-invalidation' option to Analysis Server.
...
I think we could start fishfooding it.
There might still be bugs, and I saw it still invalidating more than
I would like. But we can fix these problems.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2091883002 .
2016-06-23 13:10:04 -07:00
270695fc31
Adds PID to server.connected notification ( #26744 ).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2088663004 .
Fixes: https://github.com/dart-lang/sdk/issues/26744 .
2016-06-21 16:00:27 -07:00
1974dc5f20
Guard against missing element (issue 26685)
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2085563002 .
2016-06-20 09:51:53 -07:00
b7aff9c72f
Initial Bazel file resolver support.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2079873002 .
2016-06-17 14:20:55 -07:00
5c97a88ddd
Remove embedder locator from analysis context
...
R=pquitslund@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/2078993002 .
2016-06-17 09:42:27 -07:00
2b522d50d0
Deprecate EmbedderUriResolver
...
R=pquitslund@google.com
Review URL: https://codereview.chromium.org/2076743002 .
2016-06-17 07:44:02 -07:00
34a71429d9
Remove hook for setting a provider for an EmbedderUriResolver
...
R=pquitslund@google.com
Review URL: https://codereview.chromium.org/2075663002 .
2016-06-16 10:28:40 -07:00
ed4dc77436
Switch statement cleanups.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/2067973002 .
2016-06-14 12:34:08 -07:00
800a54354a
Conditionally enable SDK summaries in server
...
R=pquitslund@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/2020293004 .
2016-06-09 09:58:59 -07:00
4b6d9fdf39
Fix NPE when there is no keyword (issue 26630)
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2050463002 .
2016-06-07 14:14:02 -07:00
2d310f1e67
improve completions in closures and switch statements
...
This addresses several situations where the parser interprets "as" as
part of an "as" expression, but the user is trying to enter the "async"
keyword or an identifier starting with "as".
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2034713004 .
2016-06-06 08:09:44 -04:00
3fbb349629
Update status pages to include newer properties
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2023273002 .
2016-06-01 08:26:30 -07:00
62eb45dc32
Display additional context information in status pages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2030573002 .
2016-06-01 08:11:31 -07:00
fba5cbc425
Analyzer 0.27.4-alpha.9 (API fixes) ( #26562 ).
...
Restores `EmbedderUriResolver` API.
Addresses breakages in `dartdoc` and any other downstream dependencies.
See: https://github.com/dart-lang/sdk/issues/26562 .
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2021453003 .
2016-05-29 06:57:42 -07:00
6b04e74aa0
Guard against unresolved code (issue 26545)
...
R=jwren@google.com
Review URL: https://codereview.chromium.org/2013123002 .
2016-05-27 12:14:04 -07:00
08ce826f3b
Gather and report stats on the number of times flushed results are recomputed
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2005403005 .
2016-05-26 10:58:32 -07:00
53fe39137f
Embedder support refactoring (phase 1).
...
A bunch of changes to pave the way for emebdder SDK summary creation.
* Moves _embedder.yaml processing into the embedder SDK (out of the resolver).
* Changes EmbedderUriResolver to compose rather than extend a DartUriResolver.
* Fixes the wierd handling (dropping to add back) of `dart:` URIs.
* Fixes the incorrect overriding docs for `SDKLibraryImpl.shortName`.
* Updates embedder test to include a definition of `dart:core` in anticipation of adding some embedder SDK tests.
Some API work TODO in a follow-up CL (notably the way we check for the presence of embedders by querying the resolver is odd).
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2009303002 .
2016-05-25 10:52:53 -07:00
e3af3c8d76
Code completion improvement. Recommend all 'E.x' where E is an enum, also, filter out only the correct enum types in named arguments.
...
BUG=https://github.com/dart-lang/sdk/issues/24759
Review URL: https://codereview.chromium.org/1989393002 .
2016-05-18 12:08:17 -07:00
67a500e134
Issue 26460. Add Quick Fix for missing 'Function.call()' implementation.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26460
Review URL: https://codereview.chromium.org/1981353002 .
2016-05-17 09:00:53 -07:00
44836f8538
Support the name analysis_options.yaml for analysis options files
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1975963002 .
2016-05-13 07:33:06 -07:00
d87f9c09de
Update to use the latest version of the plugin package
...
R=pquitslund@google.com
Review URL: https://codereview.chromium.org/1965083002 .
2016-05-11 09:54:29 -07:00
27650456d1
Improve completion after IfStatement.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1968883002 .
2016-05-11 08:36:27 -07:00
fe1fda0766
Make dart:convert strong mode clean.
...
Also removes the ChunkedConverter.
R=lrn@google.com
Review URL: https://codereview.chromium.org/1964953003 .
2016-05-11 16:15:31 +02:00
cd7b7fc018
More tweaks for 'for' completion.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1963323003 .
2016-05-10 20:22:12 -07:00
522eaa9a80
Don't suggest types, getters, etc in 'for (Type ^)'.
...
Variable names should be suggested there.
It does not work for the moment, I'll need to make changes into
VariableNameContributor. But NOT suggesting all the garbage - for me
thi is 90% of the full solution ;-)
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1960783002 .
2016-05-09 12:30:15 -07:00
cf71ab114b
Suggest 'is' in 'if (x is^)'.
...
So, we don't treat is as an expression start, and don't suggest
inappropriate 'while', 'await', etc or identifiers.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1958733002 .
2016-05-06 14:36:43 -07:00
3775d92000
Suggest 'var' and 'final' in intializer of 'for'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1953893004 .
2016-05-06 13:49:48 -07:00
b73b82221e
Fixes for completing 'for (var v in^)' and 'if (v is^)'.
...
The 'if (v is)' will require more work - we somehow manage to suggest
'if', 'final', 'switch', 'while', but NOT 'is'. But at least identifiers
are now out.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1956813004 .
2016-05-06 13:17:15 -07:00
ada9cf43db
Issue 26355. Don't overwrite full index with declarations-only one.
...
What happens in this case is that when we analyze this project with
many (very small) files, we successfully index first declarations
(on computing RESOLVED_UNIT3) and then RESOLVED_UNIT. But when we attempt
to search, we ask for RESOLVED_UNIT, which is flushed. So, we compute it.
In the process we compute RESOLVED_UNIT3, and the listener in
_setupIndexInvalidation() indexes declarations, and overwrites the full
index.
There are several possible solutions, the simplest one is to not
overwrite any existing index information while indexing declarations.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26355
Review URL: https://codereview.chromium.org/1946353004 .
2016-05-05 07:10:14 -07:00
fcf97b6c3d
Keep directive annotations while sorting.
...
In one of the previous CLs I sorted unit members and removed the
required @MirrorsUsed annotation.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1938023002 .
2016-05-02 10:09:38 -07:00
7a9b2a3133
Use null aware operators to clean up code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1941793002 .
2016-05-02 08:38:46 -07:00
Konstantin Shcheglov