dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
86,732 Commits 2 Branches 0 Tags
8a1dbb160fdb2cfbbafbb9281dbbc0d23ba094fd
Commit Graph

12131 Commits

Author SHA1 Message Date
Jens Johansen 8a1dbb160f [parser] Parse record literals 
This is the first stab at implementing the record expressions from
https://github.com/dart-lang/language/blob/master/working/0546-patterns/records-feature-specification.md

Change-Id: I2adb6cb3cd50d4ee45e144e86ec7011d046f6170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253783
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-16 06:36:36 +00:00
Konstantin Shcheglov cccc959dd4 Implement UP for RecordType(s). 
Change-Id: I9960fbdc5cadbd600ad2ae5c9991b83852c428d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255143
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-15 22:59:27 +00:00
Konstantin Shcheglov b9f0b2ed8b Implementations for RecordTypeAnnotation nodes. 
Change-Id: Ice4425e70b62fc68d4ad3aa97faf6e56f4076781
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255144
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-15 22:35:26 +00:00
Brian Wilkerson 65058f87e1 Add visitor support for record literals 
Change-Id: I8f5aff11786a75ce02a8f3483585dc0513ae2c86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255142
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-15 20:00:46 +00:00
Konstantin Shcheglov 4eb511da43 Replace more Bazel with Blaze, some simplifications. 
Change-Id: I096860e17ce56c2f602718f11706f24989c1f65b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-15 19:50:46 +00:00
Konstantin Shcheglov c66faf9f3a RecordElement.instantiate(), substitution, type alias. 
Change-Id: Icd0e234e57d17a1c86140ed58fc9732da31bf1b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254942
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-15 17:31:36 +00:00
Brian Wilkerson d353323510 Initial AST structure for record literals 
Change-Id: I225365b90d2e006116b3a91307479839df07ec10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255140
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-15 17:01:26 +00:00
Brian Wilkerson 61af13bf29 Use var more consistently in the documentation generator 
Change-Id: I44fedefa38c34ea6813cc845aab9a0ba29abd0e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254944
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-15 03:50:16 +00:00
Konstantin Shcheglov fff672f417 Implement isSubtypeOf() for RecordType. 
Change-Id: I42003fb5ce7bb374a37cc704a85f9eb16ca3aa42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254841
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-13 17:12:25 +00:00
Konstantin Shcheglov 293c39cfce Add RecordElement, RecordTypeImpl, implement basic subtyping. 
Change-Id: I54ac91dfc5a4e01b6f960b865d3d73d11bd0cd84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255040
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-13 00:56:51 +00:00
Konstantin Shcheglov cc49399c65 Add all nodes to NodeLintRegistry. 
Change-Id: I185bcad6cc749b4ee6b78779db162d0632154585
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-13 00:06:34 +00:00
Martin Kustermann b785f7dba8 Avoid logging information by-default and never discarding such logs 
The analyzer wraps various functionality in logging calls like

    await logger.runAsync('Prepare linked bundles', () async {
      ...
    });

Doing so will cause time being measured and begin/end messages to be
written to a log. Those strings accumulate in a `StringBuffer` that
is never accessed.

For example running analyzer on a big app like flutter can cause
thousands of "--- Prepare linked bundles in 0 ms.  " strings to be
generated and hanged on to.

This CL makes us no longer generate such strings - only if the
creator of a context supplies a [PerformanceLog] explicitly (in which case
it is responsible for draining the messages written to it).

This reduces memory consumption when analyzing flutter by around 3 MB.

TEST=ci

Change-Id: I4979a964f13c63bd2a3cccef97fb702431731139
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-08-12 21:02:54 +00:00
Konstantin Shcheglov 7d87a37d57 Add RecordType interface. 
Change-Id: I22ddc807cf9bc5429c7feb806631a78273fb4366
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254860
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-12 19:26:33 +00:00
Konstantin Shcheglov f1aea65363 Add ImplicitCallReference to NodeLintRegistry 
Towards https://github.com/dart-lang/language/issues/2399

Change-Id: I4e31bec7703504711a5827e282b2b52d14ae6b05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254465
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-12 19:09:16 +00:00
Konstantin Shcheglov 5b3a78b675 Prepare to publish analyzer 4.6.0 and _fe_analyzer_shared 46.0.0 
Change-Id: I3562b5e3ce0c7f744d4bf80a71adf8e97b9b57b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254740
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-11 23:31:18 +00:00
osama 602c7674c4 Fixing broken URL in the analyzer package 
Closes https://github.com/dart-lang/sdk/pull/49645

GitOrigin-RevId: b84e83ada9264ccfb84c7a4e42482b013bcc4099
Change-Id: I91c00da6d7319ec7bcf31a073ac54d466ba1f2d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-11 21:31:19 +00:00
Konstantin Shcheglov 82e33cc598 Add DartType.element2 
Unfortunately my idea about checking for specific `DartType` subtype,
and only then asking for the element is too punitive. It almost
works in google3, but the amount and the kind of changes I had to
do make me realize that we should keep `get elementX` in `DartType`.

I guess this is the same as we had in AST when `get constructors`
does not make sense for mixins (?), but works for classes and enums,
and it is easier to pull it into the superclass.

Change-Id: Ibc4fac0b95d63748fa65de96d29300f477fdfc76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254482
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-11 16:01:48 +00:00
Paul Berry ac08c03dc6 Flow analysis: break up libraries. 
This change breaks flow_analysis.dart into the following libraries:

- assigned_variables.dart (for the AssignedVariables class and related
  code)

- promotion_key_store.dart (for the PromotionKeyStore class)

- type_operations.dart (for the TypeOperations mixin and related code)

- flow_analysis.dart (for the rest of flow analysis)

And it breaks mini_ast.dart into the following libraries:

- flow_analysis_mini_ast.dart (functionality specifically concerned
  with testing flow analysis)

- mini_ast.dart (functionality not specifically related to flow
  analysis)

This is in preparation for trying to share some more type inference
behaviors between the analyzer and CFE.

Note that although the diff is big, the only changes in this CL are
moving code from one place to another, renaming some class members
from private to public, and updating imports.

Change-Id: I71768f03b1e75ed754c7b7af39f6cf7f03c4fe44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254462
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-08-11 13:18:52 +00:00
Sam Rawlins e139fb1527 Tidy some lint issues in analyzer 
* Move many identifiers from snake_case or SCREAMING_SNAKE_CASE to
  camelCase. I think I restricted the changes to private API.
* Add an ignore in generated files for constant_identifier_names;
  we often just mirror names found in YAML files or whatever, where
  things are not necessarily named according to Effective Dart
  standards.
* Avoid some implementation imports which I think were accidental.
* Use single quotes in some more places.

Bug: https://github.com/dart-lang/sdk/issues/48784
Change-Id: I439fe50cb9f8f8f5e9c74ce594aea15e394ee7da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-08-10 21:23:21 +00:00
Paul Berry e6c805a3c5 Flow analysis: split test harness class. 
This change splits the `Harness` class into a base class, `Harness`,
which in principle can be used for testing type inference logic in
general, and a derived class `FlowAnalysisTestHarness`, which is
specialized for flow analysis tests.

This is in preparation for trying to share some more type inference
behaviors between the analyzer and CFE.

Change-Id: Ic56b8dd8748065ca59e246e0d804946cc69203c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254280
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-08-10 20:47:41 +00:00
Konstantin Shcheglov f3d919308f Use different marker file to identifier Blaze workspace. 
Bug: https://github.com/dart-lang/sdk/issues/49629
Change-Id: I8f1496735373494745a79d502488a217e3c71223
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-10 19:58:43 +00:00
Konstantin Shcheglov 43065920cc Rename Bazel to Blaze - files, classes, methods. 
No changes to implementation yet, we still look for both Blaze and Bazel.

Bug: https://github.com/dart-lang/sdk/issues/49629
Change-Id: Iaf1b1cc2c9a8cf28d8bbfb5541819a1f5c8a3de6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254343
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-10 16:00:18 +00:00
Konstantin Shcheglov a1b90438e8 Prepare to publish analyzer 4.5.0 and _fe_analyzer_shared 45.0.0 
Change-Id: I0ab45251f8a7e87b70ce6dfd1f964da7d2cc6e9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-09 22:42:26 +00:00
Konstantin Shcheglov 7e86f2e71c Deprecate 'TypeSystem.instantiateToBounds2()', use 'instantiateInterfaceToBounds()' or 'instantiateTypeAliasToBounds()'. 
Change-Id: Id706edc41e482ccff44038f922732d2ecea7c735
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254320
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-09 21:41:35 +00:00
Konstantin Shcheglov f4c009dc33 Deprecate Declaration.declaredElement, use 'declaredElement2' instead. 
This is necessary to separate `ClassElement`, `EnumElement`, and `MixinElement`. And, in the future, augmentations like `ClassAugmentationElement`, etc.

Change-Id: Iecd2f8707212e53ef56f0e101880c7bab9e5d057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254104
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-09 17:26:06 +00:00
Konstantin Shcheglov f9ba5c03df AST for RecordTypeAnnotation. 
Change-Id: I3d52c97fe4f01cfb06923829e6e519d1990ae62b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254120
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-09 17:08:56 +00:00
Konstantin Shcheglov 75b8b916d6 Deprecate ClassOrMixinDeclaration, use ClassDeclaration or MixinDeclaration. 
Change-Id: I23e292e9f7c4413edf9b068f057dd02794db21a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-08 21:40:40 +00:00
Konstantin Shcheglov 8c275efddf Update deprecation message for 'FormalParameter.identifier'. 
Change-Id: I2670fbfd01ba5864fd339bd2e6dd059660fdf9c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253904
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-08 04:28:59 +00:00
Konstantin Shcheglov a34e93f9d3 Prepare to publish analyzer 4.4.0 and _fe_analyzer_shared 44.0.0 
Change-Id: I81a6366092ede393546212cfef1746fa06d1aed6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253709
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-05 21:27:37 +00:00
Konstantin Shcheglov 59728cafb2 Support getErrors2() for parts. 
Change-Id: I6b315dedf4837668c8583c873612fce26e9cb287
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253822
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2022-08-05 21:26:38 +00:00
Konstantin Shcheglov 35413ac2b4 Deprecate getType(), use getClass() instead. 
Change-Id: I58d25a5449dfc79b1d6a092e58268f7a612d378c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253708
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2022-08-05 05:25:17 +00:00
Konstantin Shcheglov 8e5c197d42 Evaluate default values of all default parameters, even required (e.g. required named). 
Bug: https://github.com/dart-lang/sdk/issues/49596
Change-Id: Id9696a6e93499ec4eca164ccb78c39aec5acaaab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253705
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-04 21:52:56 +00:00
Konstantin Shcheglov 5458af8662 Deprecate ClassElement.isEnum/isMixin, use 'is EnumElement' instead. 
Change-Id: I493fb048d0f7c8af778a35e4543df206cfd18739
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253680
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-04 19:21:27 +00:00
Konstantin Shcheglov cbfad8f802 Deprecate DartType.element, use specific element accessor for InterfaceType, TypeParameterType. 
For `InterfaceType` keep `element2` deprecated and define
`InterfaceElement get element2` instead. Most changes are because
of this.

Change-Id: I13b888610fc707438c3c97b676f1460e7fc2b040
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253564
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-04 16:18:06 +00:00
Konstantin Shcheglov 468507bd10 Use named parameters for more AST implementations. 
Change-Id: Id99eb4c1a1e2f0e951c9813e63497719203d0821
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253608
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-04 16:01:19 +00:00
Konstantin Shcheglov 8e1224da23 Use named parameters for more AST implementations. 
Change-Id: I710f37870699d728d1ea45bafee47b822418e1ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-03 20:13:27 +00:00
Danny Tuppeny e7df4c9b19 [analysis_server] Provide context message for duplicate definition diagnostics 
Fixes https://github.com/dart-lang/sdk/issues/32762.

Change-Id: Ia2995f1065f599627d94065b2b94f0e99a7d1650
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-03 16:43:55 +00:00
Konstantin Shcheglov 7f06a066d3 Use named parameters for more AST implementations. 
Change-Id: I9b7c4e24c9174b7cb118f8830cbcb7aed5e5eda2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253560
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-02 23:34:44 +00:00
Konstantin Shcheglov 528836c4aa Deprecate 'get enums/mixin', use 'get enums2/mixins2'. 
Change-Id: I5c7dbb6dcc58537657e429893797b2631733ce16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252871
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-02 21:05:54 +00:00
Sam Rawlins 2bedf1e55d Improve UNUSED_ELEMENT documentation 
For https://github.com/dart-lang/linter/pull/3513

Change-Id: Ia522fc8958c2c7c48e3366a874ceae28cb9ed6bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-08-02 20:18:19 +00:00
Konstantin Shcheglov fe44e1e9ef Add MixinOrAugmentationDeclaration, MixinAugmentationDeclaration. 
Change-Id: I84ddbe3d95087b8925caecc5e3d2d13b23158ab8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253363
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-02 20:08:54 +00:00
Konstantin Shcheglov 7bfc648617 Use named parameters for more AST implementations. 
Change-Id: I0b47f6b9e87fa773ca08ad1ec8e7afcca69a0527
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253521
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-02 20:03:14 +00:00
Konstantin Shcheglov 71ef76ddfd Deprecate Element.enclosingElement2, use 'enclosingElement3'. 
Change-Id: I0aba589bd42648eb420051cbe04bb3ef435081e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253400
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-02 18:00:14 +00:00
Konstantin Shcheglov 5e45794796 Issue 49547. Don't replace synthetic accessors of non-synthetic fields with non-synthetic accessors. 
Support for optionally dumping linking between properties and accessors
in element model tests.

Bug: https://github.com/dart-lang/sdk/issues/49547
Change-Id: Idb195213f5812b8b3d68f0dd857e06c889a3e076
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-02 17:19:04 +00:00
Konstantin Shcheglov 01173e2aa2 Deprecate 'name' in AST, use 'name2' token instead. 
Change-Id: I867f009dca12208f835199297d2ea85c203c8556
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252566
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-02 16:25:34 +00:00
Ömer Sinan Ağacan 1a1b739872 [analyzer/ffi] Fix FfiNative check for getters and setters 
getter and setter methods also take a receiver argument, treat them the
same way as non-static methods

Fixes #49563

Bug: 49563
Change-Id: I778e0dc18e5e2e10cf689b171fac4030b104ca2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252941
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-02 07:28:34 +00:00
Sam Rawlins 4e616b6b0d Do not point to .packages file in analyzer script 
Change-Id: Id78aa0d858b5242f7a62fd737ab5cb7dc9d2b373
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253364
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-08-02 00:12:16 +00:00
pq 85d91f95b9 migration to code_style_options 
More migrations to code_style_options.

See: https://github.com/dart-lang/sdk/issues/49558

Change-Id: I8a2e8459ea9e02b9d65a219dad3ec73080001782
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252965
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-01 21:45:34 +00:00
Konstantin Shcheglov 2c54a11c23 Add 'FileResult.isAugmentation' and 'isLibrary'. 
Change-Id: I862a21d5abdefce14ad48a1043d90f0a32fc6994
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253240
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-01 21:07:44 +00:00
Konstantin Shcheglov 5f2e0017bb Add ClassOrAugmentationDeclaration, ClassAugmentationDeclaration. 
Change-Id: I274a8ad06b7cd334623fd13ff47b5eb632232c45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-01 20:27:54 +00:00