dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
51,945 Commits 2 Branches 0 Tags
89aa45f7c752b6c5cfcb4b61ba87cad0dfbeff73
Commit Graph

52 Commits

Author SHA1 Message Date
Lasse R.H. Nielsen 0b58c4bd10 Change some constant declarations to lowerCase. 
Retain the old values.

Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.

Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen e61fc07b58 Revert "Change some constant declarations to lowerCase." 
This reverts commit c048cfb178.

Reason for revert: VM code fingerprints needs update.

Original change's description:
> Change some constant declarations to lowerCase.
> 
> Retain the old values.
> 
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=lrn@google.com,floitsch@google.com

Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen c048cfb178 Change some constant declarations to lowerCase. 
Retain the old values.

Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-11-14 11:13:04 +00:00
Aske Simon Christensen 306668bf0a Support syntax error outcome in sdk test suite. 
Also updated test expectations.

Change-Id: I25fe9f47904beb89b9e18cfafd2e889c6a8106a2
Reviewed-on: https://dart-review.googlesource.com/18800
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2017-11-06 12:22:51 +00:00
Sigmund Cherem 5462885dd8 Process arguments in runMe to extract the environment and selectors 
Bug: https://github.com/dart-lang/sdk/issues/31177
Change-Id: I7c3190c95f81fb580bfa6c142d6ea9726548e343
Reviewed-on: https://dart-review.googlesource.com/15765
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-10-23 21:27:48 +00:00
Aske Simon Christensen 60be83aed4 Reland "Suite for Fasta crashes and verification errors in language tests" 
Remove obsolete "language" suite.

Original review: https://dart-review.googlesource.com/13741

Change-Id: I713fa2684fe478f6e9123d33ee7b7d2a961b1c00
Reviewed-on: https://dart-review.googlesource.com/14460
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2017-10-17 13:54:40 +00:00
Martin Kustermann 25dc42f5d8 Revert "Error on setter having not exactly one parameter" 
This reverts commit 4bb83e9311
This reverts commit f1b07b2789.

Reason for revert on analyzer bots:

    Analyzing pkg/analyzer...
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:625:9 • undefined_identifier
      error • Undefined name 'CompileTimeErrorCode' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:625:18 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:626:13 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:635:9 • undefined_identifier
      error • Undefined name 'CompileTimeErrorCode' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:635:18 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:636:13 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:645:9 • undefined_identifier
      error • Undefined name 'CompileTimeErrorCode' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:645:18 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:646:13 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:655:9 • undefined_identifier
      error • Undefined name 'CompileTimeErrorCode' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:655:18 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:656:13 • undefined_identifier
    12 errors found.

Change-Id: Ie2035bf40e50c48f85b514c7a3786141cd0f2453
Reviewed-on: https://dart-review.googlesource.com/14061
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2017-10-16 16:32:13 +00:00
Aske Simon Christensen 4bb83e9311 Suite for Fasta crashes and verification errors in language tests 
Remove obsolete "language" suite.

Change-Id: I8daad8b7fd2d6e19124850626a5815aa9dcca347
Reviewed-on: https://dart-review.googlesource.com/13741
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-10-16 16:01:55 +00:00
Leaf Petersen 3124001cc7 Eliminate uses of fuzzy arrows in pkg/testing (fix bots). 
The analyzer now issues hints on uses of the deprecated behavior in
which dynamic is treated as bottom in certain positions.  These
changes eliminate cases from pkg/testing that were relying on the
deprecated behavior.

TBR=ahe@google.com

BUG=

Review-Url: https://codereview.chromium.org/3010803002 .
 2017-08-30 16:24:56 -07:00
Johnni Winther f1b3a59da3 Use package:testing for tools/gardening 
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2999043003 .
 2017-08-16 15:55:52 +02:00
Erik Corry 029b1cb948 Spelling fixes e to i. 
R=kevmoo@google.com
BUG=

Review-Url: https://codereview.chromium.org/2957593002 .
 2017-06-24 13:41:39 +02:00
Peter von der Ahé 69d6e8e55a All strong mode cleaning of dart2js. 
Fixes https://github.com/dart-lang/sdk/issues/29886

Supersedes CLs 2939193003, 2950433002, and 2947583002.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2944843002 .
 2017-06-19 14:06:38 +02:00
Florian Loitsch 71ad537fbf Fix "?." usage in analyze.dart. 
Review-Url: https://codereview.chromium.org/2941123005 .
 2017-06-16 13:29:15 +02:00
Peter von der Ahé e24970ef40 dart2js isn't strong mode clean yet. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2939313003 .
 2017-06-16 12:21:54 +02:00
Peter von der Ahé dcf133589a Trim the String, not the Future. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2940653002 .
 2017-06-13 16:16:23 +02:00
Peter von der Ahé 964384424a Analyze package:testing. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2941493002 .
 2017-06-13 15:46:04 +02:00
Peter von der Ahé 74b037fbf9 Use Fasta scanner when running analyzer. 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2925823002 .
 2017-06-06 20:06:41 +02:00
Konstantin Shcheglov 433b7904c2 Revert "Fix another warning in pkg/testing." 
This reverts commit d935a7fd00.

R=aam@google.com, ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2922303002 .
 2017-06-05 18:44:34 -07:00
Konstantin Shcheglov d935a7fd00 Fix another warning in pkg/testing. 
R=ahe@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2925583002 .
 2017-06-05 10:32:29 -07:00
Konstantin Shcheglov 64ed9c942c Fix type argument for Result. 
R=ahe@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2920283002 .
 2017-06-05 09:43:07 -07:00
Peter von der Ahé c4481e2384 Add RuntimeError to default expectations and handle expectation groups correctly. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2913153002 .
 2017-05-31 15:02:51 +02:00
Peter von der Ahé 8f1a69826a Fix problems with closures_test. 
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2898173005 .
 2017-05-30 12:10:01 +02:00
Peter von der Ahé ddf5fc23f1 Improve analysis coverage. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2904483002 .
 2017-05-24 15:52:42 +02:00
Peter von der Ahé 547b2cdcce Implement generalized function types. 
Fixes https://github.com/dart-lang/sdk/issues/6972

Fixes https://github.com/dart-lang/sdk/issues/26581

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2876813002 .
 2017-05-19 11:03:24 +02:00
Paul Berry 8ea1906e54 Handle diagnostic messages from analyzer that lack a URI. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2886193003 .
 2017-05-17 14:17:49 -07:00
Erik Corry aa6353b6da Dart SDK Spelling b, c, and d. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2850783002 .
 2017-05-01 08:28:10 +02:00
Erik Corry 2fb5d08102 Spelling a 
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2841543002 .
 2017-04-24 14:53:51 +02:00
Erik Corry 6617737ff5 Replace 'the the' with 'the' 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2830353002 .
 2017-04-24 08:50:37 +02:00
Erik Corry 4b9bba55b4 Stoppp using trippple consonants 
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2833073002 .
 2017-04-21 17:50:13 +02:00
Peter von der Ahé f1a6b12341 Parse escapes in analyzer machine output and handle Windows file names. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2823293003 .
 2017-04-19 14:36:09 +02:00
Paul Berry 84ef5ed2da Add the ability to select a subset of tests using "...". 
For example, the following command:

    pkg/front_end/tool/fasta testing compile/type...

Now runs all tests in the "compile" suite whose name begins with
"type".

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2824373002 .
 2017-04-19 01:45:34 -07:00
Peter von der Ahé 5a81cba61a Specify location of SDK when running analyzer. 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2794003002 .
 2017-04-03 17:47:21 +02:00
Peter von der Ahé 0e82fb44c2 Run analyzer from sources instead of built SDK. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2790143002 .
 2017-04-03 16:13:51 +02:00
Peter von der Ahé 5bdc1199ca Fix dart2js warnings and add test to ensure it stays clean. 
Filed https://github.com/dart-lang/sdk/issues/29224 to track all the problems that require ignore.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2791993002 .
 2017-04-03 15:08:40 +02:00
Jacob Richman de54e18369 Run dartfmt on remaining unformated pkg packages 
BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2743423009 .
 2017-03-21 18:21:32 -07:00
Jacob Richman 88eb557b65 Fix warnings_checker.dart handling of multitests 
Update all tests

Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com
BUG=

Review-Url: https://codereview.chromium.org/2765693002 .
Review-Url: https://codereview.chromium.org/2765893003 .
 2017-03-21 17:29:56 -07:00
Jacob Richman bf2b545150 Revert "Update all tests" 
This reverts commit ce76e9c30beaf9a193d3677b88c20a1ebb3fae8c.
 2017-03-21 16:33:18 -07:00
Jacob Richman 3c7353d987 Update all tests 
Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2765693002 .
 2017-03-21 12:39:28 -07:00
Sigmund Cherem 884f0acf8d Allow to specify analysis-options to the analyzer step in package:testing, and 
use it in pkg/front_end

BUG=
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2697603009 .
 2017-02-16 10:38:51 -08:00
Peter von der Ahé 43932d0bb6 Compute default value of -j option based on number of processors. 
R=dmitryolsh@google.com, karlklose@google.com

Review-Url: https://codereview.chromium.org/2698583004 .
 2017-02-15 13:51:09 +01:00
Peter von der Ahé cca7c0ea6d Fix problem in previous CL: analyzer was alway run, and nothing else. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2697513004 .
 2017-02-14 13:33:37 +01:00
Peter von der Ahé 0d55f1b8fc Fix two problems with the analyzer suite: 
* Don't complain about no tests configured when only analyzing.

* Run analyzer on all tests, no only those that have been selected for running.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2693893004 .
 2017-02-14 12:02:06 +01:00
Peter von der Ahé cb10fc984b Add a new kind of suite to ease test.dart integration. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2693893002 .
 2017-02-14 10:45:44 +01:00
Zach Anderson 8a9a98073f [dart:io] flush() stdin before close()ing 
Calls to close() on an IOSink do not imply that writes buffered by the
underlying StreamConsumer have been flushed. This CL adds a note
indicating this to the IOSink docs, and adds calls to flush() before
calls to close() for some calls to stdin.close() for spawned
processes in our tests.

related #28737

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2687963003 .
 2017-02-10 09:55:16 -08:00
Peter von der Ahé 7512ab5c79 Enable running of fasta tests on build bot. 
Fixes https://github.com/dart-lang/sdk/issues/28594

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2675593003 .
 2017-02-03 07:12:04 +01:00
Peter von der Ahé 819182a4c5 Don't ignore analyzer and dart2js when analyzing fasta. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2646363004 .

# Conflicts:
#	pkg/fasta/testing.json
 2017-01-31 11:17:29 +01:00
Peter von der Ahé 011f616a58 Dynamic type error implies checked mode. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2641833002 .
 2017-01-31 11:16:04 +01:00
Peter von der Ahé 4570f34bc1 Implement custom status file expectations. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2623413003 .
 2017-01-31 11:16:04 +01:00
Peter von der Ahé fc51d91e99 Add general method for comma separated options. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2622383003 .
 2017-01-31 11:16:04 +01:00
Peter von der Ahé b33c057456 Implement multitest failure expectations. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2627753005 .
 2017-01-31 11:16:03 +01:00