dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
51,945 Commits 2 Branches 0 Tags
89aa45f7c752b6c5cfcb4b61ba87cad0dfbeff73
Commit Graph

21 Commits

Author SHA1 Message Date
Vijay Menon c1d45769c3 Inline constant values 
Change-Id: Iee929bc64c152be989e6e7ba38132f806c33c7e0
Reviewed-on: https://dart-review.googlesource.com/11960
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
 2017-10-10 13:21:41 +00:00
Jennifer Messerly 353583fb10 fix how DDC finds its undefined constant 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/3009733002 .
 2017-08-29 14:16:39 -07:00
Jennifer Messerly ed5ced82b1 Re-land "fix #30423, covariant parameter tearoff type should be Object" 
This is the original CL plus status file fixes.

Disables auto-generated function_type tests that are not working for the Dart 2 runtime behavior, and filed #30462 to track. Also removes the separate status that was skipping these tests in DDC when $checked was unset. $checked is not a thing for Dart 2, and DDC test status should never depend on it.

This reverts commit 1b0b1a4913.

R=leafp@google.com

Review-Url: https://codereview.chromium.org/3001053002 .
 2017-08-16 23:23:36 -07:00
Brian Wilkerson 1b0b1a4913 Gardening: Revert "fix #30423, covariant parameter tearoff type should be Object" (TBR) 
Review-Url: https://codereview.chromium.org/2995973002 .
 2017-08-15 17:02:49 -07:00
Jennifer Messerly d09868c02f fix #30423, covariant parameter tearoff type should be Object 
some tests needed to be updated to reflect the informal spec semantics.

R=leafp@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2995813002 .
 2017-08-15 14:27:06 -07:00
Jennifer Messerly 90380dfdfa fix #27259, implement covariance checking for strong mode and DDC 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2954523002 .
 2017-07-06 14:31:35 -07:00
Jennifer Messerly 334354f968 fix #29753, use ES5 constructors for ddc 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2934623003 .
 2017-06-12 15:31:32 -07:00
Jennifer Messerly 811a9eed1d Revert "Revert "fix #27256, track type bounds for generic functions"" 
This reverts commit 3a23e604e2.

The problem was unrelated to the CL; it appears to be a dart:async break of package:async.

In the meantime we have turned on --unsafe-force-compile to DDC's shapshotting step

Review-Url: https://codereview.chromium.org/2869733006 .
 2017-05-09 14:20:25 -07:00
Alan Knight 3a23e604e2 Revert "fix #27256, track type bounds for generic functions" 
This reverts commit b58f826976.

BUG=

Review URL: https://codereview.chromium.org/2870543005 .
 2017-05-09 12:58:03 -07:00
Jennifer Messerly b58f826976 fix #27256, track type bounds for generic functions 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2867493002 .
 2017-05-09 11:42:40 -07:00
Jennifer Messerly eeb0e1d2ae fix #27258, don't allow dynamic set of a final field 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2847893002 .
 2017-05-01 15:36:32 -07:00
Vijay Menon 5c3bcff375 DDC fix for foreign futures 
Fixes #29287

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2804113002 .
 2017-04-06 14:52:59 -07:00
Jennifer Messerly e4e7dffadb fix #29182, generate top level const fields lazily 
This fixes an ordering issue, but also may help load time.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2797443007 .
 2017-04-04 16:18:46 -07:00
Jennifer Messerly 1c504f8945 Fix #28120, strong mode allows field overrides 
Fix #28119, DDC supports field overrides without @virtual
Fix #28801, devirtualize private fields in DDC where possible
Fix #28589, stop supporting @virtual in strong mode

R=leafp@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2781443003 .
 2017-03-28 10:26:36 -07:00
Jacob Richman 1f38879094 Inline source maps as part of each script. 
Unfortunately this is required as even with ideal caching, performing
XHRs to load all source maps increased load times by ~5 seconds for large
applications. Performance hit is now minimal.

BUG=

Review-Url: https://codereview.chromium.org/2747513003 .
Review-Url: https://codereview.chromium.org/2746033003 .
 2017-03-13 10:46:02 -07:00
Jacob Richman a6a206062d Custom formatter cleanup Fix case where displaying a class constructor generated unreadable huge output. Fix case where exceptions were throw. Correct display of statics, fix indentation bugs. Add improved custom formatter test to main repro. As a drive by fix, switch hashCode to use a symbol instead of the name $identityHash as $identityHash was making custom formatter test output unstable. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2703263002 .
 2017-02-28 17:47:53 -08:00
Leaf Petersen ef120f105f When metadata is not requested, elide signature information that is 
not needed for dynamic checks (static fields/getters/setters and constructors).

BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2711253004 .
 2017-02-24 12:59:09 -08:00
Leaf Petersen a3b4366f11 Infer Null for return type of functions with empty returns. 
This allows inference to infer Null as the return type of functions
which have no return statements, or which return with no value.

Also allows inference to propagate Null.

Fixes https://github.com/dart-lang/sdk/issues/28602
Fixes https://github.com/dart-lang/sdk/issues/28630

BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Review-Url: https://codereview.chromium.org/2667343005 .
 2017-02-06 12:24:39 -08:00
Jacob Richman 3356f82eb3 Fix crashing bug for closures of the form () { return; } 
BUG=
R=jmesserly@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2484913004 .
 2016-11-08 15:14:10 -08:00
Vijay Menon 9af2fb0115 More DDC mirrors support 
(Note, this is a straight migration of the old DDC repo CL. :-))

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2301973002 .
 2016-09-01 10:13:31 -07:00
Leaf Petersen 0315595d60 Check in codegen test expectations. 
Codegen output is checked into repository to make codegen regressions
more visible (especially readability regressions).

BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2128353002 .
 2016-07-07 15:57:22 -07:00