c6c7580c92
Add error detection and reporting for errors related to plugins
...
Change-Id: If17e88b64022fe71c992c5867c80263c0e6b953b
Reviewed-on: https://dart-review.googlesource.com/18781
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-11-05 19:21:07 +00:00
47a861ca85
Add two new element types to the protocol.
...
Bug:
Change-Id: I5a60081d7c8500590bbabb9ee6dce74fa611b0a3
Reviewed-on: https://dart-review.googlesource.com/14883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-18 19:02:47 +00:00
a5c2256455
Send test element kinds for test outline items.
...
Bug:
Change-Id: Iebea8d4b9705c726e297722ef1678e1a2cd1ea96
Reviewed-on: https://dart-review.googlesource.com/12841
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-11 17:00:41 +00:00
b3439aa20b
Guard against broken code (issue 31023)
...
Change-Id: I9f53abb1257a3ffc86dc4bf46e2591c7f936d1fe
Reviewed-on: https://dart-review.googlesource.com/11940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-06 17:28:04 +00:00
e925eb125c
Fix type code for typedefs after switching to GenericTypeAliasElement.
...
https://dart-review.googlesource.com/c/sdk/+/9421
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I25d60ff904f15e6eeefff97b08ba9870d69733db
Reviewed-on: https://dart-review.googlesource.com/9460
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-29 04:27:53 +00:00
3ee522935d
Add suffix to remove the possibility of contention over byte stores in plugins
...
Change-Id: I448eaac6d9525432a6b154729abcaef62f0332ee
Reviewed-on: https://dart-review.googlesource.com/8260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-09-25 21:19:39 +00:00
455984bbf9
Fix fuzzy arrow warnings in analyzer and analysis_server.
...
There is one warning which I'd like to fix in a separate CL.
The rest is because of package:test predicate().
I think Leaf fixed it in https://github.com/dart-lang/matcher/commit/3625f13698346576da0f5baf44e95abc9c56fb49
R=brianwilkerson@google.com
Bug:
Change-Id: I060f7ced55dbcc460185916251c47ebbd5c838d3
Reviewed-on: https://dart-review.googlesource.com/3404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-06 00:26:18 +00:00
37042bb59b
Add an integration test for kythe support with bug fixes
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/3006693002 .
2017-08-28 10:07:04 -07:00
608bf972b0
Add folding support for plugins and update the main tutorial page
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3004733002 .
2017-08-28 08:05:37 -07:00
d1a2a43d54
Add plugin support for occurrences (and fix typo)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3006703002 .
2017-08-28 08:04:42 -07:00
86918d713b
Add SourceRange support to navigation collector
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3002343002 .
2017-08-27 12:31:13 -07:00
dd00fc7750
Add support for highlights notification
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3004613002 .
2017-08-25 09:21:36 -07:00
dc60566293
Make finalize() async and await adding imports, if any.
...
There were two flaky tests for assists because sometimes we managed
to execute adding imports before performing checks in the test. And
in this case there was additional (unexpected) empty file edit for
the library file (the only expected file edit was for the part).
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/3009563002 .
2017-08-24 21:07:34 -07:00
efd4051c7e
Add utilities to support the outline notification
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3002233002 .
2017-08-24 11:59:06 -07:00
c6b206a2d9
Clean up after some recent code changes
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3009513002 .
2017-08-24 10:01:11 -07:00
e8010e4a44
Enhance NavigationMixin to handle notifications
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3008443002 .
2017-08-24 07:44:51 -07:00
c53bc9f628
Unify lots of copied code in one utility method
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3008433002 .
2017-08-23 14:25:03 -07:00
0a50effce5
Add minimal support for sending notifications
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3003573002 .
2017-08-23 13:26:59 -07:00
d87fcfd233
Correctly update positions when adding edits before them (issue 30444)
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2997073002 .
2017-08-16 10:29:26 -07:00
6f81034a73
Initial Kythe support for plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2997833002 .
2017-08-14 08:24:15 -07:00
ecc72d6be5
Initial implementation of the kythe domain
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/2999783002 .
2017-08-10 11:49:22 -07:00
579a032564
Add kythe support to plugins and format the spec files
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/2994103002 .
2017-08-10 11:24:40 -07:00
e2f77056a5
Eliminate dependencies on pkg/front_end.
...
The API for pkg/front_end is still in flux so we want to avoid having
any packages depend directly on it (other than analyzer and
back-ends).
This CL re-exports some of the critical pieces of front_end needed by
analyzer clients so that those clients can access them via analyzer,
without having to directly depend on front_end. It also updates
pkg/analyzer_plugin to make use of those re-exports.
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2993123002 .
2017-08-07 09:46:30 -07:00
adb482002b
Prevent exception with isolate failed to start
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2986123002 .
2017-07-28 08:26:31 -07:00
9a6b134d33
Improve name generation for indexed expressions
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2990793002 .
2017-07-27 07:58:34 -07:00
8bbf373a5e
Remove the analysus.reanalyze request from the plugin API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2988743002 .
2017-07-25 12:10:52 -07:00
1e0e351406
Fix a typo in the docs
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2988683002 .
2017-07-24 09:54:23 -07:00
8a275e6df8
Add utility method to SubscriptionManager
...
R=mfairhurst@google.com
Review-Url: https://codereview.chromium.org/2983913002 .
2017-07-21 07:24:55 -07:00
0c775ae412
Guard against an AST node with no end token (issue 30089)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2974533002 .
2017-07-06 12:51:23 -07:00
75504c2b25
Remove references to AnalysisDriver from the plugin mixin classes
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2970203002 .
2017-07-06 09:07:10 -07:00
6a7b9f441b
Convert DartChangeBuilder to use AnalysisSession
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2969833002 .
2017-07-03 08:41:40 -07:00
aadafd1bd5
Use DartEditBuilder to write types and remove dead code
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2972463003 .
2017-07-01 12:03:44 -07:00
6f4420562c
Clean up some code in plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2967683002 .
2017-06-30 10:39:20 -07:00
4749014b06
Remove an unused request and the associated type
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2964113003 .
2017-06-30 09:44:59 -07:00
47244b4215
Stop creating unnecessary Source
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2969543003 .
2017-06-30 08:20:51 -07:00
d1bb233f52
Remove timeStamp from the ChangeBuilder API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2962223002 .
2017-06-29 13:48:46 -07:00
84dd01904d
Missed change to conform to other APIs
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2965453002 .
2017-06-29 06:15:38 -07:00
7bd9e6c443
Add a mixin for assists similar to that for fixes
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2956353002 .
2017-06-28 11:44:22 -07:00
6248e7cab2
Add support code to make fixes easier in plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2962903002 .
2017-06-28 10:52:06 -07:00
9ddb832e10
Generate constants in server as we do in plugin
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2960073002 .
2017-06-28 08:21:33 -07:00
a2f18fdb73
Fixes and tests for adding library imports.
...
R=brianwilkerson@google.com , pquitslund@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/1119
Review-Url: https://codereview.chromium.org/2955913002 .
2017-06-26 13:16:19 -07:00
4a10003924
Update the plugin API
...
R=maxkim@google.com , mfairhurst@google.com
Review-Url: https://codereview.chromium.org/2953093002 .
2017-06-23 12:31:00 -07:00
24996fbfe7
Add support to pass the location of the analysis options file to plugins
...
R=mfairhurst@google.com
Review-Url: https://codereview.chromium.org/2947743002 .
2017-06-20 07:41:03 -07:00
5976c78a79
Handle unresolved constructor (issue 29925)
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2944083002 .
2017-06-20 06:16:23 -07:00
eafc070479
Remove ReplacementRange
...
R=danrubel@google.com , maxkim@google.com
Review-Url: https://codereview.chromium.org/2946573003 .
2017-06-19 10:15:36 -07:00
382ddb21c3
Refactor: Removed ReplacementRange from test and ReplacementRange from src/. Copied contents of test into lib/utilities and modified test path.
...
This is needed to expose ReplacementRange outside of test folder for external plugin users to utilize. Reason discussed further in ticket: https://codereview.chromium.org/2934133002/
BUG=
R=brianwilkerson@google.com , danrubel@google.com
Review-Url: https://codereview.chromium.org/2937093002 .
2017-06-16 11:19:27 -07:00
e57d9b608f
Change to accommade Angular plugin and finalize removal of dependency to analysis_server
...
BUG=
R=brianwilkerson@google.com , mfairhurst@google.com
Review-Url: https://codereview.chromium.org/2934133002 .
2017-06-13 16:31:39 -07:00
1e9ae646ff
Clean up some hints
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2939723002 .
2017-06-13 09:24:50 -07:00
d824acbf71
Update AssistProcessor to use ChangeBuilder
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2928313002 .
2017-06-12 07:28:02 -07:00
b502bb6956
Prioritize required name param completions (flutter-intellij#1049).
...
R=danrubel@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/1049
Review-Url: https://codereview.chromium.org/2927343002 .
2017-06-09 10:20:16 -07:00
Brian Wilkerson