Commit Graph

2415 Commits

Author SHA1 Message Date
kustermann@google.com 3f148045fb Removed status file entries refering to non-existent multitests
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//22909033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26525 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 14:29:36 +00:00
sgjesse@google.com bab2500197 Update test for assignment to final variables
The latest spec (0.51) says:

Attempting to assign to a final variable anywhere except in its
declaration or in a constructor header will cause a runtime error to
be thrown as discussed below. The assignment will also give rise to a
static warning.

R=ahe@google.com
BUG=7062, 11591

Review URL: https://codereview.chromium.org//22914028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26519 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 13:15:19 +00:00
sgjesse@google.com d72b992eaf Update the language.status
Mainly adding issue numbers.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//22861024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26516 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 12:02:59 +00:00
jwren@google.com a716d8aea0 Fix for 12494
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//23382007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26478 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 21:56:28 +00:00
regis@google.com eca9ec7417 Mark new test as failing when run minified under dart2js.
Review URL: https://codereview.chromium.org//23361012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26454 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 18:32:28 +00:00
rmacnak@google.com ef72ff32fb Test that importing dart:core with a prefix does not hide dynamic.
BUG=http://dartbug.com/12478
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//22825009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26450 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 17:55:27 +00:00
regis@google.com 0ab840ae98 Fix bound checking in self referencing type (issue 12553).
Added test.

R=hausner@google.com

Review URL: https://codereview.chromium.org//23295020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26444 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 17:22:18 +00:00
kustermann@google.com bc051d0a91 Remove entries in status refering to non-existent files
R=ricow@google.com

Review URL: https://codereview.chromium.org//23245015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26438 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 16:40:40 +00:00
whesse@google.com 654c9c9ff3 Remove fixed test from language_analyzer and language_analyzer2 status files.
BUG=dartbug.com/11582
R=floitsch@google.com

Review URL: https://codereview.chromium.org//23201017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26436 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 15:58:31 +00:00
sgjesse@google.com c7bef43f06 Update language status files
Update bug number and move a line to the correct file

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//23079010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26435 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 15:49:50 +00:00
sgjesse@google.com d642996240 Update language.status
Remove some references to closed bugs. Add new bugs number and remove reference to non-existing test.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//23183009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26431 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 14:45:08 +00:00
lrn@google.com 34ca90cc41 Fix test that contains compile-time error.
This doesn't affect dart2js, which fails to detect the compile-time error.
Filing separate bug for that.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//23314005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26430 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 14:28:47 +00:00
sgjesse@google.com 9ff0a2a071 Update language status file
Updated one bug whic was closed (created new)

Removed test for source as a reserved word, as it is not anymore.

Removed reference to a multitest id which was not in the file

R=kustermann@google.com, ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//23313005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26427 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 12:37:25 +00:00
ngeoffray@google.com 4e107aa0c0 Fix receiver refining optimization in the presence of null: any Object method can be called on the null object.
R=karlklose@google.com

Review URL: https://codereview.chromium.org//23353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26418 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 07:30:19 +00:00
brianwilkerson@google.com 5e90751367 Rename Identifier.getElement. Prior to this change the method getElement() was semantically equivalent to getBestElement(), but that was rarely the correct method to be using. I have divided it into getBestElement() and getPropagatedElement(), but in most cases replaced its use with getStaticElement().
Please check this carefully. Although all of the tests pass, there's still a possibility that I translated something wrong at some point (especially in code outside engine) and I'd like to catch any mistakes as early as possible.

R=jwren@google.com, messick@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//22854024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26380 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 18:50:28 +00:00
sgjesse@google.com e95bb89f6d Remove some bogus rules from the staus files
R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//22854029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26357 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 14:19:51 +00:00
ngeoffray@google.com 67258b97fe Refine the type of a local after it has been used as the receiver of a call.
R=karlklose@google.com

Review URL: https://codereview.chromium.org//22947008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26342 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 09:36:32 +00:00
sgjesse@google.com 6b514b1a0c Remove all remaining references to dartc
R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//23301004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26338 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 06:17:03 +00:00
scheglov@google.com d554cd90c4 Rules for finals were loosened, contradiction in spec was fixed.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//23216006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26320 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-19 17:58:09 +00:00
regis@google.com f9df206e2e Report compile-time errors for conflicting overrides as specified by latest
language spec (fix issue 12342).
Add override conflict tests.
Update status files.
Add support for 'ok' status in multi-tests.

R=hausner@google.com

Review URL: https://codereview.chromium.org//22999022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26302 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 23:39:41 +00:00
lrn@google.com fd5a11d514 Analyzer: Don't allow extending or implementing Null.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//22872008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26258 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 07:52:33 +00:00
ngeoffray@google.com 83679fb8a2 Add missing tests from last CL.
R=ahe@google.com

Review URL: https://codereview.chromium.org//22996007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26255 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 07:07:33 +00:00
rmacnak@google.com 8bdc9b5696 Cleanup making Null a public class of dart:core in the VM. Remove special cases for Null in lookup and compile-time type tests.
BUG=http://dartbug.com/12364
R=asiva@google.com, regis@google.com

Review URL: https://codereview.chromium.org//22819005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26205 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 18:34:23 +00:00
ngeoffray@google.com cbf92d012d Address long-standing review comments.
Comments were from:
https://codereview.chromium.org/12299008/
https://codereview.chromium.org/11273121/

R=ahe@google.com

Review URL: https://codereview.chromium.org//22871009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26196 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 16:07:07 +00:00
lrn@google.com 6ecdf2db1d Fix static type warnings in language/null_test.
Update status file to mark analyzer as failing. It does not detect
extending or implementing Null.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//22978011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26188 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 11:39:00 +00:00
lrn@google.com 14a75969c3 Add Null class to dart:core.
Make dart2js accept this class as the type of `null`.

Dart2js still fails on tests on the form: x is Null
VM does not recognize Null as the type of `null`.

BUG= http://dartbug.com/12382
R=fschneider@google.com, karlklose@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//23012003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26175 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 09:12:19 +00:00
karlklose@google.com fc60b612d3 Add missing registration of throwRuntimeError.
BUG=
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//23194002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26173 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 08:38:03 +00:00
jwren@google.com 7a9a98445a Turn strict mode off in the dartanalyzer
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//22997004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26139 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 19:32:54 +00:00
zra@google.com a810497666 Fixes scanning of Utf16 surrogate pairs in string literals.
R=iposva@google.com

Review URL: https://codereview.chromium.org//23000008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26130 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 17:34:31 +00:00
ngeoffray@google.com 1d86c3771d Fix issue 12023 by avoiding a critical edge in the SSA graph with a switch statement.
R=karlklose@google.com

Review URL: https://codereview.chromium.org//23063003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26123 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 15:13:31 +00:00
ngeoffray@google.com b50b1f1e8b Make analyzer happy and use annotations the right way.
R=ahe@google.com

Review URL: https://codereview.chromium.org//22999005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26120 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 13:29:53 +00:00
ngeoffray@google.com e39bfbbd10 Fix test for checked mode.
Review URL: https://codereview.chromium.org//22862008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26118 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 13:24:30 +00:00
ngeoffray@google.com 886fd8e842 Fix resolved visitor to dispatch a constructor redirection to a static send instead of a closure send.
R=ahe@google.com

Review URL: https://codereview.chromium.org//23171004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26117 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 13:05:05 +00:00
fschneider@google.com 447ddebd68 Fix equality of implicit closures in the Dart VM.
This CL also lifts the restriction that classes could not
extends or implement 'Function'.

BUG=https://code.google.com/p/dart/issues/detail?id=10849
BUG=https://code.google.com/p/dart/issues/detail?id=12411

TEST=tests/language/bound_closure_equality_test.dart,
tests/language/black_listed_test.dart

R=iposva@google.com

Review URL: https://codereview.chromium.org//22425006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26114 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 11:43:50 +00:00
hausner@google.com aa27308cab Fix top-level map literals
This is the remaining part that needed to be done to implement
map literals with arbitrary keys.

Fixes issue 10472

R=srdjan@google.com

Review URL: https://codereview.chromium.org//22835005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26095 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 23:45:20 +00:00
scheglov@google.com 2a93d0d0fd Issue 12404. Treat 'dynamic' identifier as a Type object.
https://code.google.com/p/dart/issues/detail?id=12404

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//23056003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26070 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 18:20:50 +00:00
scheglov@google.com 48c56552eb Report StaticWarningCode.UNDEFINED_IDENTIFIER when name is hidden, but not defined yet in block.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//22846005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26060 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 16:24:50 +00:00
scheglov@google.com e9529b3dab Report CTEC.CONST_CONSTRUCTOR_WITH_NON_CONST_SUPER
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//22935003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26058 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 16:16:48 +00:00
ngeoffray@google.com b4cc8efec4 Fix issue 12288: a getter also returns something.
R=ahe@google.com, kustermann@google.com

Review URL: https://codereview.chromium.org//23000003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26053 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 14:32:33 +00:00
rmacnak@google.com f58a00b4b7 Mark dynamic_test as failing on the analyzer.
TBR=

Review URL: https://codereview.chromium.org//22923004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26045 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 00:34:44 +00:00
rmacnak@google.com 1edde1e0bf Ensure the classes void and dynamic have empty arrays for fields, functions, etc. Move their Types to the VM isolate, and as a side-effect they are now canonicalized.
BUG=http://dartbug.com/12071
BUG=http://dartbug.com/12246
R=asiva@google.com, iposva@google.com, regis@google.com

Review URL: https://codereview.chromium.org//22902002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26043 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 00:11:42 +00:00
zra@google.com 8ffef7528d Bug fix and status file updates for MIPS HW.
R=regis@google.com

Review URL: https://codereview.chromium.org//22828004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26037 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 21:45:41 +00:00
scheglov@google.com ebbb8daf29 Fix for function type assignable check.
It is not the same as for interface types.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//22846003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26032 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 21:03:27 +00:00
regis@google.com 9eb12ad303 Implement updated method overriding rules in the vm (issue 11495).
Introduce --error-on-bad-override flag and use it when generating snapshots.
Fix signature checking when patching methods.
Fix errors in patch files.
Fix receiver type of constructors.
Fix finalization of mixin application typedefs.
Update tests and status files.

R=asiva@google.com

Review URL: https://codereview.chromium.org//22685007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26027 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 20:28:52 +00:00
scheglov@google.com c691cb8bcb Report DEFAULT_VALUE_IN_FUNCTION_TYPE_PARAMETER.
Also triage the test that was initially marked with this issue, but now is not.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//22926002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26025 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 19:56:08 +00:00
jwren@google.com 420fab6771 Fix for issue 11497- liberalize warnings about bad overrides
TODO- This is all of the changes in the analyzer, before this lands however the status files will need to be updated with now 30 failing language/co19 tests.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//22339023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26018 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 18:34:55 +00:00
scheglov@google.com 0535260c7a Issue 11892. It is compile-time error when unqualified invocation with unresolved identifier.
https://code.google.com/p/dart/issues/detail?id=11892

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//22871003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26016 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 18:06:32 +00:00
srdjan@google.com 72ba657d4f Fix issue 12369: compare kind of unary math instruction and not only the inputs to determine if attributes are equal.
R=regis@google.com

Review URL: https://codereview.chromium.org//22892002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26014 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 17:54:36 +00:00
scheglov@google.com ab9b9f9a97 Report INVALID_ASSIGNMENT if default value type cannot be assigned to the parameter type.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//22759003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26010 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 16:10:24 +00:00
ahe@google.com 4d4fa32377 Implement Error.stackTrace.
BUG=http://dartbug.com/11681
R=bak@google.com

Review URL: https://codereview.chromium.org//22798006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26004 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 14:42:02 +00:00