05f9ed2189
Re-enable NodeIterator
...
A matching Dartium CL does the heavy lifting.
BUG=
Review URL: https://codereview.chromium.org//22859044
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26502 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 01:41:06 +00:00
97075e2d22
WebSocket security checks changed a bit with the latest Dartium roll so the test failed with the following error when protocol 'chat' was used. failed: Error during WebSocket handshake: Sec-WebSocket-Protocol mismatch"
...
I've switched the WebSocket constructor test to pass in the protocol 'chat' so that coverage for passing in a protocol is not impacted.
Note that chrome dev channel reports the same error when a JS WebSocket is created with protocol 'chat' given the same scenario.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23061008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26496 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 00:33:54 +00:00
59720b88f5
Mark some custom element tests as fail for dart2js/checked mode
...
TBR=sra@google.com ,blois@google.com
Review URL: https://codereview.chromium.org//22834004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26488 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 23:45:16 +00:00
0d492092ea
Reenble custom element tests
...
These seem to all pass for me now.
Review URL: https://codereview.chromium.org//23068022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26479 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 21:57:28 +00:00
c34afe0a63
Update status for passing test
...
Looks like this started passing with your recent cl.
TBR=jacobr@google.com
Review URL: https://codereview.chromium.org//22903019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26460 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 19:32:55 +00:00
89b8d13fb6
Support for type extensions in Dartium (part 1)
...
R=blois@google.com
Review URL: https://codereview.chromium.org//22859033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26458 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 19:30:28 +00:00
01e3c94a34
Fix status
...
The outerHtml fix has this test running on drt. I believe it's
skipped everywhere else for now.
TBR=blois@google.com
Review URL: https://codereview.chromium.org//22986020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26456 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 19:02:34 +00:00
8b84d8ee76
Changes required for Dartium roll
...
Merge checkpoint. Everything compiles.
BUG=
Committed: https://code.google.com/p/dart/source/detail?r=26335
Review URL: https://codereview.chromium.org//22886009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26455 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 18:41:58 +00:00
688ad2c706
De-flaking custom element test.
...
This appears to be the Chrome flakiness around making XHRs.
BUG=12592
R=efortuna@google.com
Review URL: https://codereview.chromium.org//23361011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26447 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 17:43:34 +00:00
6d2f9a24fc
Rewrite async test to make it non-flaky.
...
R=blois@google.com
Review URL: https://codereview.chromium.org//22976006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26441 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 16:54:12 +00:00
bc051d0a91
Remove entries in status refering to non-existent files
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23245015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26438 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 16:40:40 +00:00
db5da2949f
Fix outerHtml comparisons in document_register_type_extension_test.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23171017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26437 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 16:18:22 +00:00
79ccbfb6e1
Mark innerHtml test as flaky.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23361006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26425 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 11:54:18 +00:00
ec11e52f62
Revert "Revert "Adding polyfill support for custom elements.""
...
This fixes the issues in the custom elements polyfills.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23301012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26412 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 00:08:46 +00:00
508affefed
Revert "Adding polyfill support for custom elements."
...
Caused issues with DocumentFragment and some lingering changes from the blink roll.
BUG=
Review URL: https://codereview.chromium.org//22957010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26410 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 23:28:22 +00:00
72651260aa
Adding polyfill support for custom elements.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//22967006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26405 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 22:56:08 +00:00
fb5c0e6c95
Enable these checks in custom tests
...
R=blois@google.com
Review URL: https://codereview.chromium.org//23033011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26392 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 21:27:55 +00:00
df8513a7d3
Fix chrome status
...
TBR=blois@google.com
BUG=12573
Review URL: https://codereview.chromium.org//22903013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26383 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 19:25:58 +00:00
0bdcdc0497
Fixing input_element/range test.
...
Some bots are on FF 22, some are on 23.
BUG=
Review URL: https://codereview.chromium.org//22816015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26376 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 18:06:45 +00:00
15ff98350e
Fix status on input_element_test/supported_range
...
I see Rico marked this pass a few hours ago, but it's failing right
now. TBR to get the ff bot green.
TBR=blois@google.com ,ricow@google.com
Review URL: https://codereview.chromium.org//22885012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26375 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 17:46:53 +00:00
339b0bdd70
Attempt to land Dartium roll a second time.
...
BUG=
Review URL: https://codereview.chromium.org//23064024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26363 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 15:54:49 +00:00
e95bb89f6d
Remove some bogus rules from the staus files
...
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//22854029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26357 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 14:19:51 +00:00
bb506fb254
Update ff status for html/input_element_test/supported_range
...
Pete: Could you update your annotations?
Review URL: https://codereview.chromium.org//23225005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26356 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 14:12:04 +00:00
c6ebe4e4e0
rollback problem blink merge cl
...
Review URL: https://codereview.chromium.org//23163010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26339 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 06:22:24 +00:00
785c8416bc
Changes required for Dartium roll
...
Merge checkpoint. Everything compiles.
BUG=
Review URL: https://codereview.chromium.org//22886009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26335 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 01:50:17 +00:00
24c3ca0b47
Fix for issue 12489.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//23295016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26327 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-19 20:44:33 +00:00
abec8ce0ae
Fix caught by analyzer
...
TBR=blois@google.com
Review URL: https://codereview.chromium.org//23242007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26321 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-19 18:01:29 +00:00
dcce9cd117
Port custom element layout tests to Dart
...
These are adapted from Dominic's tests here:
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/custom/
R=blois@google.com
Review URL: https://codereview.chromium.org//23232005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26319 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-19 17:50:42 +00:00
3aabf41ea6
Removing custom element preload test.
...
Can we not skip subtests??
BUG=
Review URL: https://codereview.chromium.org//22918010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26304 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-17 01:12:01 +00:00
8976fce413
Fix typo in Dartium html.status file.
...
TBR
BUG=
Review URL: https://codereview.chromium.org//23264006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26303 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-17 00:43:33 +00:00
5214fb1d36
Skipping custom element's pre-register test on Dartium.
...
BUG=
Review URL: https://codereview.chromium.org//22893031
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26298 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 22:16:54 +00:00
e506058b83
Updating custom element's preregister test to follow new contracts.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//23276003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26290 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 19:46:10 +00:00
1006d023b8
Currently the mixins case is failing on the dart2js version.
...
The auto-tag generation makes it easier to add new tests without re-indexing or worrying about overlapping tags.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//22960005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26285 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 17:38:46 +00:00
3a17d47e58
Modify custom elements to inherit from HtmlElement
...
R=blois@google.com
Review URL: https://codereview.chromium.org//23189009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26275 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 15:24:32 +00:00
7c85f03cc9
Move _HTMLElement to HtmlElement
...
The old HtmlElement is now HtmlHtmlElement. The custom tests don't break for now. I'll modify them in a separate CL to inherit from HtmlElement instead.
R=blois@google.com
Review URL: https://codereview.chromium.org//23151005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26248 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 00:46:10 +00:00
1ffafc705d
Additional code to https://codereview.chromium.org/15026006
...
to enable user classes extending DOM classes to be registered.
Review URL: https://codereview.chromium.org//22642002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26221 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 21:18:07 +00:00
28dd6944b7
First cut at extending native classes.
...
Subclasses of native classes have to be treated largely like native classes since they require interceptors.
The ugly part is collecting the set of subclasses of native classes without resolving all classes. Only plausible classes are resolved. Plausible classes have a superclass name that is native class (or subclass of native class). The name-keyed graph is collected and inverted to identify the true subclasses of native classes.
Things that are missing from this CL:
1. I discussed with Peter a better way of finding which classes are subclasses of native classes by resolving the superclass. Peter's proposal will still require the graph inversion step but should be more precise.
2. It would be a good idea to replace the 'defineNativeSubclass' calls with more declarative static data on the class and post-process the classes.
3. We need to make sure that fields of subclasses of native classes do not conflict with any (potentially undeclared) properties of the base native class.
4. The compiler should do additional checking
- The constructor must be a factory constructor.
- No fields can have initializers.
R=ahe@google.com
Review URL: https://codereview.chromium.org//15026006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26208 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 19:09:12 +00:00
7f7778fb97
Mark flaky test pass/fail
...
TBR=jacobr@google.com
BUG=12489
Review URL: https://codereview.chromium.org//23095008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26198 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 16:41:03 +00:00
5893fa7634
Remove test for native resolver
...
This check asserts that a type with a native field must be in a
library with a native resolver. It won't be true with custom elements
- which inherit from dart:html and inherit a native field - but are
otherwise in user libraries.
I'm just removing the check altogether here.
R=asiva@google.com
Review URL: https://codereview.chromium.org//22950003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26144 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 20:18:16 +00:00
4d51b41ff8
Initial Dartium custom element support
...
This will need to be rebased with Stephen's CL or vice versa. The test mod is taken from his CL.
R=blois@google.com
Review URL: https://codereview.chromium.org//22912004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26141 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 19:47:07 +00:00
03e749caba
Fix Event delegation on IE.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23141002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26092 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 23:10:09 +00:00
d50c5b6b8c
Adjust IE test status.
...
BUG=
R=dgrove@google.com
Review URL: https://codereview.chromium.org//22662008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25988 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 22:55:54 +00:00
9fdbcf176c
Add includeAncestors to dartium matches call.
...
BUG=
Review URL: https://codereview.chromium.org//22529004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25975 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 20:21:50 +00:00
e8c1c1722f
Adjust test status for debugging in Dartium.
...
"Reverting 25970"
BUG=
Review URL: https://codereview.chromium.org//22721003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25972 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 18:48:44 +00:00
8963a49505
Event delegation
...
Fix for https://code.google.com/p/dart/issues/detail?id=6270
BUG=
R=blois@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//21607003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25969 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 17:37:32 +00:00
48bb34e7c2
Reenable notification_test
...
This one is now passing for me as well. Looks like the ExceptionState fix cleared this one up.
R=blois@google.com
Review URL: https://codereview.chromium.org//22411007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25955 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 23:13:07 +00:00
cd7a678e83
Use DartExceptionState
...
R=blois@google.com
Review URL: https://codereview.chromium.org//22605010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25953 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 22:56:57 +00:00
f58ea07d46
EventTargets should be EventTargets
...
systemnative.py keys off the ext_attr. Recent IDL changes removed the EventTarget attribute however.
Types marked with isEventTarget are handled specially during GC.
R=jacobr@google.com
Review URL: https://codereview.chromium.org//22507005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25947 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 21:18:13 +00:00
c42576069f
Update status file
...
I cannot recreate locally, but these are flaky on the bot.
TBR=jacobr@google.com ,blois@google.com
Review URL: https://codereview.chromium.org//22460010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25910 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 02:47:06 +00:00
68b7394e53
Treat EventTarget as a secondary superclass
...
This matches the C++. It's brittle, but it's not clear how to get
this out of idl right now.
R=blois@google.com
Review URL: https://codereview.chromium.org//22594012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25906 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 22:15:10 +00:00
jacobr@google.com