d632beeaa4
Add a null check to avoid trying to load libraries that don't exist.
...
R=efortuna@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//22986014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26377 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 18:22:42 +00:00
3d80dba138
If you have something that recursively looks for messages in dependencies, it can end up parsing intl.dart and giving warnings that there are invalid messages in its internals. Change the calls to invoke the static messages without a prefix so that this won't complain.
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//23241004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26233 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 22:27:48 +00:00
b136efff1c
Use deferred loading for message libraries.
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//22828006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26199 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 16:50:41 +00:00
e8dd115eb6
Relax verification checks. The locale doesn't have to be constant, print
...
the node in the error message without making assumptions about its
type, and do not require the name parameter to match the function name.
R=efortuna@google.com
Review URL: https://codereview.chromium.org//23212003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26154 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 21:06:54 +00:00
5504f5a970
Fix message_extraction test.
...
BUG=
Review URL: https://codereview.chromium.org//22928010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26103 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 00:45:48 +00:00
6970ef4c98
Rename CompositeMessage's named parent constructor.
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org//23140003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26101 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 00:33:14 +00:00
9f565af534
Workaround for bug 11834 with Chrome XHR
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//22877005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26028 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 20:33:04 +00:00
31ab754cbf
Add support for Intl.select
...
Moves some of the validation logic into the appropriate objects, so we can more easily deal with Select, which takes its arguments in a Map, versus Plural/Gender which expect named arguments.
R=efortuna@google.com
Review URL: https://codereview.chromium.org//22286013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25965 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 17:08:03 +00:00
18d38085ab
pkg: analysis aided cleanup
...
Removed a lot of warnings and hints when opening many pkg projects in the editor
R=gram@google.com
Review URL: https://codereview.chromium.org//22284003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25831 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 20:42:04 +00:00
12ee5f7c61
Improvements to warnings on message extraction.
...
Add warning for message names that don't match the function name, and
a warnings-are-errors command-line option.
R=efortuna@google.com
Review URL: https://codereview.chromium.org//22392004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25829 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 20:01:13 +00:00
899a8d27a0
Allow Intl.plural/gender as the top-level, omitting the Intl.message wrapper and the first layer of interpolation.
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//20072002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25435 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 20:01:59 +00:00
816b24e8ff
Make _shortLocale public
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//20071003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25423 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 17:12:54 +00:00
a9d24edd0f
Rename "pathos" package to "path".
...
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//18356011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24964 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-12 17:54:48 +00:00
bea11dee93
Plurals and Genders
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//18543009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24746 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 20:23:27 +00:00
887c8e7596
Move getters from Options to Platform
...
The getters for executable, script and version are now statics on
Platform. I kept them on Options for now, but updated most tests to
use Platform.
R=ajohnsen@google.com , floitsch@google.com , iposva@google.com
BUG=
Review URL: https://codereview.chromium.org//17406010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24401 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 12:56:23 +00:00
8356c667db
Added async_helper and fixed broken asynchronous test.
...
R=ahe@google.com , efortuna@google.com , floitsch@google.com
Review URL: https://codereview.chromium.org//16958006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24339 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 15:47:00 +00:00
0ec6fe103b
Allow translated messages that have no matching original message. Also clean up help text and get rid of type error for types whose name is no longer easily visible from analyzer.
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//17113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24240 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:01:13 +00:00
9d6a64e81b
Merge the dart:uri library into dart:core and update the Uri class
...
This merges the dart:uri library into dart:core removing the dart:uri library. Besides moving the library the Url class has been changed.
* Removed existing Uri constructor as it was equivalent with Uri.parse
* Remamed constructor Uri.fromComponents to Uri
* Moved toplevel function encodeUriComponent to static method Uri.encodeComponent
* Moved toplevel function decodeUriComponent to static method Uri.decodeComponent
* Moved toplevel function encodeUri to static method Uri.encodeFull
* Moved toplevel function decodeUri to static method Uri.decodeFull
* Rename domain to host
* Added static methods Uri.encodeQueryComponent and Uri.decodeQueryComponent
* Added support for path generation and splitting
* Added support for query generation and splitting
* Added some level of normalization
R=floitsch@google.com , lrn@google.com , nweiz@google.com , scheglov@google.com
BUG=
Review URL: https://codereview.chromium.org//16019002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23266 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:35:01 +00:00
06091dd24c
Remove (unused) ProcessOptions in test.
...
BUG=
Review URL: https://codereview.chromium.org//15670004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23132 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 11:16:00 +00:00
f61dd39e24
Add a dateSymbols getter to DateFormat, useful to get e.g. the list of weekday names
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//14604009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22749 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-15 17:54:43 +00:00
805def3f49
Change DateFormat doc examples to not show padding of months/days in the default locale
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//14835008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22688 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-14 16:36:04 +00:00
5f3be4f352
Add some user-friendly utility functions to pkg/analyzer_experimental.
...
R=alanknight@google.com , amouravski@google.com , brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//14998006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22567 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-09 21:05:44 +00:00
a6b47e0fad
Fix some doc formatting problems, stop using "set" methods for NumberFormat
...
R=amouravski@google.com , sethladd@google.com
Review URL: https://codereview.chromium.org//14544009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22148 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-29 20:32:04 +00:00
c9f0368d7d
Allow suppressing message extraction warnings, providing a prefix for generated files, and format warnings better.
...
Review URL: https://codereview.chromium.org//13898014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21959 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 17:03:36 +00:00
0c2102f7e8
Explain better than the en_US locale is always available, fix other doc glitches.
...
Review URL: https://codereview.chromium.org//14270009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21910 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 22:32:00 +00:00
8fd2c2e5ea
add installation instructions to pkg packages
...
BUG=
Review URL: https://codereview.chromium.org//14188048
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21770 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-19 20:51:10 +00:00
89cb31e4c4
Fix some warnings in pub and pkg packages.
...
Review URL: https://codereview.chromium.org//13817008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21701 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-18 20:24:47 +00:00
466d6670c1
Refactor Future constructors.
...
BUG=
Review URL: https://codereview.chromium.org//14070010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21517 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 21:24:27 +00:00
664fe171c6
Make use of the patterns in Intl number formatting
...
This adds code to parse and use the information from the pattern
string used to create a NumberFormat. It adds tests taken
from the Closure tests and also tests comparing a simple
format to the ICU output for a large set of locales.
In addition it has changes to
- part number_format.dart in intl.dart rather than having it as a
separate library
- Update the algorithm to incorporate some additions in Closure
- Allow setting a few of the internal parameters, which the
Closure tests wanted to use
- Add named constructors for the standard formats, e.g. DECIMAL_FORMAT
- Access _defaultLocale consistently via the getCurrentLocale() method
rather than directly, so it can never be uninitialized.
- Regenerated the locale data
Review URL: https://codereview.chromium.org//13814018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21166 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-09 19:58:42 +00:00
755c71f1fc
pkg/intl test cleanup
...
pkg/unittest has evolved a lot. Helping intl use some of the new features and
avoid some problems. I think I fixed some issues in the process
BUG=https://code.google.com/p/dart/issues/detail?id=9342
Review URL: https://codereview.chromium.org//13684003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20993 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 18:24:14 +00:00
1a6983771c
pkg/intl: cleanup after message extraction test
...
call deleteGeneratedFiles after test
update deleteGeneratedFiles to cover all generated files
Review URL: https://codereview.chromium.org//12827019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20391 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-22 17:13:05 +00:00
1d9013517e
Moved pkg pubspecs to use dev_dependencies where appropriate
...
BUG=https://code.google.com/p/dart/issues/detail?id=9309
Review URL: https://codereview.chromium.org//12962003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20285 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 19:41:10 +00:00
d98dc62e7d
Parameterize the import directories, fix test to behave correctly on an error
...
Review URL: https://codereview.chromium.org//12478010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20241 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 20:53:26 +00:00
6bda92055d
Update Intl's json data file generation to current APIs
...
Review URL: https://codereview.chromium.org//12918018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20182 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-18 22:47:42 +00:00
cdcb3e5b09
- Make test code fail when run from unexpected location.
...
Review URL: https://codereview.chromium.org//12787011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20122 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:14:07 +00:00
844cd39fad
Change getRange to sublist. Make getRange deprecated.
...
This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.
Review URL: https://codereview.chromium.org//12817003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 09:15:39 +00:00
ab0ead6b50
Intl test spawning processes must specify the encoding for stdout
...
Review URL: https://codereview.chromium.org//12645010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20055 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 22:17:24 +00:00
afc98385b5
Fix windows and pub failures in intl tests
...
Review URL: https://codereview.chromium.org//12448008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20049 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 21:36:18 +00:00
0446767578
Adds facilities for extracting Intl.message calls and generating code from translations
...
This adds both general libraries for extracting messages and generating translations and scripts for using them with a trivial translation format. It removes the previous mechanism in message_lookup_local that relied on mirrors and traversing libraries in favor of one with a more explicit lookup by library that's consistent with the generated code. It also changes the code in basic_example to use that.
It also includes a couple of other changes. It now uses pathos for path manipulation, and the data_directory.dart hack for running tests from multiple different places was cleaned up and made more general. In addition, Intl.message now returns a string rather than a Future, which was changed as part of the libv2 integration.
This version does not yet support the plural syntax, as it disallows any interpolations that aren't just replacing a variable name. It also doesn't support named arguments to functions containing Intl.message, and it doesn't yet have a mechanism for designating sections of a text as not being subject to translation.
Finally, it relies on analyzer-experimental, which has a different name in the repository and in pub. So this version will run in the repository but will not run if used from pub. Bug 9071 asks for the names to be made consistent.
Review URL: https://codereview.chromium.org//12733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20047 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 20:49:26 +00:00
cead1d41f1
ceil/floor/truncate/round return integers.
...
This CL supercedes https://codereview.chromium.org/11748016/
Review URL: https://codereview.chromium.org//12317107
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19810 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 18:54:37 +00:00
53f877edb7
Rename String.concat to operator+.
...
Review URL: https://codereview.chromium.org//12441003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19788 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 12:59:17 +00:00
25619b3922
Fix deprecated StringBuffer usages in Intl
...
BUG=
Review URL: https://codereview.chromium.org//12382036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19412 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 18:41:28 +00:00
3c0ac360e7
Remove deprecated string features.
...
Make String.codeUnits return a List.
Review URL: https://codereview.chromium.org//12282038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 10:48:09 +00:00
488b016a2f
Merge IO v2 branch to bleeding edge
...
R=ager@google.com , ajohnsen@google.com , whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//12316036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18820 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 11:58:11 +00:00
d2c575c0b0
Create generated tests inside the build directory
...
Patch Set 1 is a revert of r18295.
Review URL: https://codereview.chromium.org//12223074
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18802 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 08:10:37 +00:00
278d7b0c74
Update documentation links to point to the correct URLs.
...
Review URL: https://codereview.chromium.org//12252055
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18552 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 01:27:10 +00:00
a3061ab600
Stop using deprecated charCodeAt in Intl
...
Review URL: https://codereview.chromium.org//12262030
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18526 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 18:23:43 +00:00
9cbede1d32
Added documentation links to all of the pkg packages hosted on api.dartlang.org.
...
Review URL: https://codereview.chromium.org//12218119
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18414 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 23:38:30 +00:00
1fb79cdb28
Resubmit "Adding ease-of-use methods to HttpRequest."
...
Fixing the dependent pkg/intl code.
This is the same as my previous CL, but with the modification to pkg/intl/lib/src/http_request_data_reader.dart
BUG=
Review URL: https://codereview.chromium.org//12148002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17949 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 22:40:04 +00:00
9b23dff467
Reapply "Rename mappedBy to map."
...
This reverts commit r17907.
TBR.
Review URL: https://codereview.chromium.org//12090093
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17918 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 15:12:56 +00:00
alanknight@google.com