dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
86,157 Commits 2 Branches 0 Tags
83f0bb25a4fdeaeca14859cd8a59220bc6b51244
Commit Graph

531 Commits

Author SHA1 Message Date
Ahmed Ashour 572f24882f [analyzer_plugin] consistent hashCode for SourceFileEdit 
Fixes #49371

Change-Id: I853323df821a9b6481f6fdd190ccecba2c01aa2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250380
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-06 16:03:20 +00:00
Konstantin Shcheglov a8541852d5 Extract NullableObjectExtension. 
Change-Id: I2fe2704d875082d20e1586f924aeebd6653703ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250262
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-06-30 14:25:26 +00:00
Devon Carew cb5b66f694 [analysis_server] minor cleanups to analysis server spec generation 
Change-Id: I9fd780fb627eaab24731d426e5a0f51b9608f189
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249734
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-27 17:21:02 +00:00
Konstantin Shcheglov 46b73c6785 Use AnalysisContextCollection for DartServerPlugin. 
Not for landing, has debug logging.

There is also an example (also not for landing) of a concrete plugin.

Change-Id: Id79336205b7b6d4cd462e7cfa0fdc7bea41c2987
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-06-21 18:48:44 +00:00
Danny Tuppeny a2f9ad4ba7 [analysis_server] Tweak navigation regions/targets for named constructors 
+ fix an issue with constructor declarations not returning any matches at all for LSP which provides an offset.

Fixes https://github.com/Dart-Code/Dart-Code/issues/4020.

Change-Id: Id59c83e32630c4ab947e3c3062b55989c78d1c61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248581
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-06-16 17:47:59 +00:00
Ahmed Ashour 85700570f6 Fix typos 
Fixes #49241

TEST=ci

Change-Id: I6117bf816fc8c4613cce66927f952fef75632725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248120
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-15 11:08:28 +00:00
Phil Quitslund 9a48d1b82f Reland "[data driven] support moving symbols across packages" 
This reverts commit f111a2df54.

Reason for revert: this change was mistakenly associated w/ a windows bot breakage (https://github.com/flutter/flutter/issues/105641)

Original change's description:
> Revert "[data driven] support moving symbols across packages"
>
> This reverts commit 3290d7a137.
>
> Reason for revert: flutter engine breakage (https://github.com/flutter/flutter/issues/105641)
>
> Original change's description:
> > [data driven] support moving symbols across packages
> >
> > See: https://github.com/dart-lang/sdk/issues/48997
> >
> > Change-Id: Iad16b9eae0523bc4bc14537af642b05efa75b6f7
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246663
> > Commit-Queue: Phil Quitslund <pquitslund@google.com>
> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: I4a83d50497d6208b7f518ca1b381ece3aab192ad
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247606
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Reviewed-by: Keerti Parthasarathy <keertip@google.com>
> Commit-Queue: Phil Quitslund <pquitslund@google.com>
> Reviewed-by: Phil Quitslund <pquitslund@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I769dec0d85fc0a41048b21deec0724d8509ef8e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-06-13 14:45:06 +00:00
Phil Quitslund f111a2df54 Revert "[data driven] support moving symbols across packages" 
This reverts commit 3290d7a137.

Reason for revert: flutter engine breakage (https://github.com/flutter/flutter/issues/105641)

Original change's description:
> [data driven] support moving symbols across packages
>
> See: https://github.com/dart-lang/sdk/issues/48997
>
> Change-Id: Iad16b9eae0523bc4bc14537af642b05efa75b6f7
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246663
> Commit-Queue: Phil Quitslund <pquitslund@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I4a83d50497d6208b7f518ca1b381ece3aab192ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247606
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-08 21:35:22 +00:00
pq 3290d7a137 [data driven] support moving symbols across packages 
See: https://github.com/dart-lang/sdk/issues/48997

Change-Id: Iad16b9eae0523bc4bc14537af642b05efa75b6f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246663
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-06 16:53:38 +00:00
Danny Tuppeny fa8a33f60e [analysis_server] Set Container() as final tabstop/selection in Flutter snippets 
Change-Id: I0f1fd31a051440ccc119188cccdb3168c9e58e20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245988
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-25 18:57:28 +00:00
Danny Tuppeny 2591ed885b [analysis_server] Handle navigation for "part of"s using URIs 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3970.

Change-Id: I972f8811f0819d3018f36cb36ed796b8dafc1b3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-24 16:23:47 +00:00
Ahmed Ashour 466202bb34 [analyzer] remove lints ignore in generated files 
Fixes #49039

Change-Id: I14e98fc5ab9c1f7b7e69f99dc1c97178b56c624d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245020
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-19 05:17:00 +00:00
Konstantin Shcheglov cbab0c5245 Issue 48281. Update navigation to field formal parameters. 
In constructor initializers the reference is to the parameter itself,
not the field.

Bug: https://github.com/dart-lang/sdk/issues/48281
Change-Id: Ic875e68d9b0d4ebdc08b3a8e71ecd8f0e52c3c26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-16 15:32:19 +00:00
Sam Rawlins 531e6e175f analyzer: Prefer string interpolations 
ignore prefer_interpolation_to_compose_strings and
constant_identifier_names in generated files.

Change-Id: I963504e298f8e439734522fed9ac09911750f419
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243646
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-05-04 20:45:25 +00:00
Konstantin Shcheglov 16fadd69a6 Switch to protocol version 1.33.0, enable new completion protocol. 
Change-Id: Ib7de4d616cba91bfe3b014199b6aacaa01c9c052
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239322
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-29 20:53:39 +00:00
Danny Tuppeny 7e46465786 [analyzer] Make ConstructorElement.nameLength consistent with offset/end 
Fixes https://github.com/dart-lang/sdk/issues/48677.

Change-Id: I4198a58e6cf3e61e4e1bdf6e4f3f766fcc8efdeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-28 20:08:50 +00:00
Samuel Rawlins 5050f31b29 Revert "analyzer: Mark implicit-casts and implicit-dynamic as deprecated" 
This reverts commit 6a54fdd46e.

Reason for revert: broke flutter-analyze

Original change's description:
> analyzer: Mark implicit-casts and implicit-dynamic as deprecated
>
> Also add a fix which replaces 'implicit-casts' with 'strict-casts' and
> a fix which replaces 'implicit-dynamic' with 'strict-raw-types'.
>
> Fixes https://github.com/dart-lang/sdk/issues/47902
>
> Change-Id: I293c3c1fd671ac85c12f9c050465b4d77632f241
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224800
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Samuel Rawlins <srawlins@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ib2e9492716d3ff6da4fa4e1c64fd658451b16d88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239008
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-27 16:56:01 +00:00
Sam Rawlins 6a54fdd46e analyzer: Mark implicit-casts and implicit-dynamic as deprecated 
Also add a fix which replaces 'implicit-casts' with 'strict-casts' and
a fix which replaces 'implicit-dynamic' with 'strict-raw-types'.

Fixes https://github.com/dart-lang/sdk/issues/47902

Change-Id: I293c3c1fd671ac85c12f9c050465b4d77632f241
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224800
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-25 14:58:50 +00:00
Danny Tuppeny 9a49921c6f [analyzer] Don't produce nested LinkedEditGroups 
Fixes https://github.com/dart-lang/sdk/issues/48612.

Change-Id: Ibe8e5036420e24a1dc5cc36f93e42eded607eaf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-18 16:08:40 +00:00
Danny Tuppeny 094c598703 [analysis_server] Change empty linked edit groups to have placeholder text 
Change-Id: Id687c4db11a1b43507f61e6d8ff5775ccccc819f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-15 20:03:33 +00:00
Danny Tuppeny 0de43ae5f7 [analysis_server] Make CompilationUnitElement.lineInfo non-nullable 
Change-Id: Ia42e2a2fd153b5af167588b9d4d473d1f998a67b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-10 00:19:15 +00:00
Danny Tuppeny da5670c677 [analysis_server] Fix end locations of navigation regions for code sample links 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3867.

Change-Id: Icdfc93c1b03fdd4c40e3ea4563045d993cb50c32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-09 16:40:25 +00:00
Danny Tuppeny 77c650433f [analysis_server] Add support for empty linked edits 
Change-Id: I8e3a57732ecb36712e754549333d551bb0a47e31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-09 16:38:25 +00:00
Konstantin Shcheglov d72934449f Deprecate 'Resource.parent2', use 'parent' instead. 
Change-Id: Icf3cefa8061543a3965e1eedab4b57bb6c67c920
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-07 22:11:23 +00:00
Konstantin Shcheglov 7b108fb226 Move code locations computing when supportsLocationLink into DefinitionHandler. 
The main reason to do this is that we add navigation regions while
visiting AST, so we will not able to call the async method to parse
a file.

An accidental improvement is also that we will not parse files
multiple times when the same element is referenced multiple times.
Although if different elements of the same file are referenced, we
don't have any improvement here.

Change-Id: Ic4d914e89515af31f2dc3c4f842f0313cc89fac8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-03 00:47:39 +00:00
Danny Tuppeny 0501b497bb [analysis_server] Ensure imports are not inserted after exports or between part directives 
Change-Id: Id5137f9a9a65cd66124d375ac4c43c6726714255
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-02 22:00:49 +00:00
Danny Tuppeny f5bd632abe [analysis_server] Ensure imports are always added before other code being inserted in DartFileEditBuilder 
Change-Id: I390f24ac10f7f061e79c9bfed616e9bcc908d240
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234604
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-02 16:37:26 +00:00
Konstantin Shcheglov 60b428e2b1 Deprecate superclass2, mixinTypes2, etc. 
Change-Id: Ieaaeab57930cb93f5b6b1323efe63c3395b79993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232742
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-17 02:20:42 +00:00
Danny Tuppeny 55fd24e6a6 [analysis_server] Refactor LSP snippet building in preparation for Snippet completions 
Change-Id: Ie39e2e803d17435b31246da07ed69eba7d7aba21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-16 20:01:00 +00:00
Danny Tuppeny 4f9a044418 [analyzer_plugin] Ensure FileEditBuilder updates linked positions correctly 
Without this change, any linked edit groups that fall between the offset and offset+length of the new edit are not updated, which means new edits can be inserted that overlap with the linked edit groups instead of pushing them along by the delta.

Change-Id: If3e60bfa1efa4736f91bb85eb29cd785e933e78c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232099
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-16 19:39:40 +00:00
Konstantin Shcheglov ea4f04f56d Support completion in enum constant argument list. 
Change-Id: Id483d6ea3715e567f1d2cc9a2051f615b750a8a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232684
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-11 23:07:25 +00:00
Konstantin Shcheglov 582bf2f230 Completion for constructors in enum constants. 
Change-Id: I3a68db8045d249f7459ec0dbf0fbd9c203fccade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232683
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-11 21:41:37 +00:00
Konstantin Shcheglov 8b67b90016 A few tests for completion in class body and similar. 
Change-Id: Id8749e4c45d26a5e56de31ce0d8b117db60150a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-11 18:04:57 +00:00
Konstantin Shcheglov 4a122c0b5a Add completion tests inside enum declaration. 
As we discussed some time ago, it is not clear to me where some
tests should go. Here, I put it into "location" tests, and checked
locations that seem strongly associated with the enum - its header,
its body; including the `WithClause` on the enum.

It is less clear where tests for completion inside the header or
the body of a method inside of an enum should go. I initially
planned to put them into `declaration/enum_test.dart`, but now
starting to doubt. The tests there are currently for using an
enum from outside.

Change-Id: Ife091f82bbb0ad1f26df984be42aa93a78595816
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-10 20:26:01 +00:00
Danny Tuppeny 70d25c7ce7 [analysis_server] Make docs more explicit about positions in LinkedEditGroups 
Change-Id: Ifcc8935ac7c72d42fcc0462fd2f6ad3eb8ecd3b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-10 19:51:13 +00:00
Konstantin Shcheglov f204bf5ead Navigation for enum constants. 
Change-Id: I47c420d29b857dc57d14854255c62e4db5458179
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232223
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 21:40:19 +00:00
Konstantin Shcheglov 52290eba28 Add CompletionSuggestion.libraryUri, keep isNotImported. 
Change-Id: I1bce246c2d8eaa968a47ae6ba82114592b991a47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-04 22:49:10 +00:00
Konstantin Shcheglov 6dd2790b57 Use cached enclosingClassElement for extension completion. 
This improves time to compute completion metrics from 61 to 48 seconds.

We used to spend 21% of all time in `[Stub] InstanceOf`.
Now 2%, unfortunately it does not show back pointers.

Change-Id: I3c6c62cabfa86bac138d95d4830b605693e086d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230580
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-27 23:34:42 +00:00
Konstantin Shcheglov 540c053ca8 Add HighlightRegionType.EXTENSION 
Change-Id: I375df19b8ee5f6570fcc7d440b9d71b148bcef73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-26 16:11:59 +00:00
Konstantin Shcheglov 47eff41cdb Issue 48184. Fix suggesting local function returning void in named argument. 
Bug: https://github.com/dart-lang/sdk/issues/48184
Change-Id: I5f6c8f2443782dec3c75c44cb7baeea8ed8b5e0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-20 23:45:57 +00:00
Danny Tuppeny 32b3e18e92 [analysis_server] Insert "required" keyword in created methods/added named parameters 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3770.

Change-Id: I954b9bbcac72ffc7a7b6e168214971bf1786872a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228564
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-20 17:00:37 +00:00
Danny Tuppeny 5455047ed0 [analysis_server] Suppress code completion in comments before dartdocs 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3783.

Change-Id: I8539d8b525534ad85b42618a6a3e9888fb43c851
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-01-19 17:25:36 +00:00
Konstantin Shcheglov 1b447a1335 Navigation support for super-formal parameters. 
Change-Id: I8070b303ea4d7bce45afe63668f9ec85686dd1b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-18 17:53:25 +00:00
Konstantin Shcheglov 2170c061b0 Add Element.libraryUri and CompletionSuggestion.isNotImported 
Remove libraryUrisToImport and libraryUriToImportIndex.

Change-Id: Iafe27d6fb0c5ce0c623567a0384a4579274b151f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227580
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-11 19:53:14 +00:00
Konstantin Shcheglov 794a42074d Code completion for super-formal parameters. 
Change-Id: I52b0786f7db8e8ec0181b5e4d7eb352b157856b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226606
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-06 19:46:15 +00:00
Brian Wilkerson eaef692c3f Add quick fixes for invalid return types for generator functions 
Change-Id: I23a3befd37946c02aadc8c0ebdf75e60cf6767c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225426
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-12-23 17:36:42 +00:00
Jaime Wren 38cbbaa63d Initial @tool annotation support in the Dart Analysis Server 
There is still required IntelliJ work to have this work end to end

Change-Id: I44cea5baee24e0b1c641d329b3d19eb7733f2003
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2021-12-20 20:24:43 +00:00
Konstantin Shcheglov 3c75efe2bf Stop using astFactory outside analyzer. 
Change-Id: I482e1448205f5e4c111857c4caea3c92762bf91d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224880
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-12-20 19:33:43 +00:00
Konstantin Shcheglov e78f715541 Extract ClosureContributor from ArgListContributor. 
Changes to ArgListContributorTest include adding one test and reordering.

Change-Id: I75eb1c6948044c9846b30f80874a4557d4d78925
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222600
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-12-10 07:00:39 +00:00
Konstantin Shcheglov 15c5e38337 Support RedirectingConstructorInvocation in ArgListContributor. 
Change-Id: I969c536b5a4089bfb13fdb5f6cd4dae2e486cc4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-12-10 01:53:52 +00:00