83f0bb25a4
[analysis_server] Allow multiple not-imported items in completion if name not already imported
...
Change-Id: Ie5bfa353d59546518180a08cd4720f793a01ba30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250660
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-07-06 17:19:40 +00:00
572f24882f
[analyzer_plugin] consistent hashCode for SourceFileEdit
...
Fixes #49371
Change-Id: I853323df821a9b6481f6fdd190ccecba2c01aa2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250380
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-07-06 16:03:20 +00:00
e5da1f97b9
Remove DocumentationCache, we cache documentation and more in _ElementCompletionData.
...
Change-Id: I36e0f9cfaf648349f789658bcf80a7aab294c7ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-06-30 14:52:06 +00:00
a8541852d5
Extract NullableObjectExtension.
...
Change-Id: I2fe2704d875082d20e1586f924aeebd6653703ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250262
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-06-30 14:25:26 +00:00
fc6a140020
Add an analytics page to the server diagnostic pages
...
This page is currently disabled, and will likely remain that way until
we allow analytics to be enabled.
Change-Id: I834d3b3eba4f8b690524d7f0955a2bc55418a327
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
2022-06-28 17:43:24 +00:00
2e27dd8d0f
[analysis_server] [lsp] Handle paths with trailing slashes in didChangeWorkspaceFolders
...
Fixes https://github.com/dart-lang/sdk/issues/49338 .
Change-Id: I054cb896575e0947b840cbb7745a8fdd2d2fb098
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250041
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-28 14:29:43 +00:00
25dcfca3c2
[parser][CFE][analyzer] Function is builtIn keyword
...
This CL makes `Function` a builtIn keyword instead of a `pseudo` keyword.
See also (and fixes):
https://github.com/dart-lang/sdk/issues/45703
https://github.com/dart-lang/sdk/issues/45704
https://github.com/dart-lang/sdk/issues/45705
https://github.com/dart-lang/sdk/issues/49197
This undoes https://dart-review.googlesource.com/c/sdk/+/195761
This is ~a merge of https://dart-review.googlesource.com/c/sdk/+/195906
and https://dart-review.googlesource.com/c/sdk/+/200080
Change-Id: I8bfee6976d43819fa355de99b3b2429eb67a7cdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249484
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-06-28 14:26:33 +00:00
9f97ab9602
Restructure analytics support
...
I wanted to be able to plug in different kinds of analytics reporters,
and that's still a goal, but with the desire to make it possible for
users to see what data we are collecting I needed to change the level
at which reporters are plugged in.
This CL doesn't change the behavior of the code, but it does split the
classes out into separate files and collapse the AnalyticsManager class
and its subclasses into a single class, requiring that different
reporters be implemented by implementing the Analytics class instead.
Change-Id: Ia98ff225f97ae747d89c61fe98f520ce0b5e9961
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249943
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-27 21:19:32 +00:00
e0820bb508
Enable the prefer_function_declarations_over_variables lint in the analysis server
...
Change-Id: I53a6cd3c5d3be1c66173f52a7f01d8df63fd9350
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249727
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2022-06-27 18:27:23 +00:00
9f5942df4c
[analysis_server] fix RemoveUnnecessaryParentheses with space
...
Fixes #49343
Change-Id: I7b55f45d624197f75110759f9b507bbe9157c40d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249861
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-27 18:24:22 +00:00
78bb59655a
Use getFileSync() in ExecutionMapUriHandler instead of FileSystemState.
...
We don't need to go so low.
Change-Id: Ifbb02e60038c545bc43ebb4f7a344f1fde014fc6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249941
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-06-27 17:05:02 +00:00
09ec1743fe
[analyzer] fix method name for concrete_class_with_abstract_member
...
Fixes #49334
Change-Id: Idd47028064e4c98d693e7b9d831322a2c6c628ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249614
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-27 15:11:02 +00:00
a573cb847b
[analysis_server] ConvertIntoBlockBody to fix ENUM_WITH_ABSTRACT_MEMBER
...
Fixes #48478
Change-Id: I186f7b06e497a1b79d77fd1844488ae4302b5ba7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249612
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-24 21:16:00 +00:00
c979aa71d8
[analysis_server] ReplaceFinalWithConst to handle unnecessary const
...
Fixes #49295
Change-Id: I6974c370e14d16ce5b38471bad7c0d8e86ac6062
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-24 19:31:23 +00:00
33822c4caa
Use LibraryAnalyzer from AnalysisDriver in Cider.
...
Change-Id: I5fd1edba5c2c62a92ed6bc84099839ab98b17063
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-06-24 15:53:39 +00:00
dc58725d4e
[analysis_server] MakeFinal to handle the lint at token
...
Part of #49317
Change-Id: I616ca93bb5061ded835b4dc0938446a402fd76e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249584
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-23 16:51:55 +00:00
23f1c542e4
[analysis_server] Disallow Extract Method on nullable type names and import prefixes
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4029 (and maybe https://github.com/dart-lang/sdk/issues/48824 ).
Change-Id: I52a975a830733062dacdf72f06418f4b67d3318b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-23 16:04:55 +00:00
f9984c267b
Add quick fix for UNNECESSARY_FINAL
...
Fixes #48778
Change-Id: I86b0b8344768db9653c16507a88d4f454dc86ed6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-23 15:39:15 +00:00
2e77fe796a
Capture severity adjustments in analytics
...
Change-Id: I10d3d878c70d7acf2773db2a4c1b01293892dc4a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249543
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-23 15:28:20 +00:00
14796fafa8
[analysis_server] [lsp] Fix resolving completions with no insertText and stop using insertText entirely
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4027 .
Change-Id: I60d4e9aabdd125771cd8f3e9f63367cf21eea5fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249489
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-22 17:03:35 +00:00
d6215b7eb0
[analysis_server] [LSP] Prevent Getter<->Method refactors showing in invalid places
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4000 .
Change-Id: I3b0b39b871b2d7176a1cbbe73064fce2586813ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249482
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-22 15:30:34 +00:00
77bf07a87f
[analysis_server] Rename LSP Pattern alias to not conflict with Dart Pattern type
...
Change-Id: Ib3178eb2fd3f3e2d41844d5fb492775da7e3171a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249487
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-22 14:05:24 +00:00
3b01def1a6
Add hooks for and start gathering some analysis context dependent analytics
...
Change-Id: I6d428c1bd55aae060a09b7cc039b92df38d09d1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-21 19:47:24 +00:00
e78399ac52
Issue 23067. Report HintCode.DEPRECATED_EXPORT_USE
...
It found a few cases for `BytesBuilder` exported from `dart:io`.
I fixed most of them in a separate CL.
But package:flutter (itself only) is clean.
There are a few violations in google3.
I will ignore most of them, and fix a few.
Bug: https://github.com/dart-lang/sdk/issues/23067
Change-Id: Ic89370ad84caa60fd49326c2bc60ad5d927e2264
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248343
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2022-06-18 18:17:40 +00:00
a60df664b3
[analyzer] Add a quick fix for avoid_renaming_method_parameters
...
Fixes #47126
Change-Id: Ic9ee97174504cf8e0c6a5fcc3224849c870714c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-17 16:16:59 +00:00
cd43f3d08c
[analysis_server] Use generated typedefs for LSP code
...
Change-Id: I242413db35b22d01965aa8ecf9851e47982ea41d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-16 22:02:00 +00:00
31c49c4fd8
Use FileState from AnalysisDriver in Cider.
...
Change-Id: I3f6dc6f80845d24e555328d25f8355eb11e51883
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248709
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-06-16 17:48:49 +00:00
567b45fb1d
Add the enable-experiment flag back to DAS
...
Bug: https://github.com/dart-lang/sdk/issues/48960
Change-Id: I6576f45e63e28902986db844df49a06a71385704
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245202
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-06-16 16:26:39 +00:00
341b60796a
[analysis_server] Generate typedefs for LSP params/result unions
...
Many params/result types are defined as unions without names in the spec. This gives them names so the handlers will be able to use names instead of the full EitherX<Y> type.
Change-Id: I3f96b48e5e70c86814724edc3fec4fc7f76534de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248801
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-16 16:11:21 +00:00
b46a2d3039
[analysis_server] Preserve type aliases from the LSP spec as typedefs in generated code
...
+ improve the use of LSPAny/LSPObject where
LSPAny = anything, including null or undefined
LSPObject = any object (equiv of non-null Map<String, Object?>)
Change-Id: I335b299aad8e58b1cb4ee33cf27dc0dd887ec916
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248781
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-16 14:15:41 +00:00
8038192b9d
[analysis_server] Fix names of canParse functions for nested generics
...
Change-Id: I4f641d8cb4cc2aadfd38c5fc0b06fd11445c4165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248587
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-15 19:29:48 +00:00
d2e006eefa
quick-fix to wrap in unawaited
...
Fixes: https://github.com/dart-lang/sdk/issues/49262
See also: https://github.com/dart-lang/linter/issues/3429
Change-Id: I0d3bf6c72ae1cf3e08f50b4deda10aba52e25eb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2022-06-15 18:03:08 +00:00
c44bb947eb
Capture initializationOptions from initialize
...
Change-Id: Ib9bf4361b97d284e5e1f96edc2c4540a0551b349
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248340
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-15 16:37:49 +00:00
07f7e455fa
[analysis_server] use single function per type for canParse
...
Fixes #49229
Change-Id: I87d2dea79f8786b826162d132a63c69a2ebaba67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248009
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-15 14:31:38 +00:00
85700570f6
Fix typos
...
Fixes #49241
TEST=ci
Change-Id: I6117bf816fc8c4613cce66927f952fef75632725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248120
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-15 11:08:28 +00:00
744d14470a
Fix a bug when replacing a single parameter with multiple in Flutter code.
...
Change-Id: I87c2fdbe5e74a725463942693016e83da952718c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2022-06-15 06:12:58 +00:00
08d6d8f88d
add quick-fix for discarded_futures
...
See: https://github.com/dart-lang/linter/issues/2923
Also: https://github.com/dart-lang/sdk/issues/49262
Change-Id: I57336d792b91b5bfaf8bcf4e28d8d592716b3999
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248444
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-14 21:48:16 +00:00
40e25ebad0
[analysis_server] Always provide textEdit for LSP completions
...
Not providing textEdit means that the client will use insertText and compute its own range for what needs to be replaced. This may be incorrect if the name includes symbols that VS Code doesn't realise are part of the identifier.
To fix this, we should _always_ supply the range. This will result in a slightly larger payload, although an upcoming change to use itemDefaults will remove that for supporting clients.
Fixes https://github.com/Dart-Code/Dart-Code/issues/3943 .
Change-Id: Ifd3f38ef96fecc6c745e00f511eb0bdbbd0d4a82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248143
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-14 16:00:47 +00:00
d6e5a0fc49
[analysis_server] Support Flutter's "wrap" assists in variable declarations
...
See https://github.com/emacs-lsp/lsp-dart/issues/141 .
Change-Id: Ib5f3cbcf67ad70582ff257900f35beac61746380
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248125
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-14 14:11:47 +00:00
295898343a
[pkg/analysis_server] remove some references to package:html
...
Change-Id: I5995c1281103e632bd98e180929cb170b2a87ef2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2022-06-13 20:00:28 +00:00
d876b2b48d
Prepare to collect data about workspace folders
...
Let me know if there are other parameters that we should collect
information about. I thought about open/close, to correspond to the
number of priority files tracked for the legacy protocol, but I thought
it would be too noisy. Happy to discuss if you think otherwise.
Change-Id: Id1b8bc043052570c706dc19ea31c33c2b19177ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247480
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-13 15:23:49 +00:00
9a48d1b82f
Reland "[data driven] support moving symbols across packages"
...
This reverts commit f111a2df54https://github.com/flutter/flutter/issues/105641 )
Original change's description:
> Revert "[data driven] support moving symbols across packages"
>
> This reverts commit 3290d7a137https://github.com/flutter/flutter/issues/105641 )
>
> Original change's description:
> > [data driven] support moving symbols across packages
> >
> > See: https://github.com/dart-lang/sdk/issues/48997
> >
> > Change-Id: Iad16b9eae0523bc4bc14537af642b05efa75b6f7
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246663
> > Commit-Queue: Phil Quitslund <pquitslund@google.com >
> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: I4a83d50497d6208b7f518ca1b381ece3aab192ad
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247606
> Reviewed-by: Siva Annamalai <asiva@google.com >
> Reviewed-by: Keerti Parthasarathy <keertip@google.com >
> Commit-Queue: Phil Quitslund <pquitslund@google.com >
> Reviewed-by: Phil Quitslund <pquitslund@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I769dec0d85fc0a41048b21deec0724d8509ef8e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2022-06-13 14:45:06 +00:00
1b9554d481
Add 'textToMatchOverride' for 'setState' completion.
...
Bug: https://github.com/dart-lang/sdk/issues/49233
Change-Id: I74fd86fc7f49c932e6698e474842078ff823f3cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247933
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-13 00:54:16 +00:00
503e7232ab
[analysis_server] have a single function for union
...
Bug: #49229
Change-Id: I6141c48e48fbe88812c10d7fcc3541af28ec36c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247966
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-12 17:31:57 +00:00
57b192f3a6
[analyzer] RemoveTypeAnnotation to handle type arguments
...
Fixes #49227
Change-Id: I0f754d84e3e4e89800abdec26925229587202bca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247968
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-12 17:24:06 +00:00
4ecc7ff67e
[analysis_server] AddAwait to handle NON_BOOL_CONDITION
...
Fixes #49114
Change-Id: Id6b345a946ec124e4518c7bb526c510ae0cb92c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-12 17:23:55 +00:00
c5e725578a
Revert "Add AnalysisDriver.contextRoot, deprecate configure()."
...
This reverts commit 3b111d5e0dhttps://fusion2.corp.google.com/presubmit/tap/453818030
>
> Change-Id: Iaa6bf85e27c3be5d0ecb40126d6b857fe6f2aa64
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247626
> Reviewed-by: Samuel Rawlins <srawlins@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com ,srawlins@google.com
Change-Id: I2eb567c6343636d3affd48bb4bfb0b4b1aa788b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247861
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2022-06-09 20:53:03 +00:00
eda47496d7
[analysis_server] Removing ignoring hash_and_equals lint
...
Bug: #48785
Change-Id: I9007eb2388adac3f5f33ae81346e4bc0485a405f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247556
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2022-06-09 19:36:43 +00:00
a3d8800c9d
[analyzer] ChangeTo to handle SUPER_FORMAL_PARAMETER_WITHOUT_ASSOCIATED_NAMED
...
Fixes #48480
Change-Id: I234ccb0cd170a78f5686048a294536d434e84eb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-06-09 19:20:13 +00:00
a855030120
[vm/ffi] Allow struct nesting with looser packing
...
C compilers don't enforce nesting rules. `dart:ffi` was enforcing these
rules causing issues for binding to C libraries having looser packing
for nested structs than outer structs.
This CL completely removes the error from the analyzer and CFE.
(As an alternative we could have kept a hint/lint, but this might create
more noise than value.)
TEST=pkg/analyzer/test/src/diagnostics/packed_nesting_non_packed_test.dart
Closes: https://github.com/dart-lang/sdk/issues/46644
Change-Id: Iae2d5c885546f7799bc6dea2f8cd7dd508216a0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247382
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-09 19:08:43 +00:00
Danny Tuppeny