Asger Feldthaus
902d9ee7e8
Do some housekeeping in tools/testing/dart
...
- Fix dartanalyzer warnings about unused variables and missing returns
- Remove trailing whitespace
- Add a dummy pubspec.yaml so editors recognize it as a Dart project
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2633213003 .
2017-01-17 16:02:45 +01:00
William Hesse
7e9a9804d9
Add suppression to test.dart for flaky content_shell crashes
...
BUG=https://github.com/dart-lang/sdk/issues/26739
R=kustermann@google.com
Review URL: https://codereview.chromium.org/2081173002 .
2016-06-27 14:44:11 +02:00
William Hesse
fb117bb484
Fix analyzer warnings for browser_controller.
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org/2069243002 .
2016-06-15 22:22:34 +02:00
William Hesse
f76236db74
Revert "Revert "Make Safari tests more robust.""
...
This reverts commit b9cdd0e1b2 .
This change should now work, because the buildbot recipes use the
renamed flag --reset-browser-configuration.
BUG=
R=ahe@google.com
Review URL: https://codereview.chromium.org/2070513002 .
2016-06-15 04:29:33 -07:00
Peter von der Ahé
b9cdd0e1b2
Revert "Make Safari tests more robust."
...
This reverts commit 199806da03 .
That commit failed because tools/bots/compiler.py is being ignored, and test.py is invoked based on recipes not included in this repository.
TBR
Review URL: https://codereview.chromium.org/2065053003 .
2016-06-15 10:39:36 +02:00
Peter von der Ahé
199806da03
Make Safari tests more robust.
...
R=whesse@google.com
Review URL: https://codereview.chromium.org/1871883002 .
2016-06-15 10:16:14 +02:00
William Hesse
7c9219a48e
Revert "Delay Firefox browser startup in test scripts, to flatten load."
...
This reverts commit 40b69fd615 .
BUG=https://github.com/dart-lang/sdk/issues/26060
R=kevmoo@google.com
Review URL: https://codereview.chromium.org/1921553005 .
2016-04-26 21:29:45 +02:00
William Hesse
40b69fd615
Delay Firefox browser startup in test scripts, to flatten load.
...
BUG=https://github.com/dart-lang/sdk/issues/26060
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org/1882813002 .
2016-04-26 15:33:52 +02:00
William Hesse
c0096e6f0c
Print name of previous test when a browser test times out.
...
Remove timeout multiplier for dart2js browser tests.
BUG=https://github.com/dart-lang/sdk/issues/26060
R=kustermann@google.com
Review URL: https://codereview.chromium.org/1867283002 .
2016-04-13 12:35:27 +02:00
William Hesse
c63b10b611
Format the test scripts in /tools/testing/dart using dartfmt 1.16.0-dev.3.0.
...
R=ahe@google.com
Review URL: https://codereview.chromium.org/1859973002 .
2016-04-06 14:49:18 +02:00
William Hesse
7407ecded4
Start browsers sequentially in testing scripts, as needed.
...
BUG=https://github.com/dart-lang/sdk/issues/26060
R=ahe@google.com
Review URL: https://codereview.chromium.org/1859523002 .
2016-04-06 11:34:52 +02:00
ricow@google.com
8d4af95d99
Don't report firefox crash reports
...
This disables firefox crash reporting (which will show a pop up dialog)
R=whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//1027093004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45202 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-16 11:17:12 +00:00
whesse@google.com
8257b1874e
Restart ie11 browser while running tests. Update status files.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//888013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43329 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 10:33:07 +00:00
whesse@google.com
5406811398
Restart IE 10 browser as we do with Android browsers on buildbot, to improve stability
...
BUG=22203
Review URL: https://codereview.chromium.org//867083003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43294 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:24:00 +00:00
whesse@google.com
014a89563a
Add debug logging for android testing.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//863663002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43005 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 11:39:09 +00:00
ricow@google.com
4598291567
Add info about which command line was used to start a browser.
...
This will help us if we see hanging browsers.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//790793009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42728 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 10:46:40 +00:00
kevmoo@google.com
47de553025
tools/testing: move code into individual libraries
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//748773004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42108 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-04 15:32:57 +00:00
whesse@google.com
0059ade0dd
Add android device id to test output for failing tests.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//755263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41960 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-25 16:11:42 +00:00
whesse@google.com
12845acbf3
Revert "Add android device id to test output in test scripts."
...
This reverts r41933
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//758563004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41934 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 17:53:30 +00:00
whesse@google.com
d91010512a
Add android device id to test output in test scripts.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//752173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41933 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-24 17:40:13 +00:00
whesse@google.com
6ac0684ab8
Working SimpleHTML test front end
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//695893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41517 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 12:54:34 +00:00
whesse@google.com
0928369fc9
Improve browser testing scripts to better handle tests that reload themselves.
...
BUG=dartbug.com/18558
R=ricow@google.com
Review URL: https://codereview.chromium.org//702543006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41490 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-04 14:46:45 +00:00
ahe@google.com
d83ee35044
Terminate browsers in sequence.
...
Also make iframe larger.
R=whesse@google.com
Review URL: https://codereview.chromium.org//660823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41189 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-20 12:32:50 +00:00
whesse@google.com
b21c902607
Add support in test scripts backend for simple HTML tests.
...
BUG=dartbug.com/20698
R=ricow@google.com
Review URL: https://codereview.chromium.org//632283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40956 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 15:29:39 +00:00
whesse@google.com
f9b0a27ee9
test.dart: Serve the browser test driver page from the test file HTTP server.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//540933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39907 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-05 11:01:26 +00:00
whesse@google.com
48065a1f91
Update test scripts to run under the Dart 1.6 vm.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//483353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39443 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-21 09:30:10 +00:00
ricow@google.com
e89bd4ab1d
Try running ie10 in a new window instead of an iframe.
...
We are seeing issues where it seems that we are getting unittest-suite-success messages out of the blue and this may be related to:
https://code.google.com/p/dart/issues/detail?id=17825
This could be the old javascript still running in the iframe posting the event.
R=whesse@google.com
Review URL: https://codereview.chromium.org//477613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39245 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-14 12:36:54 +00:00
whesse@google.com
4431b50125
Browser testing: Run android content shell tests on hosts with multiple devices connected.
...
The adb_reverse_forwarder.py script in [dartium]/build/android/ needs the --all-devices option added. We will also try to upstream this flag to chromium.
This change makes the test host reinstall the ContentShell apk on the device each time the device is restarted due to timeout or periodic reset, which takes about 10 seconds, but this is simpler and more like the existing behavior with android chrome.
R=ricow@google.com
Review URL: https://codereview.chromium.org//467643002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39142 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 14:40:26 +00:00
whesse@google.com
75e14b393a
Test infrastructure: Avoid restarting browser app on Android twice simultaneously.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//442673003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38898 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-05 14:01:23 +00:00
whesse@google.com
60a9ad6c0b
Reland r37983, "Add periodic browser restart to ContentShellOnAndroid test runtime"
...
This was reverted in r38002, because it didn't seem needed. It now looks like it will make the builder more stable.
Original CL: https://codereview.chromium.org/363323002/
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//439713006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38866 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-04 16:25:47 +00:00
ricow@google.com
9f85c90367
Make ie11 use a fresh window again
...
Review URL: https://codereview.chromium.org//379923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38088 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-09 16:36:54 +00:00
ricow@google.com
33ed771f0a
Don't use new windows for ie11
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//377493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38023 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-07 11:10:35 +00:00
whesse@google.com
bb59b9fa85
Revert r37983, "Add periodic browser restart to ContentShellOnAndroid test runtime. Update test status for ContentShellOnAndroid."
...
This reverts CL https://codereview.chromium.org/363323002/
We found that the flaky timeouts are real renderer crashes, and this change does not seem to help. We will instead report more data on the renderer crashes.
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//373453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38002 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-04 09:19:08 +00:00
whesse@google.com
419bf8df29
Add periodic browser restart to ContentShellOnAndroid test runtime. Update test status for ContentShellOnAndroid.
...
BUG=dartbug.com/19127
R=kustermann@google.com
Review URL: https://codereview.chromium.org//363323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37983 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 12:59:59 +00:00
whesse@google.com
edcdb5e02d
Update co19 test suite to r737
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//330633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37305 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-13 08:15:06 +00:00
ricow@google.com
6be37386e0
Add mobile safari simulator support in the testing scripts
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//262763005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35626 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 11:32:08 +00:00
ricow@google.com
9a9ca47034
Add clear_browser_cache flag to test.dart
...
This can be used by any browser implementation to flush browser specific caches if set
clear_safari_cache is left in as a synonym for now, I will remove if after I update the bots
Review URL: https://chromiumcodereview.appspot.com//252653007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35477 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 09:38:31 +00:00
efortuna@google.com
d8a23ea25a
"Reverting 35157"
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//243253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35211 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-21 17:51:42 +00:00
efortuna@google.com
b5ffc1968e
Fix Browser Controller to not reuse iFrames, which can sometimes cause bad state to be left between tests.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//241783003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35157 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-17 22:56:05 +00:00
whesse@google.com
8fb7ab6c74
test.dart: Add timeout for browsers that are started but do not fetch tests.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//218683009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34701 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-03 12:35:22 +00:00
ricow@google.com
618140cd95
Get the correct version of ie from the reg database
...
version is 9.0.FOO.BAR on ie9
9.10.XFOO.XBAR on ie10
9.11.ZFOO.ZBAR on ie11
svcVersion is a more sane number, i.e., on ie10 it is 10.0.9200.16843 (atm) and on ie11 it is 11.0.9600.16521 (atm)
R=whesse@google.com
Review URL: https://codereview.chromium.org//210783004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34355 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 12:47:59 +00:00
ricow@google.com
6e6bc22e12
Add support for ie11 in our testing scripts
...
We explicitly need this since we need to be able to distinguesh between the
different versions in the status files. We could generalize this by having browser groups for everything but the actual status file parsing.
Review URL: https://codereview.chromium.org//206623010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34349 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 08:51:53 +00:00
kustermann@google.com
72b0b89102
Allow empty messages coming from the iframe to the driving page
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//188543003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33377 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 14:29:55 +00:00
kustermann@google.com
7e29f42833
Change tests to use test.py's test_controller.js, cleanup in browser_controller
...
This change makes all remaining tests use test.py's test_controller.js:
We have our own way of testing using test.py and that might change any time.
It's therefore not wise to rely on functionality in the unittest framework. If
we kept test_controller.js in the unittest package, we'd need to make a breaking
change whenever we change the behavior of test_controller.js. So this file was
forked into tools/testing/dart/test_controller.js.
After this, all our tests will use tools/testing/dart/test_controller.js. It is
therefore no longer necessary for the browser_controller to support the old
mechanism of posting back results. By removing this legacy code, we can ensure,
that the driving page of browser_controller will only react on valid messages
which were ment for it.
Context:
Some tests (e.g. dromaeo) might use postMessage internally, maybe even for
testing that postMessage is working. But the driving window should only react
on valid messages ment for it, ignoring any other messages.
R=blois@google.com , efortuna@google.com , ricow@google.com , whesse@google.com
Review URL: https://codereview.chromium.org//177333004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33365 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 10:37:53 +00:00
efortuna@google.com
9d53b1d682
Replace run_selenium.py with Dart script that uses the browser controller for performance tests.
...
BUG=
R=kustermann@google.com , ricow@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//178223008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33171 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 21:06:28 +00:00
kustermann@google.com
338fabdb6c
Cancel stdout/stderr subscriptions once subprocesses are dead, add more debugging information in case the debug timer expires
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//128703002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31649 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 09:04:46 +00:00
whesse@google.com
c8bfa98017
Test infrastructure: add retry to browser controller sending "done" message.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//107513004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30950 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-06 16:38:15 +00:00
kustermann@google.com
e634fb20a4
Make status updates after 10 seconds + fix handling of status updates
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//94213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30748 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-28 08:50:58 +00:00
kustermann@google.com
bb54b776ba
Checked-in binary update to v1.0.0.3
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//91473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30717 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 14:17:44 +00:00
kustermann@google.com
8649be6036
Implement a periodic timer which sends the current state of a browser test back to the browser controller
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//77763004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30468 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 13:32:16 +00:00