dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
44,997 Commits 2 Branches 0 Tags
8166deb009cfb8d54798cd2afc43094de5694747
Commit Graph

108 Commits

Author SHA1 Message Date
Kevin Millikin 8166deb009 Mark vm/lazy_deopt_vm_test as slow 
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2722113002 .
 2017-03-01 11:27:48 +01:00
Vyacheslav Egorov 8e267b29c1 Update status files for debug mode dartk/dartkp. 
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2722103002 .
 2017-03-01 10:31:42 +01:00
Peter von der Ahé 2e0e3b918f Always provide a field for context. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2723513002 .
 2017-02-28 16:49:19 +01:00
Jens Johansen 773e90869c [Fasta] Save parent in TypeDeclarationBuilder 
I get errors with library parent not set for some tests
(e.g. service tests). This fixes that.

BUG=
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2726533002 .
 2017-02-28 15:02:21 +01:00
Kevin Millikin b31e24f33a Update a test expectation. 
A pair of tests that were crashing the front end are now passing.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2718203003 .
 2017-02-28 13:03:54 +01:00
Martin Kustermann ce5906145d Status file update after analyzer->fasta dartk switch 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2721573002 .
 2017-02-27 12:45:02 +01:00
Vyacheslav Egorov de56824429 Switch -c dartk/dartkp configuration to use fasta. 
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2721443002 .
 2017-02-26 20:39:02 +01:00
Jens Johansen 26b6ecdf63 Enable causal stacktrace in kernel 
R=kmillikin@google.com, kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/b29829660bcdee7eb394e6fd4635ff7a6a77ef01
Review-Url: https://codereview.chromium.org/2690873005 .
 2017-02-24 12:11:30 +01:00
Florian Loitsch 979183decf Add support for the new function-type syntax. 
Fixes #27967
BUG= http://dartbug.com/27967
R=ahe@google.com, johnniwinther@google.com, paulberry@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/85227ba8a60332a18ae92cb1b87bf15d52a909bd
Reverted: https://github.com/dart-lang/sdk/commit/f5fc210f4f79f7e6b7ccefc24e7565e810e9dc7d
Committed: https://github.com/dart-lang/sdk/commit/e4999a631093690febb2eb90cbdbe1f9d5183455
Reverted: https://github.com/dart-lang/sdk/commit/c64c35153905fc2bf8a74c02297220385cfcbc87
Committed: https://github.com/dart-lang/sdk/commit/c289af39c36d9a5f7130a3e69b7891052652a64e
Reverted: https://github.com/dart-lang/sdk/commit/c66479f40767744d0bdd027c004583d6e32fe50f
Review-Url: https://codereview.chromium.org/2567133002 .
 2017-02-23 13:36:28 +01:00
Florian Loitsch c66479f407 Revert "Add support for the new function-type syntax." 
This reverts commit c289af39c3.

BUG=

Review-Url: https://codereview.chromium.org/2710973002 .
 2017-02-22 17:19:35 +01:00
Florian Loitsch c289af39c3 Add support for the new function-type syntax. 
Fixes #27967
BUG= http://dartbug.com/27967
R=ahe@google.com, johnniwinther@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/85227ba8a60332a18ae92cb1b87bf15d52a909bd

Reverted: https://github.com/dart-lang/sdk/commit/f5fc210f4f79f7e6b7ccefc24e7565e810e9dc7d

Committed: https://github.com/dart-lang/sdk/commit/e4999a631093690febb2eb90cbdbe1f9d5183455

Reverted: https://github.com/dart-lang/sdk/commit/c64c35153905fc2bf8a74c02297220385cfcbc87
Review-Url: https://codereview.chromium.org/2567133002 .
 2017-02-22 16:53:49 +01:00
Jens Johansen b875199cef Re-mark language/disassemble_test as Pass, Crash 
Was added here: https://github.com/dart-lang/sdk/commit/f95701bf6119f41dfcda921268ff07836bd86898
Was removed (by mistake I suppose) here: https://github.com/dart-lang/sdk/commit/fc2458b8423979573ef3bdc70edf9711b38a99b2

Readding it.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2702553002 .
 2017-02-16 12:59:02 +01:00
Jens Johansen 8175f806b3 Skip vm/optimized_stacktrace_test in kernel debug mode 
BUG=
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2697283002 .
 2017-02-16 10:40:34 +01:00
pq ce8dd9cabb Revert "Enable causal stacktrace in kernel" 
This reverts commit b29829660b.

(In quest for build greenness.)

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2697083002 .
 2017-02-15 11:11:30 -08:00
Jens Johansen b29829660b Enable causal stacktrace in kernel 
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2690873005 .
 2017-02-15 14:17:29 +01:00
Vyacheslav Egorov dad56e9b14 Gardening: Make dartk bots green. 
Mark language/vm/causal_async_exception_stack2_test as failing

Skip co19 spawnUri_A01_t06 test as it is racy.

BUG=

Review-Url: https://codereview.chromium.org/2696003002 .
 2017-02-14 18:57:48 +01:00
Martin Kustermann d93928a6ce Make dartk-{release,debug} builders work properly again 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2696613003 .
 2017-02-14 14:01:58 +01:00
Dmitry Stefantsov bbd687197b Mark deferred loading test as failing for vm-kernel-precompiled 
This is a known issue, see dartbug.com/28335

R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2681123003 .
 2017-02-09 11:18:25 +01:00
Lasse R.H. Nielsen 794f66b32b Mark language/bad_raw_string_test/{none,03} as failing on dartk. 
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2680863005 .
 2017-02-08 11:31:17 +01:00
Matthias Hausner a7eb2f45c3 [Gardening] Update status file after fix of 28302 
Front-end bug #28302 was fixed. Now update status file to adjust
test expectation.

TBR=kustermann

BUG=

Review-Url: https://codereview.chromium.org/2676453002 .
 2017-02-01 16:26:11 -08:00
Karl Klose 0f85f32162 [gardening] Update status files for dartk_precompiled tests 
TBR=vegorov@google.com

Review-Url: https://codereview.chromium.org/2661163004 .
 2017-02-01 11:12:58 +01:00
Vyacheslav Egorov a7ffe24177 VM: [Kernel] Switch to DFE for testing -c dartk configuration. 
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2668503003 .
 2017-01-31 18:25:02 +01:00
Martin Kustermann fc2458b842 VM: [Kernel] Partial support for checked mode. 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2659363003 .
 2017-01-31 12:10:46 +01:00
Paul Berry 1a0f33de44 Update status file to reflect c9b692e8d9. 
c9b692e8d9 introduced some expected analyzer failures which also
affect kernel.  Update kernel status file to expect those failures.

TBR=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2660773003 .
 2017-01-29 13:41:04 -08:00
Martin Kustermann ccd89165a0 VM: [Kernel] Add triaged test failure comments to status file 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2652653009 .
 2017-01-24 17:56:36 +01:00
Brian Wilkerson cacf3c0f18 Fix kernel bots (TBR) 
Review-Url: https://codereview.chromium.org/2642713006 .
 2017-01-20 17:08:00 -08:00
Asger Feldthaus e6793f76ee Improvements to the kernel tree shaker. 
- Use strong-mode types for more precise tree shaking.
- Bail out nicely if dart:mirrors is used.
- Run the tree shaker in the VM target.

The initial tree-shaking pass could be combined with the type checking
pass (inserting implicit down casts) but for now they remain separate.

R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/71efbad90c07bece4010162b77d3b51e79b0a34d
Review-Url: https://codereview.chromium.org/2627723003 .
 2017-01-20 10:52:27 +01:00
Regis Crelier 4b77948aac Adjust status file of vm-kernel for failures related to covariant modifier. 
Review-Url: https://codereview.chromium.org/2647633007 .
 2017-01-19 19:25:52 -08:00
Martin Kustermann c5c7f45be0 VM: [Kernel] Ensure we don't capture :stack_trace variable in yielding functions 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2640353002 .
 2017-01-19 18:53:22 +01:00
Asger Feldthaus deedd39f04 Revert "Improvements to the kernel tree shaker." 
This reverts commit 71efbad90c.

BUG=

Review-Url: https://codereview.chromium.org/2644543004 .
 2017-01-19 16:02:48 +01:00
Asger Feldthaus 71efbad90c Improvements to the kernel tree shaker. 
- Use strong-mode types for more precise tree shaking.
- Bail out nicely if dart:mirrors is used.
- Run the tree shaker in the VM target.

The initial tree-shaking pass could be combined with the type checking
pass (inserting implicit down casts) but for now they remain separate.

R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2627723003 .
 2017-01-19 14:00:31 +01:00
Asger Feldthaus 76442f9394 Fix language/bad_constructor_test in dartk and analyzer. 
The test was incorrect because it did not declare that a static warning
was to be expected due to an unresolved reference to 'q'. The unresolved
reference has been removed as it has nothing to do with what it is
supposed to test.

The analyzer was incorrect in that a setter was reported to clash with
a constructor of the same name, but this failure was hidden by the
above issue. This has been fixed.

dartk inherited the issue (and its fix) from the analyzer, but some
additional error handling was needed in dartk to avoid crashing.

Closes https://github.com/dart-lang/sdk/issues/11576

BUG=
R=kmillikin@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2643693002 .
 2017-01-19 13:10:32 +01:00
Jens Johansen 919b5ac8d0 Test for kernel async stacktrace bug 
BUG= https://github.com/dart-lang/sdk/issues/28446
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2638403004 .
 2017-01-19 12:37:58 +01:00
Asger Feldthaus d4dfb3088e Fix some crashes in dartk. 
Dartk should no longer crash in these cases:
- main method is provided through an export
- main method is missing
- initializing formal parameter is unresolved
- the loadLibrary function is torn off

BUG=
R=kmillikin@google.com, vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/d01bd88152b2d30d6a06d1379e41e1280d094dab
Committed: https://github.com/dart-lang/sdk/commit/979072821d1113248e285f7926663eb00d8a8206
Review-Url: https://codereview.chromium.org/2641523002 .
 2017-01-19 12:12:36 +01:00
Martin Kustermann 6a4d70ef3a VM: [Kernel] Fix invocation of _AssertionError._create 
A CL a few weeks ago added one more argument to the constructor (see https://codereview.chromium.org/2574003003)

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2640253002 .
 2017-01-19 10:59:53 +01:00
Martin Kustermann e006da5d8c Bulk status file update to get kernel builders green 
Review-Url: https://codereview.chromium.org/2640913004 .
 2017-01-19 10:05:12 +01:00
Asger Feldthaus be9088060d Revert "Fix some crashes in dartk." 
This reverts 979072821d

BUG=

Review-Url: https://codereview.chromium.org/2638353003 .
 2017-01-18 20:52:13 +01:00
Sigmund Cherem c64c351539 Reverts the following two commits: 
"Add support for the new function-type syntax." # e4999a6310.
"In function-type test: remove unused variables, make type stronger." # 02ffb3b140.

Reason to revert:
We found user code breaks because of ambiguous cases like this:

   ```
   class Function extends Foo {
      Function() : super();
   }
   ```

Today this fails when trying to parse the constructor.

We need to:
 * indicate this is not allowed anymore (probably at the class declaration)
 * allow it until we are ready to make it a breaking change (by maybe
 adding a special exception to allow this ambiguity in the syntax).
 * consider the language change to see whether we can prevent the breaking
 change if we use a different keyword.

BUG=
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2638063003 .
 2017-01-18 10:13:38 -08:00
Martin Kustermann f95701bf61 Support tests using VMOptions also with kernel 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2641433002 .
 2017-01-18 18:48:22 +01:00
Asger Feldthaus 979072821d Fix some crashes in dartk. 
Dartk should no longer crash in these cases:
- main method is provided through an export
- main method is missing
- initializing formal parameter is unresolved
- the loadLibrary function is torn off

BUG=
R=kmillikin@google.com, vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/d01bd88152b2d30d6a06d1379e41e1280d094dab
Review-Url: https://codereview.chromium.org/2641523002 .
 2017-01-18 16:44:45 +01:00
Martin Kustermann 887b4775a1 Mark 2 precompilation tests as passing after fixing [StringInterpolateInstr::Canonicalize] 
Review-Url: https://codereview.chromium.org/2640833002 .
 2017-01-18 14:59:56 +01:00
Asger Feldthaus 6272e23d35 Revert "Fix some crashes in dartk." 
This reverts commit d01bd88152.

Some status file updates were missing for precompiled mode.

BUG=

Review-Url: https://codereview.chromium.org/2644513002 .
 2017-01-18 12:21:43 +01:00
Martin Kustermann f40e46c3fd VM: [Kernel] Ensure we have correct try-index on join blocks for break destinations 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2637993002 .
 2017-01-18 11:25:56 +01:00
Martin Kustermann e97bcc5475 VM: [Kernel] Partial support for metadata annotations 
The CL adds metadata support for Fields/Classes/Functions/Constructors. There
are other places where annotations can be put in the Dart language but the
Kernel IR currently does not store it in the AST.

Whenever a element (e.g. a function) gets annotated, the VM will make a [Field] for this
element whos value is an array of evaluated constant metadata annotations.

This CL attaches to these [Fields] a `kernel_function` which is then used to do the constant
evaluation.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2632253002 .
 2017-01-18 10:51:24 +01:00
Asger Feldthaus d01bd88152 Fix some crashes in dartk. 
Dartk should no longer crash in these cases:
- main method is provided through an export
- main method is missing
- initializing formal parameter is unresolved
- the loadLibrary function is torn off

BUG=
R=kmillikin@google.com, vegorov@google.com

Review-Url: https://codereview.chromium.org/2641523002 .
 2017-01-18 10:39:10 +01:00
Florian Loitsch e4999a6310 Add support for the new function-type syntax. 
Fixes #27967
BUG= http://dartbug.com/27967
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/85227ba8a60332a18ae92cb1b87bf15d52a909bd

Reverted: https://github.com/dart-lang/sdk/commit/f5fc210f4f79f7e6b7ccefc24e7565e810e9dc7d
Review-Url: https://codereview.chromium.org/2567133002 .
 2017-01-13 18:45:47 +01:00
Florian Loitsch f5fc210f4f Revert "Add support for the new function-type syntax." 
This reverts commit 85227ba8a6.

Review-Url: https://codereview.chromium.org/2627343004 .
 2017-01-13 16:50:25 +01:00
Florian Loitsch 85227ba8a6 Add support for the new function-type syntax. 
Fixes #27967
BUG= http://dartbug.com/27967
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2567133002 .
 2017-01-13 15:57:08 +01:00
Brian Wilkerson 833eb07c74 Move status to fix the bots (TBR) 
Review-Url: https://codereview.chromium.org/2626303002 .
 2017-01-12 11:53:35 -08:00
Brian Wilkerson f77340996b Fix more bots (TBR) 
Review-Url: https://codereview.chromium.org/2627793004 .
 2017-01-12 09:23:56 -08:00