dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
44,997 Commits 2 Branches 0 Tags
8166deb009cfb8d54798cd2afc43094de5694747
Commit Graph

1704 Commits

Author SHA1 Message Date
Florian Loitsch 979183decf Add support for the new function-type syntax. 
Fixes #27967
BUG= http://dartbug.com/27967
R=ahe@google.com, johnniwinther@google.com, paulberry@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/85227ba8a60332a18ae92cb1b87bf15d52a909bd
Reverted: https://github.com/dart-lang/sdk/commit/f5fc210f4f79f7e6b7ccefc24e7565e810e9dc7d
Committed: https://github.com/dart-lang/sdk/commit/e4999a631093690febb2eb90cbdbe1f9d5183455
Reverted: https://github.com/dart-lang/sdk/commit/c64c35153905fc2bf8a74c02297220385cfcbc87
Committed: https://github.com/dart-lang/sdk/commit/c289af39c36d9a5f7130a3e69b7891052652a64e
Reverted: https://github.com/dart-lang/sdk/commit/c66479f40767744d0bdd027c004583d6e32fe50f
Review-Url: https://codereview.chromium.org/2567133002 .
 2017-02-23 13:36:28 +01:00
Florian Loitsch c66479f407 Revert "Add support for the new function-type syntax." 
This reverts commit c289af39c3.

BUG=

Review-Url: https://codereview.chromium.org/2710973002 .
 2017-02-22 17:19:35 +01:00
Florian Loitsch c289af39c3 Add support for the new function-type syntax. 
Fixes #27967
BUG= http://dartbug.com/27967
R=ahe@google.com, johnniwinther@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/85227ba8a60332a18ae92cb1b87bf15d52a909bd

Reverted: https://github.com/dart-lang/sdk/commit/f5fc210f4f79f7e6b7ccefc24e7565e810e9dc7d

Committed: https://github.com/dart-lang/sdk/commit/e4999a631093690febb2eb90cbdbe1f9d5183455

Reverted: https://github.com/dart-lang/sdk/commit/c64c35153905fc2bf8a74c02297220385cfcbc87
Review-Url: https://codereview.chromium.org/2567133002 .
 2017-02-22 16:53:49 +01:00
John McCutchan 19abef97f1 Reland improvements to causal async stack traces 
Original CL: https://codereview.chromium.org/2690683002

Improvements to causal async stack traces

UX improvements:

- [x] Stop printing the suffix <%s_async_body> and <%s_async_gen_body> for the generated closures.

Fixes #28743

- [x] Don't include the duplicate frame below the asynchronous suspension marker.

Fixes #28742

Bug fixes:

- [x] Fix service protocol enum naming so that it is consistent with other enums.

Fixes #28726

Misc:

- [x] Stop using package:stack_trace now that the VM does it for us.

BUG=
R=asiva@google.com, devoncarew@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2691213003 .
 2017-02-14 05:00:04 -08:00
John McCutchan e84d8a1f11 Revert "Improvements to causal async stack traces" 
This reverts commit 8538d81473.

BUG=

Review-Url: https://codereview.chromium.org/2694213002 .
 2017-02-14 02:29:40 -08:00
John McCutchan 8538d81473 Improvements to causal async stack traces 
UX improvements:

- [x] Stop printing the suffix <%s_async_body> and <%s_async_gen_body> for the generated closures.

Fixes #28743

- [x] Don't include the duplicate frame below the asynchronous suspension marker.

Fixes #28742

Bug fixes:

- [x] Fix service protocol enum naming so that it is consistent with other enums.

Fixes #28726

Misc:

- [x] Stop using package:stack_trace now that the VM does it for us.

BUG=
R=asiva@google.com, devoncarew@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2690683002 .
 2017-02-14 00:56:55 -08:00
Ryan Macnak cfe5e5f075 Include metadata in AOT to expand inline frames in stack traces and provide line numbers. 
Also fix stack trace collection to always include invisible frames. It can happen that a visible function is inlined into an invisible function, and we don't expand inlined frames until we print a stack trace.

dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418 (+16%)
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624
Total(CodeSize): 17785396 (+12%)

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2687143005 .
 2017-02-13 10:27:36 -08:00
Zachary Anderson 0111122ca0 [Fuchsia] Update test status files 
R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2693643002 .
 2017-02-10 21:34:33 -08:00
John McCutchan 2c52f8423d Fix missing top frame in exception stacks in product mode 
BUG=

Review-Url: https://codereview.chromium.org/2688783002 .
 2017-02-09 16:11:22 -08:00
Florian Schneider 031af9e899 Update status of new test for reload bots. 
It uses deferred loading, which is not yet implemented with reloading.

Review-Url: https://codereview.chromium.org/2681213002 .
 2017-02-08 16:02:51 -08:00
Regis Crelier 84ca613377 Adjust status file for previously failing tests on vm-app and vm-products bots. 
Review-Url: https://codereview.chromium.org/2671773006 .
 2017-02-03 13:54:36 -08:00
Regis Crelier 97f968de1c Implement generic function type syntax in the VM (fixes #27966). 
The new function type syntax is allowed everywhere and not just in typedef.

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2643523002 .
 2017-01-27 08:45:03 -08:00
Zachary Anderson 63c4b6b1cb Revert "Remove package:unittest from some tests" 
This reverts commit dde47b2aad.

Revert "Update Dartium status for passing test"

This reverts commit d71c70d56d.

Tests failing on dart2js and async_star_pause_test is
passing on Dartium. Need to think about how to update the
status files.

Review-Url: https://codereview.chromium.org/2656503004 .
 2017-01-25 11:06:58 -08:00
Zachary Anderson d71c70d56d Update Dartium status for passing test 
Review-Url: https://codereview.chromium.org/2655913002 .
 2017-01-25 10:38:33 -08:00
Zachary Anderson 82bddc3614 Fuchsia: Update vm and language status files 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2651803004 .
 2017-01-24 22:03:18 -08:00
Regis Crelier 23d57d28df Set correct type for enum values list (fixes #28341). 
Add regression test.
Update status file.

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2651813006 .
 2017-01-24 15:07:01 -08:00
Konstantin Shcheglov 0160332713 Issue 28027. Move Null to the bottom in the Analyzer. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/28027

Review-Url: https://codereview.chromium.org/2638183002 .
 2017-01-18 11:15:11 -08:00
Sigmund Cherem c64c351539 Reverts the following two commits: 
"Add support for the new function-type syntax." # e4999a6310.
"In function-type test: remove unused variables, make type stronger." # 02ffb3b140.

Reason to revert:
We found user code breaks because of ambiguous cases like this:

   ```
   class Function extends Foo {
      Function() : super();
   }
   ```

Today this fails when trying to parse the constructor.

We need to:
 * indicate this is not allowed anymore (probably at the class declaration)
 * allow it until we are ready to make it a breaking change (by maybe
 adding a special exception to allow this ambiguity in the syntax).
 * consider the language change to see whether we can prevent the breaking
 change if we use a different keyword.

BUG=
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2638063003 .
 2017-01-18 10:13:38 -08:00
Martin Kustermann f95701bf61 Support tests using VMOptions also with kernel 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2641433002 .
 2017-01-18 18:48:22 +01:00
Florian Loitsch e4999a6310 Add support for the new function-type syntax. 
Fixes #27967
BUG= http://dartbug.com/27967
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/85227ba8a60332a18ae92cb1b87bf15d52a909bd

Reverted: https://github.com/dart-lang/sdk/commit/f5fc210f4f79f7e6b7ccefc24e7565e810e9dc7d
Review-Url: https://codereview.chromium.org/2567133002 .
 2017-01-13 18:45:47 +01:00
Florian Loitsch f5fc210f4f Revert "Add support for the new function-type syntax." 
This reverts commit 85227ba8a6.

Review-Url: https://codereview.chromium.org/2627343004 .
 2017-01-13 16:50:25 +01:00
Florian Loitsch 85227ba8a6 Add support for the new function-type syntax. 
Fixes #27967
BUG= http://dartbug.com/27967
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2567133002 .
 2017-01-13 15:57:08 +01:00
Matthias Hausner 90b937a4ce Support covariant keyword in the VM parser 
For Dart 1.5, the VM ignores the annotation. It is just consumed by the parser, but has otherwise no effect. Errors are reported on illegal covariant declarations.

BUG=#28166
R=regis@google.com

Review-Url: https://codereview.chromium.org/2625823004 .
 2017-01-12 14:03:26 -08:00
Florian Loitsch 5e262d11ea Add a few more tests. 
R=eernst@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/c5a47927182ecdc0035bab2b80ede049e571dbbd

Reverted: https://github.com/dart-lang/sdk/commit/fb62c9acc66c1280992c5bb3219dd625b89496b4
Review-Url: https://codereview.chromium.org/2629113002 .
 2017-01-12 16:33:41 +01:00
Florian Loitsch fb62c9acc6 Revert "Add a few more tests." 
This reverts commit c5a4792718.

Review-Url: https://codereview.chromium.org/2631513004 .
 2017-01-12 15:54:17 +01:00
Florian Loitsch c5a4792718 Add a few more tests. 
R=eernst@google.com

Review-Url: https://codereview.chromium.org/2629113002 .
 2017-01-12 14:33:23 +01:00
Florian Schneider bef4967ea1 Remove dart_noopt and related parts from the VM. 
dart_noopt is not needed anymore because we have testing
and builbot integration of the real precompilation pipeline in place now.

Fixes #24569
Fixes #25726
Fixes #25845

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2624393002 .
 2017-01-11 16:55:55 -08:00
Florian Schneider 45c3ecdf9c Re-enable now passing tests and remove redundant status file entry. 
Because the tests were marked "Skip" there is no way to find out when
they started passing again.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2625833004 .
 2017-01-11 16:35:24 -08:00
Martin Kustermann 36b16c6f1c VM: [Kernel] Merge common test expectations from language_kernel.status -> language.status 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2624973004 .
 2017-01-11 20:08:19 +01:00
Martin Kustermann 23cc9cca41 VM: [Kernel] Add toString() support for generated enum classes 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2625053003 .
 2017-01-11 19:50:21 +01:00
Florian Loitsch bfb5ee07b6 Change from "CompileTimeError" to "Fail". 
Dartium treats compile time errors as runtime errors. "Fail" covers both.

Review-Url: https://codereview.chromium.org/2623073003 .
 2017-01-11 19:49:13 +01:00
Martin Kustermann 673eb56471 VM: [Kernel] Fix remaining issues with kernel-based async/await implementation 
This CL brings us on-par with the VM implementation in terms of tests.

  * Ensure we have saved-try-ctx/exception/stacktrace variables hoisted out for
    try-catch **and** try-finally.

  * Instead of closing the stream controller for 'async*' functions on return we
    do it inside an try-finally block so we get there in terms of normal and
    exceptional exit.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2627873002 .
 2017-01-11 19:35:02 +01:00
Florian Loitsch 71ec2f0297 Implement 'covariant' modifier for dart2js. 
Also adds some tests.

Fixes #28165

BUG= http://dartbug.com/28165
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2626843003 .
 2017-01-11 19:12:48 +01:00
Florian Schneider d54341927e Change test to work with app-snapshots. 
App snapshot don't contain column information. Change the expectation to
only expect line numbers.

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2624023002 .
 2017-01-10 14:29:07 -08:00
Florian Schneider 204bd5a932 VM: Add missing token position in async rethrow 
Fixes #28325.

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2626753002 .
 2017-01-10 13:49:13 -08:00
Jennifer Messerly 816592a941 fixes #28236, generic methods should not cause warnings in Dart 1 
Instantiate universal functions in subtype tests & tear-offs. Also updates the status files and one Analyzer test that covered the tear-off type.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2621433003 .
 2017-01-09 12:46:20 -08:00
Martin Kustermann 98e3037f41 Share common failures between kernel and non-kernel in language_kernel.status -> language.status 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2621623002 .
 2017-01-09 13:53:23 +01:00
Florian Schneider 4347f9f0a2 Fix test status for hot-reload for a new test 
The test uses deferred libraries which are not supported with hot reload.

TBR=johnmccutchan@google.com,

Review-Url: https://codereview.chromium.org/2616053002 .
 2017-01-05 18:41:02 -08:00
Zach Anderson 8d709c279d Gardening: Tighten status update, adjust flaky test 
related #28276

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2613713006 .
 2017-01-05 10:30:43 -08:00
Regis Crelier dc0605012f Move Null type to the Bottom in the VM (fixes #28025). 
Fix wrong comments.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2608373002 .
 2017-01-05 10:05:31 -08:00
Zach Anderson 056fbcb92e Gardening: Update status for flaky optimized_stacktrace_test 
related #28276

Review-Url: https://codereview.chromium.org/2615533006 .
 2017-01-05 10:00:58 -08:00
Vyacheslav Egorov 8360a89fce Gardening: mark language/regress_28255_test SkipByDesign in configurations without mirrors. 
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2610163005 .
 2017-01-05 17:12:05 +01:00
Bob Nystrom 45b771f946 Remove tests for generalized tear-offs. 
R=mit@google.com

Review-Url: https://codereview.chromium.org/2608363002 .
 2017-01-04 10:14:41 -08:00
Lasse Reichstein Holst Nielsen 775eb3bd23 Also expect errors in dartium for null-as-bottom tests 
Review-Url: https://codereview.chromium.org/2614713002 .
 2017-01-04 15:45:09 +01:00
Lasse R.H. Nielsen cbf69e80b4 Add test for Nullable-By-Default (Null is subtype of all types). 
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2577083002 .
 2017-01-04 14:20:30 +01:00
Lasse R.H. Nielsen 44594277e1 Make core libraries use generic method syntax. 
Removes comment syntax where possible for the following platform libraries:
* async
* collection
* convert
* core
* internal
* io
* math

The HTML related libraries are not changed. The templates used to build them
must be changed as well.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/68818315b5cc6c63fea0e10e90f515f6083ec095
Committed: https://github.com/dart-lang/sdk/commit/3f74b8d82edca8c342c43306714e68ddf84548e1
Review-Url: https://codereview.chromium.org/2529393002 .
 2017-01-03 12:05:40 +01:00
Siva Annamalai c78cb290df Adjust co19 status files for dartium. 
Review-Url: https://codereview.chromium.org/2607223002 .
 2016-12-29 15:12:22 -08:00
Siva Annamalai c69cbb586f - report tear offs using the x#y syntax as a compilation error 
(fixes issue 27520)
- adjust status files to reflect all tests which have the x#y syntax as
  compile time errors.

BUG=27520
R=regis@google.com

Review-Url: https://codereview.chromium.org/2607173002 .
 2016-12-29 13:01:12 -08:00
Johnni Winther f6b5361adb Support for Null as bottom in dart2js 
Closes #28026

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2595363002 .
 2016-12-22 15:01:33 +01:00
Kasper Lund 64a0188ac3 Revert "Runtime support for Null as any in dart2js". 
This caused failures on vm-kernel* and vm-precomp* bots.

This reverts commit 0a1ed5fab4.

TBR'ed.

R=johnniwinther@google.com
BUG=

Review-Url: https://codereview.chromium.org/2597943002 .
 2016-12-22 09:29:17 +01:00