dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
44,997 Commits 2 Branches 0 Tags
8166deb009cfb8d54798cd2afc43094de5694747
Commit Graph

607 Commits

Author SHA1 Message Date
Zachary Anderson 0111122ca0 [Fuchsia] Update test status files 
R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2693643002 .
 2017-02-10 21:34:33 -08:00
Brian Wilkerson 2ee2fe9b5c [Gardening] Disable running strong-mode analyzer tests in code that is not strong mode clean 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2679553003 .
 2017-02-06 13:26:39 -08:00
Martin Kustermann 89de0c9267 Reland "VM: Fix memory leaks during isolate spawning" 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2649283003 .
 2017-01-24 12:04:41 +01:00
Martin Kustermann 50150deaf6 Revert "VM: Fix memory leaks during isolate spawning" 
This reverts commit d7e884b05f.

Review-Url: https://codereview.chromium.org/2654443003 .
 2017-01-24 10:32:59 +01:00
Martin Kustermann d7e884b05f VM: Fix memory leaks during isolate spawning 
Fixes #28351

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2650693004 .
 2017-01-24 09:59:13 +01:00
Ryan Macnak 26a364f998 Support spawnUri in app snapshots. 
- Don't mark core_isolate_snapshot_buffer as a const pointer.
 - Update app snapshots without code to not rewrite the VM isolate snapshot, as already done by app snapshots with code.

Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2637193002 .
 2017-01-17 15:59:41 -08:00
Ryan Macnak 12a3699301 Revert "Support spawnUri in app snapshots." 
Failures on IA32.

This reverts commit c6ecfe1746.

Review-Url: https://codereview.chromium.org/2631893002 .
 2017-01-13 15:52:36 -08:00
Ryan Macnak c6ecfe1746 Support spawnUri in app snapshots. 
Don't mark core_isolate_snapshot_buffer as a const pointer.

Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2623423007 .
 2017-01-13 15:18:27 -08:00
Ryan Macnak f89056f6cd Revert "Support spawnUri in app snapshots." 
This reverts commit 593d4504b0.
This reverts commit 113aa64b98.
This reverts commit 422afa2ead.

Review-Url: https://codereview.chromium.org/2633543003 .
 2017-01-13 11:02:44 -08:00
Ryan Macnak 593d4504b0 Support spawnUri in app snapshots. 
Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2628283002 .
 2017-01-13 10:37:51 -08:00
Lasse Reichstein Holst Nielsen bd743e2187 Mark isolate/browser/package_resolve_browser_test as failing. 
Update status files wrt. issue #28382.

BUG= http://dartbug.com/28382

Review-Url: https://codereview.chromium.org/2628873008 .
 2017-01-13 16:11:36 +01:00
Terry Lucas 657720d125 Temporarily disable test under windows 
TBR=sigmund@google.com

Review-Url: https://codereview.chromium.org/2629573003 .
 2017-01-12 09:10:45 -08:00
Florian Schneider bef4967ea1 Remove dart_noopt and related parts from the VM. 
dart_noopt is not needed anymore because we have testing
and builbot integration of the real precompilation pipeline in place now.

Fixes #24569
Fixes #25726
Fixes #25845

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2624393002 .
 2017-01-11 16:55:55 -08:00
Ryan Macnak 68ac06f742 Triage isolate spawning ASAN failures. 
Issue #28351

Review-Url: https://codereview.chromium.org/2628113002 .
 2017-01-11 16:20:19 -08:00
Terry Lucas 559ae993d1 Added VMLibraryHooks setup for Dartium to support resolvePackageUri. 
BUG=25594
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2611353002 .
 2017-01-10 07:25:10 -08:00
Jennifer Messerly 816592a941 fixes #28236, generic methods should not cause warnings in Dart 1 
Instantiate universal functions in subtype tests & tear-offs. Also updates the status files and one Analyzer test that covered the tear-off type.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2621433003 .
 2017-01-09 12:46:20 -08:00
Lasse R.H. Nielsen 44594277e1 Make core libraries use generic method syntax. 
Removes comment syntax where possible for the following platform libraries:
* async
* collection
* convert
* core
* internal
* io
* math

The HTML related libraries are not changed. The templates used to build them
must be changed as well.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/68818315b5cc6c63fea0e10e90f515f6083ec095
Committed: https://github.com/dart-lang/sdk/commit/3f74b8d82edca8c342c43306714e68ddf84548e1
Review-Url: https://codereview.chromium.org/2529393002 .
 2017-01-03 12:05:40 +01:00
Sigmund Cherem 98a3c52575 mark a couple flaky tests 
Review-Url: https://codereview.chromium.org/2600463004 .
 2016-12-22 16:21:06 -08:00
Lasse R.H. Nielsen 283bba0944 Revert "Let Isolate.errors close on isolate exit." 
This reverts commit aeb544351e.

Wasn't ready for landing yet, and triggers bug in VM.

Review URL: https://codereview.chromium.org/2563723003 .
 2016-12-09 13:02:20 +01:00
Lasse R.H. Nielsen aeb544351e Let Isolate.errors close on isolate exit. 
It's not perfect because it won't catch an isolate exit that happens while nobody is listening.

Add test.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2555493003 .
 2016-12-09 13:00:43 +01:00
Sigmund Cherem 0cb170488c Update failing chrome tests after chrome 55 roll (issue #27991), also update a 
status comment.

Review URL: https://codereview.chromium.org/2557533002 .
 2016-12-05 14:38:01 -08:00
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'. 
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
 2016-12-01 16:47:33 -08:00
William Hesse 6f7005ee71 Update status for co19 tests on browsers. 
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2538443002 .
 2016-11-28 16:32:41 +01:00
Erik Ernst 4912fd1501 Make initializing formal access available by default 
This CL changes dart2js such that the effect that we used to get with
option '--initializing-formal-access' is now obtained unconditionally,
i.e., that extension is now enabled by default.

dart2js will continue to accept the option, such that scripts passing
the option will not break.

The CL is _not_ intended to be landed at this time, the plan is to
enable the feature in a coordinated manner when all tools are ready.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2141023002 .
 2016-11-25 10:15:21 +01:00
Ryan Macnak 12de13d1ae An isolate created with spawn function doesn't necessarily agree with its parent on the library private keys. 
(The long-standing issue that spawn function should use snapshots would also fix this.)

Encountered by the analyzer in https://codereview.chromium.org/2492933002/

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2509413002 .
 2016-11-23 15:36:01 -08:00
Johnni Winther 03bf746918 Remove static clues from spawn_uri_child_isolate.dart 
- the tests should be able to work without it.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2497293003 .
 2016-11-15 13:19:29 +01:00
Sigmund Cherem 2bec7b5adb Skip package-resolution tests in dartium 
TBR=lrn@google.com

Review URL: https://codereview.chromium.org/2500203002 .
 2016-11-14 15:18:47 -08:00
Sigmund Cherem f460a8706d Add implementation of Isolate.resolvePackageUri for dart2js. 
This uses 'packages/' as the default base to resolve uris from, but also exposes
a hook to allow users to overwrite it.

BUG= https://github.com/dart-lang/sdk/issues/25594
R=het@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/2495383003 .
 2016-11-14 15:11:49 -08:00
Florian Schneider a74262c0e9 Enable now-passing tests for Android precompilation 
Remove other obsolete entries.

Fixes #26373.
Fixes #27378.

R=rmacnak@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/2431163007 .
 2016-10-21 12:16:47 -07:00
Sigmund Cherem f6680d13a2 One more round of status file updates to get the bots green. 
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2285213003 .
 2016-08-29 08:14:33 -07:00
Sigmund Cherem 342eb3f296 Additional status file fixes 
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2283273002 .
 2016-08-26 18:29:19 -07:00
Sigmund Cherem 13a090a879 More status fixes 
TBR=sra@google.com,het@google.com

Review URL: https://codereview.chromium.org/2280193002 .
 2016-08-26 13:46:14 -07:00
Sigmund Cherem fc0bf7a85b First set of test triage for fast-startup 
Review URL: https://codereview.chromium.org/2285823002 .
 2016-08-26 10:04:41 -07:00
Florian Schneider 021ebb2033 Correct and GC unrecognized flags from our tests. 
Fix some misspelled flags.

Remove some non-existent flags.

Fix --short_socket_read and --short_socket_write flags used in IO tests.

Running with --ignore-unrecognized-flags is still on because some flags are only visible
in DEBUG mode.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2247733005 .
 2016-08-15 18:28:11 -07:00
John McCutchan 268082769b Initial status file updates for $hot_reload_rollback 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2207653002 .
 2016-08-02 11:03:44 -07:00
John McCutchan f79756b88d Hot reload status file updates 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2164063002 .
 2016-07-20 11:02:23 -07:00
John McCutchan 7fa9393105 Remove windows debug print and trace shutdown on some tests 
BUG=

Review URL: https://codereview.chromium.org/2153813003 .
 2016-07-15 14:53:54 -07:00
John McCutchan c692a64e5a Rework how enums are implemented and reloaded 
- Enum instances now hold their index and their label. Before the labels were held in a static array to the side and the index was used to look up the label.

- Before and after reload enum instances are now paired (by label) and put into the 'become' table.

Fixes https://github.com/dart-lang/sdk/issues/26877

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2153143002 .
 2016-07-15 10:52:20 -07:00
John McCutchan 6c27b6e381 Tweak for hot reload status file 
Enum identity tests can sometimes pass.

BUG=

Review URL: https://codereview.chromium.org/2147183003 .
 2016-07-14 07:56:56 -07:00
John McCutchan c6141005a9 More status file updates for hot reload 
BUG=

Review URL: https://codereview.chromium.org/2151743003 .
 2016-07-14 07:14:25 -07:00
Todd Turnidge 77b99396e8 Disallow deferred loading when using isolate reloading. 
Update status files.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2144113002 .
 2016-07-13 15:25:06 -07:00
John McCutchan 04dc67e2b3 More hot reload status file updates 
BUG=

Review URL: https://codereview.chromium.org/2143213002 .
 2016-07-12 13:54:16 -07:00
John McCutchan 24a0988df6 Hot reload fixes for isolate tests 
- [x] Bump maximum number of vm arguments (fixes a bunch of reload crashes....)
- [x] Only check that an isolate has reload if it was ever runnable.
- [x] Skip some isolate tests that use deferred libraries or are checking for closure identity.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2141763002 .
 2016-07-11 13:58:26 -07:00
Lasse R.H. Nielsen 191ab42d64 Make VM resolvePackageUri fail on package:foo and package:/foo. 
R=asiva@google.com, floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/eb49613cbfaca2167b124ab01064a2412ff844a5

Review URL: https://codereview.chromium.org/1998603002 .
 2016-06-14 12:22:15 +02:00
Ryan Macnak ef8baa8760 Add test harness option for app snapshots with unoptimized code. 
./tools/test.py -m all -c dart2appjit -r dart_app --use-blobs

Rename 'dart_product' runtime to 'dart_app'.

Rename Dart_PrecompiledJITSnapshotBlob to Dart_CreateAppJITSnapshot and add documentation.

Remove out-of-date scripts in tools/precompilation.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/1992703005 .
 2016-05-26 10:37:47 -07:00
Ryan Macnak 7d3cd143f7 Update status for 
./tools/test.py -mall
  ./tools/test.py -mdebug,release --checked
  ./tools/test.py -mrelease,product -cdart2app -rdart_product
  ./tools/test.py -mrelease --checked -cdart2app -rdart_product

Missing
  ./tools/test.py -mdebug -cdart2app -rdart_product
  ./tools/test.py -mdebug --checked -cdart2app -rdart_product

R=asiva@google.com

Review URL: https://codereview.chromium.org/1991543002 .
 2016-05-18 12:54:34 -07:00
Florian Schneider b349c2cbd6 Temporarily update test status for Android 
BUG=
R=kustermann@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/1924833003 .
 2016-05-02 11:19:43 +02:00
Ivan Posva 3b2a695d71 - Properly return null if an unknown package is resolved. 
- Allow short form package:foo imports.

R=asiva@google.com

Review URL: https://codereview.chromium.org/1822863002 .
 2016-03-22 09:02:04 -07:00
Sigmund Cherem 385f3350c5 Update status of cpsir tests in checked mode: skipping for now, since more than 
75% fail for one reason, once we fix that we can triage in more detail.

Review URL: https://codereview.chromium.org/1771893002 .
 2016-03-07 10:20:41 -08:00
Ryan Macnak e880063e88 Include the canonical static closure when serializing ClosureData. 
BUG=http://dartbug.com/25892
R=asiva@google.com

Review URL: https://codereview.chromium.org/1771483002 .
 2016-03-07 09:06:26 -08:00