dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
44,997 Commits 2 Branches 0 Tags
8166deb009cfb8d54798cd2afc43094de5694747
Commit Graph

14254 Commits

Author SHA1 Message Date
Kevin Millikin 8166deb009 Mark vm/lazy_deopt_vm_test as slow 
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2722113002 .
 2017-03-01 11:27:48 +01:00
Vyacheslav Egorov 8e267b29c1 Update status files for debug mode dartk/dartkp. 
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2722103002 .
 2017-03-01 10:31:42 +01:00
Jacob Richman a6a206062d Custom formatter cleanup Fix case where displaying a class constructor generated unreadable huge output. Fix case where exceptions were throw. Correct display of statics, fix indentation bugs. Add improved custom formatter test to main repro. As a drive by fix, switch hashCode to use a symbol instead of the name $identityHash as $identityHash was making custom formatter test output unstable. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2703263002 .
 2017-02-28 17:47:53 -08:00
Stephen Adams 1ae1ec7df4 Remove HRuntimeType implementation 
Use the legacy RTI format, which should be replaced with something that lets types and tests be cached and amortized.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2722753002 .
 2017-02-28 09:33:32 -08:00
Asger Feldthaus 3a7529a363 Remove status file sections for the CPS IR. 
BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/2d6c90a6b3d6d1be5095e12a0a633305e1d5db2a
Review-Url: https://codereview.chromium.org/2720513006 .
 2017-02-28 17:11:19 +01:00
Asger Feldthaus e7b9672b3e Revert "Remove status file sections for the CPS IR." 
This reverts commit 2d6c90a6b3.

BUG=

Review-Url: https://codereview.chromium.org/2720283002 .
 2017-02-28 17:08:04 +01:00
Peter von der Ahé 2e0e3b918f Always provide a field for context. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2723513002 .
 2017-02-28 16:49:19 +01:00
Jens Johansen 773e90869c [Fasta] Save parent in TypeDeclarationBuilder 
I get errors with library parent not set for some tests
(e.g. service tests). This fixes that.

BUG=
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2726533002 .
 2017-02-28 15:02:21 +01:00
Asger Feldthaus 2d6c90a6b3 Remove status file sections for the CPS IR. 
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2720513006 .
 2017-02-28 14:40:06 +01:00
Kevin Millikin b31e24f33a Update a test expectation. 
A pair of tests that were crashing the front end are now passing.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2718203003 .
 2017-02-28 13:03:54 +01:00
Stephen Adams e4ffa70ba5 Redo "Flush deferred action queue" 
This is https://github.com/dart-lang/sdk/commit/8eedb9c6527f955413e47c9350d3c5114cd89942 plus status file updates

TBR=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2726463002 .
 2017-02-27 21:10:36 -08:00
Vyacheslav Egorov 1c7cb7c5e9 VM: remove service_object_patch.dart and all associated code. 
This deletion has several reasons:

- This code is broken and refers to non-existant private parts of dart:io
(e.g. `_NativeSocket._sockets`, `_ProcessImpl._processes`, `_RandomAccessFile._files`).

- This code is not reachable through the service protocol. `_serviceObjectHandler` uses
`paths` to fetch the right handler from `_servicePathMap` but caller `ServiceGetIOHandler`
always passes empty paths.

- The only test that was attempting to test some of this code through mirrors (sic!)
has been disabled since January 2015.

After deletion all tests continue to pass meaning that nobody really relies on this
broken code in any way.

BUG=https://github.com/dart-lang/sdk/issues/28882
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2715253002 .
 2017-02-27 16:08:16 +01:00
Erik Ernst a40a1ee5db Added more double reporting tests to co19-dart2js.status. 
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2715243002 .
 2017-02-27 14:04:35 +01:00
Martin Kustermann ce5906145d Status file update after analyzer->fasta dartk switch 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2721573002 .
 2017-02-27 12:45:02 +01:00
Erik Ernst 7e8674df5d Double reporting test status updated to Skip 
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2720703002 .
 2017-02-27 11:56:29 +01:00
Vyacheslav Egorov de56824429 Switch -c dartk/dartkp configuration to use fasta. 
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2721443002 .
 2017-02-26 20:39:02 +01:00
Stephen Adams ca9581e5cf co19 Status 
co19/Language/Types/Function_Types/call_t01 started crashing due to an assert.
The cause seemed almost unrelated to the change, and can be triggered without the change.
Details at https://github.com/dart-lang/sdk/issues/28894.

TBR=johnniwinther@google.com

BUG=

Review-Url: https://codereview.chromium.org/2713183003 .
 2017-02-24 19:40:33 -08:00
Ben Konyi 68a102cab2 Fixed tests not having MallocHooks initialized for tests in release mode. 
Revert "Revert "Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing a deadlock in the hooks. Also turned off stack trace collection in a test that was timing out as a result of the stack trace collection.""

This reverts commit 1a5b555aa9.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2711353003 .
 2017-02-24 13:56:06 -08:00
Florian Schneider 864166a758 Fix VM crash when parsing a non-existing redirecting constructor 
Fixes #28217.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2710363002 .
 2017-02-24 10:26:31 -08:00
Florian Loitsch d0dc7be4a1 Use a confuse function. 
Review-Url: https://codereview.chromium.org/2712603006 .
 2017-02-24 13:35:20 +01:00
Jens Johansen 26b6ecdf63 Enable causal stacktrace in kernel 
R=kmillikin@google.com, kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/b29829660bcdee7eb394e6fd4635ff7a6a77ef01
Review-Url: https://codereview.chromium.org/2690873005 .
 2017-02-24 12:11:30 +01:00
Ben Konyi 1a5b555aa9 Revert "Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing a deadlock in the hooks. Also turned off stack trace collection in a test that was timing out as a result of the stack trace collection." 
This reverts commit 44a9a4ede3.

BUG=

Review-Url: https://codereview.chromium.org/2714083002 .
 2017-02-23 19:21:00 -08:00
Ben Konyi 44a9a4ede3 Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing a deadlock in the hooks. Also turned off stack trace collection in a test that was timing out as a result of the stack trace collection. 
Updated MallocHooks to collect stack traces when memory is allocated.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2718523003 .
 2017-02-23 18:58:50 -08:00
Ben Konyi 2b81624bb2 Revert "Revert "[test.dart] Complain if there is non-utf8 formatted data in test output"" 
This reverts commit 7af8f320a7.

TBR=zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2710603009 .
 2017-02-23 17:08:15 -08:00
Ben Konyi 7af8f320a7 Revert "[test.dart] Complain if there is non-utf8 formatted data in test output" 
This reverts commit c294dec5e6.

TBR=zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2705213006 .
 2017-02-23 16:57:31 -08:00
Zachary Anderson 3dc6a628b8 Fix standalone status file 
Review-Url: https://codereview.chromium.org/2716753002 .
 2017-02-23 15:23:11 -08:00
Zach Anderson c294dec5e6 [test.dart] Complain if there is non-utf8 formatted data in test output 
related #28872

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2710003005 .
 2017-02-23 14:15:26 -08:00
Florian Schneider 1b3a53883c Add missing abstract modifier. 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2714783003 .
 2017-02-23 13:44:23 -08:00
Florian Schneider 521526d259 Fixup redefinitions before doing code motion 
Also use redefined receiver consistently when inlining recognized methods.

This CL re-enables type propagation from CheckClassId instructions which
was disabled as a temporary stop-gap to prevent illegal code motion.
(reverts https://codereview.chromium.org/1928633002)

Now uses of redefined values that are dominated by the redefinition are renamed before doing LICM.

Related to #26347.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2709093003 .
 2017-02-23 12:34:55 -08:00
John McCutchan 88b68b30b4 Don't inline functions that the parser decides shouldn't be inlined. 
Fixes #28857
Fixes #28759

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2713593004 .
 2017-02-23 12:32:44 -08:00
Peter von der Ahé 961f710c05 More double reporting tests. 
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2712883004 .
 2017-02-23 16:51:50 +01:00
Peter von der Ahé e4738554be Skip further double reporting tests. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2707033007 .
 2017-02-23 16:29:51 +01:00
Florian Loitsch 979183decf Add support for the new function-type syntax. 
Fixes #27967
BUG= http://dartbug.com/27967
R=ahe@google.com, johnniwinther@google.com, paulberry@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/85227ba8a60332a18ae92cb1b87bf15d52a909bd
Reverted: https://github.com/dart-lang/sdk/commit/f5fc210f4f79f7e6b7ccefc24e7565e810e9dc7d
Committed: https://github.com/dart-lang/sdk/commit/e4999a631093690febb2eb90cbdbe1f9d5183455
Reverted: https://github.com/dart-lang/sdk/commit/c64c35153905fc2bf8a74c02297220385cfcbc87
Committed: https://github.com/dart-lang/sdk/commit/c289af39c36d9a5f7130a3e69b7891052652a64e
Reverted: https://github.com/dart-lang/sdk/commit/c66479f40767744d0bdd027c004583d6e32fe50f
Review-Url: https://codereview.chromium.org/2567133002 .
 2017-02-23 13:36:28 +01:00
Asger Feldthaus 2f331ecd1b Fix two issues with modular compilation in dartk. 
- The interface for a factory constructor in an external library would
  reference the class type parameters instead of its own.

- When a class from an external library gets promoted to mixin level,
  the rest of the library should not be considered "being loaded".
  This would cause members to not get added to the AST.

BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2710783004 .
 2017-02-23 12:38:20 +01:00
Peter von der Ahé 46576226ee Skip double reporting tests on dart2js configurations. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2709613010 .
 2017-02-23 12:25:30 +01:00
Peter von der Ahé bf12208dba Skip standalone/io/console_unicode_test on Android. 
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2711913002 .
 2017-02-23 11:57:50 +01:00
Zach Anderson 30da80fb17 [dart:io][windows] Set up CRT error handling behavior 
fixes #28852

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2710103002 .
 2017-02-22 13:55:07 -08:00
Florian Loitsch c66479f407 Revert "Add support for the new function-type syntax." 
This reverts commit c289af39c3.

BUG=

Review-Url: https://codereview.chromium.org/2710973002 .
 2017-02-22 17:19:35 +01:00
Florian Loitsch c289af39c3 Add support for the new function-type syntax. 
Fixes #27967
BUG= http://dartbug.com/27967
R=ahe@google.com, johnniwinther@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/85227ba8a60332a18ae92cb1b87bf15d52a909bd

Reverted: https://github.com/dart-lang/sdk/commit/f5fc210f4f79f7e6b7ccefc24e7565e810e9dc7d

Committed: https://github.com/dart-lang/sdk/commit/e4999a631093690febb2eb90cbdbe1f9d5183455

Reverted: https://github.com/dart-lang/sdk/commit/c64c35153905fc2bf8a74c02297220385cfcbc87
Review-Url: https://codereview.chromium.org/2567133002 .
 2017-02-22 16:53:49 +01:00
Dmitry Olshansky 54b56606d5 Fix analyser warnings 
TBR=kustermann@google.com

Review-Url: https://codereview.chromium.org/2709213002 .
 2017-02-22 15:13:54 +01:00
Dmitry Olshansky 38c487b4df Adjust test to run on no-IPv6 machines, update status file 
Currently crashes in precompiled debug mode.

R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2709013004 .
 2017-02-22 14:41:17 +01:00
Zach Anderson bc07953866 [dart:io][windows] Make unicode characters display correctly. 
This change has two pieces.
- Set the console code page to UTF8.
  - This makes strings printed with print() display correctly
- Set the file translation mode to _O_WTEXT when writing to a
  stdout or stderr that is connected to a console.
  - This makes strings printed with e.g. stdout.writeln()
    display correctly.

fixes #28571

R=asiva@google.com, fschneider@google.com

Review-Url: https://codereview.chromium.org/2698813002 .
 2017-02-21 22:47:03 -08:00
Karl Klose d776ae6ce0 [Gardening] Mark time-dependent spawn tests flaky on all vm configurations 
R=jensj@google.com

Review-Url: https://codereview.chromium.org/2703383002 .
 2017-02-21 15:20:29 +01:00
Karl Klose 958e9c005c [Gardening] Mark two more standalone tests as flaky on dart2analyzer 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2706973003 .
 2017-02-21 13:22:44 +01:00
Karl Klose 1f85264164 [Gardening] Mark two standalone/io/http tests as flaky on dart2analyzer 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2711433002 .
 2017-02-21 11:20:00 +01:00
Johnni Winther 9a1ceea706 Split backend implementation of EnqueuerListener 
- into a EnqueuerListenerBase with subclasses ResolutionEnqueuerListener and CodegenEnqueuerListener

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2693163002 .
 2017-02-20 12:49:09 +01:00
Johnni Winther 8ffeb45db5 Move global dependencies to BackendUsage 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2696483005 .
 2017-02-20 12:16:28 +01:00
Johnni Winther 4ada4dbb99 Introduce EnqueuerListener 
- to abstract the JavaScriptBackend coupling to Enqueuer

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2693893003 .
 2017-02-20 11:53:39 +01:00
Johnni Winther ebaff3dc66 Extract BackendUsage, MirrorsData, and CheckedModeHelpers from Backend. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2688413003 .
 2017-02-20 11:44:14 +01:00
Johnni Winther c94162a20f Add MultiSourceInformationStrategy 
- generate sourcemap for both engines using --use-multi-source-info

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2690083002 .
 2017-02-20 11:36:15 +01:00