dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
44,997 Commits 2 Branches 0 Tags
8166deb009cfb8d54798cd2afc43094de5694747
Commit Graph

488 Commits

Author SHA1 Message Date
Ryan Macnak cfe5e5f075 Include metadata in AOT to expand inline frames in stack traces and provide line numbers. 
Also fix stack trace collection to always include invisible frames. It can happen that a visible function is inlined into an invisible function, and we don't expand inlined frames until we print a stack trace.

dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418 (+16%)
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624
Total(CodeSize): 17785396 (+12%)

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2687143005 .
 2017-02-13 10:27:36 -08:00
Matthias Hausner 74da383d6f Delete Breakpoint objects, fixing memory leak 
Delete Breakpoint objects from the C heap when they are no longer needed.
Also delete inactive code breakpoint objects more aggressively.

This should fix the memory leaks reported in #28348.

General cleanup of breakpoint handling code and comments.

BUG=#28348
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2689623002 .
 2017-02-10 10:43:24 -08:00
Ryan Macnak b15b98bcc3 Reapply "Use CodeSourceMap for stack traces (still JIT only)." 
- Fix missing null termination in initialization of ZoneTextBuffer.
 - Merge with John's async stack trace changes.

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2686813006 .
 2017-02-09 18:03:41 -08:00
Ryan Macnak 15a9eafb77 Revert "Reapply "Use CodeSourceMap for stack traces (still JIT only)."" 
This reverts commit bee82fef8b.

Revert "Use zone memory for StackTrace::ToCString."

This reverts commit 4e8b265ea0.

The later CL somehow caused hangs in some service tests.

Review-Url: https://codereview.chromium.org/2683033007 .
 2017-02-09 13:14:01 -08:00
Ryan Macnak bee82fef8b Reapply "Use CodeSourceMap for stack traces (still JIT only)." 
Include CodeSourceMaps in app-jit snapshots.

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2686623006 .
 2017-02-08 16:43:47 -08:00
Brian Wilkerson 2ee2fe9b5c [Gardening] Disable running strong-mode analyzer tests in code that is not strong mode clean 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2679553003 .
 2017-02-06 13:26:39 -08:00
Ben Konyi f2fd150ea0 Added new type of unit test, RAW_UNIT_TEST_CASE, which is used for tests that can be flaky if run while the VM is alive. Tests created using the RAW_UNIT_TEST_CASE macro will run after the VM has shutdown to avoid having any worker threads contaminating the test results. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2666133002 .
 2017-01-31 15:16:38 -08:00
Todd Turnidge efcdcb7709 Add Debugger_Rewind_Optimized test. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2664303002 .
 2017-01-31 13:52:23 -08:00
Todd Turnidge bbc2ac93a3 Start adding vm/cc tests for rewind functionality. 
These will make it easier to debug rewind on simdbc64.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2662333002 .
 2017-01-31 12:02:26 -08:00
Ben Konyi 1bb198ccc7 Updated status file to allow malloc hook tests to fail while they are being de-flakified. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2663873002 .
 2017-01-30 11:06:16 -08:00
Siva Annamalai 9a4d616c35 Fix status files to correctly account for asan failure in x64 target only. 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2657953002 .
 2017-01-25 16:12:52 -08:00
John McCutchan a47af8ea9e Fix memory leaks in cc/Log_* tests 
Fixes #28347

BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2651013002 .
 2017-01-25 13:32:28 -08:00
Zachary Anderson 82bddc3614 Fuchsia: Update vm and language status files 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2651803004 .
 2017-01-24 22:03:18 -08:00
Ben Konyi cfd27042da Fixed incorrect update to status file 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2654933002 .
 2017-01-24 14:24:10 -08:00
Ben Konyi ff5f6147bc Gardening: updated status file to deal with flaky cc/UseDartApi test randomly crashing. See issue 28499. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2651673007 .
 2017-01-24 12:33:28 -08:00
Martin Kustermann a9fbe2004d VM: Tell lsan about mmap()ed regions used for our heap 
The mmap()ed pages hold pointers to `VirtualMemory` objects. So we tell
lsan that the mmap()ed regions are roots.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2646363005 .
 2017-01-24 12:47:36 +01:00
John McCutchan dc83d0ad7a Use a better stack bound in DartEntry::InvokeFunction 
Fixes https://github.com/dart-lang/sdk/issues/28282
Fixes https://github.com/dart-lang/sdk/issues/28304

BUG=
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2639673003 .
 2017-01-18 06:43:21 -08:00
Ryan Macnak 26a364f998 Support spawnUri in app snapshots. 
- Don't mark core_isolate_snapshot_buffer as a const pointer.
 - Update app snapshots without code to not rewrite the VM isolate snapshot, as already done by app snapshots with code.

Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2637193002 .
 2017-01-17 15:59:41 -08:00
Ryan Macnak 12a3699301 Revert "Support spawnUri in app snapshots." 
Failures on IA32.

This reverts commit c6ecfe1746.

Review-Url: https://codereview.chromium.org/2631893002 .
 2017-01-13 15:52:36 -08:00
Ryan Macnak cf3e91fe39 Fix leaked script in cc/EmbeddedScript. 
Fixes #28345.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2630863002 .
 2017-01-13 15:28:42 -08:00
Ryan Macnak c6ecfe1746 Support spawnUri in app snapshots. 
Don't mark core_isolate_snapshot_buffer as a const pointer.

Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2623423007 .
 2017-01-13 15:18:27 -08:00
Ryan Macnak 89986c0b03 Fix memory leak in ServiceTestMessageHandler. 
Guard against potential double-free.

Fixes #28342

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2629413003 .
 2017-01-13 15:08:02 -08:00
Ryan Macnak f89056f6cd Revert "Support spawnUri in app snapshots." 
This reverts commit 593d4504b0.
This reverts commit 113aa64b98.
This reverts commit 422afa2ead.

Review-Url: https://codereview.chromium.org/2633543003 .
 2017-01-13 11:02:44 -08:00
Ryan Macnak 593d4504b0 Support spawnUri in app snapshots. 
Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2628283002 .
 2017-01-13 10:37:51 -08:00
Florian Schneider bef4967ea1 Remove dart_noopt and related parts from the VM. 
dart_noopt is not needed anymore because we have testing
and builbot integration of the real precompilation pipeline in place now.

Fixes #24569
Fixes #25726
Fixes #25845

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2624393002 .
 2017-01-11 16:55:55 -08:00
Ryan Macnak f12527455d Fix leaks in some parsers tests and triage remaining cc tests. 
Issue #28342
Issue #28345
Issue #28347
Issue #28348
Issue #28349

R=zra@google.com

Review-Url: https://codereview.chromium.org/2627713005 .
 2017-01-11 13:12:32 -08:00
Zachary Anderson a1579c6a45 Fuchsia: Implement recursive delete 
Currently, readdir() doesn't fill out d_type correctly, so we just do
an extra stat() to get the file type.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2621093002 .
 2017-01-10 15:08:39 -08:00
Zachary Anderson a5d8a2f365 Fuchsia: Adds support for Process.kill() 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2619233003 .
 2017-01-09 15:57:41 -08:00
Regis Crelier f5c80237e3 Status update: profiler tests pass on windows x64 debug, but one crashes on 
mac debug x64.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2621583003 .
 2017-01-09 13:43:38 -08:00
Ryan Macnak 422b0c47fe Refine suppressions for issue 28304. 
Review-Url: https://codereview.chromium.org/2622593004 .
 2017-01-09 10:35:24 -08:00
Ryan Macnak ccd6cc7fc5 Change GN debug builds to use -O2, which is the value used by GYP. 
Running the language tests in debug mode, I got the following times
GYP -O2 1:50
GN -O1 4:48
GN -O2 1:55

R=zra@google.com

Review-Url: https://codereview.chromium.org/2614003003 .
 2017-01-09 09:09:40 -08:00
Florian Schneider f995513880 Temorarily update status for two flaky tests 
Filed issues #28198 and #28197.

Review-Url: https://codereview.chromium.org/2600543003 .
 2016-12-23 14:05:59 +01:00
Zachary Anderson 1f99052303 Fuchsia: Adds File::Copy() 
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2591523002 .
 2016-12-20 09:44:08 -08:00
Zachary Anderson 918b90ba46 Fuchsia: implement Process::Wait() for Process.runSync() 
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2591473004 .
 2016-12-20 09:30:00 -08:00
Zachary Anderson 1f289fc12b Fuchsia: resolve executable name, fetch environment vars 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2581363002 .
 2016-12-16 21:23:20 -08:00
Zachary Anderson 846a73e262 Fuchsia: Directory listing 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2579483002 .
 2016-12-14 15:06:27 -08:00
Zachary Anderson 32e5ef787d Fuchsia: dart:io Processes 
This change adds support for non-detached processes
spawned with Process.run and Process.start (but not Process.runSync).

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2563463002 .
 2016-12-13 11:09:55 -08:00
John McCutchan f125cc7d0b Improve the casing of Stackmap and Stacktrace. 
- [x] Stackmap -> StackMap
- [x] Stacktrace -> StackTrace

This makes us consistent with the Dart language (StackTrace) and
corrects the casing of StackMap.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2572563004 .
 2016-12-12 14:51:30 -08:00
Ben Konyi 0d16859d87 Updated SimpleManyTasksWithZones test to not use PrintJSONForVM 
Fixed test to not use PrintJSONForVM to get isolate information since it only returns @Isolates. Also removed some unnecessary comments and checks for isolate ids.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2567153002 .
 2016-12-12 13:35:43 -08:00
John McCutchan cd116d861b Fix service tests 
BUG=

Review-Url: https://codereview.chromium.org/2568963002 .
 2016-12-12 12:43:01 -08:00
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'. 
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
 2016-12-01 16:47:33 -08:00
Ryan Macnak e60c9d52b6 Fuchsia: Enable newly working socket tests; use MX_CLOCK_UTC. 
R=kulakowski@google.com, zra@google.com

Review URL: https://codereview.chromium.org/2536943002 .
 2016-11-28 15:50:54 -08:00
Siva Annamalai 42e4370818 Adjust status files for some test failures. 
TBR

BUG=

Review URL: https://codereview.chromium.org/2530783002 .
 2016-11-23 22:54:29 -08:00
Siva Annamalai ae7c951b6b Fix status file. 
TBR

BUG=

Review URL: https://codereview.chromium.org/2527613004 .
 2016-11-23 16:44:52 -08:00
Siva Annamalai 22ac70a563 Fix status file 
- Some DBC tests (regexp, field guards) was turned on inadvertantly
 - Skip cc/Profiler_InliningIntervalBoundry on release builds
  (need to figure how to handle the inlining difference between
   debug/release builds)

BUG=

Review URL: https://codereview.chromium.org/2528793003 .
 2016-11-23 16:34:38 -08:00
Siva Annamalai 501720c644 Retry landing cl for issue with TSAN. 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2525103003 .
 2016-11-23 15:40:26 -08:00
Ryan Macnak 8d57e3d540 Enable SecureSocket on Fuchsia using BoringSSL and compiled-in certificates from dart-sdk/root_certificates. 
Implement OS::CurrentTimeMicros in terms of gettimeofday.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2519133005 .
 2016-11-23 10:48:18 -08:00
Siva Annamalai 7bbdbe3541 Skip multiple references to fuchsia test. 
Review URL: https://codereview.chromium.org/2519133007 .
 2016-11-23 09:09:12 -08:00
Siva Annamalai 373aa1980f Skip Fuchsia test on non VM runtimes. 
BUG=#27867

Review URL: https://codereview.chromium.org/2530613002 .
 2016-11-23 09:05:30 -08:00
William Hesse 4bfe727db6 Update status for Firefox 50 
BUG=https://github.com/dart-lang/sdk/issues/27873
BUG=https://github.com/dart-lang/sdk/issues/27872
BUG=https://github.com/dart-lang/sdk/issues/27871
BUG=https://github.com/dart-lang/sdk/issues/27867
R=sortie@google.com

Review URL: https://codereview.chromium.org/2526493004 .
 2016-11-23 09:49:01 +01:00