dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
44,997 Commits 2 Branches 0 Tags
8166deb009cfb8d54798cd2afc43094de5694747
Commit Graph

13884 Commits

Author SHA1 Message Date
Asger Feldthaus af10678cb3 Add source information to the covariance checks inserted for strong mode 
BUG=
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2718363003 .
 2017-03-01 09:51:10 +01:00
danrubel 0c290ae456 echo analysis options information if dartanalyzer --verbose is specified 
With this change, if the dartanalyzer --verbose option is specified
then you will see additional output indicating which analysis options
file was read:

Loaded analysis options from /path/to/.analysis_options

In addition, if there are any command line flags that specify/override
an analysis option then you will see something similar to this:

Analysis options: strong = true

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2726783002 .
 2017-02-28 17:49:43 -08:00
Jacob Richman a6a206062d Custom formatter cleanup Fix case where displaying a class constructor generated unreadable huge output. Fix case where exceptions were throw. Correct display of statics, fix indentation bugs. Add improved custom formatter test to main repro. As a drive by fix, switch hashCode to use a symbol instead of the name $identityHash as $identityHash was making custom formatter test output unstable. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2703263002 .
 2017-02-28 17:47:53 -08:00
Jennifer Messerly fe294f3753 unfork DDC's copy of most SDK libraries 
There's some changes in strong mode errors we may want to follow up on.

Unforks the following: async, collection, convert, core, developer, internal, io, isolate, math, mirrors.

Does not unfork: html, indexed_db, js, js_util, svg, typed_data, web_audio, web_gl, web_sql.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2698353003 .
 2017-02-28 17:10:52 -08:00
Paul Berry 79cce42e38 Add an AST factory method for fieldDeclaration with all optional named parameters. 
Also add 'covariantKeyword' to the Impl constructors and named factories.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2722033002 .
 2017-02-28 16:43:31 -08:00
Paul Berry 8849a29406 Implement AstBuilder.handleOperatorName. 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2723873002 .
 2017-02-28 16:36:03 -08:00
Konstantin Shcheglov 36cec1faef Parse ParenthesizedExpression as Fasta. 
R=paulberry@google.com, ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2726693002 .
 2017-02-28 15:08:23 -08:00
Paul Berry fb1bc6ad83 Add preliminary support for method declarations to AstBuilder. 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2706293014 .
 2017-02-28 15:05:31 -08:00
Paul Berry f55f111d7a Update kompile.status to reflect e260980624 
Commit e260980624 changed some Fasta
tests from "crash" to "fail".

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2725683003 .
 2017-02-28 15:04:03 -08:00
Konstantin Shcheglov 4d4275d36e Replace the sequence isInstanceOf/assign with assist-with-cast in ExpressionParserTestMixin. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2719403004 .
 2017-02-28 14:31:41 -08:00
Konstantin Shcheglov 25fb3dabdb Parse ThisExpression with Fasta. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2719083007 .
 2017-02-28 13:52:01 -08:00
Konstantin Shcheglov e260980624 Parse SuperExpression with Fasta. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2721973002 .
 2017-02-28 13:48:57 -08:00
Konstantin Shcheglov f7d379a494 Run ExpressionParserTestMixin tests with Fasta. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2726543003 .
 2017-02-28 13:33:52 -08:00
Stephen Adams 1ae1ec7df4 Remove HRuntimeType implementation 
Use the legacy RTI format, which should be replaced with something that lets types and tests be cached and amortized.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2722753002 .
 2017-02-28 09:33:32 -08:00
Asger Feldthaus 3a7529a363 Remove status file sections for the CPS IR. 
BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/2d6c90a6b3d6d1be5095e12a0a633305e1d5db2a
Review-Url: https://codereview.chromium.org/2720513006 .
 2017-02-28 17:11:19 +01:00
Asger Feldthaus e7b9672b3e Revert "Remove status file sections for the CPS IR." 
This reverts commit 2d6c90a6b3.

BUG=

Review-Url: https://codereview.chromium.org/2720283002 .
 2017-02-28 17:08:04 +01:00
Peter von der Ahé 2e0e3b918f Always provide a field for context. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2723513002 .
 2017-02-28 16:49:19 +01:00
Kevin Millikin f31b6d5e2c Reland "Track the 'awaiter return' call stack..." 
Original CL: https://codereview.chromium.org/2692803006/

Original commit message:
Tracking the awaiter return call stack:

- [x] Each async function closure now knows who is awaiting on their
return. This is effectively the asynchronous equivalent of the 'frame pointer'.
- [x] Each async* function closure now knows how is listening on their
stream. This is effectively the asynchronous equivalent of the 'frame pointer'.

Detecting uncaught exceptions in async functions:

- [x] Code object keeps a map from :await_jump_var to token position
- [x] Exception Handlers keep track if they are generated (as part of compilation) or directly from user code
- [x] Debugger maps :await_jump_var to a specific try index

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2725623003 .
 2017-02-28 16:13:41 +01:00
Peter von der Ahé 86cad48993 Create Fasta bootstrap test. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2719863003 .
 2017-02-28 15:49:03 +01:00
Jens Johansen 773e90869c [Fasta] Save parent in TypeDeclarationBuilder 
I get errors with library parent not set for some tests
(e.g. service tests). This fixes that.

BUG=
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2726533002 .
 2017-02-28 15:02:21 +01:00
Asger Feldthaus 2d6c90a6b3 Remove status file sections for the CPS IR. 
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2720513006 .
 2017-02-28 14:40:06 +01:00
Lasse R.H. Nielsen 2d137a8375 Mark analyzer test as slow. Has timeout on windows. 
Is slowest test in batch even when it doesn't time out.

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2720873003 .
 2017-02-28 14:10:26 +01:00
Asger Feldthaus ccaff30f00 Fix a type error in reify/transformation/builder.dart. 
A call to toList was missing after .map().

BUG=
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2725623002 .
 2017-02-28 13:38:10 +01:00
Karl Klose 5df5395559 closure conversion: Do not set Context.parent if the value is null 
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2716573002 .
 2017-02-28 11:23:00 +01:00
Karl Klose 5a42bf8062 Support closures in initializers 
Moved the code to modify the current block with context updates to its own class and added another class for context updates in initializer expressions.

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2712473003 .
 2017-02-28 11:16:41 +01:00
Stephen Adams e4ffa70ba5 Redo "Flush deferred action queue" 
This is https://github.com/dart-lang/sdk/commit/8eedb9c6527f955413e47c9350d3c5114cd89942 plus status file updates

TBR=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2726463002 .
 2017-02-27 21:10:36 -08:00
Stephen Adams 07cd6a9f57 Revert "Flush deferred action queue" 
TBR=johnniwinther@google.com
BUG=

Review-Url: https://codereview.chromium.org/2723453004 .
 2017-02-27 21:06:22 -08:00
Peter von der Ahé c2f7f52e42 Run dartfmt on pkg/front_end/lib. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2718113003 .
 2017-02-28 05:52:41 +01:00
Stephen Adams 8eedb9c652 Flush deferred action queue 
It is possible for deferred actions to be queued without enqueing
classes.  This can happen when resolving a typedef for mirrors - a
cyclic check action may be added as the only change.

TBR=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2718253003 .
 2017-02-27 19:12:54 -08:00
Steve Messick b3ed30b822 Add assists to move Flutter widgets up and down one level. 
Fixes:
https://github.com/flutter/flutter-intellij/issues/461

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2724473002 .
 2017-02-27 15:03:51 -10:00
Konstantin Shcheglov 69063303ac Add support for field formal function typed formal parameters. 
Plus a couple of new tests.

R=paulberry@google.com, ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2720763003 .
 2017-02-27 14:01:26 -08:00
Konstantin Shcheglov b86388e3ed Support for function typed formal parameters. 
R=paulberry@google.com, ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2715203003 .
 2017-02-27 12:50:08 -08:00
Konstantin Shcheglov 6d231ad0ef Extract ExpressionParserText from SimpleParserTest. 
So that we can run this portion of tests with Fasta.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2717233004 .
 2017-02-27 12:47:57 -08:00
Stephen Adams 50b6107eec dart2js: HGetLength may become fixed 
We may not know initially that the input to HGetLength is fixed-length, but discover so later.
Most notably this happens with --trust-type-annotations, since the HTypeKnown for 'trusting' the type hides the underlying type, but it also happens as a consequence of local dataflow and other optimizations.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2713393002 .
 2017-02-27 12:33:21 -08:00
Konstantin Shcheglov 2816c93faf Ask Dart analysis results only for Dart files. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28905

Review-Url: https://codereview.chromium.org/2720023002 .
 2017-02-27 11:50:42 -08:00
pq 8e6817f1da New Completion defaultArgumentListString protocol. 
BUG=
R=brianwilkerson@google.com

See: https://github.com/flutter/flutter-intellij/issues/553.
Review-Url: https://codereview.chromium.org/2719083003 .
 2017-02-27 11:36:30 -08:00
Konstantin Shcheglov 5c0bf9539c Await in DefaultFixContributor.internalComputeFixes() to catch exceptions. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2720013002 .
 2017-02-27 10:40:24 -08:00
Brian Wilkerson c416aabed1 Deprecate the analysis.updateOptions request 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2719853004 .
 2017-02-27 10:37:02 -08:00
Janice Collins 05b00a9884 Add toSource() to ElementAnnotation, ElementAnnotationImpl (issue 28631) 
This is the dartdoc-required case only.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2713243003 .
 2017-02-27 09:22:27 -08:00
Peter von der Ahé 9a84b63402 Revert "Record shebangs as comments." 
This reverts commit c4045d4ce8.

Review-Url: https://codereview.chromium.org/2712383004 .
 2017-02-27 16:34:36 +01:00
Peter von der Ahé c4045d4ce8 Record shebangs as comments. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2711453002 .
 2017-02-27 15:32:39 +01:00
Peter von der Ahé 5ed2a5bc8b Compute correct parent and fileUri for top-level fields. 
Fixes https://github.com/dart-lang/sdk/issues/28884.

R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2722503003 .
 2017-02-27 13:11:03 +01:00
Peter von der Ahé 34be60b663 Use the correct URI for diagnostics during outline construction. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2715223002 .
 2017-02-27 13:07:54 +01:00
Peter von der Ahé 6684a7845c Configure watch list for pkg/front_end. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2723453002 .
 2017-02-27 12:59:50 +01:00
Peter von der Ahé 632c4130fe Use printUnexpected and add location information. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2717673002 .
 2017-02-27 09:28:04 +01:00
danrubel ea4b380f80 fix source restoreUri test 
Review-Url: https://codereview.chromium.org/2717933002 .
 2017-02-26 15:18:38 -08:00
danrubel 00e705835d revert restoreUri test on Windows 
Review-Url: https://codereview.chromium.org/2719803002 .
 2017-02-26 14:52:46 -08:00
danrubel 4ca5ac929a fix MemoryResourceProvider context on Windows 
On Windows, the MemoryResourceProvider.convertPath method
prefixes the path with the C: drive, but the context associated with
the MemoryResourceProvider has a drive letter based upon the underlying
current directory. Most of the time, these two drive letters are the
same, but sometimes, such as on the Windows bot, the current working
directory is on drive E:, rather than drive C:.
This causes package Uris to be mapped to drive E: rather than the
expected drive C:

This CL changes the MemoryResourceProvider constructor
to set the current working directory to C:\ when running on Windows
so that it aligns with MemoryResourceProvider.convertPath.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2714373002 .
 2017-02-26 13:30:42 -08:00
danrubel b401f7272f cleanup bazel workspace relative path test 
Review-Url: https://codereview.chromium.org/2712333002 .
 2017-02-26 13:19:25 -08:00
danrubel 4c771a52d3 fix failing bazel workspace relative path test 
Review-Url: https://codereview.chromium.org/2721483002 .
 2017-02-26 12:44:28 -08:00