dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
37,728 Commits 2 Branches 0 Tags
7f4e76a4048bf2180d229ee5c0b4d570bfe00a18
Commit Graph

1501 Commits

Author SHA1 Message Date
Jaime Wren b13f1fe313 Code completion API refactoring: replace resolveExpression(Expression) with resolveContainingExpression(AstNode) and resolveContainingStatement(AstNode) 
R=danrubel@google.com

Review URL: https://codereview.chromium.org/1898983004 .
 2016-04-20 13:13:14 -07:00
Paul Berry 8f9defbb50 Move InheritanceManager to its own file. 
No changes other than code motion.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1903663003 .
 2016-04-20 08:58:00 -07:00
Brian Wilkerson f3b177e481 Remove references to and uses of MemberMap 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1893313004 .
 2016-04-20 07:40:02 -07:00
Brian Wilkerson 9aa64259dc Revert "Remove MemberMap in favor of HashMap" 
Review URL: https://codereview.chromium.org/1898193004 .
 2016-04-19 12:20:48 -07:00
Brian Wilkerson fb43f1276c Remove MemberMap in favor of HashMap 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1904433003 .
 2016-04-19 11:59:44 -07:00
Jaime Wren 214a201ae5 Code completion improvement, use type information when suggesting constructors 
BUG=https://github.com/dart-lang/sdk/issues/26254
R=danrubel@google.com

Review URL: https://codereview.chromium.org/1892823003 .
 2016-04-18 12:11:46 -07:00
Brian Wilkerson 3ab253b977 More steps toward making server strong mode clean 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1900503002 .
 2016-04-18 07:52:42 -07:00
Brian Wilkerson d680aba415 Move scopes into a separate library 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1888223003 .
 2016-04-15 07:38:57 -07:00
Brian Wilkerson 21a1b757c1 Clean up hints after a new hint was introduced 
R=jwren@google.com

Review URL: https://codereview.chromium.org/1890973002 .
 2016-04-14 13:15:34 -07:00
Jaime Wren 01aaf8629e Code completion improvement: in NamedExpressions (m(someNamedParam: ^)), use type information to sort variables higher in relevance. 
R=danrubel@google.com

Review URL: https://codereview.chromium.org/1882243003 .
 2016-04-13 16:11:39 -07:00
Jaime Wren 6a29eab2c3 Code completion refactoring in local contributor, have calls to _addLocalSuggestion() split into the different categories of completions so that fitering, see _addLocalSuggestion_includeTypeNameSuggestions(), can occur before the suggestion gets to _addLocalSuggestion() 
Take two: can't commit it here: https://codereview.chromium.org/1881153002/

Review URL: https://codereview.chromium.org/1882903002 .
 2016-04-13 10:15:50 -07:00
Brian Wilkerson 7bc093bf1c Remove unused field 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1882473004 .
 2016-04-12 12:32:42 -07:00
Florian Loitsch 50bdab3841 Steps towards making the convert library strong-mode compliant. 
This version has a few deprecated methods. In a future release they will be removed.

See https://codereview.chromium.org/1827803002 for the final patch (once the deprecated methods have been removed).

R=leafp@google.com, lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/4ab1219bf93a33a2a3d4803e053ccd70ce190371
Reverted: https://github.com/dart-lang/sdk/commit/045a3753665268761508c8053e0ee84372d9ef35

Review URL: https://codereview.chromium.org/1847843002 .
 2016-04-12 20:59:21 +02:00
danrubel 657f88d7f0 use type information to filter RHS of "is" expression for imported types 
fixes #22357

R=jwren@google.com

Review URL: https://codereview.chromium.org/1876603002 .
 2016-04-11 15:57:41 -04:00
Florian Loitsch 045a375366 Revert "Steps towards making the convert library strong-mode compliant." 
This reverts commit 4ab1219bf9.

Review URL: https://codereview.chromium.org/1881553002 .
 2016-04-11 19:52:57 +02:00
Florian Loitsch 4ab1219bf9 Steps towards making the convert library strong-mode compliant. 
This version has a few deprecated methods. In a future release they will be removed.

See https://codereview.chromium.org/1827803002 for the final patch (once the deprecated methods have been removed).

R=leafp@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/1847843002 .
 2016-04-11 19:16:04 +02:00
Jaime Wren 8a9403e15c Code completion improvement in the DAS- only suggest completions on the RHS of an as-expression that are proper subtypes of the type of the LHS of the as-expression. 
R=danrubel@google.com

Review URL: https://codereview.chromium.org/1872073002 .
 2016-04-11 09:59:30 -07:00
Jaime Wren bb62c408bf Fix for issue 22357: use type information on the RHS of is expressions to improve quality of completions. 
BUG=https://github.com/dart-lang/sdk/issues/22357
R=danrubel@google.com

Review URL: https://codereview.chromium.org/1871073003 .
 2016-04-08 15:16:53 -07:00
danrubel dbaf0c33b0 show only named argument suggestions - fixes #25198, fixes #23992 
R=jwren@google.com

Review URL: https://codereview.chromium.org/1867063003 .
 2016-04-08 12:54:31 -04:00
Jaime Wren 3c8b0d20f3 Fix for issue 23861: CompletionSuggestion.parameterType are now populated. 
BUG=https://github.com/dart-lang/sdk/issues/23861
R=danrubel@google.com

Review URL: https://codereview.chromium.org/1864243002 .
 2016-04-07 13:01:53 -07:00
Brian Wilkerson f819f9fb07 Add hooks for changing priorities of warnings to errors in strong mode 
R=leafp@google.com

Review URL: https://codereview.chromium.org/1861363002 .
 2016-04-06 13:06:29 -07:00
Jaime Wren 84b9a47926 Fix for issue 24555: import/export/part completion improvement. 
BUG=https://github.com/dart-lang/sdk/issues/24555
R=danrubel@google.com

Review URL: https://codereview.chromium.org/1860213002 .
 2016-04-06 09:52:47 -07:00
Steve Messick d3929293d9 Minor change to fix some strong-mode errors 2016-04-05 15:17:32 -07:00
Brian Wilkerson 97c613aad4 More strong mode changes in analysis_server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1852113002 .
 2016-04-03 17:56:30 -07:00
Brian Wilkerson f9b575e5b3 More strong mode changes to analysis_server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1855643002 .
 2016-04-01 18:00:04 -07:00
Konstantin Shcheglov d1104de8db Issue 26096. Explicitly compute the result that ensures that directives are resolved in units. 
In the past computing LIBRARY_ELEMENT2 also set elements for directives
in the defining unit AST. But when this unit is flushed and reparsed
we didn't set these directive elements again because LIBRARY_ELEMENT2
is valid. Now resolving directive ASTs to elements is an explicit
dependency.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/26096

Review URL: https://codereview.chromium.org/1854863002 .
 2016-04-01 14:00:38 -07:00
Brian Wilkerson cbcb689184 Fix the way generated code is made strong mode clean 
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1849973002 .
 2016-03-31 13:43:07 -07:00
Konstantin Shcheglov 054be34e6c Issue 26148. Don't use a current token if it does not match - create a new synthetic. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26148

Review URL: https://codereview.chromium.org/1851623002 .
 2016-03-31 13:40:17 -07:00
Brian Wilkerson 301a6a4725 Fix generated server code to be strong mode compliant 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1852473002 .
 2016-03-31 10:44:42 -07:00
Konstantin Shcheglov 559bc17535 Rework computing simple strings difference. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26140

Review URL: https://codereview.chromium.org/1849843002 .
 2016-03-31 10:18:06 -07:00
Brian Wilkerson 0d743fbacf Start making server strong mode clean 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1842063003 .
 2016-03-31 08:27:05 -07:00
Konstantin Shcheglov 582c038940 Fix for sorting directives with documentation comments. 
Stop trying to keep non-documentation directive comments after sorting.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1843763002 .
 2016-03-30 17:21:30 -07:00
Brian Wilkerson 8c22a5f807 Format code in analysis_server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1838933003 .
 2016-03-29 08:27:14 -07:00
Brian Wilkerson 338c95be8c Sort the files in analysis_server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1834423002 .
 2016-03-28 18:25:29 -07:00
Konstantin Shcheglov d097a6e1cd Allow Analysis Server crawl up the folders to search .analysis_options file. 
R=brianwilkerson@google.com, jwren@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org/1832643002 .
 2016-03-23 17:09:48 -07:00
Konstantin Shcheglov c675ba270f Pass AnalysisOptions into SdkCreator, disable changing afterwards. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1830703002 .
 2016-03-23 13:11:49 -07:00
Konstantin Shcheglov 08989ce327 Disable using SDK summaries in Analysis Server. 
Rollbacks https://codereview.chromium.org/1812013002/

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26072

Review URL: https://codereview.chromium.org/1831503002 .
 2016-03-23 10:18:16 -07:00
Konstantin Shcheglov 5e4218b754 Issue 26063. Index declarations in even partically analyzed units. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26063

Review URL: https://codereview.chromium.org/1829463002 .
 2016-03-22 17:24:17 -07:00
Konstantin Shcheglov c7531fb499 Issue 26050. Don't suggest to import an already imported (with 'show') library again. 
R=pquitslund@google.com, brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26050

Review URL: https://codereview.chromium.org/1816163002 .
 2016-03-21 10:21:29 -07:00
Brian Wilkerson 0720a24af7 Add information to the status pages about the options for the context associated with the SDK being used by each context. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1814233006 .
 2016-03-19 16:25:15 -07:00
Jaime Wren 2a3acf94ec Fix in code completion for named parameters in constructor, method and function invocations, https://github.com/dart-lang/sdk/issues/25975 
BUG=https://github.com/dart-lang/sdk/issues/25975
R=brianwilkerson@google.com, danrubel@google.com

Review URL: https://codereview.chromium.org/1806113002 .
 2016-03-18 10:26:27 -07:00
Konstantin Shcheglov e3e2ef0ace Enable using SDK summaries in Analysis Server. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1812013002 .
 2016-03-17 12:25:42 -07:00
Konstantin Shcheglov c0d40223bf Issue 25945. Include static/propagateInvokeType for MethodInvocation names into hover. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25945

Review URL: https://codereview.chromium.org/1814893002 .
 2016-03-17 10:29:10 -07:00
Konstantin Shcheglov 6eb900838b Prepare for turning on SDK summaries in Analysis Server. 
1. Move plugins registering before SDK creation so that when SDK
   creates AnalysisContext and initializes EnginePlugin, all tasks are
   already registered.

2. Provide additional results which are used by the strong mode.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1814723002 .
 2016-03-17 08:37:53 -07:00
Brian Wilkerson 9b0fcd3a39 Remove more calls to safelyVisit methods 
checkpoint

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1814453002 .
 2016-03-16 11:25:38 -07:00
Konstantin Shcheglov 5051380a09 Fix for searching parameters of constructors. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1802023002 .
 2016-03-14 14:39:54 -07:00
Brian Wilkerson e28c816855 Fix generation of getters and fields in quick fixes (issue 25691) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1804743002 .
 2016-03-14 14:03:44 -07:00
Konstantin Shcheglov bd76934452 Remove old index and search implementations. 
Also rename the new implementation files and classes to remove the
'2' suffix.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1801883002 .
 2016-03-14 12:19:40 -07:00
Brian Wilkerson 93aa6f1ecf Deprecate the generated element library and clean up imports 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1789233002 .
 2016-03-12 09:13:44 -08:00
Brian Wilkerson 7d72c6e1f5 Deprecate the generated AST library and clean up imports 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1788223002 .
 2016-03-12 08:50:48 -08:00