bcd2414640
Do not pass tautology predicates into check list.
...
R=podivilov@chromium.org
Review URL: https://codereview.chromium.org//11342046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14299 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 18:05:54 +00:00
979016caf9
Do not emit members of parent EventTarget interface.
...
Currently WebKit mixes EventTarget in.
R=podivilov@chromium.org ,sra@google.com
Review URL: https://codereview.chromium.org//11340013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14288 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 15:28:33 +00:00
45b14d706e
Emit secondary members in the fixed order.
...
Let's sort by interface name to be stable.
R=podivilov@chromium.org
Review URL: https://codereview.chromium.org//11276062
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14275 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 13:28:08 +00:00
a083c1a108
Removed IllegalAccessException and UnsupportedOperationException.
...
Both were converted to StateError.
Review URL: https://codereview.chromium.org//11235054
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14012 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 12:36:10 +00:00
e524049060
Switch to new library syntax.
...
R=podivilov@chromium.org ,kasperl@google.com ,vsm@google.com
Review URL: https://codereview.chromium.org//11235059
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13962 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 13:52:27 +00:00
c0b6dd849e
Get rid of Dynamic.
...
R=podivilov@chromium.org ,kasperl@google.com
BUG=6187
Review URL: https://codereview.chromium.org//11235060
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13958 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 12:56:44 +00:00
24f777a084
Get rid of abstract modifier for members.
...
Actually it was only put on getters.
R=kasperl@google.com
Review URL: https://codereview.chromium.org//11225055
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13954 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 12:10:28 +00:00
7da3f29f41
Remove more () from getters.
...
Anton, there seems to be some unrelated changes put in the
html_dartium.dart file as a result of me re-running the
lib/html/scripts/go.sh script. Could you take a look at
those too?
R=antonm@google.com
BUG=
Review URL: https://codereview.chromium.org//11225054
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13943 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 10:28:53 +00:00
bd7784b08b
Get rid of ===/!===.
...
R=podivilov@chromium.org
BUG=6133
Review URL: https://codereview.chromium.org//11235029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13941 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 10:18:26 +00:00
b4c773d3ff
Fixes to unbreak the build.
...
TBR=podivilov@chromium.org
Review URL: https://codereview.chromium.org//11227049
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13931 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 08:53:13 +00:00
c3cec5113c
Cleanup list-like interfaces generation.
...
R=antonm@google.com
Review URL: https://codereview.chromium.org//11227024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13876 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 14:09:30 +00:00
b9234ecc28
Use CheckSecurityForNode to filter out insecure calls
...
Testing note, I took out the special-cased lines under
_removed_html_members, verified that crossframetest and innerframetest
started breaking, and fixed with the more general code in this CL.
Review URL: https://codereview.chromium.org//11175014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13846 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 23:13:45 +00:00
137370942a
Force named arguments in constructors.
...
R=blois@google.com ,efortuna@google.com ,podivilov@chromium.org ,sra@google.com ,vsm@google.com
Review URL: https://codereview.chromium.org//11196020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13833 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 18:45:00 +00:00
7ee39fa99b
Generate contains() method for list mixin only if not already defined.
...
Review URL: https://codereview.chromium.org//11187063
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13828 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 17:36:03 +00:00
23236055d6
Change return types of Callbacks to w3c standard of void
...
Review URL: https://codereview.chromium.org//11138028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13795 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 18:43:58 +00:00
ae9664a9cc
Revert "Add "contains" method to Collection."
...
Review URL: https://codereview.chromium.org//11186045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13769 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 10:55:02 +00:00
c3c2ae61c6
Add "contains" method to Collection.
...
Also added a Sequence interface to capture things with a length and
integer indexing. List and String implement that interface, and
there is a base skeleton class for collections that are Sequences.
BUG=1030
Review URL: https://codereview.chromium.org//11169004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13766 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 08:48:11 +00:00
dbe15ba638
Minor simplification.
...
R=podivilov@chromium.org
Review URL: https://codereview.chromium.org//11190023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13745 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 15:01:30 +00:00
8889337203
Unify formatting of parameters in interfaces and implementing classes.
...
R=podivilov@chromium.org
Review URL: https://codereview.chromium.org//11191026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13744 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 14:49:11 +00:00
2d7f516b9f
Extract common logic from Backend.BaseClassName().
...
R=antonm@google.com
Review URL: https://codereview.chromium.org//11118025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13742 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 14:24:50 +00:00
dc0c8157bc
Rename Dartium dart:html implementation classes.
...
Currently, Dartium implementation classes are named as "_<IDL_Name>Impl" while
dart2js implementation classes are named as "_<Dart_Name>Impl". The goal of
this patch is to unify the naming across the backends.
R=antonm@google.com
Review URL: https://codereview.chromium.org//11108017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13740 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 14:02:25 +00:00
e846c4789b
Switch to using IDLTypeInfo.interface_name().
...
R=antonm@google.com
Review URL: https://codereview.chromium.org//11114019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13736 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 12:53:20 +00:00
a8c94bc8f5
Provide a correct value for is_optional argument of ParamInfo constructor.
...
R=podivilov@chromium.org
Review URL: https://codereview.chromium.org//11194029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13735 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 12:52:46 +00:00
f20ca10855
Remove ParamInfo.dart_type field.
...
R=antonm@google.com
Review URL: https://codereview.chromium.org//11117025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13732 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 12:37:10 +00:00
1eeb83bbdf
Convert legacy 'native code' to JS-forms in dart:html
...
This should enable minification to rename function arguments. Issue 5821 and Issue 5822 need to be fixed first.
BUG=dart:5808
Review URL: https://codereview.chromium.org//11094082
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13690 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 17:50:15 +00:00
f6c129ce61
Move interface merging info to type registry.
...
R=antonm@google.com
Review URL: https://codereview.chromium.org//11091046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13533 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-11 11:45:40 +00:00
2a77601516
Rename WebKit's WheelEvent.wheelDelta{X,Y} to W3C WheelEvent.delta{X,Y}.
...
Also remove WheelEvent.wheelDelta.
We originally have done that for dart2js, but that broke Dartium support. Instead of
removal, just rename to generate binding code still.
R=blois@google.com ,podivilov@chromium.org
BUG=5756
Review URL: https://codereview.chromium.org//11099033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13476 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-10 14:53:29 +00:00
f8762b2568
Introduce ListLikeIDLTypeInfo as a replacement for nativified_classes table.
...
IDLTypeInfo hierarchy is a convenient way to deal with idl type polymorfism.
R=antonm@google.com ,efortuna@google.com ,vsm@google.com
Review URL: https://codereview.chromium.org//11065042
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13472 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-10 13:22:45 +00:00
9d19336573
Add interface_name and implementation_name to IDLTypeInfo class and use them instead of dart_type.
...
R=antonm@google.com
Review URL: https://codereview.chromium.org//11040059
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13470 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-10 12:38:41 +00:00
30b34c8457
Better return types for window.location and window.history
...
Review URL: https://codereview.chromium.org//11086029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13432 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 19:37:41 +00:00
166d2b2d86
Fix some type narrowing
...
I think I 'broke' this is an earlier CL.
Review URL: https://codereview.chromium.org//11086017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13430 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 19:29:55 +00:00
c40edf6954
Wrap Window in case it's a window from a different page / frame.
...
I also refactored inner_frame_test to explicitly notify if the subframe tests pass or fail. This should make them more robust and (if they break) fail quickly instead of timing out.
BUG=1913
Review URL: https://codereview.chromium.org//11074005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13331 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 23:07:08 +00:00
caa43082d6
Fixes to get SelectElement working properly on IE.
...
BUG=
Review URL: https://codereview.chromium.org//11031076
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13307 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 18:13:13 +00:00
bc5a9328bb
Fixing SelectElement.selectedOptions to work on all platforms.
...
This is a fixup of the original CL which broke dartium because I mistakenly applied the polyfill to both dart2js and dartium.
Fix was to move impl_SelectElement.darttemplate to dart2js.
BUG=4503
Review URL: https://codereview.chromium.org//11035032
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13304 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 17:03:28 +00:00
fa3dba72b2
Override CSSStyleDeclaration.getPropertyValue in general way.
...
Hide actual implementation and check returned value.
R=efortuna@google.com
BUG=5617
Review URL: https://codereview.chromium.org//11065014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13253 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 18:38:43 +00:00
a1d9180d98
New cross frame base types.
...
Local types (LocalWindow, LocalLocation, LocalHistory) now subtype the corresponding "safe" base type. The _CrossFrameImpl classes implement the safe types.
This also fills out Location and History for dart2js.
Note for dart2js, I still need to trap returned windows. That's a separate bug.
BUG=3836
Review URL: https://codereview.chromium.org//11047021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13252 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 18:16:03 +00:00
87cda6aa97
Move Dart type narrowing to TypeRegistry.
...
R=antonm@google.com
Review URL: https://codereview.chromium.org//11027033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13248 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 17:55:30 +00:00
f892f55ecb
Refactor idl to dart renaming logic for interfaces.
...
Make sure all types that comes to TypeRegistry.TypeInfo are either registered
or present in database. That is to fix the mess with idl vs. dart types.
Also, InterfaceIDLTypeInfo.dart_type now returns an already renamed type.
R=antonm@google.com
Review URL: https://codereview.chromium.org//11026039
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13247 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 17:54:04 +00:00
4198b9d3a8
Revert "Fixing SelectElement.selectedOptions to work across all platforms."
...
This reverts commit #13239 because it breaks the dartium build.
TBR=vsm
BUG=
Review URL: https://codereview.chromium.org//11032033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13242 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 16:16:51 +00:00
4f396585c4
Remove global DartType function.
...
R=antonm@google.com
Review URL: https://codereview.chromium.org//11030027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13241 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 16:13:57 +00:00
25f67482f2
Fixing SelectElement.selectedOptions to work across all platforms.
...
BUG=4503
Review URL: https://codereview.chromium.org//11049012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13239 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 16:10:12 +00:00
bffc05a1b1
CSSStyleDeclaration.getPropertyValue returns empty string instead of null.
...
Review URL: https://codereview.chromium.org//11047008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13189 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-03 18:05:41 +00:00
f36360ec8b
Converting NodeList to List<Node>.
...
This keeps the NodeList class because other classes depend on it (notably RadioNodeList), but converts all APIs over to List<Node>.
BUG=2712
Review URL: https://codereview.chromium.org//11055009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13188 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-03 17:47:48 +00:00
5169ef12d7
Extract common logic for emitting implementation classes.
...
R=antonm@google.com
Review URL: https://codereview.chromium.org//11051014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13181 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-03 16:04:30 +00:00
b9e0a92118
Merge BaseGenerator into HtmlDartInterfaceGenerator.
...
R=antonm@google.com
Review URL: https://codereview.chromium.org//11045020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13180 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-03 15:58:03 +00:00
f37795b15d
Remove constants declaration from dart2js implementation classes.
...
They aren't used anymore.
R=antonm@google.com ,vsm@google.com
Review URL: https://codereview.chromium.org//11053016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13173 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-03 14:41:59 +00:00
a6efb0872e
Provide a fallback for AudioBufferSourceNode.start to noteOn and stop to
...
noteOff.
Review URL: https://codereview.chromium.org//11043013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13156 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-03 00:49:37 +00:00
a800e16aeb
Cleanup html events generation.
...
Get rid of HtmlSystemShared and move event interfaces and implementations
generation to HtmlEventGenerator class.
R=antonm@google.com ,sra@google.com
Review URL: https://codereview.chromium.org//11020008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13107 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-02 10:22:37 +00:00
315a0f88c0
Get rid of System class.
...
R=antonm@google.com
Review URL: https://codereview.chromium.org//11018012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13106 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-02 10:11:47 +00:00
d0aa4f7409
Remove systeminterface from scripts.
...
Review URL: https://codereview.chromium.org//11027011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13091 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-02 00:22:06 +00:00
antonm@google.com