72b2199a3a
Issue 4072. Generate warning when private instance method is called
...
R=brianwilkerson@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10829064
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10001 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-28 00:52:24 +00:00
900fa10dcd
Restore DartCompiler method to fix the build (TBR)
...
Review URL: https://chromiumcodereview.appspot.com//10826053
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9993 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-27 21:04:20 +00:00
5bdca22f3b
Replace parsed and resolved maps with cache interface
...
Review URL: https://chromiumcodereview.appspot.com//10826047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9991 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-27 20:03:13 +00:00
e41a49c9a6
fix support for --package-root command line option to analyzer
...
Review URL: https://chromiumcodereview.appspot.com//10825054
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9981 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-27 16:15:29 +00:00
e212422aa0
Fix for issue 3915
...
Review URL: https://chromiumcodereview.appspot.com//10824045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9944 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-26 17:19:00 +00:00
deec248e91
Fix for issue 3783
...
Review URL: https://chromiumcodereview.appspot.com//10833012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9909 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-25 21:18:02 +00:00
85b8de496c
Fix for issue 1489
...
Review URL: https://chromiumcodereview.appspot.com//10823014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9892 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-25 16:20:48 +00:00
53c1cc23a5
Basic 'Quick Fix' support and one fix as example/test
...
Also use ErrorCdoe instead of "problemId" integer.
R=messick@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10816034
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9865 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-24 21:48:39 +00:00
787b7602d1
Convert into/from => function syntax
...
R=messick@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10818028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9864 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-24 21:25:16 +00:00
a25ed30356
Check for conflicts between new function/method and other elements.
...
R=messick@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10790117
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9812 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-23 14:33:54 +00:00
80a831b570
changes to SystemLibraryManager to support list of roots
...
Review URL: http://codereview.chromium.org//10809023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9786 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-20 20:01:28 +00:00
51ffc7db49
Folded in recent changes from the dartc parser error codes into the Analysis Engine.
...
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10793029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9716 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-17 18:08:37 +00:00
894762c40a
Cache model elements for compiler elements.
...
With this Editor Core tests run 2 times faster.
Indexing speed increased several times, something like 5-7.
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10692198
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9635 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-13 16:18:53 +00:00
4e76ba611a
Optimize comments to nodes binding
...
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10695166
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9600 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-12 16:36:44 +00:00
376923affa
Fix copyright year
...
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9599 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-12 16:35:22 +00:00
bb13f021a4
Use 'int' instead of Position.
...
By doing so we get 5-7% of performance in running JUnit tests.
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10704180
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9596 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-12 16:10:10 +00:00
c4327d6db5
Issue 3986. Class member cannot have the same name as the class
...
http://code.google.com/p/dart/issues/detail?id=3986
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10735039
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9577 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-12 00:31:07 +00:00
f9339df1eb
Issue 4040. Fix NPE when report problem with no node.
...
http://code.google.com/p/dart/issues/detail?id=4040
Clean up after previous quick build fixes.
Can not reproduce actual rename problem, but it may be caused by exception during parsing which this CL is fixing.
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10700146
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9522 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-10 20:28:06 +00:00
5d73fe4cf3
Attempt to fix build
...
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9514 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-10 16:15:49 +00:00
69435a374d
Issue 2622. Fix for SourceInfo for DartUnit for one case of invalid source
...
http://code.google.com/p/dart/issues/detail?id=2622
R=messick@google.com ,brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10702119
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9513 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-10 16:02:01 +00:00
38feb0a647
Issue 3985. Tweaks for warning messages
...
http://code.google.com/p/dart/issues/detail?id=3985
R=devoncarew@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10704114
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9451 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-08 14:02:15 +00:00
a5ad949dd4
TBR fix my fix
...
Review URL: https://chromiumcodereview.appspot.com//10701110
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9449 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-06 20:38:28 +00:00
3f82af28b6
Fix a build issue w/ non-terminating builds and issues parsing dart:html.
...
Review URL: https://chromiumcodereview.appspot.com//10690099
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9448 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-06 17:19:17 +00:00
4efd5000c1
Terminate parsing any single compilation unit if we encounter more then 100 parse errors.
...
Review URL: https://chromiumcodereview.appspot.com//10704068
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9445 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-06 16:20:40 +00:00
838a513f89
Add unit tests for ParserErrorCode values
...
Review URL: https://chromiumcodereview.appspot.com//10692080
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9377 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-03 21:28:59 +00:00
8a466804dc
Another round of JUnit tests to finish off ResovlerErrorCodes I could reproduce
...
Review URL: https://chromiumcodereview.appspot.com//10700089
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9373 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-03 18:51:04 +00:00
c7f31ca176
Migrates some resolver errors to parser stage
...
I found some resolver errors I could not reproduce because they were
not reachable code (parser wouldn't accept them). Since we have discussed
running the analysis server in stages where parsing might be done first,
it made sense to me to move some error reporting into the parser anywy.
I also tried to make the messages more friendly.
Review URL: https://chromiumcodereview.appspot.com//10690074
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9361 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-03 16:24:30 +00:00
209c5ba14b
Another small batch of resolver tests
...
Removed some logic that duplicates errors from the parsing step
Review URL: https://chromiumcodereview.appspot.com//10695079
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9356 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-03 15:04:37 +00:00
7b28b0c257
Another small batch of Junit test for errors in the resolver
...
Review URL: https://chromiumcodereview.appspot.com//10693074
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9315 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-02 21:37:29 +00:00
029e0bd4ef
Added a few tests, removed some error codes from Resolver
...
Review URL: https://chromiumcodereview.appspot.com//10695067
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9313 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-02 21:21:01 +00:00
502a83da3c
Adds some JUnit tests for type analysis
...
Review URL: https://chromiumcodereview.appspot.com//10704057
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9299 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-02 16:38:59 +00:00
f899cff1f7
Mark analyzer error codes with no corresponding JUnit test
...
Review URL: https://chromiumcodereview.appspot.com//10700059
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9287 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-02 14:50:34 +00:00
2ffcb28ff6
Issue 3931. Visit children nodes safely.
...
http://code.google.com/p/dart/issues/detail?id=3931
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10702054
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9276 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-30 00:53:08 +00:00
d86c0dc9f9
Fix for issues 3729 and 3523
...
Review URL: https://chromiumcodereview.appspot.com//10696056
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9270 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-29 21:31:07 +00:00
13a1ef71b4
Issue 3753. Support for @deprecated annotation
...
http://code.google.com/p/dart/issues/detail?id=3753
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10703046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9264 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-29 20:26:02 +00:00
f467653c17
Report type warning on assigning to some types of elements
...
For elements that are instance members, we want to emit a type warning
as opposed to a hard compile-time error.
Issue 3662 : http://code.google.com/p/dart/issues/detail?id=3662
Review URL: https://chromiumcodereview.appspot.com//10693047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9255 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-29 17:21:01 +00:00
825f8b9cb9
Flag uninitialized final variables in a class.
...
Issue 3655 : http://code.google.com/p/dart/issues/detail?id=3655
Review URL: https://chromiumcodereview.appspot.com//10699027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9233 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-28 22:08:12 +00:00
f0dac6bd73
Validate the target of break and continue statments from within a switch
...
Issue 3658 http://code.google.com/p/dart/issues/detail?id=3658
Review URL: https://chromiumcodereview.appspot.com//10725002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9220 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-28 20:52:31 +00:00
74a356e682
Fixes the scope of case labels so that duplicate case labels are properly detected
...
Issue 2441 http://code.google.com/p/dart/issues/detail?id=2441
Review URL: https://chromiumcodereview.appspot.com//10716005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9200 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-28 14:29:59 +00:00
68b1aa49c9
Issue 3897. Don't use method _invocation_ as enclosing Element
...
http://code.google.com/p/dart/issues/detail?id=3897
TBR
Committed for now.
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10693023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9196 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-28 02:32:59 +00:00
f2e095cba3
No compile-time error when overriding a static field or method
...
In some cases, you need a warning though
Issue 3659 http://code.google.com/p/dart/issues/detail?id=3659
Issue 3779 http://code.google.com/p/dart/issues/detail?id=3779
Review URL: https://chromiumcodereview.appspot.com//10701011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9191 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-27 22:18:01 +00:00
230d02406c
When a variable name is used as a type, emit a warning, not an error
...
Issue 3474 http://code.google.com/p/dart/issues/detail?id=3474
Review URL: https://chromiumcodereview.appspot.com//10699005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9171 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-27 14:21:37 +00:00
5db61f2d72
Issue 3793. Fix for function expressions with a parameter of the same name
...
http://code.google.com/p/dart/issues/detail?id=3793
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10696006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9170 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-27 14:10:49 +00:00
ae1ca6df94
Make invalid @override an warning
...
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10696008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9169 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-27 14:09:57 +00:00
f204b3fc82
Fix some issues when debugging against package: libraries (Dartium and command-line).
...
Some general cleanup of logging messages on connection close.
Review URL: https://chromiumcodereview.appspot.com//10690002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9147 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-27 04:44:16 +00:00
cf2fecd6aa
An implicit super() invocation wasn't being checked for the wrong # of args
...
Issue 2580 http://code.google.com/p/dart/issues/detail?id=2580
Review URL: https://chromiumcodereview.appspot.com//10668045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9136 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-26 21:14:13 +00:00
90d27a764a
Issue 3839. Warn when 'dart:io' and 'dart:html' are used in single library
...
http://code.google.com/p/dart/issues/detail?id=3839
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10659037
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9133 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-26 20:06:12 +00:00
ee5b047a5f
Attempt to fix build
...
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9131 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-26 19:57:52 +00:00
47e814198a
Produce error for invalid @override
...
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9130 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-26 19:52:37 +00:00
6ed95757fe
Issue 3752. Support for @override annotations (as structured doc comments)
...
http://code.google.com/p/dart/issues/detail?id=3752
Now we always record comments and bind them to nodes.
We record DartMetadata for each DartDeclaration with flags for @deprecated and @override.
In this CL we analyze @override and report error if method does not actually override anything.
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10661022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9129 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-26 19:47:48 +00:00
scheglov@google.com