Commit Graph

103 Commits

Author SHA1 Message Date
kustermann@google.com 20b8ddbfee Remove the command-specific outcome temporarily when writing out the .test-outcome.log file
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//96603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30773 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-29 09:28:15 +00:00
kustermann@google.com 26f065bdb2 Add .test-outcome.log support to test.dart
R=ricow@google.com

Review URL: https://codereview.chromium.org//95603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30768 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-29 08:29:20 +00:00
kustermann@google.com bb54b776ba Checked-in binary update to v1.0.0.3
R=ricow@google.com

Review URL: https://codereview.chromium.org//91473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30717 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 14:17:44 +00:00
kustermann@google.com e6077d093a Remove pixel/layout tests in tests/utils + special casing in the testing scripts for pixel/layout tests
R=ricow@google.com

Review URL: https://codereview.chromium.org//26998002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28502 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 10:29:46 +00:00
kustermann@google.com ed3fe0161c test.py: Support for CompileTimeError,RuntimeError,MissingRuntimeError,MissingCompiletimeError markers in status files
R=ricow@google.com

Review URL: https://codereview.chromium.org//23702055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27804 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 10:21:15 +00:00
kustermann@google.com b0889233cd test.py: Print the warning about left-over dirs only for directories created using Directory.createTemp()
R=ricow@google.com

Review URL: https://codereview.chromium.org//23714002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27003 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 09:29:12 +00:00
kustermann@google.com 45c42e08f2 Update checked-in binary to 0.6.21.3_r26639 (M6)
R=ricow@google.com

Review URL: https://codereview.chromium.org//23568002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26704 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 11:16:37 +00:00
kustermann@google.com 92303dffda test.py: First step towards support of caching dart2js compilations across runtimes
This CL changes the way we run tests completely: When enqueueing TestCases we
build up a dependency graph of Commands. This has the advantage that if more
TestCases share common commands, we only execute it once.

R=ricow@google.com

Review URL: https://codereview.chromium.org//21001003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25760 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 07:54:17 +00:00
kustermann@google.com 03f7b209b2 test.py: Report timings by adding up the time of all commands
BUT=http://dartbug.com/11847
R=ahe@google.com

Review URL: https://codereview.chromium.org//19388002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25096 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 13:15:22 +00:00
ricow@google.com af21d74d2d Fix safari browser to use Future.value
Also correct type errors found by the analyzer.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//18089005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24532 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 17:07:17 +00:00
ricow@google.com 545f6e1341 Update checked in binary to version 0.5.19.0
This is a reland of r24086 with a fix catching errors in the websocket server in tools/testing/dart/http_server.dart.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//18065003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24520 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 16:10:59 +00:00
kustermann@google.com 8984694c97 Print out experimental test.py reproduction command
R=ricow@google.com

Review URL: https://codereview.chromium.org//17361003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24231 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 14:19:11 +00:00
ricow@google.com 12682d3bc7 Add timing information for the individual steps of a failing test.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//17302007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24213 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 09:03:23 +00:00
ricow@google.com 4c5b2ac2ab Revert 24086 Update checked in binary to version 0.5.19.0
This is causing crashes in http server.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//17274002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24096 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-17 13:22:15 +00:00
ricow@google.com 1970fc7afb Update checked in binary to version 0.5.19.0
R=kustermann@google.com

Review URL: https://codereview.chromium.org//17078007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24086 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-17 10:47:02 +00:00
kustermann@google.com 3707cd889b Print output of all commands if a testcase failed
R=ricow@google.com

Review URL: https://codereview.chromium.org//15740034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23408 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 13:15:26 +00:00
ricow@google.com 72cb8b7577 Catch errors on directory listings.
I saw issues on the new linux chrome bot when there was a broken symlink in /tmp

R=kustermann@google.com

Review URL: https://codereview.chromium.org//16085002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23235 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 06:37:18 +00:00
kustermann@google.com 9c08adf54b Print the number of failed tests
R=ricow@google.com

Review URL: https://codereview.chromium.org//14718005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22323 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-02 15:17:28 +00:00
kustermann@google.com c1df0a5418 Only print the failure summary header if there were failures
Review URL: https://codereview.chromium.org//14251009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21453 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 13:57:31 +00:00
whesse@google.com d47b6701ea Fix type error in test scripts
BUG=

Review URL: https://codereview.chromium.org//14047011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21292 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-11 16:31:02 +00:00
kustermann@google.com 1c1590da22 Remove \r in command stdout/stderr when building failure a failure output.
BUG=http://dartbug.com/8704

Review URL: https://codereview.chromium.org//13521002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20860 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-03 13:20:51 +00:00
kustermann@google.com 78ac77e8c9 Fixed test_progress to print the failure summary even if no stepname was given
Review URL: https://codereview.chromium.org//13432003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20846 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-03 11:32:44 +00:00
kustermann@google.com ca08052687 Do not close stdout/stderr in CompactProgressIndicator
BUG=http://dartbug.com/9419

Review URL: https://codereview.chromium.org//13052004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20497 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-25 22:29:25 +00:00
kustermann@google.com 4c45723e98 Added --failure-summary option to test.dart
Review URL: https://codereview.chromium.org//12902035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20379 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-22 13:31:06 +00:00
sgjesse@google.com d6955d176c Reapply "Update the test runner to use the new dart:io API"
This reverts r20031.

R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12751005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20070 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 11:13:39 +00:00
sgjesse@google.com f5270bf202 Revert "Update the test runner to use the new dart:io API" again
This reverts r20027 and r20029

TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12475010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20031 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 15:38:18 +00:00
sgjesse@google.com fdaca2fe83 Revert "Update the test runner to use the new dart:io API" again
This reapplies r20004 and r20008 and fixes a HTTP server issue.

TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12431020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20027 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 15:24:36 +00:00
sgjesse@google.com 3e2ffb4394 Revert "Update the test runner to use the new dart:io API" again
This reverts r20004 and r20008.

TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12559013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20009 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 12:13:37 +00:00
sgjesse@google.com db7821cdf3 Reapply "Update the test runner to use the new dart:io API"
The Linux binary will work on the bots. Fixed a number of issues.

The new binaries are from r19850.

R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12608007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20004 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 11:39:20 +00:00
sgjesse@google.com 78403ce605 Revert "Update the test runner to use the new dart:io API"
This reverts commit r19987.

The included binaries did not work on the bots due to a glibc version issue.

TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12864003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19988 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 08:08:56 +00:00
sgjesse@google.com 7ff44f77ac Update the test runner to use the new dart:io API
The new binaries are from r19850.

R=whesse@google.com, ager@google.com, ricow@google.com, kustermann@google.com

BUG=

Review URL: https://codereview.chromium.org//12417004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19987 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 07:54:07 +00:00
kustermann@google.com 4924f73340 Bugfix in test_progress.dart after refactoring
TBR=ricow

Review URL: https://codereview.chromium.org//12728005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19881 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 17:37:28 +00:00
kustermann@google.com 53497f0c2c Refactoring of ProgressIndicator
Currently ProcessQueue creates and depends on exactly ONE ProgressIndicator.
This is not optimal for the following reasons:

 a) The used ProgressIndicator has several responsibilities (printing timing information,
    setting 'io.exitCode', printing test failures, ...)
    Splitting these responsibilities into different classes makes the code cleaner and more testable.

 b) If we make ProcessQueue depended on an abstract EventListener object (or a list of them) and make
    it send events to those listeners would make it easier to test ProcessQueue itself.

Issue: 8095

Review URL: https://codereview.chromium.org//12302016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19867 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 14:09:05 +00:00
kustermann@google.com c7857e7c0b Quote all arguments when printing a Command
Review URL: https://codereview.chromium.org//12379041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19291 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 10:33:59 +00:00
kustermann@google.com 90e2760642 Start two http servers for every configuration
This should fix: http://dartbug.com/8366

Review URL: https://codereview.chromium.org//12340021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18964 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 11:54:20 +00:00
kustermann@google.com 0a5a3306f7 Added '--package-root' to http_server.dart.
Review URL: https://codereview.chromium.org//12087130

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17968 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 10:22:55 +00:00
kustermann@google.com 5d083443f8 Don't exit() in test_progress but rather set io.exitCode
Review URL: https://codereview.chromium.org//12026013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17264 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 12:28:08 +00:00
kustermann@google.com ecf1cdeeb8 Fixed utf8 encoding/decoding issues in the testing scripts
Review URL: https://codereview.chromium.org//11883033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17057 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-15 10:59:24 +00:00
efortuna@google.com 4622dc3e76 Make browser tests all run from a server instead of the local filesystem.
BUG=

Review URL: https://codereview.chromium.org//11810004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17007 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-13 01:11:07 +00:00
kustermann@google.com a18994679b Call DumpRenderTree directly from test.dart instead of using the drt-trampoline.py indirection
Currently drt-trampoline.py is used to call DRT. Unfortunately this causes
problems on Windows: If drt-trampoline.py times out, it is killed by test.dart.
But drt-trampoline.py has no way of installing a signal handler on Windows which
would kill the actual DumpRenderTree process. So sometimes we're left with one
hanging DumpRenderTree process on the Windows buildbots.

This change removes the drt-trampoline.py indirection and calls DRT directly
from test.dart.

Committed: https://code.google.com/p/dart/source/detail?r=16214

Review URL: https://codereview.chromium.org//11586012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16247 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 09:52:54 +00:00
kustermann@google.com 0be2cb3fa5 Revert "Call DumpRenderTree directly from test.dart instead of using the drt-trampoline.py indirection"
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//11591017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16215 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 17:21:48 +00:00
kustermann@google.com 8071e88618 Call DumpRenderTree directly from test.dart instead of using the drt-trampoline.py indirection
Currently drt-trampoline.py is used to call DRT. Unfortunately this causes
problems on Windows: If drt-trampoline.py times out, it is killed by test.dart.
But drt-trampoline.py has no way of installing a signal handler on Windows which
would kill the actual DumpRenderTree process. So sometimes we're left with one
hanging DumpRenderTree process on the Windows buildbots.

This change removes the drt-trampoline.py indirection and calls DRT directly
from test.dart.

Review URL: https://codereview.chromium.org//11586012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16214 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 16:27:11 +00:00
kustermann@google.com 62c83a4443 Moved the testing scripts to the new import/library/part syntax
Review URL: https://codereview.chromium.org//11575028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16163 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 14:19:01 +00:00
kustermann@google.com c01e393aa5 Added support for skipping redundant dart2js compilations.
Currently, the buildbots run tests on every commit. But often neither
the tests nor the dart2js compiler did change (e.g. on status file updates).

The added code will check if the dependencies (i.e. files listed in
test.js.deps) or the dart2js snapshot did change. If not, the output
of the previous dart2js compilation is up to date and the compilation
step is skipped.
The skipping of redundant dart2js compilations works only if the '--use-sdk'
option was specified (because in this case the dart2js snapshot is used).

Committed: https://code.google.com/p/dart/source/detail?r=15080

Review URL: https://codereview.chromium.org//11369216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16158 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 11:56:00 +00:00
whesse@google.com 6220720429 Add --build-directory option to test.py.
Fix problem when no --step-name option is present.

BUG=dart:6885

Review URL: https://codereview.chromium.org//11308179

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15280 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-23 12:54:04 +00:00
kustermann@google.com 52077af7fa Revert "Added support for skipping redundant dart2js compilations."
We must disable this feature until we've made sure that the boolean
dart2js flags (e.g. --checked) are included in the directory names.

TBR=ahe

Review URL: https://codereview.chromium.org//11280061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15087 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 15:47:59 +00:00
kustermann@google.com f4bc6a5f3f Added support for skipping redundant dart2js compilations.
Currently, the buildbots run tests on every commit. But often neither
the tests nor the dart2js compiler did change (e.g. on status file updates).

The added code will check if the dependencies (i.e. files listed in
test.js.deps) or the dart2js snapshot did change. If not, the output
of the previous dart2js compilation is up to date and the compilation
step is skipped.
The skipping of redundant dart2js compilations works only if the '--use-sdk'
option was specified (because in this case the dart2js snapshot is used).

Review URL: https://codereview.chromium.org//11369216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15080 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 13:56:11 +00:00
kustermann@google.com 42b89c9f77 Changed: TestCase.output -> TestCase.commandOutputs[]
Currently the TestCase has exactly one TestOutput. This worked
until now, since we were only interested in the output of the
last command.

This change introduces one CommandOutput for each command which
has been run. Doing so enables us to fetch output (stdin,stderr)
information as well as exitCode ... for all commands.

See also 11293278.

Review URL: https://codereview.chromium.org//11348088

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15006 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-16 11:17:47 +00:00
kustermann@google.com 3dc5c7056a Revert of commit 14947
Review URL: https://codereview.chromium.org//11348060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14949 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-15 09:15:43 +00:00
kustermann@google.com 5ec78286df Changed: TestCase.output -> TestCase.commandOutputs[]
Currently the TestCase has exactly one TestOutput. This worked
until now, since we were only interested in the output of the
last command.

This change introduces one CommandOutput for each command which
has been run. Doing so enables us to fetch output (stdin,stderr)
information as well as exitCode ... for all commands.

Review URL: https://codereview.chromium.org//11293278

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14947 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-15 09:05:41 +00:00