18a8f25608
Command class hieracy refactoring, environmentOverride extraction
...
R=ricow@google.com , whesse@google.com
Review URL: https://codereview.chromium.org//118783003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31269 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-19 13:01:46 +00:00
667c9ec4bf
Make sure we mark all depending commands (transitively!) UnableToRun if a command fails
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//107153004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31241 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-18 21:54:45 +00:00
ca307461d0
test.py: Removed JUnitTestSuite, since it's no longer used
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//113713006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31214 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-18 08:48:00 +00:00
539d41deb1
Remove unused parameter from test infrastructure: use_unittest_controller.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//104963003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30988 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-09 15:18:11 +00:00
c8bfa98017
Test infrastructure: add retry to browser controller sending "done" message.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//107513004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30950 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-06 16:38:15 +00:00
eb09d1e40b
co19-roll to r672
...
Review URL: https://codereview.chromium.org//100363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30854 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 13:00:12 +00:00
20b8ddbfee
Remove the command-specific outcome temporarily when writing out the .test-outcome.log file
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//96603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30773 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-29 09:28:15 +00:00
bae4d99ce1
Add debug information to verify that we actually get the onDone event send to the driver page.
...
I am aware that we should not clutter up the message that we show to developers, but I think it is important to validate that we actually send the onDone message to the driver page.
We should also put in functionality for tracking network errors in the browser_controller generated js (+potentially retrying the send of the message)
R=kustermann@google.com
Review URL: https://codereview.chromium.org//96503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30771 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-29 08:57:47 +00:00
26f065bdb2
Add .test-outcome.log support to test.dart
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//95603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30768 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-29 08:29:20 +00:00
fc15ac395d
Remove left-over print statement in test_runner.dart
...
Review URL: https://codereview.chromium.org//95593002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30766 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-28 17:34:01 +00:00
5ed5e5b17a
Added debug timer to test.dart
...
We are seeing a lot of test.dart timeouts on our browser bots. This is an
attempt to get more information on what is going on.
R=ricow@google.com
Review URL: https://codereview.chromium.org//88803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30765 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-28 16:20:28 +00:00
e634fb20a4
Make status updates after 10 seconds + fix handling of status updates
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//94213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30748 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-28 08:50:58 +00:00
eeee37127b
Fix after upgrading to new checked-in binary
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//91693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30718 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 14:53:46 +00:00
bb54b776ba
Checked-in binary update to v1.0.0.3
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//91473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30717 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 14:17:44 +00:00
e70a3e5a21
Print again how many compilations were skipped
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//88823003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30699 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 08:27:21 +00:00
8a9d4c085e
Whitelist nonzero content_shell exitcode
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//88443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30670 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-26 14:48:41 +00:00
c23917be9b
Print events only to the console and never to the DOM
...
IE9 does not have a console, so events were printed to the DOM. But since we get
all events anyway when using the browser controller, there is no need to print
it to the DOM.
R=ricow@google.com
Review URL: https://codereview.chromium.org//85853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30630 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 14:35:50 +00:00
52a12f1b37
Remove old warning code for wrong usage of warnings in co19
...
Review URL: https://chromiumcodereview.appspot.com//85303004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30621 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 12:54:15 +00:00
6c04b9a0b2
Followup on co19-roll to r667, marked co19/Language/12_Expressions/32_Type_Test_A02_t04 as failing in minified mode
...
Review URL: https://codereview.chromium.org//79143005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30513 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-21 12:09:52 +00:00
8b103390e2
Make sure variable names used in status files are available in the environment
...
Previously we didn't validate that a variable name used in a status file
expression was available.
It wasn't surfaced, since lookups in Map objects return null if the key is
missing and calling 'toString()' on 'null' doesn't throw an exception.
BUG=http://dartbug.com/12959
R=ricow@google.com
Review URL: https://codereview.chromium.org//78723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30502 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-21 09:54:36 +00:00
3d910a2a9a
Remove filtering of analyzer warnings/errors by filename
...
The only files that are now not analyzed are the patch files in
"sdk/lib/_internal/lib" and test files (i.e. files ending with "_test.dart")
R=ricow@google.com
Review URL: https://codereview.chromium.org//78483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30471 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 14:06:34 +00:00
8649be6036
Implement a periodic timer which sends the current state of a browser test back to the browser controller
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//77763004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30468 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 13:32:16 +00:00
e3d8608ca2
test.py: Sending JSON between test_controller.js <-> browser_controller
...
Currently test.py will look for FAIL/PASS messages in the DOM to determine if a
test has failed or not. test_controller.js will add these PASS/FAIL messages to
the DOM (in addition to other messages).
This approach has several issues:
- The test itself could create nodes in the DOM containing FAIL/PASS. This means
that the outcome of a test cannot be reliably determined.
- The test ifself can remove nodes from the DOM (e.g. setting
document.body.innerHTML). This could result in a situation where the
stacktraces/... test_controller.js prints to the DOM are lost.
- It is unclear which parts of the DOM we see in test failure messages
(reported by test.py) come from the test itself and which parts come from
test_controller.js.
This CL tries to fix this by recording all events that happend with global
variables in test_controller.js and send back a JSON string with information
about
- debug messages
- posted messages
- print() calls of the test
- DOM
- errors (from window.onerror, script.onerror ...)
Furthermore this CL fixes unittest to report
unittest-suite-success/unittest-suite-fail instead of unittest-suite-done (which
is broken).
R=ricow@google.com
Review URL: https://codereview.chromium.org//36913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30407 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-19 12:54:41 +00:00
1fd9f4b774
Print drt exitcode when we pass test but crash before exiting
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//60763004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30401 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-19 12:08:54 +00:00
af29f7901f
Removed assert for nonexistent use_browser_controller option
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//75243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30344 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 12:59:20 +00:00
2adf3ea3c0
Fix SummaryReport after introduction of the RuntimeError,CompileTimeError,... markers
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//75213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30342 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 12:41:59 +00:00
36fe570a31
Remove the --use_browser_controller flag, now that it is always true.
...
Fix an error in r30269.
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//68133017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30270 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 15:20:31 +00:00
e545ffef5d
Remove uses of Selenium and webdriver from test scripts.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//68213016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30269 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 12:30:35 +00:00
00f34f7ca4
Use browser_controller instead of selenium in test scripts, by default.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//68113023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30268 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 10:25:19 +00:00
804fd00f9c
Fix launch_browser.dart after changes to utils.dart:Location
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//61793014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30231 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-13 15:50:31 +00:00
0f2f482388
Add browser path options to testing scripts.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//60503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29981 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 16:24:33 +00:00
a69e4a5e8d
Adds checked mode to Dartium on Android browser test controller.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//52803007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29832 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 18:26:41 +00:00
76a9b8a358
Pass sharedOptions to the compilation command of a browser test.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//55023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29681 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 17:10:18 +00:00
7006de6f23
Remove deprecated parts of dart:async.
...
Attempt to fix most uses of the deprecated features.
R=floitsch@google.com , nweiz@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org//48483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29628 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 02:24:29 +00:00
6029bd2f44
co19-roll to r651
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//53453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29596 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 22:16:51 +00:00
97489a5dcd
Implement SharedOptions in test scripts.
...
R=kustermann@google.com , ricow@google.com
Review URL: https://codereview.chromium.org//47703006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29568 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 17:30:10 +00:00
41ff075e31
Remove deprecated dart:utf library.
...
BUG= http://dartbug.com/12843
R=fschneider@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//48133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29537 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 12:25:02 +00:00
aac5479809
Only generate multitests if content changed, enables us to dart2js compilations for multitests
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//52113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29528 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 10:41:17 +00:00
0456d4136b
Run the analyzer on dart files under sdk/ -- even in sdk/_internal, if not ending with _test.dart
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//48763003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29420 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 09:02:14 +00:00
b5373a419a
Run all tests inside an iframe + restrict number of chrome browser processes on mac
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//49043003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29367 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 16:31:18 +00:00
cf822a851a
test.py: Run the analyzer on all dart files in the sdk.
...
BUG=http://dartbug.com/13024
R=ricow@google.com
Review URL: https://codereview.chromium.org//47743005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29362 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 14:45:59 +00:00
94ebff2225
Bugfix in test.dart, adding of specialized test outcomes for analyzer
...
This CL will:
- fix a bug in the legacy AnalyzerCommandOutputImpl class (in certain cases
we did not report that the analyzer was missing a warning).
- make the outcome of running the analyzer on a test be one of:
* CompileTimeError
* MissingCompileTimeError
* StaticWarning
* MissingStaticWarning
- Make status file updates using the new Expectation markers
- Remove support for '@static-clean':
Previously running the analyer on a test could either result in
'Pass' or in 'Fail'. The '@static-clean' annotation has been used
as a (poor) mechanism to distinguish between errors and warnings.
Having the 4 markers mentioned above means we can remove '@static-clean'
- Remove 100 lines of rotted legacy code in our testing scripts.
- Make a status file entry for every test that has analyzer errors or warnings
R=ricow@google.com
Review URL: https://codereview.chromium.org//46163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29350 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 10:39:38 +00:00
7ac0b7d0bd
Rename analyzer_experimental to analyzer.
...
R=jmesserly@google.com , pquitslund@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//45573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29302 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 23:59:38 +00:00
bdc3343090
Adds test target for Dartium on Android.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//43773005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29293 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 21:34:25 +00:00
5572278a23
Changes to run tests on Dartium content shell on Android.
...
- In browser_controller.dart, adds a drtOnAndroid Browser.
- Adds flags for starting test servers at fixed ports.
- This is needed so that android reverse port forwarding
can be set up in advance.
- Adds setProp to android.dart to be used in lieu of
environment variables when testing on Android.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//29773006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29259 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 16:39:48 +00:00
746d924e59
co19-roll to r641
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//44263003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29255 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 15:07:10 +00:00
3a01260611
Remove dart:json
...
BUG= http://dartbug.com/12843
R=floitsch@google.com , fschneider@google.com
Review URL: https://codereview.chromium.org//40323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29240 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 10:30:34 +00:00
ea765638fb
Updated webdriver setup script to use new location for downloads.
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//33003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29200 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 20:01:48 +00:00
b3ba5c5c95
test.py: Support for running tests in checked mode on none-dartium with the browser controller
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//38753008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29175 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 15:37:33 +00:00
ccb7d5304f
fix issue 14300 -- polymer tests under CSP
...
R=ricow@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//34483003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29020 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:29:46 +00:00
kustermann@google.com