dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
21,047 Commits 2 Branches 0 Tags
727d29d6b6d4324595750411647789d2fd39dbb4
Commit Graph

89 Commits

Author SHA1 Message Date
asiva@google.com 1f9f8ecf7a - Setup infrastructure to white list some native methods as not requiring 
auto setup of Dart API scopes
- List some functions in the list to check out the infrastructure. Performance
  gains from listing these:

  firstChild         222.33 to 309.6903096903097
  lastChild          217.56 to 306.0
  nextSibling        363.00 to 514.0
  previousSibling    357.64 to 506.0
  nextSiblingDynamic 348.01 to 511.0
  childNodes         309.38 to 444.5554445554446

R=rmacnak@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//119543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31342 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-20 19:02:04 +00:00
asiva@google.com 3b1902e54a Add auto scope setup parameter to the native resolvers in preparation for 
https://codereview.chromium.org/117723002/

R=vsm@google.com

Review URL: https://codereview.chromium.org//113913010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31287 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-19 17:48:14 +00:00
rmacnak@google.com b149db19e3 Changes to generated code for templatized DartDOMWrapper::lookupWrapper. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//100923004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31050 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-11 00:21:46 +00:00
asiva@google.com dd18f8d84f Change generator to pass in domData in calls to createWrapper. 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//110513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31034 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-10 18:36:10 +00:00
whesse@google.com 7010c7b798 Don't write generated C++ bindings twice, only once. 
R=kustermann@google.com

Review URL: https://codereview.chromium.org//70453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30198 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-12 17:16:17 +00:00
jacobr@google.com fa8b243f62 Add JsArray 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//41163005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29393 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-28 20:46:36 +00:00
vsm@google.com db97191375 Dartium fixes for latest Blink rolls. 
TBR=blois@google.com

Review URL: https://codereview.chromium.org//37203003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29085 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 15:00:32 +00:00
jacobr@google.com c274135947 Revert "Revert breaking CL" 
This reverts commit 582a7848d7ad11fe981257598124431e36a9c982.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//35513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29014 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 18:15:03 +00:00
vsm@google.com e92900f914 Revert breaking CL 
Revert "Companion to https://codereview.chromium.org/33973002 Generate correct source locations for Dart log messages."

TBR=jacobr@google.com
BUG=

Review URL: https://codereview.chromium.org//32643009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28981 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 04:30:23 +00:00
jacobr@google.com c74e0cec97 Companion to https://codereview.chromium.org/33973002 Generate correct source locations for Dart log messages. 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//33993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28976 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 00:46:02 +00:00
jacobr@google.com 5ee178076a A few API changes: 
Remove Callback in favor of directly using closures or JsFunction.withThis().
Move jsify() to a named constructor on JsObject.
 - Throw on types other than Map and Iterable.
 - Handle cycles
Add JsObject.fromDartObject() which force a transferrable native to be proxied.

Still to do: Reach a conclusion on Serializable

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//27514003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28902 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-19 04:36:10 +00:00
blois@google.com e7aef33a2c Fixing custom element type extensions in Dartium to have correct native type ID 
This is in support of the recent change to write the native type ID to the Dart wrappers

Dart changes for https://codereview.chromium.org/27769002/

BUG=14190
R=vsm@google.com

Review URL: https://codereview.chromium.org//29033003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28899 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-18 23:43:45 +00:00
asiva@google.com ab61301521 Generate a class table of all the IDL classes in the database. This table is used 
to access the C++ class hierachy information to do a proper subtype of check.

The new subtype of check improves the following benchmarks
Dromaeo-drt dom-modify appendChild runs-per-second from 889.0 to 1575.0
Dromaeo-drt dom-modify insertBefore runs-per-second from 592.4075924075925 to 1298.0

The generated class table is as follows:
enum {
    _HistoryCrossFrameClassId = 0,
    _LocationCrossFrameClassId,
    _DOMWindowCrossFrameClassId,
    _DateTimeClassId,
    // New types that are not auto-generated should be added here.

    ANGLEInstancedArraysClassId,
    AbstractWorkerClassId,
    ....
    ....
};
typedef struct {
    const char* class_name;
    int library_id;
    int base_class_id;
    bool is_node;
    bool is_active;
    bool is_event;
} _Classinfo;
typedef _Classinfo _DartWebkitClassInfo[NumWebkitClassIds];

_DartWebkitClassInfo DartWebkitClassInfo = {
    { "_HistoryCrossFrame", DartHtmlLibraryId, -1, false, false, false },
    { "_LocationCrossFrame", DartHtmlLibraryId, -1, false, false, false },
    { "_DOMWindowCrossFrame", DartHtmlLibraryId, -1, false, false, true },
    { "DateTime", DartCoreLibraryId, -1, false, false, false },
    // New types that are not auto-generated should be added here.

    { "AngleInstancedArrays", DartWebGlLibraryId, -1, false, false, false, },
    { "AbstractWorker", DartHtmlLibraryId, -1, false, false, false, },
    .....
    .....
};

R=rmacnak@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//27358002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28821 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-17 20:27:30 +00:00
blois@google.com 89802cee42 Updating CustomElement lifecycle scope logic 
More closely following what V8 is doing in:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.pm&l=1725

Primary issue was that this was being emitted in too many places (getters and attributes which didn't need it).

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//25675008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28818 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-17 20:13:14 +00:00
asiva@google.com 33b96c8696 Pass in domData as a parameter to unwrapDartWrapper. 
R=rmacnak@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//26051003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28353 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-08 03:25:48 +00:00
asiva@google.com 19a260904e Generate a library ID instead of a library name, so that the ID can be used 
to get the library handles from the cache (avoids having to lookup everytime)

R=rmacnak@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//25626002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28226 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-03 16:21:17 +00:00
blois@google.com c801e99a65 Adding custom element lifecycle processing to all attribute modifiers. 
This is needed for the custom element attributeChanged lifecycle event. It appears to be the same thing that V8 is currently doing.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//25666008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28179 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-02 19:48:10 +00:00
blois@google.com 354c4dd5ad Revert "Revert "Start of dartium custom element lifecycle event support."" 
Primary changes are that a fast-path has been added for the single-argument Document.createElement and the systemnative.py changes were split out to CL https://codereview.chromium.org/24661002/.

This is dependent on https://codereview.chromium.org/24677002/

First patch is the original, second is the updates.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24491003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27921 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-25 23:15:09 +00:00
blois@google.com f4734449cd Emitting CustomElementCallbackDispatcher for all APIs impacting custom element lifecycle 
This is part of getting custom element lifecycles working in Dart and follows the same model that V8 is using. Basically it ensures that the lifecycle events are processed after any operations which may have custom element side-effects.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24661002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27910 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-25 20:34:33 +00:00
blois@google.com 3fd115d5e3 Revert "Start of dartium custom element lifecycle event support." 
This reverts commit 27718 to see if it gets performance back down.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24479002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27897 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-25 17:56:53 +00:00
asiva@google.com 928894a58c - Added Dart_GetNativeIsolateData so that the bindings code can access the IsolateCurrentData 
where possible without having to invoke Isolate::Current()
- Modified lookupWrapper to accept DartDOMData as a parameter so that the return to Dart functions
  won't invoke Isolate::Current()

Some Dromaeo numbers before this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr getAttribute runs-per-second 1162.2
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr element_property_access runs-per-second 1255.6

after this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr getAttribute runs-per-second 1237.6
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr element_property_access runs-per-second 1385.4

R=rmacnak@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//24376005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27789 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-23 23:53:39 +00:00
blois@google.com 34f58a8209 Start of dartium custom element lifecycle event support. 
These are the Dart repo changes paired with https://codereview.chromium.org/24294002/

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//23817006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27718 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-20 18:40:11 +00:00
asiva@google.com ca128dea70 - Modify toDart to first do a simple lookup in the appropriate table before going down the templatized 
morass of switch statements
- Add a returnToDart function so that the WeakPersistent Handle returned from a lookup/create of the wrapper
  could be returned as is without the need to call Dart_handleFromWeakPersistentHandle
- Use Dart_SetDoubleReturnValue for doubles

some DromaeoDartium numbers before this change:

CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(div) runs-per-second 84240.6
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-traverse nextSibling runs-per-second 207.91683326669332
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(*) runs-per-second 69599.2

some DromaeoDartium numbers after this change:

CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(div) runs-per-second 104252.4
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-traverse nextSibling runs-per-second 366.8
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(*) runs-per-second 94922.6

R=rmacnak@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//23681014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27710 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-20 16:25:12 +00:00
jacobr@google.com 013e3bb062 Dart binding changes to along with Blink merge 155942-156717 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23829002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26948 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-30 21:24:02 +00:00
blois@google.com 87e39090a1 Exposing native doubles as doubles when they are read-only or method return values. 
This keeps num for parameters of operations and fields which are settable. Requested because some DOM APIs (such as Performance.now) don't really make sense returning ints.

BUG=11133
R=vsm@google.com

Review URL: https://codereview.chromium.org//21555003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26817 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-28 21:07:13 +00:00
asiva@google.com 4f6536ba66 Use new Dart API functions 
Dart_GetNativeIntegerArgument
Dart_GetNativeBooleanArgument
Dart_GetNativeDoubleArgument

R=vsm@google.com

Review URL: https://codereview.chromium.org//22859038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26500 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-22 01:15:58 +00:00
jacobr@google.com 339b0bdd70 Attempt to land Dartium roll a second time. 
BUG=

Review URL: https://codereview.chromium.org//23064024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26363 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-20 15:54:49 +00:00
jacobr@google.com c6ebe4e4e0 rollback problem blink merge cl 
Review URL: https://codereview.chromium.org//23163010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26339 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-20 06:22:24 +00:00
jacobr@google.com 785c8416bc Changes required for Dartium roll 
Merge checkpoint. Everything compiles.

BUG=

Review URL: https://codereview.chromium.org//22886009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26335 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-20 01:50:17 +00:00
asiva@google.com 24c3ca0b47 Fix for issue 12489. 
R=vsm@google.com

Review URL: https://codereview.chromium.org//23295016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26327 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-19 20:44:33 +00:00
asiva@google.com f010ffa98d - Add a new toNative which accepts Dart_NativeArguments as a parameter. 
Currently it is implemented as two calls to the API to get at the native
  wrapper (will be made one call in another CL).
- Use the new API call Dart_SetWeakHandleReturnValue to return a string
  from the cache directly without having to call Dart_NewHandle(...)

R=vsm@google.com

Review URL: https://codereview.chromium.org//22694004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26148 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-14 20:45:40 +00:00
vsm@google.com cd7a678e83 Use DartExceptionState 
R=blois@google.com

Review URL: https://codereview.chromium.org//22605010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25953 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-08 22:56:57 +00:00
asiva@google.com abb3ca866b Do not generate calls to Dart_EnterScope/Dart_ExitScope around native 
callbacks as an ApiLocalScope is auto created by the VM when making
external native calls.

R=vsm@google.com

Review URL: https://codereview.chromium.org//22392006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25846 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-06 23:57:50 +00:00
vsm@google.com c5dd3d3ba7 MERGE: 152953-155080 
TBR=jacobr@google.com,blois@google.com

Review URL: https://codereview.chromium.org//22357003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25832 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-06 21:17:56 +00:00
asiva@google.com 7376bf6cf2 Alter the native code generator to directly use 
Dart_SetBooleanReturnValue
 Dart_SetIntReturnValue
 Dart_SetDoubleReturnValue

instead of 
 Dart_Handle retval = toDart(...); // Calls Dart_Boolean, Dart_NewInteger,
                                   // Dart_Double.
 Dart_SetReturnValue(args, retval);

R=vsm@google.com

Review URL: https://codereview.chromium.org//21156011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25698 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-01 00:58:22 +00:00
blois@google.com 651836e67b Fixing some SVG collections not working on Dartium. 
Issue was that we were generating code calling native methods which were not present for these SVG collections.

BUG=11204
R=vsm@google.com

Review URL: https://codereview.chromium.org//21085008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25682 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-31 20:18:42 +00:00
vsm@google.com 992776552a Fixes for Blink roll. 
TBR=jacobr@google.com,asiva@google.com

Review URL: https://codereview.chromium.org//19820007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25395 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-24 04:46:29 +00:00
amouravski@google.com c0a39d0412 Make html metadata follow the spec. 
Per https://code.google.com/p/dart/issues/detail?id=11568

R=scheglov@google.com

Review URL: https://codereview.chromium.org//18182010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24638 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-01 18:34:30 +00:00
blois@google.com 9dd81d94a7 Fixing up DOM constructors. 
This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//18054021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-29 00:14:23 +00:00
blois@google.com 6b44f65407 Revert "Making all DOM types abstract and removing superfluous Dartium constructors." 
This reverts commit http://code.google.com/p/dart/source/detail?r=24241.

Compiler error, not sure of best fix.

BUG=

Review URL: https://codereview.chromium.org//17508002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 19:37:47 +00:00
blois@google.com c3547d4e9b Making all DOM types abstract and removing superfluous Dartium constructors. 
Adding factory constructors to all classes to suppress missing generative constructor warnings.

Adding a throw to Dartium's base DOM class to prevent construction of native objects.

This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//17063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 17:31:36 +00:00
antonm@google.com a352956d29 Chrome roll 202464->204370. 
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//16234006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23743 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-07 14:56:12 +00:00
antonm@google.com 081a2be830 Allow null strings in setters. 
V8 generator always allows nulls for Reflect attributes of type
DOMString.  That looks somewhat hairy, but let's just follow the logic
for Dart as well.

R=podivilov@chromium.org
BUG=8189

Review URL: https://codereview.chromium.org//16329002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23541 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-03 13:26:11 +00:00
vsm@google.com b85b97cbe6 Fixes for Blink roll to r151189 
TBR=antonm

Review URL: https://codereview.chromium.org//16308002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23511 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-02 18:34:36 +00:00
blois@google.com a1f522165f Modernizing HttpRequest documentation. 
Also fixing docs so they get applied to Dartium.

BUG=https://code.google.com/p/dart/issues/detail?id=10547
R=efortuna@google.com

Review URL: https://codereview.chromium.org//15819003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23303 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-28 19:33:06 +00:00
antonm@google.com fd3c7da1ee Verify that correct number of arguments was passed. 
R=amouravski@google.com

Review URL: https://codereview.chromium.org//15850004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23296 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-28 17:42:13 +00:00
antonm@google.com 6e51015ab7 Remove now unused attribute. 
R=vsm@google.com

Review URL: https://codereview.chromium.org//15732002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23033 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-22 18:12:59 +00:00
antonm@google.com 1d6243bb18 Changes for the roll. 
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//15250010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22942 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-21 14:18:00 +00:00
vsm@google.com 8379279dc0 Retry "Changes for webkit roll 148757-149482" 
TBR=antonm

Review URL: https://codereview.chromium.org//14948011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22801 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-16 16:39:09 +00:00
vsm@google.com 45fc399cf7 Revert "Changes for webkit roll 148757-149482" 
TBR=antonm

Review URL: https://codereview.chromium.org//14636013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22769 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-16 06:06:49 +00:00