4dd740e2de
Fix bug 15417
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//103933005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31032 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 18:25:41 +00:00
cb0fa66a9b
Fixing BeforeUnloadEvent.returnValue
...
This is an update of https://codereview.chromium.org/54913005/ which was failing on the Dartium bots.
Original is patch #1 , fix is #2 (re-ordering the parts in html_dartium).
Issue with the original appears to be that parts have some order-dependency in the VM when executing with --error_on_bad_type, which is used in snapshotting.
Opened bug https://code.google.com/p/dart/issues/detail?id=14721
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//55903004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29766 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 19:53:45 +00:00
7046fc201e
Revert "Fixing the BeforeUnloadEvent"
...
Causing problems with build on Dartium:
class _CustomEventStreamImpl<T extends Event> extends Stream<T>
^
'file:///mnt/data/b/build/slave/dartium-lucid32-full-be/build/src/dart/tools/dom/src/EventStreamProvider.dart': Error: line 334 pos 41: type '_CustomEventStreamImpl<KeyEvent>' has an out of bound type argument
class _CustomKeyEventStreamImpl extends _CustomEventStreamImpl<KeyEvent>
TBR
BUG=
Review URL: https://codereview.chromium.org//54923006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29754 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 16:37:33 +00:00
a948d4384a
Fixing the BeforeUnloadEvent
...
Basically the last Blink upgrade introduced the BeforeUnloadEvent which conflicted with our previous polyfill. Our definition was removed, but the suppression remained for Event.returnValue.
The suppression is still needed since that's the incorrect type and on the wrong class, so I modified our metadata lookup to allow it to only target exact class matches (and not super classes).
BUG=
R=efortuna@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//54913005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29752 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 16:17:38 +00:00
79b447a313
Renamed XmlHttpRequestEventTarget to remove Xml for consistency.
...
R=blois@google.com
Review URL: https://codereview.chromium.org//49013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29385 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 19:54:00 +00:00
45701cfb4b
Second round of deprecation removal.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//41843003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29275 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:39:09 +00:00
9b40aca70c
Remove the low hanging deprecation fruit.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//41753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29219 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 22:13:51 +00:00
7e685302b9
Add back unseparated out version of method overloads in dart:html.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//34733007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29135 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 00:07:45 +00:00
db97191375
Dartium fixes for latest Blink rolls.
...
TBR=blois@google.com
Review URL: https://codereview.chromium.org//37203003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29085 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 15:00:32 +00:00
360ea42322
Rename mdv -> template_binding, remove experiemntal apis from dart:html
...
essentially, we trade off reduce dart:html API surface area for more annoying usage of these APIs. Since Polymer hides most of this, I suspect it won't be too annoying in practice.
Sample usage:
nodeBind(node).bind(...)
templateBind(node).model = ...;
R=sigmund@google.com
Review URL: https://codereview.chromium.org//34453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29057 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 02:11:49 +00:00
15e086338d
Revert "Revert "Removing some deprecated members""
...
Take-two of https://code.google.com/p/dart/source/detail?r=29022
The issue with the original was that addEventListener was changed to private, but this caused the IDB classes which override it to not override it any longer. This was breaking C++ multiple inheritance type casts. Fix is to make addEventListener public.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//35013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29051 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:44:10 +00:00
a4a2e26bde
Reapply lineDash with polyfill.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//35623004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29050 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:15:36 +00:00
3aef09e008
Revert "Removing some deprecated members"
...
For some reason this broke indexed_db on Dartium, I debugged in some but need more time to understand. The completed event is not firing.
TBR
BUG=
Review URL: https://codereview.chromium.org//32523007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29033 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 20:20:32 +00:00
e2c4716609
Removing some deprecated members
...
These are all DOM APIs that we had annotated as deprecated but not actually removed. They've all been deprecated for quite a while.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//30353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29022 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:42:01 +00:00
8b4e5e92ba
"Reverting 29013"
...
TBR
BUG=
Review URL: https://codereview.chromium.org//35723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29017 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:25:40 +00:00
f4e40d6d9a
Make getLineDash return [] instead of null if it has not yet been set.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//27983005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29013 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 17:40:58 +00:00
e3b35dabb6
Renaming Node.document back to Node.ownerDocument
...
With custom elements, the document instance variable creates an odd conflict with the document global.
BUG=14099
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//27602002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28810 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 17:55:38 +00:00
333054ee75
Supporting non-SSVs in CustomEvent.detail
...
BUG=12641
R=vsm@google.com
Review URL: https://codereview.chromium.org//27308006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28758 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 23:09:33 +00:00
19655e4e6b
Revert "Revert "Removing setImmediate and hiding WindowTimers interface""
...
Issue was that requestAnimationFrame got removed from Dartium during a merge conflict :(
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//27441002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28700 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:50:49 +00:00
951dca71cb
Deprecate query and queryAll, also add back querySelector and querySelectorAll.
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//27223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28699 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:44:47 +00:00
8e255ada0f
Revert "Removing setImmediate and hiding WindowTimers interface"
...
This reverts commit 28690.
TBR
BUG=
Review URL: https://codereview.chromium.org//27440002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28696 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:16:59 +00:00
303710040b
Removing setImmediate and hiding WindowTimers interface
...
These timing APIs are all redundant with dart:async and those versions should be used instead.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//26534005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28690 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 23:52:09 +00:00
9baacafa7a
Making all callbacks use zones (take 2)
...
Changes: fixed parameter ordering for RTCPeerConnection.getStats and fixed error for StorageInfo.
Revert "Revert "Making all callbacks use zones""
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//27240004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28674 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 19:07:22 +00:00
e1d441b22f
Revert "Making all callbacks use zones"
...
This reverts commit 28607, running into analyzer issues.
TBR
BUG=
Review URL: https://codereview.chromium.org//27232003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28609 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 20:23:11 +00:00
84a3415e82
Making all callbacks use zones
...
This was primarily converting APIs to use Futures, all appear to be new ones since we did the last pass.
MutationObserver and Window.requestAnimationFrame had to be fixed manually.
BUG=
R=efortuna@google.com , floitsch@google.com
Review URL: https://codereview.chromium.org//27082002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28607 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 19:49:17 +00:00
19a260904e
Generate a library ID instead of a library name, so that the ID can be used
...
to get the library handles from the cache (avoids having to lookup everytime)
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//25626002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28226 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 16:21:17 +00:00
d5212a6ac0
Make OptionElement construtor arguments named optional parameters.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//25585002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28115 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 20:33:49 +00:00
354c4dd5ad
Revert "Revert "Start of dartium custom element lifecycle event support.""
...
Primary changes are that a fast-path has been added for the single-argument Document.createElement and the systemnative.py changes were split out to CL https://codereview.chromium.org/24661002/ .
This is dependent on https://codereview.chromium.org/24677002/
First patch is the original, second is the updates.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24491003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27921 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 23:15:09 +00:00
3854434797
Removed position and totalSize because HttpRequestProgressEvent has other fields that do the same thing.
...
Turns out position and totalSize were on Firefox 3 and earlier, but we don't
have to worry about backwards compatibility that far.
https://developer.mozilla.org/es/docs/XMLHttpRequest/Usar_XMLHttpRequest
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//24427003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27900 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 18:03:20 +00:00
d312cbbd08
Exposing document.createElement
...
As part of removing all $dom_ APIs, making this one public. There are valid scenarios for creating elements in other documents.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//24084004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27415 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 00:00:39 +00:00
647d73af0f
Fix for CSS URIs not parsing correctly with innerHTML
...
Chrome has a bug (https://code.google.com/p/chromium/issues/detail?id=229142 ) where CSS URIs are not converting correctly when an element is parsed in one document then moved to another document. This uses a base element to set the baseURI of the parse document so it doesn't need to be converted on clone.
BUG=13147
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23903020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27305 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 19:06:27 +00:00
9f52a2969c
Added back childNodes and getAttribute and setAttribute.
...
This is a quick check to verify that it was this CL:
https://codereview.chromium.org/23189014/ was the cause of the performance
regression. If it is, I have some ideas of potential performance improvements
going forward that we should investigate, and I'll also investigate why I wasn't
getting this performance behavior on my machine locally. Either way, expect at
least one additional change on these APIs going forward.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23808005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27139 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 19:34:39 +00:00
b14e379d94
Cleaning up a bunch of DOM generation tables
...
Many unused keys and missing events, etc.
BUG=
R=efortuna@google.com , jacobr@google.com
Review URL: https://codereview.chromium.org//23889005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27137 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 18:30:54 +00:00
013e3bb062
Dart binding changes to along with Blink merge 155942-156717
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23829002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26948 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 21:24:02 +00:00
47dcd084f3
Removing more dom_ methods (dom_getAttribute and dom_setAttribute.).
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23189014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26928 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 17:18:40 +00:00
93c361dd36
This is an updated version of https://codereview.chromium.org/16374007/
...
Original submission is the first patch, fixes are the second.
There were two issues with the original-
- Issue with URI sanitization where relative URIs on IE were being dropped.
- Analyzer issue on missing members for CustomElement.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23525003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26757 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 01:03:01 +00:00
24e9f22c90
Revert "First rev of Safe DOM"
...
This reverts commit 26681.
Some IE issues with URL validation that I need to investigate further.
BUG=
Review URL: https://codereview.chromium.org//23523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26682 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 02:18:48 +00:00
63ecf1a3fd
First rev of Safe DOM
...
BUG=
R=jacobr@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//16374007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26681 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 01:48:13 +00:00
90873051ad
Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
...
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23055008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
69bea8b4e8
Suppress getPresentationAttribute
...
Should fix analyzer bot.
TBR=jacobr@google.com ,blois@google.com
Review URL: https://codereview.chromium.org//23004006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26364 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 16:19:05 +00:00
339b0bdd70
Attempt to land Dartium roll a second time.
...
BUG=
Review URL: https://codereview.chromium.org//23064024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26363 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 15:54:49 +00:00
c6ebe4e4e0
rollback problem blink merge cl
...
Review URL: https://codereview.chromium.org//23163010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26339 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 06:22:24 +00:00
785c8416bc
Changes required for Dartium roll
...
Merge checkpoint. Everything compiles.
BUG=
Review URL: https://codereview.chromium.org//22886009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26335 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 01:50:17 +00:00
7c85f03cc9
Move _HTMLElement to HtmlElement
...
The old HtmlElement is now HtmlHtmlElement. The custom tests don't break for now. I'll modify them in a separate CL to inherit from HtmlElement instead.
R=blois@google.com
Review URL: https://codereview.chromium.org//23151005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26248 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 00:46:10 +00:00
affaf4c2df
Renaming Crypto's new horribly generic class 'Key' to CryptoKey.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//21929004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26142 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 19:54:44 +00:00
4d51b41ff8
Initial Dartium custom element support
...
This will need to be rebased with Stephen's CL or vice versa. The test mod is taken from his CL.
R=blois@google.com
Review URL: https://codereview.chromium.org//22912004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26141 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 19:47:07 +00:00
3304c64b52
Make includeAncestors match a separate method.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//22305005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25979 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 20:41:48 +00:00
9fdbcf176c
Add includeAncestors to dartium matches call.
...
BUG=
Review URL: https://codereview.chromium.org//22529004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25975 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 20:21:50 +00:00
0094164ae8
Regenerating DOM types from IDL roll.
...
TBR=vsm
BUG=
Review URL: https://codereview.chromium.org//22352004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25849 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 00:57:08 +00:00
c5dd3d3ba7
MERGE: 152953-155080
...
TBR=jacobr@google.com ,blois@google.com
Review URL: https://codereview.chromium.org//22357003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25832 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 21:17:56 +00:00
jacobr@google.com