1bbe4d5452
Make sure that classes in dart:html do not implement both List and List<E>.
...
R=johnniwinther@google.com , blois@google.com
BUG=
Review URL: https://codereview.chromium.org//50263004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29417 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 08:37:10 +00:00
7e685302b9
Add back unseparated out version of method overloads in dart:html.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//34733007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29135 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 00:07:45 +00:00
15e086338d
Revert "Revert "Removing some deprecated members""
...
Take-two of https://code.google.com/p/dart/source/detail?r=29022
The issue with the original was that addEventListener was changed to private, but this caused the IDB classes which override it to not override it any longer. This was breaking C++ multiple inheritance type casts. Fix is to make addEventListener public.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//35013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29051 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:44:10 +00:00
3aef09e008
Revert "Removing some deprecated members"
...
For some reason this broke indexed_db on Dartium, I debugged in some but need more time to understand. The completed event is not firing.
TBR
BUG=
Review URL: https://codereview.chromium.org//32523007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29033 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 20:20:32 +00:00
e2c4716609
Removing some deprecated members
...
These are all DOM APIs that we had annotated as deprecated but not actually removed. They've all been deprecated for quite a while.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//30353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29022 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:42:01 +00:00
035e04fb2d
Making all base class DOM types throw as well (to prevent a default constructor for DOM types that are not constructable).
...
BUG=https://code.google.com/p/dart/issues/detail?id=11620
R=blois@google.com
Review URL: https://codereview.chromium.org//27033009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28615 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 21:58:46 +00:00
f51dad91fd
Untyping List types
...
Making all DOM lists implement List rather than List<T>. This is primarily for NodeList which is used in cases where it's just a list of Elements and allows us to assign it to List<Element> without type checks.
BUG=
R=sra@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//27227002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28597 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 18:36:59 +00:00
d5212a6ac0
Make OptionElement construtor arguments named optional parameters.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//25585002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28115 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 20:33:49 +00:00
d312cbbd08
Exposing document.createElement
...
As part of removing all $dom_ APIs, making this one public. There are valid scenarios for creating elements in other documents.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//24084004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27415 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 00:00:39 +00:00
4d8651f8af
1. Make direct calls to _nativeIndexedGetter in "get last" "get first" "get single" instead of calling the "[]" operator. This avoids one additional native call to the length method for each call to "last" "first" or "single"
...
2. Fix templateloader to deal with nested 'if' conditions
R=vsm@google.com
Review URL: https://codereview.chromium.org//23534050
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27270 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 23:22:31 +00:00
87e39090a1
Exposing native doubles as doubles when they are read-only or method return values.
...
This keeps num for parameters of operations and fields which are settable. Requested because some DOM APIs (such as Performance.now) don't really make sense returning ints.
BUG=11133
R=vsm@google.com
Review URL: https://codereview.chromium.org//21555003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26817 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 21:07:13 +00:00
90873051ad
Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
...
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23055008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
339b0bdd70
Attempt to land Dartium roll a second time.
...
BUG=
Review URL: https://codereview.chromium.org//23064024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26363 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 15:54:49 +00:00
c6ebe4e4e0
rollback problem blink merge cl
...
Review URL: https://codereview.chromium.org//23163010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26339 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 06:22:24 +00:00
785c8416bc
Changes required for Dartium roll
...
Merge checkpoint. Everything compiles.
BUG=
Review URL: https://codereview.chromium.org//22886009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26335 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 01:50:17 +00:00
59c29150b4
Removing overloaded operations in dart2js.
...
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//22933003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26041 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 22:23:42 +00:00
992776552a
Fixes for Blink roll.
...
TBR=jacobr@google.com ,asiva@google.com
Review URL: https://codereview.chromium.org//19820007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25395 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 04:46:29 +00:00
f81052f2c8
Reapply expanding overloaded functions into separate functions.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//18577002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24709 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 22:32:44 +00:00
3629744086
"Reverting 24655"
...
BUG=
Review URL: https://codereview.chromium.org//18277003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24656 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 21:09:19 +00:00
fc0df10d8b
Expand overloaded methods and optional parameters in the html library.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//16494002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24655 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 20:49:07 +00:00
c0a39d0412
Make html metadata follow the spec.
...
Per https://code.google.com/p/dart/issues/detail?id=11568
R=scheglov@google.com
Review URL: https://codereview.chromium.org//18182010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24638 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 18:34:30 +00:00
9dd81d94a7
Fixing up DOM constructors.
...
This is a continuation of https://codereview.chromium.org/17063007/
Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//18054021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
6b44f65407
Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
...
This reverts commit http://code.google.com/p/dart/source/detail?r=24241 .
Compiler error, not sure of best fix.
BUG=
Review URL: https://codereview.chromium.org//17508002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
c3547d4e9b
Making all DOM types abstract and removing superfluous Dartium constructors.
...
Adding factory constructors to all classes to suppress missing generative constructor warnings.
Adding a throw to Dartium's base DOM class to prevent construction of native objects.
This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//17063007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
ab50cfcc68
Adding annotations for native types of type Object or dynamic.
...
Also added generation warnings to try to detect these.
BUG=10946
R=sra@google.com
Review URL: https://codereview.chromium.org//16638013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23875 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 19:46:57 +00:00
768d611f4e
Remove more question marks.
...
R=antonm@google.com , blois@google.com
Review URL: https://codereview.chromium.org//14976004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23563 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 19:56:58 +00:00
fd3c7da1ee
Verify that correct number of arguments was passed.
...
R=amouravski@google.com
Review URL: https://codereview.chromium.org//15850004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23296 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 17:42:13 +00:00
7156616c08
Revert to ? presence checks.
...
TBR=amouravski@google.com
Review URL: https://codereview.chromium.org//15960004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23127 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 09:02:25 +00:00
f968d3465c
Added tests to previously broken functionality and added null checks.
...
R=antonm@google.com
Review URL: https://codereview.chromium.org//15138002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23123 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 08:23:24 +00:00
f297525d5a
Adding annotations to DOM constants.
...
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//15043005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22589 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-10 17:39:40 +00:00
bc44aa444e
Changed the order of optional parameter creation so that they're created from
...
last to first.
R=blois@google.com
Review URL: https://codereview.chromium.org//14863011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22578 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-10 00:02:58 +00:00
75770524fa
Changing metadata lookup to always use interface.id
...
We had some discrepancies where interface lookup was using interface.doc_js_name but member lookup was using interface.id.
Standardized on interface.id.
Also updated the @DomName annotation to always use the JS interface name, which should help with MDN fallback documentation.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//14651019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22556 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-09 18:41:07 +00:00
0c48687c86
Updating DOM code to use list mixins
...
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//14036014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22512 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-08 15:45:30 +00:00
585621924c
Remove outdated DOM generation check
...
This doesn't appear to be used any more (removing it had no effect), other than to drive John nuts when he tries to rename a member.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//14708003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22296 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-02 00:21:52 +00:00
72cf63c068
Refactoring DOM annotations and comment generation, adding DOM API triage list
...
This pulls the annotation and comment code out of generator.py and into a Metadata class, which is also tracking new APIs from the IDLs.
Right now the API triage list is being updated when new members appear, but is not adding any metadata to the Dart APIs. Of note for the triage list is that there are currently 437 untriaged members- these are all of the APIs which have either been introduced, renamed or moved in the past week.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//14455007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22193 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-30 18:35:30 +00:00
98f022a003
First try at removing ? from HTML.
...
R=blois@google.com
Review URL: https://codereview.chromium.org//14400004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22163 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-30 02:29:32 +00:00
7291f59cdc
Some more cleanups.
...
R=ager@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//14367047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22026 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-25 12:14:26 +00:00
12d5e65894
Chrome roll.
...
TBR=ager@google.com , podivilov@chromium.org
Review URL: https://codereview.chromium.org//14211014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21967 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 18:02:30 +00:00
ee0f44baff
Update code generator for dartium dart:html with typeddata.
...
R=antonm@google.com , vsm@google.com
BUG=
Review URL: https://codereview.chromium.org//13811054
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21790 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 08:24:41 +00:00
7f79491c06
Move to new dart:typeddata types
...
Mads: if you land this, please rerun go.sh from tools/dom/scripts to regenerate html_dart2js.dart. I didn't include it here to make this patchable.
Stephen: I still need to run the perf tests we talked about to sanity check.
Review URL: https://codereview.chromium.org//14367012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21789 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 08:22:51 +00:00
639cab021b
Changing the IDL DartName= annotation to only operate on a per-member basis, allowing overloaded methods to be renamed independently.
...
This also includes a change to rename one overload of CanvasRenderingContext2D.createImageData as a test case.
The remaining changes are to address differences between old semantics of DartName and new semantics, as well as some ordering differences of generated code.
BUG=
Review URL: https://codereview.chromium.org//12964003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20355 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-21 21:50:15 +00:00
0eba171ced
Make Float{32,64}Array implement List<double>.
...
R=ager@google.com ,blois@google.com ,vsm@google.com
BUG=9282
Review URL: https://codereview.chromium.org//12886032
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20232 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 18:45:18 +00:00
c4437b9274
Reapply the expanded names with the correct form of requestFileSystem on the
...
test.
BUG=
Review URL: https://codereview.chromium.org//12663017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20136 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-16 01:02:25 +00:00
26c5c48fe2
Revert 20127
...
TBR
BUG=
Review URL: https://codereview.chromium.org//12474007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20133 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-16 00:14:27 +00:00
66b399a31e
Fix list syntax in python script.
...
BUG=
Review URL: https://codereview.chromium.org//12457026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20130 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-16 00:06:37 +00:00
3e1f5ce451
Expanded map options to named parameters.
...
BUG=
Review URL: https://codereview.chromium.org//12531013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20127 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:46:13 +00:00
f438ac1d31
Maintain proper signature_index.
...
R=ager@google.com ,podivilov@chromium.org
Review URL: https://codereview.chromium.org//12660007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19851 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 11:38:30 +00:00
72dd746b39
Ensure proper order of overload checks.
...
As dart:typeddata's class can implement both counterpart
of ArrayBufferView and of ArrayBuffer, always favour
treatment of an argument as an ArrayBufferView.
R=ager@google.com ,podivilov@chromium.org
Review URL: https://codereview.chromium.org//12518013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19842 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 09:04:38 +00:00
598ddebb91
Allow more objects to be treated as ArrayBuffer and ArrayBufferView.
...
Temporary ugly hack. Eventually we'll just remap ArrayBuffer and
ArrayBufferView to the proper dart:typeddata types.
R=ager@google.com ,blois@google.com ,podivilov@chromium.org
Review URL: https://codereview.chromium.org//12543021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19794 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 14:36:00 +00:00
58b10f811e
Reapply Futureification.
...
BUG=
Review URL: https://codereview.chromium.org//12543014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19590 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 00:13:57 +00:00
kasperl@google.com