e898028b18
Attempt to deflake our status files
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//109893004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31022 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 15:37:34 +00:00
e86f53598e
Update analyzer statusi file for the dart2js sample I fixed.
...
TBR=ahe@google.com
Review URL: https://codereview.chromium.org//105503007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30889 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-05 12:14:42 +00:00
cfb4941f47
Make the analyzer bots happier.
...
R=nweiz@google.com
Review URL: https://codereview.chromium.org//90193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30691 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 01:31:01 +00:00
aaa1d67a1b
Removed status file entries which refer to non-existent tests
...
Review URL: https://codereview.chromium.org//80913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30518 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-21 13:46:36 +00:00
0bfeaf1772
Status file update for analyze_library test suite
...
Review URL: https://codereview.chromium.org//78563002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30472 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 14:30:25 +00:00
3d910a2a9a
Remove filtering of analyzer warnings/errors by filename
...
The only files that are now not analyzed are the patch files in
"sdk/lib/_internal/lib" and test files (i.e. files ending with "_test.dart")
R=ricow@google.com
Review URL: https://codereview.chromium.org//78483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30471 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 14:06:34 +00:00
431a9699b8
(TBR) Fix for issue 15151
...
Review URL: https://codereview.chromium.org//73453007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30382 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 23:28:57 +00:00
14bc723b31
Fix for issue 14982
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//75043004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30381 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 22:23:34 +00:00
a95d147aa7
Status file update for analyzer
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//72333006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30345 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 13:07:02 +00:00
63ee14720a
Mark version.dart in pub as having a CompileTimeError in the analyzer.
...
BUG=14982
TBR
Review URL: https://codereview.chromium.org//67663002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30136 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-09 02:36:29 +00:00
2d07b5ce90
Update status file.
...
BUG=
Review URL: https://codereview.chromium.org//66413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30105 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-08 09:38:54 +00:00
3651d4879a
Issue 14685. Don't analyzer parts.
...
https://code.google.com/p/dart/issues/detail?id=14685
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//54903009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29781 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 23:46:12 +00:00
d4359631f7
New analyzer snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//51043010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29765 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 19:24:33 +00:00
232df13346
Fix a few warnings and update status file.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//55173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29759 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 17:32:12 +00:00
264678ccf4
Update status file
...
Make correctly for both analyzers.
R=ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//54253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29652 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 07:37:02 +00:00
f97b697ff9
Update status file
...
Analyzer cannot deal with the fromEnvironment const constructors.
R=ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//54183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29646 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 07:04:22 +00:00
587e9186f1
Second attempt at fixing analyzer buildbot redness.
...
Review URL: https://codereview.chromium.org//50493013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29626 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 01:51:20 +00:00
9903368cef
Issue 14580. Fix for extra type arguments applying.
...
https://code.google.com/p/dart/issues/detail?id=14580
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//50683007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29571 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 17:50:22 +00:00
94cd12a7eb
Update analyzer status-file to match recent sdk fixes.
...
BUG=
Review URL: https://codereview.chromium.org//52273003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29523 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 09:55:29 +00:00
6cbe42976e
Issue 14580. Fix for Source in which problem is reported.
...
https://code.google.com/p/dart/issues/detail?id=14580
Now we correctly report problem in list.dart:331
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//47543010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29499 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 22:24:45 +00:00
17e3cc1928
Update some succeeding analyzer tests.
...
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//50603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29436 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 11:42:14 +00:00
338c31bd6d
Revert "Make Analyzer expect a compile time error where none exist."
...
Review URL: https://codereview.chromium.org//50143004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29432 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 10:38:40 +00:00
fcd4ea1241
Make Analyzer expect a compile time error where none exist.
...
It seems most of the async library is suffering from this.
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//50553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29427 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 10:06:07 +00:00
0456d4136b
Run the analyzer on dart files under sdk/ -- even in sdk/_internal, if not ending with _test.dart
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//48763003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29420 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 09:02:14 +00:00
ce4f0aeab6
Mark analyze_library/lib/html/html_common/lists as flaky
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//48913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29363 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 15:04:17 +00:00
cf822a851a
test.py: Run the analyzer on all dart files in the sdk.
...
BUG=http://dartbug.com/13024
R=ricow@google.com
Review URL: https://codereview.chromium.org//47743005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29362 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 14:45:59 +00:00
94ebff2225
Bugfix in test.dart, adding of specialized test outcomes for analyzer
...
This CL will:
- fix a bug in the legacy AnalyzerCommandOutputImpl class (in certain cases
we did not report that the analyzer was missing a warning).
- make the outcome of running the analyzer on a test be one of:
* CompileTimeError
* MissingCompileTimeError
* StaticWarning
* MissingStaticWarning
- Make status file updates using the new Expectation markers
- Remove support for '@static-clean':
Previously running the analyer on a test could either result in
'Pass' or in 'Fail'. The '@static-clean' annotation has been used
as a (poor) mechanism to distinguish between errors and warnings.
Having the 4 markers mentioned above means we can remove '@static-clean'
- Remove 100 lines of rotted legacy code in our testing scripts.
- Make a status file entry for every test that has analyzer errors or warnings
R=ricow@google.com
Review URL: https://codereview.chromium.org//46163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29350 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 10:39:38 +00:00
6a72655d1b
Very simple version of Isolates.
...
R=ajohnsen@google.com , iposva@google.com , kasperl@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//27215002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29271 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:23:00 +00:00
10eac518ef
Fix analyzer test status.
...
Review URL: https://codereview.chromium.org//40703003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29188 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 17:40:26 +00:00
581b368515
New analyzer_experimental snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//27278004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28831 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 22:14:19 +00:00
59fd8f58c8
New analyzer_experimental snapshot.
...
1. "catch (Exception e)" is translated into "on JavaException catch (e)".
2. Java exceptions now extend JavaException.
3. MemberMap moved into resolver, because it is not a generic collection and has references to elements.
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//26096002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28296 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-06 05:11:15 +00:00
7ce03ef926
New analyzer_experimental snapshot.
...
There are couple small changes in analyzer itself:
1. AnalysisCache.entrySet() to return Collection instead of Set - it is expensive to fill actual Set in Dart - hash code, equals, etc. We know there are no duplicates.
2. Matcher in TODO scrapper - there are no start(i) in Dart, I have to change implementation to translate it accurately.
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//24481002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27889 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 16:02:19 +00:00
e6ce94adab
java2dart improvement - use field if getter/setter are trivial.
...
Also analyzer_experimental snapshot.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//23769004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27138 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 19:17:38 +00:00
f6ab02857e
test.py: Fixed incorrect handling of multitest in status files, status file cleanups.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//23721006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27013 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 14:04:59 +00:00
663530693f
New analysis_experimental snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//23080005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26876 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 16:30:24 +00:00
cef46dcaa0
Remove entries in status refering to non-existent files/multitests
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//22846007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26584 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 08:47:58 +00:00
38506f9d57
Remove the LineTransformer from dart:io
...
The LineTransformer has been retired, and is replaced with LineSplitter from dart:convert
R=floitsch@google.com , nweiz@google.com
Review URL: https://codereview.chromium.org//22927016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26419 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 07:35:46 +00:00
5e90751367
Rename Identifier.getElement. Prior to this change the method getElement() was semantically equivalent to getBestElement(), but that was rarely the correct method to be using. I have divided it into getBestElement() and getPropagatedElement(), but in most cases replaced its use with getStaticElement().
...
Please check this carefully. Although all of the tests pass, there's still a possibility that I translated something wrong at some point (especially in code outside engine) and I'd like to catch any mistakes as early as possible.
R=jwren@google.com , messick@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//22854024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26380 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 18:50:28 +00:00
353428a918
Remove the Path class from dart:io
...
The Path class in dart:io has been deprecated for some time
now. It was scheduled to be removed on August 11th, so here it
goes.
dart:io still uses the Path class internally, but now it is
private. I will trim it down to what is actually used in a
follow-up change.
R=ahe@google.com , devoncarew@google.com , whesse@google.com
BUG=http://dartbug.com/11666
Review URL: https://codereview.chromium.org//23054008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26181 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 10:10:53 +00:00
c52c1736ee
New analyzer_experimental snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//22285004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25902 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 21:15:25 +00:00
09bcdc6d6d
Fix VM implementation of CastError not to extend TypeError (issue 5280).
...
Remove non-compliant fields in various Error classes (issue 10144).
Remove implicit constructor when patching in a constructor (issue 12217).
Patch corelib Error classes instead of declaring subclasses.
Update tests and status files.
R=asiva@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//21832003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25782 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 18:35:04 +00:00
8abc6895fd
Fixes analyzer status file.
...
Why do we have to duplicate this information across status files?
Wouldn't it be easier for the analyzer test scripts to use the
existing status files?
Review URL: https://codereview.chromium.org//21410002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25684 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 21:47:08 +00:00
87a578829a
Fix the analyzer status file after 25361
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//19509006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25375 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 22:35:11 +00:00
1b541506ff
Roll forward "Use package:stack_trace in unittest."
...
This reverts r25135, and rolls forward r25131, r25132, and r25133.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//19540015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25169 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-18 19:30:33 +00:00
e93476aa9d
Roll back "Use package:stack_trace in unittest."
...
This reverts r25131, r25132, and r25133.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//19684006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25135 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 23:55:46 +00:00
c09a8caf09
Mark analyzer tests as failing due to issue 11647.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//19702002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25132 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 23:14:25 +00:00
4ac2a1452c
New analyzer_experimental snapshot.
...
FYI bot is red, as I can see this is caused by VM crashes.
https://code.google.com/p/dart/issues/detail?id=11873
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//19590006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25121 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 19:32:30 +00:00
41d8e6ee39
Test running changes.
...
1. Change in the test runner to consider any warning as warning.
After this following was required:
2. Triage language tests.
3. Triage co19 tests.
R=brianwilkerson@google.com , kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//18174010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25069 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-16 20:35:51 +00:00
6c6b88967f
Remove dartc status sections.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//18566003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24735 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 17:50:34 +00:00
b7260126ca
Make some HTTP utility functions public
...
Added a new static function splitQueryString to the URI class to expose parsing of a query string without constructing a URI.
Added class HttpDate in dart:io with a few HTTP date parsing and formatting methods.
Also turned some Uri comments into dartdoc.
I have not remove the parseQueryString and decodeUrlEncodedString from _HttpUtils as they still do some non standard things that I am not sure we want to add to the URI class. These are:
* Supporting semi-colon as separator in query strings (see http://www.w3.org/TR/REC-html40/appendix/notes.html#ampersands-in-uris )
* Supporting other encodings than UTF-8 for percent encoded strings
R=ajohnsen@google.com
BUG=http://dartbug.com/9888
Review URL: https://codereview.chromium.org//16812004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23972 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 12:19:09 +00:00
kustermann@google.com