0c8ac24661
Isolate.spawn{Uri} only reports errors asynchronously.
...
It is generally considered bad style to throw synchronous and asynchronous errors. This CL catches all synchronous errors and reports them in the asynchronous future that is returned.
R=iposva@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//88783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31131 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-13 13:05:28 +00:00
152cf1e3fe
Mark failing dart2js_extra isolate test on chromeOnAndroid platform. Mark two flaky tests with timeouts.
...
BUG=dartbug.com/14458
R=kustermann@google.com
Review URL: https://codereview.chromium.org//113943002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31096 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-12 14:24:06 +00:00
e898028b18
Attempt to deflake our status files
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//109893004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31022 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 15:37:34 +00:00
a03ce2ad10
Make the global port a "weak" port.
...
We could have just removed all references to the lazyPort, but this CL
prepares for using the lazyPort as controlPort.
BUG= http://dartbug.com/14461
R=lrn@google.com , ngeoffray@google.com
Review URL: https://codereview.chromium.org//102473004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30938 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-06 09:31:59 +00:00
c38ca34d79
Update status file.
...
Review URL: https://codereview.chromium.org//95263003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30763 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-28 15:24:53 +00:00
f23edaae4d
Clean up isolate tests.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//92223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30761 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-28 14:36:25 +00:00
90eddd0cee
Mark isolate/isolate2_negative_test as passing on the analyzer
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//91953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30722 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 16:04:42 +00:00
0cf3a346b4
Fix isolate test.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//91703002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30719 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 15:11:36 +00:00
d4394ccdc1
Make isolate tests work on drt (and hopefully dartium).
...
The current isolate tests don't work in drt/dartium because the
DOM isolate can't use Isolate.spawnFunction.
To avoid this problem, this change makes the affected tests start out
by doing an Isolate.spawnUri with their own main file, therevy running the test
in a non-DOM isolate. The test results are propagated back to the original
isolate.
I haven't been able to test dartium yet. I might be missing Selenium.
BUG= http://dartbug.com/14626
R=floitsch@google.com
Review URL: https://codereview.chromium.org//70103014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30610 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 08:19:53 +00:00
2a63af9099
Add RawReceivePort to dart2js.
...
BUG= http://dartbug.com/14456
R=floitsch@google.com , ngeoffray@google.com
Review URL: https://codereview.chromium.org//70263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30456 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 10:36:41 +00:00
ed814958fc
Fix VM not accepting static methods for Isolate.spawn.
...
BUG= http://dartbug.com/3011
Committed: https://code.google.com/p/dart/source/detail?r=30300
R=iposva@google.com
Review URL: https://codereview.chromium.org//68813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30442 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 09:14:30 +00:00
ab18829ae4
Revert "Fix VM not accepting static methods for Isolate.spawn."
...
Comitted by mistake.
Review URL: https://codereview.chromium.org//73893004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30301 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-15 11:23:47 +00:00
b0e40ddc70
Fix VM not accepting static methods for Isolate.spawn.
...
BUG= http://dartbug.com/3011
Review URL: https://codereview.chromium.org//68813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30300 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-15 10:28:32 +00:00
56c59b638c
Fix warning in mandel_isolate_test.
...
BUG= http://dartbug.com/14782
R=kustermann@google.com
Review URL: https://codereview.chromium.org//61233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29944 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-05 23:24:50 +00:00
c3e489730f
Issue 14452. Fix for skipping 'final' modifier in function expression parameters.
...
https://code.google.com/p/dart/issues/detail?id=14452
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//57383007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29838 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 19:13:35 +00:00
ecb4291d96
Remove deprecated second argument to SendPort.send().
...
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//51393004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29836 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 19:01:11 +00:00
59f34542e2
Removed status file entries which refer to non-existent tests
...
R=fschneider@google.com
Review URL: https://codereview.chromium.org//56123009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29811 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 15:28:44 +00:00
5375bc79ad
Remove SendPortSync and ReceivePortSync.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//56153005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29778 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 23:13:21 +00:00
81af1a5ea1
Raise an exception instead of crashing when attempting to pass a MirrorReference between isolates.
...
Fix warnings in isolate illegal values tests.
BUG=http://dartbug.com/14584
R=asiva@google.com
Review URL: https://codereview.chromium.org//51393002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29694 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 20:36:32 +00:00
66c9d75971
Fix analyzer status file.
...
Review URL: https://codereview.chromium.org//53863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29616 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 00:54:47 +00:00
3fa7a61efc
Implement latest spec changes regarding malformed types (see issue 14006):
...
- a malformed type used in a is, as, or catch type test results in a dynamic
type error being thrown.
- a malformed type is not mapped to dynamic anymore.
For now, this applies to type tests in checked mode as well, but discussion is
still on-going.
R=hausner@google.com
Review URL: https://codereview.chromium.org//53583003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29608 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 23:30:32 +00:00
94ebff2225
Bugfix in test.dart, adding of specialized test outcomes for analyzer
...
This CL will:
- fix a bug in the legacy AnalyzerCommandOutputImpl class (in certain cases
we did not report that the analyzer was missing a warning).
- make the outcome of running the analyzer on a test be one of:
* CompileTimeError
* MissingCompileTimeError
* StaticWarning
* MissingStaticWarning
- Make status file updates using the new Expectation markers
- Remove support for '@static-clean':
Previously running the analyer on a test could either result in
'Pass' or in 'Fail'. The '@static-clean' annotation has been used
as a (poor) mechanism to distinguish between errors and warnings.
Having the 4 markers mentioned above means we can remove '@static-clean'
- Remove 100 lines of rotted legacy code in our testing scripts.
- Make a status file entry for every test that has analyzer errors or warnings
R=ricow@google.com
Review URL: https://codereview.chromium.org//46163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29350 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 10:39:38 +00:00
c5d691f64c
Status fix for Dartium bots
...
TBR=asiva@google.com ,floitsch@google.com
Review URL: https://codereview.chromium.org//46183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29301 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 23:30:52 +00:00
93cdda2d69
Fix bad type.
...
Review URL: https://codereview.chromium.org//45473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29286 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 20:51:05 +00:00
ffccd42cae
Update status files.
...
Review URL: https://codereview.chromium.org//38563003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29285 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 20:47:52 +00:00
dcac807c32
Status file updates.
...
Review URL: https://codereview.chromium.org//45433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29284 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 20:40:29 +00:00
6a72655d1b
Very simple version of Isolates.
...
R=ajohnsen@google.com , iposva@google.com , kasperl@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//27215002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29271 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:23:00 +00:00
3253eb3b84
Update status files to account for 14400 being fixed.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//40443004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29215 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 21:51:53 +00:00
910c318003
Fix status file to mark spawnFunction as crashing until 14400 is fixed.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//41153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29199 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 19:51:57 +00:00
4a01686b28
Un-mark an isolate test as failing on the analyzer.
...
TBR
BUG=13945
Review URL: https://codereview.chromium.org//26573011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28823 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 20:31:14 +00:00
b24a73c137
Remove unittest-based wrapping from our testing scripts
...
The unittest-based wrapping of tests is completely broken and will be removed
with this CL. ('none-drt' is the last configuration where we currently still do
unittest-based wrapping.)
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//26162007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28501 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 09:01:17 +00:00
8abd795865
Skipping test that isn't failing properly
...
TBR=asiva@google.com ,ricow@google.com
BUG=13961
Review URL: https://codereview.chromium.org//26572011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28442 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 03:42:15 +00:00
6deb0eb350
More status updates
...
It appears that the spawnUri tests pass with DRT and fail in Dartium.
I have not been able to run locally in "dartium" mode.
TBR=asiva@google.com
Review URL: https://codereview.chromium.org//26650007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28440 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 02:57:37 +00:00
34f3592c56
Fix typo in status file
...
TBR=asiva@google.com
Review URL: https://codereview.chromium.org//26592008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28432 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 23:46:34 +00:00
afb3cc7f01
Issue 13918. final fields induce setters that are illegal to call
...
https://code.google.com/p/dart/issues/detail?id=13918
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//26746002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28415 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 20:30:42 +00:00
334fd6bf07
Mark spawnFunction tests as Fail on Dartium
...
See corresponding Dartium CL:
https://chromiumcodereview.appspot.com/26397003/
This disables spawnFunction on DOM enabled isolate (i.e., where
dart:html is available). spawnFunction should continue to work on
non-DOM enabled isolated. spawnUri should be unaffected.
R=asiva@google.com
Review URL: https://codereview.chromium.org//26616002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28406 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 16:25:28 +00:00
edacf33810
Status file update for none-dartium
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//25896005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28254 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 09:25:26 +00:00
8480c79e54
Remove spawnDomIsolate code
...
This is more or less a straight remove of code. By disabling print and timers on background isolates in Dartium, we can get rid of the last vestiges of spawnDom*.
R=asiva@google.com
Review URL: https://codereview.chromium.org//25536007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28191 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 03:20:00 +00:00
22d20313b4
Implement testing support for "--compiler=none --runtime=dartium"
...
This is implemented without the broken unittest-based wrapping of tests.
R=kasperl@google.com
Review URL: https://codereview.chromium.org//25514002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28141 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 07:37:50 +00:00
9067dd5b51
Mark spawn_uri_multi_test/01 as failing.
...
Review URL: https://codereview.chromium.org//24455004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27951 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 13:27:07 +00:00
a24014ab08
Automatically append ".js" on spawnUri if we are running in JavaScript.
...
BUG= http://dartbug.com/9422
R=kasperl@google.com , kustermann@google.com
Review URL: https://codereview.chromium.org//24730002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27941 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 11:32:11 +00:00
dfbf264f40
Automatically converted general Fail status file markers to one of the more specific markers
...
R=johnniwinther@google.com , ricow@google.com
Review URL: https://codereview.chromium.org//23494066
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27876 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 12:47:03 +00:00
0cc1e648e2
Re-enable VM isolate tests.
...
BUG=https://code.google.com/p/dart/issues/detail?id=6890
R=ricow@google.com
Review URL: https://codereview.chromium.org//24542002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27868 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 09:20:40 +00:00
16b022c81d
spawn_uri_multi_test/none also doesn't work on jsshell (no workers).
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//23654059
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27825 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 15:51:54 +00:00
e3a0e24cf5
isolate/spawn_uri_test also broken in CSP mode.
...
Review URL: https://codereview.chromium.org//24195025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27822 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 14:39:55 +00:00
7d9e2f5506
Update status file for spawnUri.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//24034003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27817 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 13:10:46 +00:00
ab78c663ad
Generate out.precompiled.js, not precompiled.js.
...
BUG=http://dartbug.com/6880
R=kasperl@google.com , kustermann@google.com
Review URL: https://codereview.chromium.org//23721012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27813 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 12:04:49 +00:00
05a9a7834e
Emit CSP code in separate file.
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//24267004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27745 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-23 09:06:14 +00:00
ce874ffe22
More chrome-on-android status tweaking.
...
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23885007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27620 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 14:38:26 +00:00
dda7b89340
Another chrome-on-android status file tweak.
...
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23533059
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27616 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 12:57:48 +00:00
floitsch@google.com