Commit Graph

36 Commits

Author SHA1 Message Date
blois@google.com 78ec3b44a7 Attempting to de-flake the fileapi_test
Multiple tests were using the same filenames, but were executing in parallel. Could have caused the flakes observed.

BUG=15355
R=efortuna@google.com

Review URL: https://codereview.chromium.org//92253003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30942 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-06 11:29:45 +00:00
floitsch@google.com 466d6670c1 Refactor Future constructors.
BUG=

Review URL: https://codereview.chromium.org//14070010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21517 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 21:24:27 +00:00
floitsch@google.com 5431a5af54 Remove AsyncError with Expando.
Review URL: https://codereview.chromium.org//14251006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21498 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 18:58:32 +00:00
efortuna@google.com c4437b9274 Reapply the expanded names with the correct form of requestFileSystem on the
test.

BUG=

Review URL: https://codereview.chromium.org//12663017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20136 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-16 01:02:25 +00:00
efortuna@google.com 26c5c48fe2 Revert 20127
TBR

BUG=

Review URL: https://codereview.chromium.org//12474007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20133 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-16 00:14:27 +00:00
efortuna@google.com 3e1f5ce451 Expanded map options to named parameters.
BUG=

Review URL: https://codereview.chromium.org//12531013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20127 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:46:13 +00:00
efortuna@google.com 184c00f1cb Add a larger time window for file creation test.
BUG=

Review URL: https://codereview.chromium.org//12638016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19828 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 23:16:35 +00:00
efortuna@google.com 58b10f811e Reapply Futureification.
BUG=

Review URL: https://codereview.chromium.org//12543014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19590 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 00:13:57 +00:00
efortuna@google.com 60a5ed7215 "Reverting 19586"
BUG=

Review URL: https://codereview.chromium.org//12463028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19587 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 22:43:47 +00:00
efortuna@google.com 18f08c3a4c Future-ify All the methods!
(with a few exceptions we've planned).
Also added some tests to test these apis.

BUG=

Review URL: https://codereview.chromium.org//12380046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19586 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 22:32:54 +00:00
antonm@google.com 9cfe4b0f1f Enable tests.
TBR=blois@google.com
BUG=8836

Review URL: https://codereview.chromium.org//12391052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19368 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 09:20:48 +00:00
blois@google.com edb2b3c697 Revert "Revert "Converting dart:html to use DateTime rather than Date.""
Re-submitting change to use DateTime rather than Date.

I'm just disabling the new tests I added since they're failing on Dartium. Opened a bug tracking the Dartium and tests changes.

This means that dates are broken on Dartium, but they were broken everywhere before this change.

BUG=

Review URL: https://codereview.chromium.org//12330174

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19325 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 17:34:40 +00:00
blois@google.com 4698696514 Revert "Converting dart:html to use DateTime rather than Date."
This reverts commit 19107 because it broke Dartium.

BUG=

Review URL: https://codereview.chromium.org//12335120

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19108 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 03:16:01 +00:00
blois@google.com bc54cc3f32 Converting dart:html to use DateTime rather than Date.
We had been exposing JS Date objects as Dart Dates, but it appears to never actually worked. Switched over to DateTime and added a converter for it.

BUG=

Review URL: https://codereview.chromium.org//12316139

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19107 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 02:57:31 +00:00
kustermann@google.com feaf6e95e3 Status updates for Safari - part2
Review URL: https://codereview.chromium.org//12053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17368 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-21 19:03:31 +00:00
blois@google.com a152bc270c Adding support checks for FileSystem APIs and making APIs not webkit-specific.
This is an updated version of https://codereview.chromium.org/11856014/ which was failing because the test was causing a timeout when file APIs are not supported.

The first patch is the original, second is the updated version.

BUG=

Review URL: https://codereview.chromium.org//11888013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17037 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-14 23:53:22 +00:00
blois@google.com fa191811a7 Revert "Adding support checks for FileSystem APIs and making APIs not webkit-specific."
This reverts commit 16987.

TBR=efortuna
BUG=

Review URL: https://codereview.chromium.org//11881007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16995 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-11 22:56:13 +00:00
blois@google.com 638568dc80 Adding support checks for FileSystem APIs and making APIs not webkit-specific.
BUG=

Review URL: https://codereview.chromium.org//11856014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16987 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-11 21:48:27 +00:00
blois@google.com 4411ef9c37 Renaming Window to WindowBase and LocalWindow to Window.
Ditto for LocalHistory and LocalLocation.

http://code.google.com/p/dart/issues/detail?id=7516

Review URL: https://codereview.chromium.org//11642035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16401 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 21:41:26 +00:00
blois@google.com 5bc653278a Dartifying dart:html type names.
BUG=

Review URL: https://codereview.chromium.org//11419300

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15739 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-05 17:48:38 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
gram@google.com f7d27f2c64 Modified unittest to use new argument syntax.
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 22:52:03 +00:00
antonm@google.com 00ffc1ba5a Start a whitelist of methods those optionals should be treated as named formals in dart:html.
R=blois@google.com,efortuna@google.com,podivilov@chromium.org,sra@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//11236008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13925 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 08:08:15 +00:00
antonm@google.com 46f6cd6d0f Support new named arguments.
R=blois@google.com,efortuna@google.com,podivilov@chromium.org,sra@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//11184007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13721 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 08:40:40 +00:00
vsm@google.com a1d9180d98 New cross frame base types.
Local types (LocalWindow, LocalLocation, LocalHistory) now subtype the corresponding "safe" base type.  The _CrossFrameImpl classes implement the safe types.

This also fills out Location and History for dart2js.

Note for dart2js, I still need to trap returned windows.  That's a separate bug.

BUG=3836

Review URL: https://codereview.chromium.org//11047021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13252 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 18:16:03 +00:00
efortuna@google.com 9163dfe93c revert 1204. Will investigate when I get a chance.
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 01:21:41 +00:00
rnystrom@google.com 383488ec4f Update unittest to new package layout.
Review URL: https://codereview.chromium.org//10917275

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 21:12:17 +00:00
rnystrom@google.com 659a57df3e Revert "Make unittest follow the new package layout."
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.

Review URL: https://codereview.chromium.org//10911318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 19:43:10 +00:00
rnystrom@google.com 2ba81033a6 Make unittest follow the new package layout.
Review URL: https://codereview.chromium.org//10918240

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 18:22:24 +00:00
blois@google.com 1ce358bf0c Fixing up file API tests to run (or fail) appropriately.
BUG=3022

Review URL: https://chromiumcodereview.appspot.com//10886017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11541 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-29 20:07:16 +00:00
antonm@google.com 39dacd1f90 Fix fileapi_test.dart.
Now options are named options, not flags.

R=podivilov@chromium.org,sra@google.com

Review URL: https://chromiumcodereview.appspot.com//10824374

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10958 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-20 13:35:34 +00:00
dgrove@google.com c265902bea Move unittest from lib to pkg.
Review URL: https://chromiumcodereview.appspot.com//10836241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10685 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-14 22:36:59 +00:00
gram@google.com 9b79e27e17 Some unit test fixes:
Fixed a couple of issues in the ensureInitialized() function.
Added expectAsyncUntil methods to support callbackDone style tests.
Split the matcher tests up so that we can exclude those that use isInstance
from the environments where they don't work.
Eliminated the need for two functions calls in throws/throwsA.
Fixed some tests.
Changed some uses of Expect to expect.
Fixed a bug when using expectAsync with a count of zero.
Fixed a bug where we weren't updating the call count in invoke0/1/2.
Made expect behave sensibly in cases where the user doesn't supply a 
matcher (e.g. expect(foo, 0)). USing the predicate form with a 
reason now requires a named parameter.
Review URL: https://chromiumcodereview.appspot.com//10544167

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8753 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-15 23:17:57 +00:00
vsm@google.com 6129f24038 Revert "Removed asyncTest and improved comments."
This reverts commit r8170 while we figure out dartium breakage.

TBR=gram

Review URL: https://chromiumcodereview.appspot.com//10447126

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8176 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-31 21:34:23 +00:00
gram@google.com 7ca82abaf2 Removed asyncTest and improved comments.
Review URL: https://chromiumcodereview.appspot.com//10449091

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8170 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-31 17:59:39 +00:00
podivilov@google.com c049595987 Add test for DOM fileapi.
R=antonm@chromium.org

Review URL: https://chromiumcodereview.appspot.com//10382176

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7686 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-16 13:49:41 +00:00