Commit Graph

23 Commits

Author SHA1 Message Date
efortuna@google.com 8e4205db3a Reapply remove upgradeCustomElement methods.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//33593003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28960 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 21:55:40 +00:00
efortuna@google.com 37989cf2ce "Reverting 28947"
TBR
BUG=

Review URL: https://codereview.chromium.org//33643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28949 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 20:48:18 +00:00
efortuna@google.com 3a4a3ba95f Remove Platform.upgrateCustomElements.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//31993005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28947 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 20:21:28 +00:00
blois@google.com c2f5471669 Removing Element.createdCallback
This was a placeholder for before dart2js converted to the constructor, can now be removed.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//26592009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28465 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 16:59:19 +00:00
blois@google.com 1aa8a7be0e Adding Element.created constructor and .created constructors to all subclasses. Also ensuring generative constructor for all superclasses.
This is for post-construction custom element creation.

Element.created is public, then the base classes of that get private ._created constructors.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24653006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28120 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 21:26:06 +00:00
blois@google.com 93c361dd36 This is an updated version of https://codereview.chromium.org/16374007/
Original submission is the first patch, fixes are the second.

There were two issues with the original-
  - Issue with URI sanitization where relative URIs on IE were being dropped.
  - Analyzer issue on missing members for CustomElement.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23525003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26757 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 01:03:01 +00:00
blois@google.com a85f2a8d4c Changing onCreated callback to created.
Brings it in-line with the browser's createdCallback and Polymer's created. Avoid conflict with event names.

Dartium changes are https://codereview.chromium.org/23494005

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//23451006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26754 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 23:51:42 +00:00
blois@google.com 24e9f22c90 Revert "First rev of Safe DOM"
This reverts commit 26681.

Some IE issues with URL validation that I need to investigate further.

BUG=

Review URL: https://codereview.chromium.org//23523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26682 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 02:18:48 +00:00
blois@google.com 63ecf1a3fd First rev of Safe DOM
BUG=
R=jacobr@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org//16374007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26681 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 01:48:13 +00:00
vsm@google.com f1f2431bef Platform.upgradeCustomElements for Dartium
Using this as a workaround for 12642.

R=blois@google.com

Review URL: https://codereview.chromium.org//22891020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26602 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 16:12:08 +00:00
blois@google.com 688ad2c706 De-flaking custom element test.
This appears to be the Chrome flakiness around making XHRs.

BUG=12592
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23361011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26447 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 17:43:34 +00:00
blois@google.com ec11e52f62 Revert "Revert "Adding polyfill support for custom elements.""
This fixes the issues in the custom elements polyfills.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23301012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26412 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 00:08:46 +00:00
blois@google.com 508affefed Revert "Adding polyfill support for custom elements."
Caused issues with DocumentFragment and some lingering changes from the blink roll.

BUG=

Review URL: https://codereview.chromium.org//22957010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26410 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 23:28:22 +00:00
blois@google.com 72651260aa Adding polyfill support for custom elements.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//22967006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26405 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 22:56:08 +00:00
blois@google.com 3aabf41ea6 Removing custom element preload test.
Can we not skip subtests??

BUG=

Review URL: https://codereview.chromium.org//22918010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26304 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-17 01:12:01 +00:00
blois@google.com e506058b83 Updating custom element's preregister test to follow new contracts.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//23276003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26290 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 19:46:10 +00:00
blois@google.com 1006d023b8 Currently the mixins case is failing on the dart2js version.
The auto-tag generation makes it easier to add new tests without re-indexing or worrying about overlapping tags.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//22960005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26285 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 17:38:46 +00:00
vsm@google.com 3a17d47e58 Modify custom elements to inherit from HtmlElement
R=blois@google.com

Review URL: https://codereview.chromium.org//23189009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26275 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 15:24:32 +00:00
sra@google.com 1ffafc705d Additional code to https://codereview.chromium.org/15026006
to enable user classes extending DOM classes to be registered.

Review URL: https://codereview.chromium.org//22642002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26221 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 21:18:07 +00:00
sra@google.com 28dd6944b7 First cut at extending native classes.
Subclasses of native classes have to be treated largely like native classes since they require interceptors.

The ugly part is collecting the set of subclasses of native classes without resolving all classes.  Only plausible classes are resolved.  Plausible classes have a superclass name that is native class (or subclass of native class).  The name-keyed graph is collected and inverted to identify the true subclasses of native classes.

Things that are missing from this CL:

1. I discussed with Peter a better way of finding which classes are subclasses of native classes by resolving the superclass.  Peter's proposal will still require the graph inversion step but should be more precise.

2. It would be a good idea to replace the 'defineNativeSubclass' calls with more declarative static data on the class and post-process the classes.

3. We need to make sure that fields of subclasses of native classes do not conflict with any (potentially undeclared) properties of the base native class.

4. The compiler should do additional checking
   - The constructor must be a factory constructor.
   - No fields can have initializers.

R=ahe@google.com

Review URL: https://codereview.chromium.org//15026006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26208 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 19:09:12 +00:00
vsm@google.com 4d51b41ff8 Initial Dartium custom element support
This will need to be rebased with Stephen's CL or vice versa.  The test mod is taken from his CL.

R=blois@google.com

Review URL: https://codereview.chromium.org//22912004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26141 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 19:47:07 +00:00
vsm@google.com e53d1e9588 Refactor custom element tests
R=blois@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//21124003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25589 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-29 22:27:00 +00:00
blois@google.com da161d6ab1 Sample test for custom elements.
BUG=

Review URL: https://codereview.chromium.org//12212056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18421 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 00:30:20 +00:00