dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
21,047 Commits 2 Branches 0 Tags
727d29d6b6d4324595750411647789d2fd39dbb4
Commit Graph

46 Commits

Author SHA1 Message Date
jmesserly@google.com 20b120eba2 Fix for dart2js mirrors caching with custom elements 
Custom elements code is from https://github.com/dart-lang/CustomElements/pull/4

R=sigmund@google.com

Review URL: https://codereview.chromium.org//112613003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31296 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-19 19:55:57 +00:00
jmesserly@google.com d700bba3e4 fix custom elements that extend tags like "section" 
Some tags don't have their own HTMLElement subclass (because they lack unique DOM properties), but it should still be possible to extend them.

R=blois@google.com

Review URL: https://codereview.chromium.org//90113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30833 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-03 23:46:43 +00:00
regis@google.com 7b18b7c4ff Second attempt at fixing html test. 
I really have no idea what I am doing here, but the test now passes.
Dartium folks, please have a look.

Review URL: https://codereview.chromium.org//59883004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29940 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-05 21:53:22 +00:00
regis@google.com 43d64b38f8 Fix typo in html test. 
Review URL: https://codereview.chromium.org//59843006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29936 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-05 21:08:25 +00:00
blois@google.com c49df8bd12 Commenting out template_wrappers test while investigating crashes 
TBR
BUG=

Review URL: https://codereview.chromium.org//55503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29714 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-31 22:53:47 +00:00
blois@google.com 4525b95f8e Adding test for old wrappers causing multiple upgrades 
This is the test for https://codereview.chromium.org/54833003/

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//55153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29704 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-31 21:16:23 +00:00
blois@google.com 39733ff298 Removing window.console.log from js_custom_test 
IE does not declare window.console when debugger is not open.

TBR
BUG=

Review URL: https://codereview.chromium.org//47073010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29625 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-31 01:48:08 +00:00
blois@google.com 366b2364da Tests for premature GC of custom elements within template contents 
BUG=14483
R=vsm@google.com

Review URL: https://codereview.chromium.org//49673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29612 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-31 00:29:22 +00:00
blois@google.com 02d745044d Adding tests for accessing custom elements from alternate script contexts 
BUG=14597
R=vsm@google.com

Review URL: https://codereview.chromium.org//52913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29591 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-30 21:46:03 +00:00
blois@google.com c1a11e55d5 Adding validation that Custom element constructor has zero args 
BUG=13800
R=vsm@google.com

Review URL: https://codereview.chromium.org//30283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29011 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 17:20:46 +00:00
blois@google.com 980834fe33 Validating that types which require extendsTag actually provide it 
BUG=14292
R=vsm@google.com

Review URL: https://codereview.chromium.org//32703006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29004 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 16:14:17 +00:00
efortuna@google.com 8e4205db3a Reapply remove upgradeCustomElement methods. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//33593003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28960 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 21:55:40 +00:00
efortuna@google.com 37989cf2ce "Reverting 28947" 
TBR
BUG=

Review URL: https://codereview.chromium.org//33643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28949 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 20:48:18 +00:00
efortuna@google.com 3a4a3ba95f Remove Platform.upgrateCustomElements. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//31993005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28947 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 20:21:28 +00:00
blois@google.com e7aef33a2c Fixing custom element type extensions in Dartium to have correct native type ID 
This is in support of the recent change to write the native type ID to the Dart wrappers

Dart changes for https://codereview.chromium.org/27769002/

BUG=14190
R=vsm@google.com

Review URL: https://codereview.chromium.org//29033003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28899 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-18 23:43:45 +00:00
blois@google.com e3b35dabb6 Renaming Node.document back to Node.ownerDocument 
With custom elements, the document instance variable creates an odd conflict with the document global.

BUG=14099
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//27602002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28810 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-17 17:55:38 +00:00
blois@google.com ceb07acde3 Fixing status of document.register test for dart2js tests 
I added this test for Dartium, but it's failing on dart2js.

TBR
BUG=

Review URL: https://codereview.chromium.org//27220003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28606 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-14 19:45:07 +00:00
blois@google.com 5a06040888 Dart changes for https://codereview.chromium.org/26571005/ 
Ensuring that custom elements have correct super classes.

BUG=

Review URL: https://codereview.chromium.org//27222003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28603 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-14 19:29:42 +00:00
blois@google.com 6d3acc0175 Test fixes for CustomElement upgrade changes 
This is the Dart portion of https://codereview.chromium.org/27183006

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//26700003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28598 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-14 18:38:28 +00:00
blois@google.com c2f5471669 Removing Element.createdCallback 
This was a placeholder for before dart2js converted to the constructor, can now be removed.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//26592009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28465 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-10 16:59:19 +00:00
blois@google.com 108dec86bd Fixing Node.clone not returning upgraded custom elements. 
This was an issue for Polymer as the templates are cloned with shallow clones.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//25719003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28363 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-08 16:02:49 +00:00
blois@google.com c6b1d91f34 Implementing custom element's attributeChanged callback in Dartium 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//25793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28232 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-03 17:37:51 +00:00
blois@google.com 05bb03642d Implementing CustomElement's attributeChanged callback in dart2js. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//25325004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28168 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-02 15:57:56 +00:00
blois@google.com c71f315c8d Fixing analyzer issues in tests. 
BUG=

Review URL: https://codereview.chromium.org//25614002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28124 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-01 22:01:25 +00:00
blois@google.com 1aa8a7be0e Adding Element.created constructor and .created constructors to all subclasses. Also ensuring generative constructor for all superclasses. 
This is for post-construction custom element creation.

Element.created is public, then the base classes of that get private ._created constructors.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24653006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28120 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-01 21:26:06 +00:00
blois@google.com 5eed34b47d Running entered & left view events in Dartium 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28023 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-27 19:48:53 +00:00
blois@google.com 354c4dd5ad Revert "Revert "Start of dartium custom element lifecycle event support."" 
Primary changes are that a fast-path has been added for the single-argument Document.createElement and the systemnative.py changes were split out to CL https://codereview.chromium.org/24661002/.

This is dependent on https://codereview.chromium.org/24677002/

First patch is the original, second is the updates.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24491003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27921 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-25 23:15:09 +00:00
blois@google.com 3fd115d5e3 Revert "Start of dartium custom element lifecycle event support." 
This reverts commit 27718 to see if it gets performance back down.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24479002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27897 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-25 17:56:53 +00:00
blois@google.com 209e413a5c Retry of custom element lifecycle events. 
First patch is the original, changes were:
 - Shadow DOM upgrade landed as separate CL
 - CustomElement polyfill wasn't always firing WebComponentsLoaded event (causing timeouts on FF and IE), fixed polyfill.
 - Dartium test exclusions were not working

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23498053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27841 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-24 19:14:16 +00:00
blois@google.com 6def065afd Revert "Dart2js support for custom element lifecycle events" 
This reverts commit 27729. Shadow DOM polyfill appears to have regressed some tests and some issues are coming up with the browser controller.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//24251016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27730 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-21 00:46:48 +00:00
blois@google.com fb8f32bcc4 Dart2js support for custom element lifecycle events 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//24096027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27729 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-20 23:49:12 +00:00
blois@google.com 34f58a8209 Start of dartium custom element lifecycle event support. 
These are the Dart repo changes paired with https://codereview.chromium.org/24294002/

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//23817006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27718 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-20 18:40:11 +00:00
blois@google.com d312cbbd08 Exposing document.createElement 
As part of removing all $dom_ APIs, making this one public. There are valid scenarios for creating elements in other documents.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//24084004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27415 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-12 00:00:39 +00:00
blois@google.com fbc6cd91aa Updating Dartium status and IE9 status 
Dartium tests started passing because changes for polyfill triggered expected behavior for Dartium, even though the bug is still active.

Updated tests for some IE9 expectations, but still failing and needs further investigation.

TBR
BUG=

Review URL: https://codereview.chromium.org//23513029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27321 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-09 23:34:38 +00:00
blois@google.com b904bf81ba Revert "Revert "Tag extensions"" 
Original CL is the first patch, changes follow. Includes fixes for Chrome test failures and Firefox type check issues.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23442011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27313 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-09 22:03:43 +00:00
blois@google.com 6570db562c Revert "Basic functionality is working with JS native support and polyfill, still some issues with dart2js typechecking." 
This reverts commit r26935. Failing in FF checked on type extension and IE9 on synchronous constructor upgrading, need to investigate.

TBR
BUG=

Review URL: https://codereview.chromium.org//23567006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26938 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-30 19:37:23 +00:00
blois@google.com 5607d75eca Basic functionality is working with JS native support and polyfill, still some issues with dart2js typechecking. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23190026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26935 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-30 19:08:19 +00:00
blois@google.com 38047d896e Fixing custom/created_callback test for Safe HTML 
TBR
BUG=

Review URL: https://codereview.chromium.org//23495005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26762 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-28 02:49:47 +00:00
blois@google.com 93c361dd36 This is an updated version of https://codereview.chromium.org/16374007/ 
Original submission is the first patch, fixes are the second.

There were two issues with the original-
  - Issue with URI sanitization where relative URIs on IE were being dropped.
  - Analyzer issue on missing members for CustomElement.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23525003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26757 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-28 01:03:01 +00:00
blois@google.com a85f2a8d4c Changing onCreated callback to created. 
Brings it in-line with the browser's createdCallback and Polymer's created. Avoid conflict with event names.

Dartium changes are https://codereview.chromium.org/23494005

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//23451006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26754 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-27 23:51:42 +00:00
blois@google.com 24e9f22c90 Revert "First rev of Safe DOM" 
This reverts commit 26681.

Some IE issues with URL validation that I need to investigate further.

BUG=

Review URL: https://codereview.chromium.org//23523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26682 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-27 02:18:48 +00:00
blois@google.com 63ecf1a3fd First rev of Safe DOM 
BUG=
R=jacobr@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org//16374007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26681 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-27 01:48:13 +00:00
vsm@google.com db5da2949f Fix outerHtml comparisons in document_register_type_extension_test. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23171017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26437 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-21 16:18:22 +00:00
vsm@google.com fb5c0e6c95 Enable these checks in custom tests 
R=blois@google.com

Review URL: https://codereview.chromium.org//23033011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26392 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-20 21:27:55 +00:00
vsm@google.com abec8ce0ae Fix caught by analyzer 
TBR=blois@google.com

Review URL: https://codereview.chromium.org//23242007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26321 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-19 18:01:29 +00:00
vsm@google.com dcce9cd117 Port custom element layout tests to Dart 
These are adapted from Dominic's tests here:
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/custom/

R=blois@google.com

Review URL: https://codereview.chromium.org//23232005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26319 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-19 17:50:42 +00:00