Commit Graph

695 Commits

Author SHA1 Message Date
lrn@google.com 1fa76c85b5 Fix bug in Duration.toString.
BUG= http://dartbug.com/15678

Review URL: https://codereview.chromium.org//119263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31318 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 07:18:21 +00:00
ngeoffray@google.com a4cf4f2334 Remove obsolete TODOs from tests.
R=lrn@google.com

Review URL: https://codereview.chromium.org//100443005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31254 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-19 10:46:15 +00:00
lrn@google.com bd5f28916f Add tests for symbols of operators.
R=ahe@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org//114603004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31187 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-17 12:38:53 +00:00
lrn@google.com 86edf90273 Add num.sign getter.
BUG= http://dartbug.com/15580
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//113833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31126 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-13 12:10:23 +00:00
kustermann@google.com 34afbbc66a Mark symbol_test/0{2,3} as passing on drt (in addition to dartium)
R=whesse@google.com

Review URL: https://codereview.chromium.org//111903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31028 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 17:34:19 +00:00
kustermann@google.com e898028b18 Attempt to deflake our status files
R=whesse@google.com

Review URL: https://codereview.chromium.org//109893004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31022 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 15:37:34 +00:00
sgjesse@google.com 3d2b5c4bd4 Add encodimg argument to Uri.encodeQueryString
R=lrn@google.com
BUG=http://dartbug.com/12780

Review URL: https://codereview.chromium.org//94733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30791 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-02 09:01:22 +00:00
lrn@google.com dbdb16afb3 Reduce running time of nan_parse_test.
It times out on Dartium.
It was testing all combinations of whitespace around all test strings.
Now it just does it around some representable test strings, and only
test space characters around most strings.

Also add a few more tests.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//94173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30749 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-28 08:57:04 +00:00
srdjan@google.com 8058e7b135 Fix simarm test (add timeout).
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//89403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30683 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-26 23:07:27 +00:00
lrn@google.com 700ed41411 Remove num-parse failure expectation for dart2js after changing test.
Review URL: https://codereview.chromium.org//88003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30668 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-26 11:18:00 +00:00
lrn@google.com ef66be8610 Change Expect.identical(NaN, x) to not assume NaNs are identical.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//87953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30667 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-26 10:32:51 +00:00
lrn@google.com e1b4afa85d Add num.parse.
The implementation is still primitive: It calls int.parse, then double.parse, and then fails if it hasn't found a result yet.

BUG= http://dartbug.com/8237
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30624

Review URL: https://codereview.chromium.org//85633003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30663 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-26 08:44:38 +00:00
lrn@google.com f5bf3613dc Revert "Add num.parse."
Fails on IE9.

Review URL: https://codereview.chromium.org//85623004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30631 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 14:52:23 +00:00
lrn@google.com 61e1c18e78 Add more tests.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//84993004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30628 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 13:50:09 +00:00
lrn@google.com e0f3bb3092 Add num.parse.
The implementation is still primitive: It calls int.parse, then double.parse, and then fails if it hasn't found a result yet.

BUG= http://dartbug.com/8237
R=floitsch@google.com

Review URL: https://codereview.chromium.org//85633003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30624 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 13:09:04 +00:00
ngeoffray@google.com f02627fe15 Update status file for safari bug.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//85573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30616 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 11:22:39 +00:00
ngeoffray@google.com 27d1f7aa7f Inline the fixed array constructor manually in the SSA builder. Also track whether a fixed array ever flows into a method that may check if it is growable.
Also fixes new List(null): it now throws.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//82953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30612 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-25 09:10:57 +00:00
floitsch@google.com 1b97a4765f Fix timezone extraction for IE and Opera.
Not perfect, but these browsers don't give enough information.

BUG= http://dartbug.com/14717
BUG= http://dartbug.com/14691
BUG= http://dartbug.com/15027
R=lrn@google.com

Review URL: https://codereview.chromium.org//78043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30469 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 13:57:53 +00:00
lrn@google.com 06e97d46b6 Fix expectation of corelib/queue_test to not fail analysis.
Review URL: https://codereview.chromium.org//78333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30464 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 12:56:46 +00:00
lrn@google.com 410268a15e Fix set test, number of arguments to helper function changed.
Review URL: https://codereview.chromium.org//77993003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30457 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 10:42:28 +00:00
lrn@google.com cd2cf5058e Add SplayTreeSet.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//61733013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30444 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 09:35:39 +00:00
floitsch@google.com 7c5a2a13cb Move unicode tests to utf package.
BUG= http://dartbug.com/2252
R=lrn@google.com

Review URL: https://codereview.chromium.org//68563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30409 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-19 12:58:09 +00:00
sra@google.com c4993e4b62 Reapply "This change makes it easier to put type parameters on JavaScript Arrays."
Updates recursive_import_test

Review URL: https://codereview.chromium.org//75453004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30380 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 22:06:48 +00:00
sra@google.com 34fefd2715 Revert "This change makes it easier to put type parameters on JavaScript Arrays."
Review URL: https://codereview.chromium.org//75703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30377 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 21:53:27 +00:00
sra@google.com 483cb2553a This change makes it easier to put type parameters on JavaScript Arrays.
There is one special factory constructor for putting the type on an existing Array, and some higher level factory constructors that implement the common List subtypes.

The effect of this is to move the type parameter assignment from every "new List" site to a handful of site within JSArray.  This shrinks some programs by half a percent, e,g, 3k of swarm.

JSArray.toList() and JSArray.sublist() now return JSArrays with the expected type parameters.

R=karlklose@google.com, ngeoffray@google.com

Review URL: https://codereview.chromium.org//70703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30374 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 21:06:48 +00:00
karlklose@google.com fe2595422d Register generic type of instantiated Map literal.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//59693006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30041 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 11:31:29 +00:00
floitsch@google.com ec3db0d42c Fix the generic type of Map.values for map literals.
R=karlklose@google.com

Review URL: https://codereview.chromium.org//59463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29995 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 20:58:39 +00:00
floitsch@google.com 6bdd901604 Add test that makes sure print deals with broken toStrings.
R=ahe@google.com

Review URL: https://codereview.chromium.org//60553002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29994 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 20:40:03 +00:00
karlklose@google.com 26877eda37 Change status of corelib/map_values2_test.
On dart2js, the library function to create the values-iterable uses IterableBase.map, which create a MappedIterable where the second type argument is set to dynamic. As a consequence, the result of `get values` is an Iterable<dynamic>.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//57373007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29875 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-05 07:16:53 +00:00
karlklose@google.com 1ddf0d9a53 Reapply "Set runtime type on list and map literals."
Reviewed as: https://chromiumcodereview.appspot.com/54293008/.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//56553004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29798 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 10:25:25 +00:00
floitsch@google.com 2d7491b99e Update status file.
Review URL: https://codereview.chromium.org//56303004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29763 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 18:53:11 +00:00
floitsch@google.com c71cec69e2 Update status file for Opera corelib failures.
R=lrn@google.com

Review URL: https://codereview.chromium.org//46163004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29760 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 17:33:59 +00:00
floitsch@google.com 820560eef0 Fix timezone name for IE.
R=lrn@google.com

Review URL: https://codereview.chromium.org//54393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29758 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 17:03:42 +00:00
floitsch@google.com e51764f89e Fix some corelib tests.
R=lrn@google.com

Review URL: https://codereview.chromium.org//55533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29757 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 17:02:27 +00:00
karlklose@google.com df5da8b6f3 Revert "Set runtime type on list and map literals."
This reverts commit r29747.

TBR=kasperl@google.com

Review URL: https://codereview.chromium.org//56003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29748 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 14:58:33 +00:00
karlklose@google.com a3c5867999 Set runtime type on list and map literals.
R=johnniwinther@google.com
BUG=6827,12889

Review URL: https://codereview.chromium.org//54293008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29747 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 14:19:02 +00:00
ngeoffray@google.com d630ad89c3 Revert r29862, cache must have been updated now.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//51213004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29734 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 09:51:49 +00:00
ngeoffray@google.com fcdfebb688 The bots are using a cached version of the tests that is invalid now that the shared flags are passed.
Review URL: https://codereview.chromium.org//55053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29682 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 17:28:49 +00:00
ngeoffray@google.com 9fb8d997f7 Implement fromEnvironment on bool, int, String in dart2js.
R=johnniwinther@google.com, kasperl@google.com

Review URL: https://codereview.chromium.org//48323003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29675 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 14:41:44 +00:00
lrn@google.com 5cd6aace2b Change bool.fromEnvironment to recognize "true" and "false" and use default for rest.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//54623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29672 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 14:05:28 +00:00
lrn@google.com 66959d9dbf Change int.fromEnvironment in VM to use same code as int.parse.
R=fschneider@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//54663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29670 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 13:45:39 +00:00
lrn@google.com eb9e33e328 Update documentation on .fromEnvironment. Make bool default be false.
I want more text, and examples of usage, alternative usage, etc.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//54203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29657 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 09:33:18 +00:00
sgjesse@google.com 239e561e60 Update status file
Treat drt and dartium the same for fromEnvironment

TBR=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//48643004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29645 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 06:38:38 +00:00
sgjesse@google.com 4072a20392 Update status file
The analyzer cannot see compile-time errors in .fromEnvironment

TBR=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//54133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29644 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 06:13:51 +00:00
sgjesse@google.com 36a67fa046 Implement fromEnvironment on bool, int and String
This implements const constructor fromEnvironment on bool, int and
String.

The VM have the added -Dname=value option to define the value for the
properties. All values are provided by using the -D - nothing is read
from the environment.

If the resulting value is null or - in the case of int.fromEnvironment
- not a number an ArgumentError is thrown.

This CL does not have any implementation for dart2js.

This is a continuation of the change
https://chromiumcodereview.appspot.com/24975002 by iposva@
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//50983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29642 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 05:46:57 +00:00
floitsch@google.com 0c25691130 improve DateTime parsing a UTC timezone offset
BUG= http://dartbug.com/14550
R=floitsch@google.com

Review URL: https://codereview.chromium.org//48823005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29615 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 00:53:21 +00:00
lrn@google.com 0354366832 Mark corelib/list_test/01 as failing on dart2js.
See issue 14616. This behavior is now checked for by a test.

Review URL: https://codereview.chromium.org//51223004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29530 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 11:26:46 +00:00
lrn@google.com dc19265838 Fix test to not assume that JSON.decode returns dynamic.
It currently returns Object.
I have CL to make it do that again, but it's open for discussion.

Review URL: https://codereview.chromium.org//52353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29527 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 10:37:00 +00:00
lrn@google.com 441688711f Update List constructor documentation. Say that null is not a length.
R=floitsch@google.com, ngeoffray@google.com

Review URL: https://codereview.chromium.org//50733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29522 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 09:54:45 +00:00
ngeoffray@google.com 55974b2751 Update status file.
Review URL: https://codereview.chromium.org//49203005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29424 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 09:24:39 +00:00