dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
21,047 Commits 2 Branches 0 Tags
727d29d6b6d4324595750411647789d2fd39dbb4
Commit Graph

24 Commits

Author SHA1 Message Date
johnmccutchan@google.com 50ef680923 Bucket unknown symbols by PC and demangle native symbols 
R=iposva@google.com

Review URL: https://codereview.chromium.org//100133004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31247 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-19 00:29:51 +00:00
johnmccutchan@google.com 397a9a56e5 Add flag to control profiler rate 
R=asiva@google.com

Review URL: https://codereview.chromium.org//118673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31244 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-18 23:11:20 +00:00
johnmccutchan@google.com a961710bfa Fix signed unsigned comparison error 
BUG=

Review URL: https://codereview.chromium.org//98333008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31193 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-17 16:57:18 +00:00
johnmccutchan@google.com dc217a8aa0 Fix crash walking call stack on Linux. 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//116703003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31192 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-17 16:48:55 +00:00
johnmccutchan@google.com 4a65b869d0 Only interrupt thread don't record sample. Narrowing in on flaky crash on Linux. 
TBR

Review URL: https://codereview.chromium.org//113133010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31175 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-16 22:35:55 +00:00
johnmccutchan@google.com 919dc2d6eb * Introduce ThreadInterrupter which calls a TLS set callback when thread is interrupted. 
* Threads can only register and unregister themselves with ThreadInterrupter.
* Profiler is no longer involved in interrupting threads. It's just a callback and the buffer.
* Profiler operates lock free using an atomic operation to reserve sample in sample buffer.
* Linux, Mac, and Windows done.

R=asiva@google.com

Review URL: https://codereview.chromium.org//109803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31170 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-16 18:52:15 +00:00
johnmccutchan@google.com 6f50c75bbf Disable profiler 
BUG=

Review URL: https://codereview.chromium.org//92953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30737 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-27 22:21:22 +00:00
johnmccutchan@google.com 593b148d37 Switch SetupIsolateForProfiling to use calloc instead of new [] 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//92513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30733 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-27 21:51:02 +00:00
johnmccutchan@google.com 8c42e5908b Disable profiler on Windows 
TBR

Review URL: https://codereview.chromium.org//88943004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30680 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-26 22:03:58 +00:00
johnmccutchan@google.com 39c9c5b3e4 Guard against profiler shutdown race 
In response to: https://codereview.chromium.org/87643003/

Review URL: https://codereview.chromium.org//88403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30669 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-26 14:28:47 +00:00
ajohnsen@google.com c4ca0bf072 Disable profiler, as profiler shutdown is racing with isolates. 
Some tests using isolates, crashes with the following assertion error:

  runtime/vm/profiler.cc:237: error: expected: initialized_

It turns out that ProfileManager::Shutdown is called, while there are still isolates running. The comment in runtime/vm/dart.cc:152 seams to explain the issue.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//87643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30666 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-26 09:41:19 +00:00
johnmccutchan@google.com d53d7013ef Ensure profiler manager thread has shutdown before main thread 
Review URL: https://codereview.chromium.org//86793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30655 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-26 00:48:09 +00:00
johnmccutchan@google.com 72afb81a8c - Fix MonitorData ASSERT failure in thread_win: 
E:\b\build\slave\vm-win32-debug-russian-be\build\dart\runtime\platform/thread_win.h:66: error: expected: next_ == NULL.
- Reduce sample buffer size by an order of magnitude (this should fix .
- Disable profiler on simulators.
- Only sample when scheduled thread id matches current thread id.

Review URL: https://codereview.chromium.org//85333006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30647 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-25 22:06:33 +00:00
johnmccutchan@google.com ab9f2e59ed Always update scheduled thread id 
TBR

Review URL: https://codereview.chromium.org//84993005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30633 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-25 15:41:10 +00:00
johnmccutchan@google.com f42edb213a Guard against an isolate being scheduled twice 
TBR

Review URL: https://codereview.chromium.org//83623004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30608 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-25 01:42:50 +00:00
johnmccutchan@google.com f6459c2dcc - SetupIsolateForProfiling before SetCurrent is called on an isolate for the first time. 
- ProfilerManager::Shutdown no longer frees isolate profiling data for registered isolates. Each isolate will free its own data when shutdown.
- Fix monitor timeout test to disable signal delivery.
- Do not walk the call stack in signal handler.

TBR

Review URL: https://codereview.chromium.org//84813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30607 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-24 23:33:41 +00:00
johnmccutchan@google.com 65e7b9f980 - Fix shutdown race. 
- Move signal blocking out of dart.cc and isolate.cc and into profiler.cc.
- Nest scope objects explicitly.
- Add missing signal block in ProfilerManager::ShutdownIsolateForProfiling.

R=iposva@google.com

Review URL: https://codereview.chromium.org//83093004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30602 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-23 00:26:35 +00:00
johnmccutchan@google.com 7ee1ada97c Disable profiler 
TBR

Review URL: https://codereview.chromium.org//82343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30559 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-22 00:57:24 +00:00
johnmccutchan@google.com b04d313c80 Disable native symbol resolver on WindowsDisable native symbol resolver on Windows 
TBR

Review URL: https://codereview.chromium.org//81513004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30545 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-21 21:30:19 +00:00
johnmccutchan@google.com 08042b2642 Disable profiler 
TBR

Review URL: https://codereview.chromium.org//79783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30488 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-20 23:42:15 +00:00
johnmccutchan@google.com eb99334209 Attempt at enabling profiler 
BUG=

Review URL: https://codereview.chromium.org//78713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30478 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-20 17:57:56 +00:00
johnmccutchan@google.com c5f1647572 Fix Android build and disable profiler 
TBR

Review URL: https://codereview.chromium.org//64363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30428 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-19 23:25:28 +00:00
johnmccutchan@google.com 31989f3b4d Post landing fixes 
TBR

Review URL: https://codereview.chromium.org//65983005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30420 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-19 19:11:41 +00:00
johnmccutchan@google.com 97ac18aee9 Sampling profiler 
BUG=4350
R=asiva@google.com

Review URL: https://codereview.chromium.org//25909002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30419 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-19 18:26:10 +00:00