Commit Graph

5 Commits

Author SHA1 Message Date
hausner@google.com 98883150d6 Partial solution to analyze potentially constant expressions
This change adds code that detects if an expression can definitively
never be constant. We use this to analyze the initializer expressions
in const constructors. This check is not entirely water tight, but
together with the checks in canonicalization code catches most
illegal initializer expressions.

The const constructor of class Symbol turns out to be illegal. The
name verification check can't be part of the constructor code.

R=iposva@google.com

Review URL: https://codereview.chromium.org//18649003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24749 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 20:47:14 +00:00
ahe@google.com 2abb5be5ec Implement Symbol correctly in dart2js.
Review URL: https://codereview.chromium.org//14079003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21694 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-18 19:25:22 +00:00
ahe@google.com ddbc806aab Remove redundant type check.
Review URL: https://codereview.chromium.org//13963007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21616 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-17 11:49:06 +00:00
ahe@google.com 45ad548837 Update dart:mirrors to use Symbol.
Review URL: https://codereview.chromium.org//14173005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21460 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 15:00:45 +00:00
ahe@google.com bdce382768 Add Symbol class.
Review URL: https://codereview.chromium.org//14142003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21273 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-11 12:46:16 +00:00