dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
21,047 Commits 2 Branches 0 Tags
727d29d6b6d4324595750411647789d2fd39dbb4
Commit Graph

30 Commits

Author SHA1 Message Date
nweiz@google.com 04a2a02fa8 Add debugging prints to the Mac OS directory watcher. 
This is a temporary CL that will make it easier to track down and fix the errors
in the mac watcher.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//107403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30919 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-05 22:49:03 +00:00
nweiz@google.com b3fc09ef15 Update the Mac OS watcher in pkg/watcher. 
The behavior of Directory.watch has changed, and this updates the
watcher to match the new behavior.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//100823005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30915 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-05 20:26:18 +00:00
nweiz@google.com 165f8eb4b5 Update the Linux watcher to accommodate changes in [Directory.watch]. 
This also removes the extra time allotted for the test since issue
14606 is now mitigated.

R=rnystrom@google.com
BUG=15446

Review URL: https://codereview.chromium.org//99483006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30874 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-04 22:31:18 +00:00
nweiz@google.com 69f1243709 Add a missing import to mac_os_watcher. 
TBR

Review URL: https://codereview.chromium.org//68523020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30330 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-16 01:10:23 +00:00
nweiz@google.com 205f55ad4a Remove debugging prints from the Mac OS directory watcher. 
R=rnystrom@google.com
BUG=15024

Review URL: https://codereview.chromium.org//63643008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30329 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-16 01:05:45 +00:00
nweiz@google.com 1c828f6820 Fix the Mac OS directory watcher tests on the bots. 
R=rnystrom@google.com
BUG=15024

Review URL: https://codereview.chromium.org//58903015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30328 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-16 00:54:50 +00:00
nweiz@google.com 1bface13de Re-mark directory_watcher/mac_os_test as passing. 
As before, this test is expected to fail. It's only failing on the
bots so we need to get the debug information from the bots to figure
out how to fix it.

This also adds some additional debug information to help clarify some
confusing output from the most recent failing log.

R=rnystrom@google.com
BUG=15024

Review URL: https://codereview.chromium.org//64383004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30315 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-15 21:43:50 +00:00
nweiz@google.com e7ba1a8663 Roll forward r30205. 
Unlike previous versions of this CL, the debug info will only be printed when
running directory_watcher/mac_os_test, so it won't break the pub bots.

R=rnystrom@google.com
BUG=15042

Review URL: https://codereview.chromium.org//71353011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30254 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-13 21:56:52 +00:00
nweiz@google.com 0a4fb91145 Properly close watcher streams during tests. 
This also makes [futureStream] pass cancellations through to the underlying
stream, and adds the ability for it to return broadcast streams.

R=rnystrom@google.com
BUG=14943

Review URL: https://codereview.chromium.org//66293008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30180 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-12 01:42:00 +00:00
nweiz@google.com db4cfbd3bf Work around a flake in the Mac OS watcher test on the bots. 
Issues 14373 and 14793 were tag-teaming to cause no_subscription_test
to fail for the Mac OS watcher occasionally.

This also marks directory_watcher/mac_os_test as timing out, apparently due to
issue 14943.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//59143006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30174 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-11 21:26:11 +00:00
nweiz@google.com d7c3ee487b Fix a typo in path_set_test. 
I'd have sworn I fixed this in the orignal CL.

R=rnystrom@google.com
TBR

Review URL: https://codereview.chromium.org//67973003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30173 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-11 21:20:51 +00:00
nweiz@google.com 28ef6879f5 Fix some analyzer warnings and hints in pkg/watcher. 
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//69013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30172 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-11 21:02:06 +00:00
nweiz@google.com c5d6dd178d Make path_set_test use Windows-friendly paths where necessary. 
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//68683004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30171 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-11 21:01:41 +00:00
nweiz@google.com 03337e9e5f Wrap Directory.watch on Mac OS for the watcher package. 
R=rnystrom@google.com
BUG=14428

Review URL: https://codereview.chromium.org//66163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30168 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-11 19:47:18 +00:00
nweiz@google.com 73e68b810f Fix the watcher tests on Windows. 
The tests were assuming POSIX paths.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//66073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30091 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-08 01:44:53 +00:00
nweiz@google.com 500eb1266b Wrap Directory.watch on linux for the watcher package. 
R=rnystrom@google.com
BUG=14428

Review URL: https://codereview.chromium.org//46843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30081 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-07 22:49:18 +00:00
rnystrom@google.com cd88620191 Bump wait time for watcher test. 
This is to see if it makes the test less flaky on the bots,
in particular the ARM ones.

BUG=https://code.google.com/p/dart/issues/detail?id=13705
R=nweiz@google.com

Review URL: https://codereview.chromium.org//26398002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28341 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-08 00:14:44 +00:00
whesse@google.com 428e84e7d4 Use Directory.systemTemp getter in pkg subdirectory of repository. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//25731003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28218 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-03 13:12:10 +00:00
nweiz@google.com 9300846114 Use filtered stacks in pub, barback, and watcher tests. 
This also exposes more unittest stuff to users of scheduled_test.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//23582003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26751 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-27 23:13:30 +00:00
rnystrom@google.com 6c2fe4dea5 Normalize test paths. 
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//23183006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26160 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-14 21:46:41 +00:00
rnystrom@google.com a07415d196 Handle watching a non-existent directory. 
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//22999008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26153 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-14 21:02:02 +00:00
kevmoo@j832.com 18d38085ab pkg: analysis aided cleanup 
Removed a lot of warnings and hints when opening many pkg projects in the editor

R=gram@google.com

Review URL: https://codereview.chromium.org//22284003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25831 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-06 20:42:04 +00:00
rnystrom@google.com b44ec0e706 Re-implement directory polling. 
BUG=https://code.google.com/p/dart/issues/detail?id=12107
R=nweiz@google.com

Review URL: https://codereview.chromium.org//21628002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25746 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-02 22:01:39 +00:00
gram@google.com fb62473ebf Add missing newline after Actual value in fail message. 
Remove the BasMatcher class; it made some sense when we had both 'interface'
and 'class' but adds no value now.
Fix a comment in the CustomMatcher documentation.
Fix tests affected by these changes.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//18442002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25356 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-23 19:48:26 +00:00
rnystrom@google.com 67506c3e49 Normalize paths when matching them. 
Review URL: https://codereview.chromium.org//18464006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24986 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-13 00:10:44 +00:00
rnystrom@google.com 44364a50dd Normalize paths in mock timestamp map. 
Makes sure separators are consistent on Windows.

Review URL: https://codereview.chromium.org//18430006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24984 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-12 23:47:49 +00:00
rnystrom@google.com 2147df7433 Add some debug prints to figure out why a test is failing on windows. 
R=nweiz@google.com

Review URL: https://codereview.chromium.org//18513006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24983 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-12 23:25:28 +00:00
rnystrom@google.com 94fdc83209 Split up tests and add some heartbeats to try to make them not timeout. 
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//18877005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24978 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-12 22:45:43 +00:00
rnystrom@google.com b269f59153 Fix pathos->path in watcher example. 
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//18878003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24976 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-12 21:47:02 +00:00
rnystrom@google.com ed4a747343 File watching package. 
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//18612013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24971 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-12 21:15:02 +00:00