04a2a02fa8
Add debugging prints to the Mac OS directory watcher.
...
This is a temporary CL that will make it easier to track down and fix the errors
in the mac watcher.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//107403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30919 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-05 22:49:03 +00:00
b3fc09ef15
Update the Mac OS watcher in pkg/watcher.
...
The behavior of Directory.watch has changed, and this updates the
watcher to match the new behavior.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//100823005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30915 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-05 20:26:18 +00:00
946df0e955
Add a missing import to pkg/watcher.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//104033003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30914 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-05 20:24:10 +00:00
cbbad67d58
Add stack chain support to pkg/watcher and pkg/http.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//94093007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30912 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-05 19:31:19 +00:00
165f8eb4b5
Update the Linux watcher to accommodate changes in [Directory.watch].
...
This also removes the extra time allotted for the test since issue
14606 is now mitigated.
R=rnystrom@google.com
BUG=15446
Review URL: https://codereview.chromium.org//99483006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30874 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 22:31:18 +00:00
e5014cd8a9
Properly close the Linux directory watcher when listing a subdirectory fails.
...
R=rnystrom@google.com
BUG=15279
Review URL: https://codereview.chromium.org//89503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30690 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 01:16:56 +00:00
205f55ad4a
Remove debugging prints from the Mac OS directory watcher.
...
R=rnystrom@google.com
BUG=15024
Review URL: https://codereview.chromium.org//63643008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30329 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-16 01:05:45 +00:00
1bface13de
Re-mark directory_watcher/mac_os_test as passing.
...
As before, this test is expected to fail. It's only failing on the
bots so we need to get the debug information from the bots to figure
out how to fix it.
This also adds some additional debug information to help clarify some
confusing output from the most recent failing log.
R=rnystrom@google.com
BUG=15024
Review URL: https://codereview.chromium.org//64383004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30315 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-15 21:43:50 +00:00
e7ba1a8663
Roll forward r30205.
...
Unlike previous versions of this CL, the debug info will only be printed when
running directory_watcher/mac_os_test, so it won't break the pub bots.
R=rnystrom@google.com
BUG=15042
Review URL: https://codereview.chromium.org//71353011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30254 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-13 21:56:52 +00:00
85bc44d154
"Reverting 30205"
...
Review URL: https://codereview.chromium.org//69863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30217 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-13 03:03:33 +00:00
5a33f0b1e8
Be sure we don't forward an error to a closed event stream.
...
R=rnystrom@google.com
BUG=15034
Review URL: https://codereview.chromium.org//68253010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30210 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 22:17:01 +00:00
b58d984659
Add a bunch of debugging prints to the Mac OS watcher.
...
This reverts r30184, which in turn reverted r30181. It correctly detects whether
it's running on a buildbot in a way that will work for the vm-mac-release bot.
This is a temporary CL intended to help provide information about a test failure
that's only reproducing on the build bot. It will be rolled back as soon as
sufficient information is gathered.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//69933007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30205 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 20:08:41 +00:00
0a5afb6654
Revert "Add a bunch of debugging prints to the Mac OS watcher."
...
This reverts r30181. This CL causes the pub tests to fail due to excess output,
so I didn't want to leave it in the build overnight. In addition, it didn't seem
to be working; no additional output was being printed in the tests. It's
possible BUILDBOT_BUILDERNAME isn't being set on vm-mac-release.
This also marks the directory_watcher/mac_os_test as flaky.
R=rnystrom@google.com
TBR
Review URL: https://codereview.chromium.org//68203008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30184 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 02:23:05 +00:00
ea9d92f3f4
Fix a synchronous event bug in futureStream.
...
R=rnystrom@google.com
TBR
Review URL: https://codereview.chromium.org//68713004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30182 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 01:56:18 +00:00
f289c34b8f
Add a bunch of debugging prints to the Mac OS watcher.
...
This should help debug the intermittent, difficult-to-reproduce issues
on the vm-mac-release bot.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//68293005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30181 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 01:43:38 +00:00
0a4fb91145
Properly close watcher streams during tests.
...
This also makes [futureStream] pass cancellations through to the underlying
stream, and adds the ability for it to return broadcast streams.
R=rnystrom@google.com
BUG=14943
Review URL: https://codereview.chromium.org//66293008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30180 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 01:42:00 +00:00
28ef6879f5
Fix some analyzer warnings and hints in pkg/watcher.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//69013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30172 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-11 21:02:06 +00:00
03337e9e5f
Wrap Directory.watch on Mac OS for the watcher package.
...
R=rnystrom@google.com
BUG=14428
Review URL: https://codereview.chromium.org//66163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30168 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-11 19:47:18 +00:00
578e9a5281
Fix an analyzer error in the linux directory watcher.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//65533005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30093 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-08 01:46:11 +00:00
500eb1266b
Wrap Directory.watch on linux for the watcher package.
...
R=rnystrom@google.com
BUG=14428
Review URL: https://codereview.chromium.org//46843003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30081 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 22:49:18 +00:00
308c960be6
fix csslib and watcher warnings
...
R=rnystrom@google.com , terry@google.com
Review URL: https://codereview.chromium.org//50703011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29632 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 02:43:00 +00:00
103eac574c
Remove FileException, DirectoryException and LinkException from dart:io and use FileSystemException instaed.
...
BUG=https://code.google.com/p/dart/issues/detail?id=12461
R=nweiz@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//26968003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29168 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 12:17:20 +00:00
4be547c705
Adapt streams for additional stackTrace argument.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//25094002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28511 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 12:02:20 +00:00
79743b6a93
Fix error handling in watcher.
...
BUG=
R=nweiz@google.com
Review URL: https://codereview.chromium.org//23085006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26156 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 21:28:31 +00:00
a07415d196
Handle watching a non-existent directory.
...
BUG=
R=nweiz@google.com
Review URL: https://codereview.chromium.org//22999008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26153 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 21:02:02 +00:00
18d38085ab
pkg: analysis aided cleanup
...
Removed a lot of warnings and hints when opening many pkg projects in the editor
R=gram@google.com
Review URL: https://codereview.chromium.org//22284003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25831 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 20:42:04 +00:00
b44ec0e706
Re-implement directory polling.
...
BUG=https://code.google.com/p/dart/issues/detail?id=12107
R=nweiz@google.com
Review URL: https://codereview.chromium.org//21628002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25746 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 22:01:39 +00:00
94fdc83209
Split up tests and add some heartbeats to try to make them not timeout.
...
BUG=
R=nweiz@google.com
Review URL: https://codereview.chromium.org//18877005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24978 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-12 22:45:43 +00:00
ed4a747343
File watching package.
...
BUG=
R=nweiz@google.com
Review URL: https://codereview.chromium.org//18612013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24971 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-12 21:15:02 +00:00
nweiz@google.com