c732e4172f
Fix small bug in RecursiveVisitor
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//80923003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30547 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-21 22:00:32 +00:00
8503bbb19f
Split out Index AST node from Invoke
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//74543003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30437 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 03:47:01 +00:00
e7aab3f862
fix analyzer error
...
Review URL: https://codereview.chromium.org//72683004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30279 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 18:29:10 +00:00
c93868eaac
Make sure 'enumerate' changes when the underlying collection changes.
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//71353012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30278 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 17:52:23 +00:00
d9709470cc
"Reverting 29728"
...
I changed the test to avoid using mirrors. Somehow, import mirrors exposes a strange dart2js interceptor bug, but only in unchecked mode. (I only ran checked mode in my local tests :|. Doh)
Needs more investigation, but what seems to be happening:
* setInnerHtml creates a document
* it tries to append <base> to the <head>
* interceptor gets "Document" instead of "HtmlDocument"
* so the `document.head` fails
The bug seems to require Shadow DOM+unchecked+mirrors. Anyway, since it's totally unrelated to this test or the bug fix for 14700, I'm just working around it for now. Will open a separate issue.
R=sigmund@google.com
Review URL: https://codereview.chromium.org//54983011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29767 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 19:59:45 +00:00
68ff3d28cc
Revert "fix nested bindings"
...
This reverts r29722.
R=jmesserly@google.com
BUG=
Review URL: https://codereview.chromium.org//54603008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29728 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 08:47:49 +00:00
6179df0ad5
fix nested bindings
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//51953012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29722 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 02:15:15 +00:00
33fa4d5eba
introduce ObservableList.listChanges to keep list changes separate from property changes
...
this is part of addressing: 13554, 14157, 13359
R=sigmund@google.com
Review URL: https://codereview.chromium.org//53743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29630 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 02:31:50 +00:00
36e2df1a1d
Mirrors overhaul.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//23455028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29551 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 14:58:58 +00:00
c574e860ec
polymer warning clean
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//50703009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29505 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 00:48:07 +00:00
7b3123e02a
Update our TemplateBinding port
...
https://github.com/Polymer/TemplateBinding/tree/ed3266266e751b5ab1f75f8e0509d0d5f0ef35d8
R=sigmund@google.com
Review URL: https://codereview.chromium.org//50203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29500 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 23:26:20 +00:00
360ea42322
Rename mdv -> template_binding, remove experiemntal apis from dart:html
...
essentially, we trade off reduce dart:html API surface area for more annoying usage of these APIs. Since Polymer hides most of this, I suspect it won't be too annoying in practice.
Sample usage:
nodeBind(node).bind(...)
templateBind(node).model = ...;
R=sigmund@google.com
Review URL: https://codereview.chromium.org//34453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29057 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 02:11:49 +00:00
829a775cdc
Log exceptions caught in polymer expressions
...
BUG=https://code.google.com/p/dart/issues/detail?id=12130
R=justinfagnani@google.com
Review URL: https://codereview.chromium.org//26619002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28805 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 17:17:54 +00:00
38c4cd1f6b
package:observe fix various api issues
...
in particular:
provide oldValue/newValue/target in PropertyChangeRecord -- https://code.google.com/p/dart/issues/detail?id=12075
use == in notifyPropertyChange -- https://code.google.com/p/dart/issues/detail?id=12463
remove Mixin/Base suffix -- https://code.google.com/p/dart/issues/detail?id=13353
remove ChangeRecord.changes -- https://code.google.com/p/dart/issues/detail?id=14128
other changes:
rename PropertyChangeRecord.field to .name (it's not just fields)
PathObserver rethrows errors from inside the getter/setter to help debug those
PathObserver now looks up Map keys using Strings instead of Symbols.
generic type on PropertyChangeRecord, MapChangeRecord
I stopped short of adding "target" to List/Map change record but am interested in a follow up to address that: https://code.google.com/p/dart/issues/detail?id=14157
R=sigmund@google.com
Review URL: https://codereview.chromium.org//27618002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28774 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 03:32:40 +00:00
d583f16e4f
add @MirrorsUsed to observe/polymer/polymer_exprs pkgs
...
Fairly straightforward. @observable and @CustomTag are metaTargets, so no changes needed for types that use those. The only other changes are for data binding to objects with built in change notification. In that case, we add package:observe's @reflectable annotation. Other than that, just a few other things in mirrors that are now locked down appropriately to only reflect on the things they need.
R=sigmund@google.com
Review URL: https://codereview.chromium.org//26967004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28689 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 22:55:47 +00:00
958feffd78
fix dart2js warnings in polymer_expressions pkg
...
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org//26318004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28627 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 02:54:24 +00:00
b16ddf6c12
use symbol literals instead of const ctor
...
R=rnystrom@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//26734004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28485 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 22:55:17 +00:00
5df1c0d7f9
Fix bug in polymer expressions where input-value bindings are incorrectly
...
updated twice, losing the cursor position.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//26649002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28480 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 21:29:07 +00:00
01230279a3
add enumerate to the default filter set
...
R=justinfagnani@google.com
Review URL: https://codereview.chromium.org//23874018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28358 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 06:14:31 +00:00
e516d3de65
fix list filtering if the filter is a method
...
https://code.google.com/p/dart/issues/detail?id=13459
R=justinfagnani@google.com
Review URL: https://codereview.chromium.org//25967002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28345 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 00:35:19 +00:00
e171e69093
Use const instead of runtime type for equality of EmptyExpression.
...
R=jmesserly@google.com , justinfagnani@google.com
Review URL: https://codereview.chromium.org//24983003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28042 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-30 06:37:05 +00:00
0a30cd7b70
Silently handle handle eval exceptions in PolymerExpressions
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//24031006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27672 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 18:25:23 +00:00
557e50f241
PolymerExpressions: fix for null iterators in comprehensions
...
BUG=
R=cbracken@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//24096016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27528 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-16 20:15:06 +00:00
d123c267ba
Added library-level comments for polymer and polymer_expressions
...
BUG=
R=kathyw@google.com
Review URL: https://codereview.chromium.org//23453034
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27504 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-13 21:28:52 +00:00
518fcf5825
fix dart2js warnings when compiling polymer_expressions
...
it might be a dart2js bug, but I'm not sure the generic adds anything here, so removed it.
R=justinfagnani@google.com
Review URL: https://codereview.chromium.org//23609017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27267 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 20:33:25 +00:00
9a5b4c3092
Add null literals
...
BUG=
R=cbracken@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//23458017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27263 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 19:59:40 +00:00
3ac13ad168
Fixing analyzer error in polymer_expressions.
...
Was complaining "The name 'hash' cannot be referenced in the initializer of a variable with the same name", seems like an incorrect error message for this code (though it is arguably less confusing this way).
TBR
BUG=
Review URL: https://codereview.chromium.org//23583021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26892 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 21:33:39 +00:00
52f201e87c
Wanted to get these out of the way because I was working on some other analyzer bugs.
...
Still a number of warnings in visitor.dart, opened https://code.google.com/p/dart/issues/detail?id=12912 for those.
BUG=
R=justinfagnani@google.com
Review URL: https://codereview.chromium.org//23724005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26889 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 19:46:34 +00:00
f300344407
move fancy_syntax into Dart SVN
...
Changes after moving:
deleted: AUTHORS, LICENSE, PATENTS, codereview.settings.
these are redundant with the Dart repository files.
pubspec.yaml: remove versions, changed homepage
syntax_test.dart: add the HTML via Dart, so it can run on browser bots
syntax_test.html: removed the HTML that is now added by syntax_test.dart
pkg/pkg.status: skip the in-browser syntax_test on standalone VM
R=justinfagnani@google.com
Review URL: https://codereview.chromium.org//22950008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26237 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 23:04:19 +00:00
justinfagnani@google.com